GNU bug report logs - #43714
28.1: auto-revert code improvements [PATCH]

Previous Next

Package: emacs;

Reported by: Boruch Baum <boruch_baum <at> gmx.com>

Date: Wed, 30 Sep 2020 06:27:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: larsi <at> gnus.org, 43714 <at> debbugs.gnu.org
Subject: bug#43714: 28.1: auto-revert code improvements [PATCH]
Date: Wed, 30 Sep 2020 19:03:55 +0300
> Date: Wed, 30 Sep 2020 11:28:27 -0400
> From: Boruch Baum <boruch_baum <at> gmx.com>
> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 43714 <at> debbugs.gnu.org
> 
> On 2020-09-30 17:25, Eli Zaretskii wrote:
> > >     (auto-revert-buffers): Use save-match-data.
> >
> > It could be due to remote files (and file-handlers)?
> 
> But I don't see anywhere in the code itself being evaluated in
> auto-revert.el that would produce its own match-data to potentially
> disturb the pre-existing state.

That's what I meant: it could be hidden from plain sight.

Why is that a problem to leave save-match-data alone?  Does it do any
harm?




This bug report was last modified 4 years and 293 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.