From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 06:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 43714@debbugs.gnu.org X-Debbugs-Original-To: Emacs Bug Reporting Received: via spool by submit@debbugs.gnu.org id=B.16014472037251 (code B ref -1); Wed, 30 Sep 2020 06:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Sep 2020 06:26:43 +0000 Received: from localhost ([127.0.0.1]:57898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNVZb-0001st-3S for submit@debbugs.gnu.org; Wed, 30 Sep 2020 02:26:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:51346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNVZZ-0001sk-OM for submit@debbugs.gnu.org; Wed, 30 Sep 2020 02:26:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNVZZ-0007Le-EC for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 02:26:41 -0400 Received: from mout.gmx.net ([212.227.17.22]:45091) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNVZX-0007W2-0T for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 02:26:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601447196; bh=wNBSr/wSK/bH/A9l0b01uuYGcGvOnXt9TqJG7Txl/9A=; h=X-UI-Sender-Class:Date:From:To:Subject; b=IH2rTNaq/MwQn8/Lr1awNX5zUgilf5iGJV3TPG/+qw16Y8ZzbdN1Dghj5Si14N+Sb NjZ8MLazxrgLHaqcCtw4mP/CrsniuLzff3JW0zBk9D07oiNvVvAtqpBcvOW8EOJc2B cRbikbrwGQk4gcOxE+JmFuZzkiw4u1DPLUHv++4Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M7b2T-1kKVI90qDd-007zz9 for ; Wed, 30 Sep 2020 08:26:36 +0200 Date: Wed, 30 Sep 2020 02:26:33 -0400 From: Boruch Baum Message-ID: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="5ou2waw76t5nyno3" Content-Disposition: inline User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:m761G7R/gnLSf1o6fTVyIXHzFTdj+HFScE6km6+PoL5x5xqPrdA z1ZB973TaEOm9qtvvECfuqM8SenbkM9prVdHjyxNoEDJVFI8KViqTEAwa4oF79KpE/TOj9K Q7sF9e0AMMaMxDWL51W/AUPA+l1mWY46yWUnjcUphlAb1+ANb2gS8qTxDtfHCocwNW1Xrlt lyZWXtjBmUZcpLCir3x3g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:JCs3p2R3b9o=:FAwNhFwxR+g3CrKyR137PQ P0F6kLJmNfEidmjxdxqWaS5YuIfpnZ2+HVwt2zbkBlW7TzHoOADTRb/KzmJaiE9i5tDEIsSeY H9ToTnyiUipJ85b5Y9FQLvcDx1t4LpuhNCyH2n3oH64ru+WwNMJp/H+QaQ5stLDhdN9YoUiCp nxUNr7j7fH3DHhRstoW746UgDYyOcWH1lFuN9CXVd8GQam7a7AwSTI1bosErEzUM3H1wtcLkg 0Cy0ToOZw7plQ9OFZVKdovI2jG9YsTEIdKJ79ZJShwNEfP45rJ9v9oogA/qW7Ku/9E2Dsf6LD kzofcTOSBHCwbWe5lT39jG/a+5vEHz4YLyk+c2yz7DEPzPOqvRTD3isMZGpcj0v+bkXIvVYbP O2sJCskGYZtmSHrQ3heUoMqbUDpa90bTCRKAVBeGgzaMLk+2Kd5Vs+NdUoeo2JitErYtltHV/ pQTfZEecW6sD6+2vII9L+vC+AyfsFJUPUOT/qcmMIKcMrMIG9BGjzkIRS9vBAwlKMCPI+x7ip TskFUmMAinAhiAci9A5jN9tUHwtx4ZwbufpTRoLgm6twS6aO2clOyWh8xgYGoXHY2YIgwMkQB 4eOyWm6C/qTHrjutrjYEtiei6hDATFDr4WLs589Dexb41JBqvT0GN7whU2MOXy9xRODAMNE1i p7R3IJgtHuk4YywVmKiTz4D5Pss+MYABsEWNLGOxxmxgznrz/VOWCvhNdcPlBv32VXphsElJA q0u4EXGSZrKmKbQd13PNbpmAQy45Diff1P/8xgpH0g3r0bcw5weUcIYTe5eDM+vKnk8i3x+pz aqIL4e0XBF/gxK86bZvYbcjMETTIiZ1K4hv4q8vTBGx2o9CaqnH0P4bak+OmWWgRZj5lQRX+T PC8dRvttKbPXTNrzZwLDnQh2lAbMa/liTa+li/xXW0yzxwJoLM/ROE2p6aFqBhDjEeo2xAR0u E/hDruRhjMAEU/5GQIVdw1cf7lfmwlVi874A4kSUdaAx5EOOLybwfDIw/tDvO8e1JD7Q/h79j AokR4CBe1+GtNm0TtxWZaanU46XabUsjdc2ayf0dQi/hCUNCOtWYUkWQTTDNXVZ/fuJFCILw+ sU50IDvXhOTmfwD5rZCf4Qk6x/+O+wq0FzBsQLMDX1axUUdQ2+xzrSgjbBlSOnJNEDPgx2t+V p1uPKoFos9Z/tAAJbpQynDKkpNdvVjBLPSMRkvsF1KaBnETok3j95lc1eYuveaX4aDF5/SqLi zSsFJUDJ6A6BAEPVzvU0hGVjkxogW92yPjZkBzA== Received-SPF: pass client-ip=212.227.17.22; envelope-from=boruch_baum@gmx.com; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/30 02:26:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.614, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --5ou2waw76t5nyno3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In pursuing a 'best' solution for bug-report#43412, I've taken the plunge and gotten an emacs 28 snapshot installed locally, and in examining the code, saw things that didn't make sense to me or were unnecessary or could just do with better readability. My testing indicates no harm done by the changes, but they should be peer-reviewed and undergo further testing. Nothing in the attached patch is aimed at changing functionality, so you may want to reject it on the basis of "if it ain't broke, don't fix it", but it does improve the code. Just as a 'for example': I started on this because I saw that the code was saving match data, which had me on a wild goose chase hunting for why and where it was necessary - I found nothing, and removing the code doesn't seem to have ill effect. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --5ou2waw76t5nyno3 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="auto-revert-28-cosmetic.patch" Content-Transfer-Encoding: quoted-printable diff --git a/autorevert.el b/autorevert.el index 011febf..de4407b 100644 =2D-- a/autorevert.el +++ b/autorevert.el @@ -869,6 +869,62 @@ This is an internal function used by Auto-Revert Mode= ." (restore-buffer-modified-p modified))) (set-visited-file-modtime)) +(defun auto-revert--buffer-candidates () + "Return a prioritized list of buffers to maybe auto-revert. +The differences between this return value and the reference +variable `auto-revert-buffer-list'. include: 1) this has more +entries when in global-auto-revert-mode; 2) this prioritizes +buffers not reverted last time due to user interruption. " + (let (remaining new + (bufs (delq nil + ;; Buffers with remote contents shall be reverted only + ;; if the connection is established already. + (mapcar + (lambda (buf) + (and (buffer-live-p buf) + (with-current-buffer buf + (and + (or (not (file-remote-p default-directory)= ) + (file-remote-p default-directory nil t= )) + buf)))) + (auto-revert--polled-buffers))))) + ;; Partition `bufs' into two halves depending on whether or not + ;; the buffers are in `auto-revert-remaining-buffers'. The two + ;; halves are then re-joined with the "remaining" buffers at the + ;; head of the list. + (dolist (buf auto-revert-remaining-buffers) + (if (memq buf bufs) + (push buf remaining))) + (dolist (buf bufs) + (if (not (memq buf remaining)) + (push buf new))) + (nreverse (nconc new remaining)))) + +(defun auto-revert-buffer (buf) + "Revert a single buffer. + +This is performed as specified by Auto-Revert and Global +Auto-Revert Modes." + (if (not (buffer-live-p buf)) + (auto-revert-remove-current-buffer buf) + (with-current-buffer buf + ;; Test if someone has turned off Auto-Revert Mode + ;; in a non-standard way, for example by changing + ;; major mode. + (and (not auto-revert-mode) + (not auto-revert-tail-mode) + (auto-revert-remove-current-buffer)) + (when (auto-revert-active-p) + ;; Enable file notification. + ;; Don't bother creating a notifier for non-file buffers + ;; unless it explicitly indicates that this works. + (when (and auto-revert-use-notify + (not auto-revert-notify-watch-descriptor) + (or buffer-file-name + buffer-auto-revert-by-notification)) + (auto-revert-notify-add-watch)) + (auto-revert-handler))))) + (defun auto-revert-buffers () "Revert buffers as specified by Auto-Revert and Global Auto-Revert Mode= . @@ -892,66 +948,17 @@ are checked first the next time this function is cal= led. This function is also responsible for removing buffers no longer in Auto-Revert Mode from `auto-revert-buffer-list', and for canceling the timer when no buffers need to be checked." - - (save-match-data - (let ((bufs (auto-revert--polled-buffers)) - remaining new) - ;; Buffers with remote contents shall be reverted only if the - ;; connection is established already. - (setq bufs (delq nil - (mapcar - (lambda (buf) - (and (buffer-live-p buf) - (with-current-buffer buf - (and - (or (not (file-remote-p default-directo= ry)) - (file-remote-p default-directory ni= l t)) - buf)))) - bufs))) - ;; Partition `bufs' into two halves depending on whether or not - ;; the buffers are in `auto-revert-remaining-buffers'. The two - ;; halves are then re-joined with the "remaining" buffers at the - ;; head of the list. - (dolist (buf auto-revert-remaining-buffers) - (if (memq buf bufs) - (push buf remaining))) - (dolist (buf bufs) - (if (not (memq buf remaining)) - (push buf new))) - (setq bufs (nreverse (nconc new remaining))) + (let ((bufs (auto-revert--buffer-candidates))) (while (and bufs (not (and auto-revert-stop-on-user-input (input-pending-p)))) - (let ((buf (car bufs))) - (if (not (buffer-live-p buf)) - ;; Remove dead buffer from `auto-revert-buffer-list'. - (auto-revert-remove-current-buffer buf) - (with-current-buffer buf - ;; Test if someone has turned off Auto-Revert Mode - ;; in a non-standard way, for example by changing - ;; major mode. - (if (and (not auto-revert-mode) - (not auto-revert-tail-mode) - (memq buf auto-revert-buffer-list)) - (auto-revert-remove-current-buffer)) - (when (auto-revert-active-p) - ;; Enable file notification. - ;; Don't bother creating a notifier for non-file buffers - ;; unless it explicitly indicates that this works. - (when (and auto-revert-use-notify - (not auto-revert-notify-watch-descriptor) - (or buffer-file-name - buffer-auto-revert-by-notification)) - (auto-revert-notify-add-watch)) - (auto-revert-handler))))) - (setq bufs (cdr bufs))) + (auto-revert-buffer (pop bufs))) (setq auto-revert-remaining-buffers bufs) ;; Check if we should cancel the timer. (unless (auto-revert--need-polling-p) - (if (timerp auto-revert-timer) - (cancel-timer auto-revert-timer)) - (setq auto-revert-timer nil))))) - + (when (timerp auto-revert-timer) + (cancel-timer auto-revert-timer)) + (setq auto-revert-timer nil)))) ;; The end: (provide 'autorevert) --5ou2waw76t5nyno3-- From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014737131148 (code B ref 43714); Wed, 30 Sep 2020 13:49:02 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 13:48:33 +0000 Received: from localhost ([127.0.0.1]:58668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNcT3-0000II-JI for submit@debbugs.gnu.org; Wed, 30 Sep 2020 09:48:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNcT0-0000I3-Ty for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 09:48:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AglaYntiMpJ9aCQY0qLYYrcrNHfn1pfXHkyd51c/fYU=; b=Jy0gRCtCzkxFyO/kGu1xchr0KR zMutBvfFMtuMaU7xXC9twMxptrmhvbd4eGRV9VptJzceA9i2p9Ykq73epwqYpFcMrxTDSkJFHZbNk ccAKZOa0OPNISWONqTE+HdOgQJpXEQzgGYH+IQpX6vgGnzmNxsUtstznvDiVo7ywZ1c4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNcSk-00023y-La; Wed, 30 Sep 2020 15:48:16 +0200 From: Lars Ingebrigtsen References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> X-Now-Playing: So's _So_: "f" Date: Wed, 30 Sep 2020 15:48:05 +0200 In-Reply-To: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 30 Sep 2020 02:26:33 -0400") Message-ID: <877dsb74ve.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: > Just as a 'for example': I started on this because I saw that the code > was saving match data, which had me on a wild goose chase hunting for > why and where it was necessary - I found nothing, and [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: > Just as a 'for example': I started on this because I saw that the code > was saving match data, which had me on a wild goose chase hunting for > why and where it was necessary - I found nothing, and removing the code > doesn't seem to have ill effect. That's really hard to tell, though -- the reason for saving the match data may be in hard-to-trigger circumstances, and the saving was introduced in a commit of its own, so I'm guessing there was some specific reason for it. The commit message is super-helpful here: commit 33512cbeb168764f83f5a740090ce40b4b948591 Author: Luc Teirlinck AuthorDate: Wed Jun 1 20:51:03 2005 +0000 (auto-revert-buffers): Use save-match-data. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: boruch_baum@gmx.com, 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160147595722942 (code B ref 43714); Wed, 30 Sep 2020 14:26:01 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 14:25:57 +0000 Received: from localhost ([127.0.0.1]:60680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNd3N-0005xy-8H for submit@debbugs.gnu.org; Wed, 30 Sep 2020 10:25:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNd3K-0005xi-Hp for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 10:25:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34364) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNd3F-0001bZ-9d; Wed, 30 Sep 2020 10:25:49 -0400 Received: from [176.228.60.248] (port=3798 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kNd3E-00050F-By; Wed, 30 Sep 2020 10:25:48 -0400 Date: Wed, 30 Sep 2020 17:25:41 +0300 Message-Id: <83wo0biboa.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <877dsb74ve.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 30 Sep 2020 15:48:05 +0200) References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Wed, 30 Sep 2020 15:48:05 +0200 > Cc: 43714@debbugs.gnu.org > > commit 33512cbeb168764f83f5a740090ce40b4b948591 > Author: Luc Teirlinck > AuthorDate: Wed Jun 1 20:51:03 2005 +0000 > > (auto-revert-buffers): Use save-match-data. It could be due to remote files (and file-handlers)? From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 15:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160147859527208 (code B ref 43714); Wed, 30 Sep 2020 15:10:02 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 15:09:55 +0000 Received: from localhost ([127.0.0.1]:60788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNdju-00074m-HR for submit@debbugs.gnu.org; Wed, 30 Sep 2020 11:09:54 -0400 Received: from mout.gmx.net ([212.227.17.21]:42885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNdjo-00074S-Ge for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 11:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601478581; bh=JlRBiIpWSGh9y9jnkHkeztniyHXETkxXGZo7xANtchE=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=LnRKfAvL+2zLITT7XRC9jdaSjK41CwZsVcSfU3PmlupbMyhT9kXcipHQjEiMuWu6E N+0QzFHBLqeDa/1vT52IGi2uLiEw9LP+MVFf1iz6F6rRMWjEELRVw8hq/UgMO69tzy z5lKP87nGBfZm4j/1epgOXqMy+Figc7ez73fOJU4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MZCbB-1jtCZZ3afB-00VCZ1; Wed, 30 Sep 2020 17:09:41 +0200 Date: Wed, 30 Sep 2020 11:09:38 -0400 From: Boruch Baum Message-ID: <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877dsb74ve.fsf@gnus.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:PdvEqv/u/t4XjVYpKhfmevy7xIRFNFIPgGlmODr0FAUJcULmvv/ OH9Bv0u9aODXGDVSjDWQC3oq+yAaYOwKCEjgIX9UI6N8CcIjzgZtgUoXiK7Aa21S1T6cBac fkQUKTZNSTZIsUbcOfcnV9GpXTv7uokzIvVG1g3Alvyaw0tnNOpel7eJOM5cHFB6ipAy08Z e34oTRnYoGRZomnivnqbA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Zw5bo7soNxA=:WeOsY9TUiYa8c76Uw775yZ MjD/KmkCDDbqsh40RGbzdADGTV1fo76M/o1a4A0IqcBhzSQ8cNmpOP6l52scJ6ynfXSy6dqFh H+ucDRtCT2yhaGiVCtWh1gEMZ3X4UU2GBpNAZevr3RvCOwQjAdYaT0r0vIymD/m+f6IZqRd5z IHiE1yXZzz6NK3snP0peqFsElfnxoQgxjMZFP0zK6KTxBs0jF0QXh/Rlob6RM8FSs+A6xNxvm Lb39EgV6+STLDTqOUfg86Dyysi/AflSGeMzmjR60BkvDebMYC4QRbJipp7cugZ5qP0Jolvc84 QcvjQsV4glHRDnoLZNgK/Lv3RyDDmx5/oD2tuV2Bl/w2GsMnWZlQPlwr2HlDCypp/muWEDILN zJKaL9AHSQJUMhyOBJ3WR5JK+Gom2R3UJlyW9XCsX3qa65KT1rQB48rR1WjUnHEK1c/NlfHyC zBIfYVlS9JGnFi+sqmenXtHinnZuHVy6l88KM5jJt9nQiMkaKuTzK8KyuJliZUDZWaNd9HAV9 iAj9mvUPS/J6YvYQI/RfmJxij9054zwk9IkT+N8/O6wRcQjyOJ2bLIreQ11ynOt+teGZ5BO7t pYSh+4LFfDeQVYfQq00NovQUZ4dQ3ICAd4hC7avkMgqHGssG5x9fxB1n7kA9Jl91AWYQAJ1Y8 +MxEjjanRQxGjLT1bFV9cguMfpYU9gpJATPAZF+EMbbfUzi7EbLpcMCpZI6KJhyVKgV7mYW/n Vdxe3FNEKs9ZVt63pHMWxYtwM7Ym5tjMo+1eb0cDNr/reA/tGKhwyZwqe/oV/tKmei507/55s xd9Fxz02/Qvz0cloBduxFnxlNSZ2H/kkoR1fGXn+MFJV5CpNCqQ2dofh7GZV5K7ZHInU20T9q Di473vSzmSfIDWguu4wQknE1nHYKOfQcfB8q6TCLj2KhPWE0exKBo2TBzxwWozudACuPE9RKn M9M1rR86E+2RK1tlO6EjEi6pHMQNKe529jMT5y1Kh88RbG26KqYJro0K+GajYuJFkqhKYWubw wvxIpmSd2Y8scpd1QF/Zd94495Pql6/N9Gxf8Nwml6yVT368NVK2viPTtdGOQUP3Ex81XG279 EkUhddoRaY/96Exhh63nSwBzLWwDApV7pxoBbShn++MlXerE77fraBW5dPwj3sB5xgwJ9Jc3/ lmweSOxhvGrnBUfRO/P9yX8JyXTcEu5xLdnz7G8W78vSNtJwX+2Wqraj/ZBFUKY8dPwQQFm7i JKtuOsJIN8Gu3f6NI1M2v4jh/pIRnYCEgg9z0Yw== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2020-09-30 15:48, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > > Just as a 'for example': I started on this because I saw that the code > > was saving match data, which had me on a wild goose chase hunting for > > why and where it was necessary - I found nothing, and removing the cod= e > > doesn't seem to have ill effect. > > That's really hard to tell, though -- the reason for saving the match > data may be in hard-to-trigger circumstances, and the saving was > introduced in a commit of its own, so I'm guessing there was some > specific reason for it. > > The commit message is super-helpful here: > > commit 33512cbeb168764f83f5a740090ce40b4b948591 > Author: Luc Teirlinck > AuthorDate: Wed Jun 1 20:51:03 2005 +0000 > > (auto-revert-buffers): Use save-match-data. Seriously now. Should I send an email to Luc, asking him what he was thinking 15 years ago? Otherwise, I'd be willing to look over the versions at that commit and it's HEAD^ if you can send them to me. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160147873427434 (code B ref 43714); Wed, 30 Sep 2020 15:13:01 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 15:12:14 +0000 Received: from localhost ([127.0.0.1]:60792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNdmA-00078Q-4X for submit@debbugs.gnu.org; Wed, 30 Sep 2020 11:12:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNdm7-00078D-Rn for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 11:12:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FB3GT/bjp+MV5+cqTxRLjWGmx8KPWCSdtPlLid99H4o=; b=jW0J0DF92npE2Yp0fU7DUZ2kwi 5psTrr8i42qSU7HL5aSRCCG89MYkl6vc/2iZdOarlIo35dtVfGpHHaEILn/lAXFu80Dd/dd+H00Ih tid6Q5tLqunEAag0XyNQEm85fdNbb3mrwnDV7l3G38ta3xLkwW5oQOOaEEhp2mRWFuNY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNdly-0002p4-DZ; Wed, 30 Sep 2020 17:12:05 +0200 From: Lars Ingebrigtsen References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUqGCJdLTf69vKg V0nJrKH///97zUPUAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QJHg8LFXmiy/QAAAGkSURBVDjLdZML loMgDEXD4AKS6gYaWYB8FlCR/a9pErBI7UzOgdp3zUcSAAAeq6G80hxjLCVGTwTNZt46iB2grLBB OjqI3QOMIYoUvwGYOUWv2tFAIwRGw1QQY6oA6+sENNPim5oOBdXH6G+Mu6zEhd0JBKmrlKvZ+eBS fGIukDcwaDDvFWi4UlgBKwAK1ICnlFkNHqh1SfYTLCK6khmK6AZU15plkyQaCxwqoFpatcQtFL+k XoN0We5gQTuCJbrMrgKagUZbAx+aY/IEZtCRSvLgASePMBLjw0u/wf/sI0CwjjbpKx7TMQI51qJ7 wvKz1uN/OwBYjZ3JBbddQJ/qmyxV5w5apy1X4B1j6zy+Z2BR4Ofk6j8cpkOMydt89h4/QATDH8pp ciT2BkwN+ZSH/AmmWr6swNsn4P2sWo5+NMvti8M/YJI+bnegu7YYb0AF1R3cgYTgv4DDBr5CuXiC e3KZ6QZesI8kq1KBxztwZyiz43CAjzqiak/aqd1SugEs4/iECyylT6/MPvccCt4u9klXcrdw91hW DB3ILb6uhzN6D38BA7tcFlauQdsAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDktMzBUMTU6MTE6 MjErMDA6MDDLe0r5AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA5LTMwVDE1OjExOjIxKzAwOjAw uibyRQAAAABJRU5ErkJggg== X-Now-Playing: Rhythm King And Her Friends's _Rhythm King And Her Friends_: "Client Interne" Date: Wed, 30 Sep 2020 17:12:01 +0200 In-Reply-To: <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 30 Sep 2020 11:09:38 -0400") Message-ID: <87ft6z47um.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: > Seriously now. Should I send an email to Luc, asking him what he was > thinking 15 years ago? Otherwise, I'd be willing to look over the > versions at that commit and it's HEAD^ if you can send them [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: > Seriously now. Should I send an email to Luc, asking him what he was > thinking 15 years ago? Otherwise, I'd be willing to look over the > versions at that commit and it's HEAD^ if you can send them to me. Pulling down (and building) Emacs is super-duper easy: sudo apt build-dep emacs git clone git://git.savannah.gnu.org/emacs.git cd emacs make ./src/emacs & -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Lars Ingebrigtsen , 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160147972329034 (code B ref 43714); Wed, 30 Sep 2020 15:29:02 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 15:28:43 +0000 Received: from localhost ([127.0.0.1]:60837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNe27-0007YD-3k for submit@debbugs.gnu.org; Wed, 30 Sep 2020 11:28:43 -0400 Received: from mout.gmx.net ([212.227.17.21]:34375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNe21-0007Xu-7f for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 11:28:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601479710; bh=ruNXWvSv5Eq56YUwmSuYEhrrLS8V1GccUua7QlleKyk=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=Z4zcSlG3Z/lnudyNEXl5OalTmd5P2Wmgi/ygh4vUke1Aalc6dwBWS8ZId26lvZL7u Q0Dz4T9zxW6lmP1+Avw2omgq8995PQqsouzp14iXA5Uxd4EuP7kheWucm+VvmNC60G +oQ2uGd8He0EVn3+jhMYD/fPH8jGgkpjiwlpcKpI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MN5eX-1k5Hpb1RG1-00J3h4; Wed, 30 Sep 2020 17:28:30 +0200 Date: Wed, 30 Sep 2020 11:28:27 -0400 From: Boruch Baum Message-ID: <20200930152827.jseuon2q2xeh2om6@E15-2016.optimum.net> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <83wo0biboa.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83wo0biboa.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:FO/47OxPcQ7j51Ls5Fxs53kKeIsTcJoKntQL0fDSy7bnT9BEpGC ilMVKSr8qGpV8r8h/odgTkPQypVs5HfEy3M7atRzakzXOBZl5IdhSDwodEaFNcepWo+n0YT Aje+qrhW63QLkMNoVfxwxgF59oJsGfT8WCwV22+7UvcMMOxVEf/kIszieaC6XKoxafjCx6D qkleVZq56CAsX7uEkq/ng== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FI+X4asuF8g=:AkM3PzYgXhOIHwFYrU7/dP HJ4K3970zYhnwcstlzXMCIIQaYgKDvPTAa0z2y9EPhq+RZE9HLSltbxG+qrM8KUpNSkzr5IZC KZCs1mbS8I+YIgBhFp/oM6o/W3vnEEW6FeYRt+9rcwB3jiT5g/RLkmGXuPjy7szlP3iaykR4S FJCaunl43C+sSLccZGh+niCAvq13caw7uEcSQQiv6HuLNDMbZ43Uz1cuxTQto3tDTZq5Ac02d IAgNhAZDRW6sWhQbkq58AsdpHqc45/615XZZBAQ0LmTtARsC+0mQsSvJD44mI3zmN/l6bcsN5 9ahIOJPI/m2q6ardbq1vko9qKrtqurJdituHvlYNbquW1MEweYCgOs5ntYZg1vNeMGhCeYBQG O78goAzLuETI7dzXNWSaYX2hVGWWcllm3p1CYcve9anlOjPKUJvm1qEPhPVT5W/rQ83i/gLo2 ygJZTbpWlbzWClhOpmiYaAOADmEnIfJTbFzPALOgJGMndgrKUyfjh2W4HrQZ8CTHZ5IkwoLng vBEn/62OsTic/s4z/jk32TUTaWtnQxOzJ0nvMj2UDb2meh8WcLx6psx4n9w8DtAVhNafk6qaz 0/HLwNMio675gppFtPfPKphvWoC7OMQxJLuJXCs+6isyaYVexXQHShOskxiL4duYI/EQr9KVt 4uNBE+/k23c9oZb4hzpOXKp3AgMafat36i4d+CVzpILcoRi6F5Twfc6U0zWddj1dgBKXVl+z7 3xxnYwxHF6VXeRv8kDEfy5m4lR8dXgD+G1Z2oNxcURqe3/s3BOtoFTaAqLUyoKpHjzq1TWtKI aV/PPkqfbPAfRaG3hnnCJR/I3QSJcgKfBfalMOMfRdVOUAyAs6qwrI54uHNRolcqYmiazUUCs Xsb1XN3MTES14MrLyrWP/3Rpn0QFPlMeyfmsJjq6ay7fxQxbdr75wUjBQFR15yP2gKFxWwuT+ EQE/0J2/bgZpI4BHMKe1B7TSpxhjuQyCPIRWAy6qiI0unJj2Thp8PcmyHO0AROH16BH0SFVUD zBGNaudQnh4xkmtUzfj5gpgEWpfmOfJcsZojgUWZQEKHOLx83e466Dtfe5yzOXpeprWYySkkm TZzYTCtO+9VMjARLYMaTElcGEugYaKLvxO4jAorhWYhDTbpIRd1gd9S1oSNYdBl5kJi61Od7z dPRSBUeUSWsDC/i2aPjVEGGyK/8icGpRzwIm9DduSDCiOVfe56GU94Dqq4qTfCX70nT+n+i3e vXngBM851jPZUcIAadHVSuN8xaKQ2QETq8upqIw== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2020-09-30 17:25, Eli Zaretskii wrote: > > (auto-revert-buffers): Use save-match-data. > > It could be due to remote files (and file-handlers)? But I don't see anywhere in the code itself being evaluated in auto-revert.el that would produce its own match-data to potentially disturb the pre-existing state. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: larsi@gnus.org, 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160148185416712 (code B ref 43714); Wed, 30 Sep 2020 16:05:02 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 16:04:14 +0000 Received: from localhost ([127.0.0.1]:60970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNeaT-0004LU-VI for submit@debbugs.gnu.org; Wed, 30 Sep 2020 12:04:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNeaS-0004LI-7B for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 12:04:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36870) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNeaJ-0002T4-Ud; Wed, 30 Sep 2020 12:04:05 -0400 Received: from [176.228.60.248] (port=1939 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kNeaI-0000ab-Ur; Wed, 30 Sep 2020 12:04:03 -0400 Date: Wed, 30 Sep 2020 19:03:55 +0300 Message-Id: <83h7rfi74k.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20200930152827.jseuon2q2xeh2om6@E15-2016.optimum.net> (message from Boruch Baum on Wed, 30 Sep 2020 11:28:27 -0400) References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <83wo0biboa.fsf@gnu.org> <20200930152827.jseuon2q2xeh2om6@E15-2016.optimum.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 30 Sep 2020 11:28:27 -0400 > From: Boruch Baum > Cc: Lars Ingebrigtsen , 43714@debbugs.gnu.org > > On 2020-09-30 17:25, Eli Zaretskii wrote: > > > (auto-revert-buffers): Use save-match-data. > > > > It could be due to remote files (and file-handlers)? > > But I don't see anywhere in the code itself being evaluated in > auto-revert.el that would produce its own match-data to potentially > disturb the pre-existing state. That's what I meant: it could be hidden from plain sight. Why is that a problem to leave save-match-data alone? Does it do any harm? From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: [boruch_baum@gmx.com: Re: bug#43714: 28.1: auto-revert code improvements [PATCH]] References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> In-Reply-To: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 16:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014846995341 (code B ref 43714); Wed, 30 Sep 2020 16:52:01 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 16:51:39 +0000 Received: from localhost ([127.0.0.1]:32916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfKM-0001O5-RX for submit@debbugs.gnu.org; Wed, 30 Sep 2020 12:51:39 -0400 Received: from mout.gmx.net ([212.227.17.21]:49115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfKK-0001Ns-Hb for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 12:51:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601484690; bh=Kzu3PA8pIqb3tFw8E04mA9iO1CcgxRfdC5Qp/eBiibo=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject; b=DbL+T/gNFDOY5fjSXj5IAhBM3lLTNKCfhY02CALO9VkCgYNJ/E4u1Hmu3KOTqvoDQ 2PCn+IXWFtfpIGYUQRtfhETgrid1S/nahlJYZx78Oqig0ihZekPVzqQJpXINuoRFmO eQ9gqpVNc4dPxDyg1lJsMQCiSuXwH7v6Wzuix6gc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N0X8u-1kZfrZ2r0G-00wX6v; Wed, 30 Sep 2020 18:51:30 +0200 Date: Wed, 30 Sep 2020 12:51:27 -0400 From: Boruch Baum Message-ID: <20200930165127.ukukbvqkvwdx2j57@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:2zwcUr4IfdTx8Sie/KpVyu9NCCfG8T3KWt1y40kAf2iJ+Qh8B7P iJA4AFDoqEZRE1tQdAlVa5kiOlRLinmAYGu5Ev6725mVMYX0hq65EKtCQuVPmuKx1d4fyk3 5khKw2/FmEbamzf8VQqz7uvDFERBYSLzPEzO6NJXKMcS8XgVytItHQbquV4fRJvcPmTtKOi sk/TMCfvgVYFAbNRr0GaA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:bjkb19aBDAE=:5jKzv2WVp9Gkus9AzXBPCm CdcQlBNNctFDBV4Nqgd+O2NZxKzACJ5n9c81lH2y+3u8mzNKzWkpJuui/fKNQ8kZ84FHzWVNd luhRfAU6Ic/JCSROr6fmX9VvBNiwYNSmKZLZj0wXhlZol2+3jg4NTL4SwJGLbCuLpHL/fA8OY e9KK9S3R/315PgMkG3Nc42RbS7ec+sTkvGONb1JHjdBp7TLHThAAOvNqsERT4xuxspUciTJie rVDOikprU6vya1uRXRYeddQ4fLrDnerEu1ttwVciBuWdp3ewRnXuFqnS0C2rUUOCFOpIbWT0/ 268bgG21WVAR+K2F/c0C+FlxGjrbxpLXWicKcz2OCTH1nOyvEOHmaIj7r06nz2o6oQkCj8nZj c3TNKOUu1V1/k0+BdCtyYpcbasJDv90NCJKsuDckzJK8g0fBj/Mm4otRPhFeisafMwK43DGEh 6aDq/Rp089LbM8fYQ/k3XfgDo95gSwMUC2xuzSuP6t/otLF6lpBHwQiZuhBcCoBikZ4S16log A/kDiEfK1pNP+Exq7CNByaa2Sc/7KnRhRKbROq9y/SEYkTik7MHaufM0sBqopLHfTa5QZdZM7 zHOXNwttLr9vsKfqJKe+i0pyAoNQkzE6fZxWw0S82p42GbQ0cGlVfRdgafDF0I3818P235KQU mLnuu2WwgZ67QLsCuypdm6ek5XdJQ3yrsP7q9uGaXxkGAIjiWwZrEzeikL4chUl5WFhR6+E5G oHX9Lo175K5FEm1eRJc+3IMqYKOSJK9H/uznRzRKMSCrSczmKYa101xJMPATdqon2Fx1At/lI 0/usEbyEOWgRWJNoxyDJpx1tGxCYgHh1lEuWcP1OgwUNjZGP6NjrkhlTHYtPFW1OCGybSnCU/ eI6/VJxcrCOlw1oFzoqWfl02mHKSDH9/KgRBykBqmdzXRzCxaOL0pHxd8MaHFUW+1jL11BT9j /htcylX8FNxVHPQCOrSLHUBO5VGDTXh7EDaB5/I4Oh9W8u2UmM9gq7ZMTgJCTzyzNA9DauvoF LVnpikOQEE99yDzEMWdEK7H448OfStWDe85yhkPqwLAgfGEhmeM+pcQ+Ks/vRSkCv4cFu0lME mN4FdpvyHZEY/g0OZK+KymQEW8gLiUJAztQO0Tka2A1uWk65FTOGOGuf+Z8922ECNeM+O1OCc emN7UVSFThc8xiruzGzFLGrAGkVgqnCkkfflXNLYgF+Nf23TXIH9AB+JASVNxs174DraFjJWw lC5DukMcbeKra7rN/0qdnkgBuDxZy03nZCz58iA== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2020-09-30 17:12, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > > Seriously now. Should I send an email to Luc, asking him what he was > > thinking 15 years ago? Otherwise, I'd be willing to look over the > > versions at that commit and it's HEAD^ if you can send them to me. > > Pulling down (and building) Emacs is super-duper easy: No, it wasn't. I spent a lot of time last week failing to resolve the ensuing dependency hell generated. > > sudo apt build-dep emacs > git clone git://git.savannah.gnu.org/emacs.git > cd emacs > make > ./src/emacs & Maybe I wasn't clear. I meant just the file autorevert.el from the commit and its HEAD^, not the entire emacs snapshot at those points. Apart from that, all I need is probably less than 5kb of data. You're asking me to pull in how many mega-bytes / giga-bytes of git for this? Had I the extra space and computing power, I would have done it ages ago (seven year old pentium...). Another possibility would be if there is there a way to query the savannah cgit web interface for that individual file at the snapshot and its antecedent? =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: [boruch_baum@gmx.com: Re: bug#43714: 28.1: auto-revert code improvements [PATCH]] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014848965616 (code B ref 43714); Wed, 30 Sep 2020 16:55:01 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 16:54:56 +0000 Received: from localhost ([127.0.0.1]:32920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfNY-0001SV-B8 for submit@debbugs.gnu.org; Wed, 30 Sep 2020 12:54:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfNW-0001SH-Kj for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 12:54:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pEfsNIiuJRoWSqRrDV0ijSlxLcXzdyCwXHgh1EaU1+s=; b=Nx2A9Fcr0NN7RelINz/WNT5vIS n3X03RuoKDdJeksGoG+DyUd7jmFE+vFUGOz1m8j2dwI33/K1DWXmlKRf9WeGsep2qvYO7umFW2QH0 vdFI5f5acmXPPzkNnf4VsTL8ni5S8RY4Rt/zGFZFOKd+R7exLNieYYxH4TucEUSa36Yk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNfNN-0003fl-FW; Wed, 30 Sep 2020 18:54:48 +0200 From: Lars Ingebrigtsen References: <20200930165127.ukukbvqkvwdx2j57@E15-2016.optimum.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEX8+/rb08+HeXeu oZ9PQ0L///99ddW+AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QJHhAyOsuNn1oAAAGySURBVDjLdZSJ kaQwDEXtJQFsbQAgOYC2PgHMuMk/ppHoBXPMiiqq2g9dX3KHELKMIQTy18WGxkJQ5juJ+k6JtKzv u0sYXyFgkfQA0YL8wRSewDMJ/w8s8wOkFFNkXa24a2UDYoXq6iYXkOwBb2Bt9QQsS8THw+x1A2U7 Nb92CiUHcJs64DHiOO8uEXhF7qC7AFV7JG6HCIVP35fGy97n31OYVYrq9Bt4L4JP/wnrxVjm7E0S M/fMraxNNE8bKK3r4UxVvzxS8S0Z/GSPBdj8h/oZULQyd1DJmqf6T81iAm65ZBAHJocfU7G062hj LJUUq4GtZoJUKmUKMTIM2PbZaiZCHWOWZZ1Mz5oxZ94aKQKwqHXzysCYXNIvbzxxTclKtl0BkEbU wt9WVdJj/rmqEUIzoIy+F3m2n+RgCnwsGVmcCmYCN+2rEqLAP29swr31tJKDRU+C4mLPjw3PMMnA kDsYqs2PhJ6bX7NpW8+59yuR7calc+59xUy7SI8UrsMrxHxLkdyigWsKragmbB7DcOnC+gO5izlc I+03k/D489jyqPCzCRumb2gv5hB4u7WfQD+3RWwBHfiVugAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAy MC0wOS0zMFQxNjo1MDo1OCswMDowMLb3ckEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDktMzBU MTY6NTA6NTgrMDA6MDDHqsr9AAAAAElFTkSuQmCC X-Now-Playing: Thee Oh Sees's _Putrifiers II_: "Putrifiers II" Date: Wed, 30 Sep 2020 18:54:44 +0200 In-Reply-To: <20200930165127.ukukbvqkvwdx2j57@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 30 Sep 2020 12:51:27 -0400") Message-ID: <87tuvf19yj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: >> Pulling down (and building) Emacs is super-duper easy: > > No, it wasn't. I spent a lot of time last week failing to resolve the > ensuing dependency hell generated. > >> sudo apt build-dep emacs > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: >> Pulling down (and building) Emacs is super-duper easy: > > No, it wasn't. I spent a lot of time last week failing to resolve the > ensuing dependency hell generated. > >> sudo apt build-dep emacs >> git clone git://git.savannah.gnu.org/emacs.git >> cd emacs >> make >> ./src/emacs & > > Maybe I wasn't clear. I meant just the file autorevert.el from the > commit and its HEAD^, not the entire emacs snapshot at those points. Even if you don't want to build Emacs, "git clone" gives you the tree and you can investigate whetever you want. > Apart from that, all I need is probably less than 5kb of data. You're > asking me to pull in how many mega-bytes / giga-bytes of git for this? > Had I the extra space and computing power, I would have done it ages > ago (seven year old pentium...). I didn't know they were still making Pentium CPUs seven years ago. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: larsi@gnus.org, 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014851856158 (code B ref 43714); Wed, 30 Sep 2020 17:00:02 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 16:59:45 +0000 Received: from localhost ([127.0.0.1]:32936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfSD-0001bF-JK for submit@debbugs.gnu.org; Wed, 30 Sep 2020 12:59:45 -0400 Received: from mout.gmx.net ([212.227.17.21]:40745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfSC-0001b1-Hk for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 12:59:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601485178; bh=s9o16xf0NHtbmbdfNzDbYwuh18DiQ/V0w1N+Jv8pEws=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=gPPXr/UdVVQjGkP8hK506qx9JAHu7mmo9mnxLTArvrUFJ5BcaN6oxuDJ3enbfB9sf f0xnGQ8UkuUpvMVbUyqFBHO8c8vNMnRIPiQh0x4h67k4wZcfJ0hOmwy1K+3l7O2woo T5eTDkoIlivL+Dt1GsTIeRzrTk3B6S0lPq/3Czvo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MxDou-1kcyLB3Olk-00xdSI; Wed, 30 Sep 2020 18:59:38 +0200 Date: Wed, 30 Sep 2020 12:59:34 -0400 From: Boruch Baum Message-ID: <20200930165857.6sdswdttxiy4gly7@E15-2016.optimum.net> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <83wo0biboa.fsf@gnu.org> <20200930152827.jseuon2q2xeh2om6@E15-2016.optimum.net> <83h7rfi74k.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83h7rfi74k.fsf@gnu.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:JldTGgmEB1a7CKO5plAm+YHH6OvkT+QSwLwQRoCWzWnU6xMTIRA VUDNoK9rNtrtIB/gzMPzc8vrVUtcL0VE/6+AwbF0XsE2QdQbmCfcu2aB5YguCV3Q3NRniKJ Op8vUjooORs5L82Xu6GeHFiSa2z6+ysumVIc/wlGNDv+1aruAvSe6MBtBjFPnCYVc0rg+gp eTDbdt/dx59Dh5Z/H2h4A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:hXsSYRWMH88=:TV36Ws+8s2fAaIEtQTg/Or Wp9VNR/3EuJ4N1P3I/CkJBqJhoIWJlYseWAXiIox6yHfBBbogqu9jCDdd26jKOmKu6dLIPV5T 5fVeL1FVxnbuRuAezrW0GGdcr4NixVZwtg+s18mf6Amn+Rau3GUO+7sc1lyb+EvUqhTQQQFGR b+92rCx8twlyQFsgCohQozTvG9UOkzmmUdu5fnvtsZJsm04zCxVfcfor3nh7o2Wln6W3LIzyh ft2zd6oatnKm85JW254L+ebaT91zs+nnjCl6ZQCfL9Vy4klv95xOAnRaUaZjzprx20BS2NsBj BxRX28APgGpAQp9hD3Bpa9iB8EUmstC/Fl227KGLE+NQDl48VmIjYDbg77rhYlSlwevFe+S4I fTmLpgTHekX3Hk+DzHfZZoj66jJljLXug/aXlYumzY2h5R6pUMk3n7NMitVQ26wBei/UJHUpf H6p8G3YWm8F6svRz6xudJ8qiFp4+a+/k+A7i3AD3KCMFS9PByEiieN4a5GpWv8BKPwG6Swkoi /bxYRonaqwDO7+wEIK1MQwfGsWUnX10GQ1TSTNZ7F0wMaka+U4FC3MDKykY3UojhkqVWzx9D3 7XgUbycYaRHkCW+TGDgeWNv5oNUA7PKyTkNEnoWCV6G85ORxAnCWqjNoRO/gEIdmwkyLR2YcV a2gr8cV8QQaaRW/zRIjjgCf6Ad/9eQ1DCfGcuH1l/yeeKzm7q/Ru41WnIO4YKq0vkYGpfaLrh gGj/T9VGOUGKXJ7o1Hjg2aPRQmgtHIWnev/33OA+jeVzXi1wnwIeEqbTLFTd2NVMOreBLfAxJ CJenoUOotBEOb51WwTK8htpdzTht2eoHEcFMYlYG5TyWypWT4RFjix4GIm3HH2cYLXxYgQs5V vCiYj+0n8QDxDoRzOmHsPb3ZtAIh9uh2zYIvqYR9OxbITbzefSD6KDVvlc4OAiFhfoIDGxD4N 1vo3xk9wvyd0KV052ijFTs9/OsXoqQX/0QZxw7QlxNGXElbS2TvCJxJAM7VREyOUaPU4O3Bz0 0iE6akI6XONoNWpn0X4wcU1F+cFMsNuqFSi3KAqw04dDNq6oIc/sprx3/Q0CCHbpR8ATeVd+d rVdE51/INwX8c7oAXT3N4C188aZVvnA5rlgd9pXmKZ8Mlo6+8RWYGt4HZuHSZx09N1Isz1QcK +s/MDkQG/yf4+G3myq5xZNMJlfdsjnZAdtNfmQQ0gIQj/8gVg5TIHcO8qUc+OxXbW8KaLzRyd CH+loUb5c3h6lYoUkbR0DmWlPB4FPCGP8ajjB9Q== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2020-09-30 19:03, Eli Zaretskii wrote: > Why is that a problem to leave save-match-data alone? Does it do any > harm? I explicitly said in the introduction to the patch that it wasn't 'fixing' anything broken, just cleaning things up (potentially / hopefully). When I was researching how to best implement that "auto-revert only if visible" feature, I found myself puzzling over some parts of the code and came to clean it up to be better able to wok on it. That said, You could leave the (save-match-data alone, and accept the othe= r changes; the other proposed changes are clearly independent. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: Eli Zaretskii , 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014853266502 (code B ref 43714); Wed, 30 Sep 2020 17:03:01 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 17:02:06 +0000 Received: from localhost ([127.0.0.1]:32950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfUT-0001go-Sa for submit@debbugs.gnu.org; Wed, 30 Sep 2020 13:02:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfUS-0001gK-SB for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 13:02:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=htO2HFByRR2OIyEZpehOL4/7fyp3rKoOtGfy7d0yijU=; b=NoS9rgOicYBUBSdRgiauvGEjMM xDqzoCDaxAOIhOC+AYe2oMYxNaRGaDdIGqOOyRHFSdeyE0307wYcrnsIcaFkVbYJBDhHI2Q8JXITG 2djwt69W+9httMoURAm3a8i+HzwfTH94fka7/LskqF2t+4gAQZlztSq4DKOPZHkOgTFU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNfUJ-0003hP-M9; Wed, 30 Sep 2020 19:01:58 +0200 From: Lars Ingebrigtsen References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <83wo0biboa.fsf@gnu.org> <20200930152827.jseuon2q2xeh2om6@E15-2016.optimum.net> <83h7rfi74k.fsf@gnu.org> <20200930165857.6sdswdttxiy4gly7@E15-2016.optimum.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEX8+/rb08+HeXeu oZ9PQ0L///99ddW+AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QJHhAyOsuNn1oAAAGySURBVDjLdZSJ kaQwDEXtJQFsbQAgOYC2PgHMuMk/ppHoBXPMiiqq2g9dX3KHELKMIQTy18WGxkJQ5juJ+k6JtKzv u0sYXyFgkfQA0YL8wRSewDMJ/w8s8wOkFFNkXa24a2UDYoXq6iYXkOwBb2Bt9QQsS8THw+x1A2U7 Nb92CiUHcJs64DHiOO8uEXhF7qC7AFV7JG6HCIVP35fGy97n31OYVYrq9Bt4L4JP/wnrxVjm7E0S M/fMraxNNE8bKK3r4UxVvzxS8S0Z/GSPBdj8h/oZULQyd1DJmqf6T81iAm65ZBAHJocfU7G062hj LJUUq4GtZoJUKmUKMTIM2PbZaiZCHWOWZZ1Mz5oxZ94aKQKwqHXzysCYXNIvbzxxTclKtl0BkEbU wt9WVdJj/rmqEUIzoIy+F3m2n+RgCnwsGVmcCmYCN+2rEqLAP29swr31tJKDRU+C4mLPjw3PMMnA kDsYqs2PhJ6bX7NpW8+59yuR7calc+59xUy7SI8UrsMrxHxLkdyigWsKragmbB7DcOnC+gO5izlc I+03k/D489jyqPCzCRumb2gv5hB4u7WfQD+3RWwBHfiVugAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAy MC0wOS0zMFQxNjo1MDo1OCswMDowMLb3ckEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDktMzBU MTY6NTA6NTgrMDA6MDDHqsr9AAAAAElFTkSuQmCC X-Now-Playing: Thee Oh Sees's _Putrifiers II_: "Lupine Dominus" Date: Wed, 30 Sep 2020 19:01:54 +0200 In-Reply-To: <20200930165857.6sdswdttxiy4gly7@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 30 Sep 2020 12:59:34 -0400") Message-ID: <87pn6319ml.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: > That said, You could leave the (save-match-data alone, and accept the other > changes; the other proposed changes are clearly independent. Could you submit a patch with the save-match-data left intact? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: > That said, You could leave the (save-match-data alone, and accept the other > changes; the other proposed changes are clearly independent. Could you submit a patch with the save-match-data left intact? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: [boruch_baum@gmx.com: Re: bug#43714: 28.1: auto-revert code improvements [PATCH]] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014858457253 (code B ref 43714); Wed, 30 Sep 2020 17:11:02 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 17:10:45 +0000 Received: from localhost ([127.0.0.1]:32959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfcq-0001su-T6 for submit@debbugs.gnu.org; Wed, 30 Sep 2020 13:10:45 -0400 Received: from mout.gmx.net ([212.227.17.22]:39109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfco-0001sg-8g for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 13:10:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601485836; bh=Xjf4wsU0W7/JqjadAfMiV89ymTetXvMQ0ps3GG0lIqI=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=c+fZFH46Oq99OHAG3H36HD9DNKszsGasRJZM7+uMMOoqH6E5W3GJenvIbu5wTfyZe N3+5SULZVQu7pX6eQqfvUqyJTV9+cZqGdt9A4wMvWXNR4JlNZslaxs415j3cqav6Zs aL/FSVz+XxWcg+P1FkeYNg03CM0DmWNS12eJXou8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mxm3K-1kcQK531aw-00zHEa; Wed, 30 Sep 2020 19:10:36 +0200 Date: Wed, 30 Sep 2020 13:10:33 -0400 From: Boruch Baum Message-ID: <20200930171032.jomwde7damhszlf4@E15-2016.optimum.net> References: <20200930165127.ukukbvqkvwdx2j57@E15-2016.optimum.net> <87tuvf19yj.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tuvf19yj.fsf@gnus.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:IvTJ2GEX/MvQvw50lQEtZuKNZDuOhR0ift+2O1JybXj5Xtx7cKj Jx6NW/Rr+Pz1mXt1WFvrQfR0Shk82ge59rlrbP/w56O01PFXmalCc/iVQGGS3ACiMaKWtri f6WUFHR2H+e8vuu+FJhWuNK/QIuOwVGM4NQFpzxifjASim7gtdhuLcwx09+VRS1N0YUG71T mrgmEr1oMJI/lhhAxZFmQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:MzJW3Q7jkds=:h5yTFKcbEapRDK9ZdeHX7M b0akyE6Y4O+n2H0aqWM+iohJm58OpL5A7Wa+Z2jSpVqzCxINoNv1+k12Ao7JmUsknb14JiPlS mjivDN4Sh2K/PoK04VyemTqZjB9S82BhBnLswEose0rH2/pUDeEODbP5TRbMdfAn0UsQoS2Ky UOzVSEoKU5gjLHW5qqNXie2yXBW6wz/W+M3QN7c/yY5mMDX4u0zk/fqbPuIQLqcUmU0bew+lk Bcdy8eG9pUMysKRQHXWPoaYbkKzZWvZyButgRTWKjmb81KecczNU1HbwOUt6NylZI7XL8e3Pr TL+4mkASGCNLMOZ47sFzx/x4vj0KSGm2tOXE1XyPIBuEjWcl4ANL8Sup9afy0c47wYQYSO/LJ rl5Z/4ame4fkxTnaQzEdh/bzZ8KavF4wENyJZYNi4bhcY2eCm8DLzolmahhfuCg1a2lFdtdZX lY3Y/rCLVR2cpcJkeXEIfgWNOjpMTIsfTjOdEKO7/ZBVmuYMsppypb2fzp0r3gGe0M2uFxEME AZFfMkJdFXyIQ8T+LlzXH9wVODtHgFxVfXfIIwf8criyrj+bWvt05rUCAgJqDZZsKo8rL3sXU zoESkpyJZeETYt4ECfgZ6SNc81aSOObZaHPdY5nkPppNaqfC0SqhERPKIsbUb2mUX8MWa9ONp bn3V54shop5qQOE3q7srGjSVchywEsv6a3z+ZpNBajLXbu2z1wt0f6bj0OKsFrAXM5UOob3ih /xm6zuwxv84G/hSwzofT6o8LHT0VoP9WypUAwN+9RbDddC/QJfdHrJmOcP857WkpSeoXaOZcV fdxxpfCOulCs5aJ6AEl3kb2O8b2gZIQJYGdr62DhazldPH0O1uyf4Ewoe4WSrG0UYoL+CHFMZ tixeZ0hvjqEjukm01FZ3PD56SbWQug/umEd8RgPO0iDiAuvU2+uD7hs6j9rBZkCgW8rv/RxmT cVTjkuVicKWquYjnb+d1zF9JyA70XketqczF423pTO8vpfdTHb76VKsxRvhgdv2m40xZDcPw8 kgu3ej2wihTD8qVOnqKkPpTO9WrrMJFJBmuE6Drx2mN5bj/NXdwsqk/hKcoZAf7Qr4FBLu8yD NbdjsE1vFyx4xBJsWk02IgfDB6SgcwL1FoorC6rHp9MSmkhJQe5K4MgNJXXby6lGW/ws2LxNX i1bISR3LRczp63uEcmw9C5hQJe84QWC/y4m4YQtPEj4TZAJ4CPs9KU14tPRbttnZ3EInfmnfq n5qj4k2zXBdPbgyfB13XC2OgnbwcwaDgiqa+lQg== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2020-09-30 18:54, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > Even if you don't want to build Emacs, "git clone" gives you the tree > and you can investigate whetever you want. Then you read my next paragraph... > > Apart from that, all I need is probably less than 5kb of data. You're > > asking me to pull in how many mega-bytes / giga-bytes of git for this? > > Had I the extra space and computing power, I would have done it ages > > ago (seven year old pentium...). > > I didn't know they were still making Pentium CPUs seven years ago. dmidecode tells me its a pentium; I routinely forget all the detailed hardware internals of my machine, but I remember purchasing it new seven years ago. So, returning to focus on the work. option 1: just flat out reject that line of the patch; option 2: send me the old versions of the files; option 3: tell me how to use the savannah cgit interface to pull the two files. This all being volunteer work, all options are of course themselves optional. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Eli Zaretskii , 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014860397566 (code B ref 43714); Wed, 30 Sep 2020 17:14:02 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 17:13:59 +0000 Received: from localhost ([127.0.0.1]:32968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNffy-0001xy-NU for submit@debbugs.gnu.org; Wed, 30 Sep 2020 13:13:58 -0400 Received: from mout.gmx.net ([212.227.17.22]:44237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNffw-0001xh-LR for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 13:13:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601486030; bh=HbNBFYdPGFA9SlS7EvTHs82lRL07z5k7JxZ1BMeiGRA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=U2/uROi7M3E+1G831iQ9K6znuu1mbVkToL/Sco116iopdiFu6arSYXV6ofAAMbbsl pf7rzNXh+8U63Ox1Y6ZWohymCwNgSXp4JnfVr7GSr7/50yutwN021kvtr7i+S6j5YT 1td0F+f9sLPpbz8NrzR11cO59/m/nbZJ/t9AFurc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N2mFY-1kXSCI0bca-0138jt; Wed, 30 Sep 2020 19:13:50 +0200 Date: Wed, 30 Sep 2020 13:13:47 -0400 From: Boruch Baum Message-ID: <20200930171347.5qi4attui7v7lf2j@E15-2016.optimum.net> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <83wo0biboa.fsf@gnu.org> <20200930152827.jseuon2q2xeh2om6@E15-2016.optimum.net> <83h7rfi74k.fsf@gnu.org> <20200930165857.6sdswdttxiy4gly7@E15-2016.optimum.net> <87pn6319ml.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pn6319ml.fsf@gnus.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:Q305/2GVJlaIecW3AVDht9LVXN3r1DaoF09HIuVRdt/UvbGcFfl y5qqBS/ZZEBOJiRNtZLI/O0wiwxpmPfeZZvOhXa5LNu6v467BI9L/cfao3+IOb91U1jjyT7 ol/sVkwMTWse6HQHue4X1GyErC10NQ6Dz7tQsEiHp1Z+QWltl5I5AzCuiA0wuVqgdpOEYyT 9ulWEIVOntUb1DPerOe1Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:RModY4uU3NE=:TL3uq1tja9RUcuiQUeFNxO kNWecTuOGOO7L3ZiFiAXKCUNYm0LtUzwVAT3dSwlYBlfUHPmgkMoLu7b+BsKKwZzxJEFFmz+1 uiA16J3bY1Az9Vy4ZWHicYnoU5lV9PK6YB+sGP30XLVRqRlKDeJt2PWTh7RkyLZ31jb2sy2AA 5xCDLmPd7W8r87YTtJFPnzppvJBwsCcyWDiQZOA5oSshVnKdEo1KuQeG6SiXhf+z7G4KLXRU0 C2upcg3qXqyEAu+Fz5BX/MT4SmHe6z/fstC5UGbf2FGEFLhslsndxDnCictlEzhwHwm3wEzHt MpXQPIYltwO+krERo5hUEaLDhPoZgvpxm54nlx1PIhZyuQCfoYmjt2iMfuumgxoCPY+P8thUr 8Jc0DR5w2WPsHsbOXPDR9NsJNi266NWss00wF2uPZZeKwcYlg/lXLjeG7IuBSQ4Wlo1zUcrxo U2TAI3mUc2xWK272s3PcEhfyG/JuLHs/oNJSPeBSrRXSJLW4GEqTi/Cv1M8E2Gjnqtzxevnht 8Toi3S4gj7WWJCeh6xvqq+O9VXv/xvqN3L6gNQyPSHO2Is6Fq5CVWQxXEfyG/SXKB0va4vY+Q ktOEE7P82+0pZCLA0iS5sZogM2oAY7OcMsou/oNXXfi8rSYQl0TQwFdcFTLdwOHm3TJniWhNG RnGI9JSfDjXZ0YSdjmPOULiqx/9byKnuncIcd69gx0f9a3OvAbMHfkepg/+JWzEXDtOKUHjt+ LlgCx2E0IQYT4tJADGdjbSXuuQi4Ft68owouzk+Jjw6f47lCuk2ZhQ6XRu+jeQF0NBwzJMoVB bgj2w/YsJBxTPZZd4Qnwre2LOUyDKXcrQjf5wOWXyZs9OipaIE+rOKAnmQ3swEQoVbVbU7OIL Z1IgEQgQnpqNLYASG56u43ivB0cYXhaKMQ7avSMWb0WXQSk/UKncxtuswMSENgwkk2C00K15F RDLAJoRdU+ltcTi8p9auW3vEOnqerZiAqLmov/PYAFujUaozE6qKMXEGnwOz/6j6HD8/xStjk 4mGwCuPjUmdWtUY3pQr7i/qVFq0f2hVrunt7pddrLpFAZM0AjgvSzAsnhHsg6/QgQJYXDa4k3 f2bNCKaym36cS3M4ua4xKhKPYncviN72qOT8yfJeI/yjvtjirhL6IlInPKNUfOB34M9bgVYCC aKgImrM2nIpZvM6aA6Ff33ihVG+Y/PkFyLFxI2XgZ5TJY0uzMfermgA0uOKaOL+SSGna+WRRo wH8cNipOXQEclzaZs2DZFkvUWfmvuG9E/oXDqIw== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2020-09-30 19:01, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > > That said, You could leave the (save-match-data alone, and accept the = other > > changes; the other proposed changes are clearly independent. > > Could you submit a patch with the save-match-data left intact? Does that mean that the remainder is acceptable / accepted without further discussion? If I'm going to make more submissions, I'd prefer to minimize / aggregate the work. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 17:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Lars Ingebrigtsen , boruch_baum@gmx.com, 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014864738385 (code B ref 43714); Wed, 30 Sep 2020 17:22:01 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 17:21:13 +0000 Received: from localhost ([127.0.0.1]:32990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfmz-0002BB-FY for submit@debbugs.gnu.org; Wed, 30 Sep 2020 13:21:13 -0400 Received: from mout.gmx.net ([212.227.17.22]:36243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfmv-0002Av-US for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 13:21:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601486463; bh=K+ZEHsTGfnQmf8QjZkoqrZkYCfPcrJs117CJwxOQGiU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=iuv8TTr/eg4xA5tMGnumToFlwKifjFCHcc2Un9mHLI3e4BgH3aJmw2sC0B8wWUU0Y pTCniAvXe0awl1ATRWUYyJ8swXvD3jhQWAQyxQS3RQlMXJFXNOAodwZLyu2zkl4XoW gP0Diq7NV2Td6JhwHiqAY6MiByMJJ43CkEDHRFr0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.159.134]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvK0X-1kfTmo0mSv-00rH14; Wed, 30 Sep 2020 19:21:03 +0200 From: Michael Albinus References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <83wo0biboa.fsf@gnu.org> Date: Wed, 30 Sep 2020 19:21:00 +0200 In-Reply-To: <83wo0biboa.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Sep 2020 17:25:41 +0300") Message-ID: <87k0wbji4j.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:0p775TgMPZj9SUxBM53JnwvnurCCkYXr3BUDYE9PGM3evLcD8E5 uBfdljAP2WzBxKc5bWAJ/fJlVIFQhn6Jg81B9KaT7FnnQEwXSc5174u4Kh2nfWwtxjjdQF9 EnFBouUK+6IwF/n5qEgwOTbagANk/hHCkwoaqeKU+cq+YD8mJtXBic2Gfov229oz4u8LUkH KtzGa2StuPXJz23hOVxoA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jf+jxh4tOjw=:Y7k0ZDeStSoS++YLvhLpbD i/MM4/GPoVFYcylNgi7iivYo8OV9nTvqI4vpc4Ay6if270JPBLcf8vW2Jci4hFYkbJTGwVsfz WzXengyGvt2P8UGf2dcJeua6bnirfldLnp9rpNg96ap/4Yb84Piav33r0uHpn1ro5GP2L+WFv VLaNYb0nQszVWWNnjuW679gm54/vw1liXToJXYh1KUNNGjRA7gKGlxqxeUWv726b17/9OgPKD oF/lUxRNKGB8LIyyNJ7pJ6HDfO6DRY72FlCDRWG75tdO2aZrzW1glloVGjfA5PpQnavis5kRH 8leTQjx9niyIO45V80jhsGFXKdaVVHKTQwYsx8Wdl/8Y4Sm9A8htGiOh9eHKc0u04cVs9ztc3 gcmX6ISMq924xe60vpoQjUHqIlvzLFPxEXBS+NrsWILxkEm5K3EOd2xDdLbOkBIfwJbbPpRx9 LYOLiNLZ2cglE9xClZ10J+JdlBgM9Eg5xQu87edyYa2MIOO0fP3JNJpB2DVRzcLDsEJAO7CGp hkiAsh1zTdk8bX3APvht5God/BVb2tIN9VSM4V0mnBYy1hRMGWmaVxmcrRlUDl6U/4O8VKS5s egVs63pvW8pjai9pe9Tl5GrLLUiBeNcprXq/KZ742jmqFOHSuehRvTNrjjWVM7qaR88XXEt0y RHb8iEBvz6GDPYzBMou20XvAEchxVsCfAJSPGI5Ec65343N/f9Fu/4BepdSW31n902Kbx6SWw xZCkfbS/fWSoj4b2AV0JJdFqsPmmxykwKZ//Rm6dQKy4H0RVhJZUToslhoM6YMbuf/JjHgvHU turf+7mwg+pWj8dPaU5pJuACWrOxKxuc/8OHHITzJguHYJL91Kzal39ddCxWYVanj4ddG4GbK sBdAVdSyVL8sklRiYdorpUpL+0P70fMTNb3n619C9fMs6RFC137V2Ltv88e6zIQRtJ9SqETDN hz6wZ6Rib5ak4YF+ClYHhFwl9t8ZcBZPDRkxTm669i4Ebgbn+Eu3ET94UgCJ9EftHtlaNncmt oqfP2kd5zGtLUuyNtz4sXualhatBg3s+fDgm5YVc7Trer+g5T9w7nTl2NuW0LurO0mrWhQr9g Vyac7hndsA8IutlPdYIezJo9j2GiHVTP9sPwXY6AGw9pZ+ERpcA+G6si9xF7pZY6i7+uOmZnT jSVMjOp1UrrKnlA8EhzQN9s5clfqO8KA7Cveg8f14/cgOlAC7g4oK9alxL0W/AUPdEKwmnDpI TDyI56F/al17/h6nHbeHdRuWe19JDcR9yWZi4XA== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Eli Zaretskii writes: >> commit 33512cbeb168764f83f5a740090ce40b4b948591 >> Author: Luc Teirlinck >> AuthorDate: Wed Jun 1 20:51:03 2005 +0000 >> >> (auto-revert-buffers): Use save-match-data. > > It could be due to remote files (and file-handlers)? Could be the case. There is no promise that the file name handlers do not change match data. And I'm kind of sure this save-match-data form has been introduced after such an accident, that auto-revert has corrupted somebody's match data. So please keep it. It doesn't hurt. Best regards, Michael. From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: Lars Ingebrigtsen , 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160148768518682 (code B ref 43714); Wed, 30 Sep 2020 17:42:02 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 17:41:25 +0000 Received: from localhost ([127.0.0.1]:33039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNg6W-0004rG-Qs for submit@debbugs.gnu.org; Wed, 30 Sep 2020 13:41:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNg6V-0004qz-3R for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 13:41:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39723) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNg6O-0003kX-Dr; Wed, 30 Sep 2020 13:41:17 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kNg6K-0001VZ-Q3; Wed, 30 Sep 2020 13:41:13 -0400 From: Glenn Morris References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> X-Spook: Communications infrastructure Bomb threat CESID kibo SSL X-Ran: q{'t%h>-~fbg"O]HM72}O}np:Db+OEraANbc/&jN7HQ`\gwaad.#flkB;8dX}=uCbby9W: X-Hue: magenta X-Attribution: GM Date: Wed, 30 Sep 2020 13:41:08 -0400 In-Reply-To: <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 30 Sep 2020 11:09:38 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The mailing list archives around the time of a commit are often informative. https://lists.gnu.org/r/emacs-devel/2005-05/msg01414.html From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 18:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Glenn Morris Cc: Lars Ingebrigtsen , Michael Albinus , 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160149083723742 (code B ref 43714); Wed, 30 Sep 2020 18:34:01 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 18:33:57 +0000 Received: from localhost ([127.0.0.1]:33118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNgvM-0006As-GS for submit@debbugs.gnu.org; Wed, 30 Sep 2020 14:33:56 -0400 Received: from mout.gmx.net ([212.227.17.20]:43941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNgvK-0006Aa-8H for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 14:33:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601490827; bh=GuIg0PkIYxvwOf/75rZW4cQerq3i1im5krGmS3m0fhA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=OD5+v1elOQ5ZvBPd4eDeoxIBnYCKEmHiaD/VzC3jZTvajsQ2glwWSvrQyHwxJ0f1P tffX7Oxd7OlUf2Las7S1NCorSmHSIg1MjqcLZEUYAfKMK9HNnz97TXfG9yvKJl3IFU GkMsreLUOzH9kUQWGE5+gbMyFP/MtvY38TKH6Po8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MI5UN-1kAGGi0XRf-00FBZC; Wed, 30 Sep 2020 20:33:47 +0200 Date: Wed, 30 Sep 2020 14:33:44 -0400 From: Boruch Baum Message-ID: <20200930183343.dmmyg2l6yzmfhkyl@E15-2016.optimum.net> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="63vrc7nydud32wto" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:ecLtlBc9omBO+Rn71rD5Wuwq2g1NwEO6nrmg0izJIga81fI346i 1GKJ91O12rHMzVCvXHMRnssEAykugU3We/2e1cx3wjK6pv7edKA3uFNxCuXYAWEoAk2443I fYxNma49CNcztIqhzqStLSflnNlvLCt9YpTkYfWcYrjf+oy7LBW+gQjJ0ZOw4hxPYw32V7k Gzqm/bjdReuOIs0u7/Kvg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:2ZH0YvCi7WM=:rC2h+omu8+adeMVKRIQstj nxKXmcqM0h9A9VQ3ucPI5ySzHgI6pQFfP49iop5DegQWhI1ESQDvWxCBO2sNM2fYFQdvSYVZC ZBxhq12BSrkz6X7ca76PFj5/WKQE8iQBRfvevdd2szYbfUldIltytxotczwLpjwutbVEyYkDS +W3hKe6piPJdztT5V21m84lTv0l3X+b0RPj7fcDMr3NdmF+p8LQUmXgdszIp3RIVPEU3trol1 rC1pN6kg4sj5nhXXwsDZNVs+AmJsso7739MKxjQOYAvn6I5BBwy7KW7Gj1LsveIyGp90C4QUA gpbuTwdXFdu6KR85gVIdXiZWOmcH93EK8oxWvj2+OfvCRT1xgwm3zEsR/dKh/gCHe7UzN4bPE gRlbNp2IZfojm+ak1na8tVjV7E9L6E+rfVzR+QROGtaDNTsyoXEtLvKwFLh7ZnldMq5fBX0UE hsJCtBhbB1fm6/qtrUFG7oejU8Poi9xyKX5NPiRKr/s+HudlDMzbxjlgKWmdXYbMDIbAVcKSZ HX1S6hgHrCG2wP2gAb5k8KKkfs7GG10GEzoBFFks/McDOX9CXzfPcSqnQRt3kG6OKsYAPs//L FcmKCfUhhiTqyW3ASEAen3xu5svBUS0nfE5UdJyRt6GpcOj+1c3piFGAK5amT7MvNgJqUUOx8 bdyZwq0AY5X4gOGiOUrIORuJmBRaEiPK3d3iLE2nTrRYPJOB/gHrJqOaLZP7LAVt0kEnGCvJc JIwwZrCAsJVXd2haVDgI+5GVvAAoA6Oir4Z2Bs2La/HB4WKkSCM6XjlH+J1xABY6skXorsIRX 1noZhLs/27cM0NxuwFSMcc1CukcxairZrUg1IPQmEUHssHoE84f+ujqV7BrJ5Ft6uNH3Kv7Qm CSdQNKDcZdmmtN8oW4BFdAQaMIxiIU9i4+V3LpSQH9kMs5FPueGRhj1FpCNVM6l1KGRpVy5z8 v3LRZ9QkCC0AejvYd1kt6kov9OtGGtSUj152ekZBPKDbO6H68xGNo+/QkxmLGBdaBLID+55aP MoFbkfD+QTOXxlNZOPlMKA37DNvlLNl8wnJVhxWpe07VM8esZITfUrS9sBbZMx72/IZ7m5aX4 KK6Js2xWzL8Mh63x55Qd+qkrF7ep5uwvnZAMDFhP/W7ybKGpsDhLF9sPOMUE6r+2xw9qRvtr1 iTMU+Bb2qQE8JFvRDP3AimcV4TvfV04pDXYaPKlzfLjpomLm4PBFPdxINSyH9qU2uxiYNRYU5 WlWVqDZ0OSqQfEUhtkokgK/JYAVngfZ7z3WXPDw== X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --63vrc7nydud32wto Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2020-09-30 13:41, Glenn Morris wrote: > The mailing list archives around the time of a commit are often informat= ive. > https://lists.gnu.org/r/emacs-devel/2005-05/msg01414.html Absolutely great, Glenn! An obvious follow-up observation: The patch that was applied was for Luc's option #3, but it seems to me that the honest solution to the problem with timers is his option #2, to put the fix in timers. Was that ever done? I'm guessing a decision at some point was made not to pursue Luc's option #2 because the emacs documentation for timers[1] says, "If a timer function calls functions that can change the match data, it should save and restore the match data. See Saving Match Data". Reconsidering that decision could be of benefit emacs-wide. Attached is a new version of the patch, with the 'save-match-data' restored. Thanks again, Glenn. [1] https://www.gnu.org/software/emacs/manual/html_node/elisp/Timers.html =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --63vrc7nydud32wto Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="auto-revert-28-cosmetic.patch" Content-Transfer-Encoding: quoted-printable diff --git a/autorevert.el b/autorevert.el index 011febf..4ca8010 100644 =2D-- a/autorevert.el +++ b/autorevert.el @@ -869,6 +869,62 @@ This is an internal function used by Auto-Revert Mode= ." (restore-buffer-modified-p modified))) (set-visited-file-modtime)) +(defun auto-revert--buffer-candidates () + "Return a prioritized list of buffers to maybe auto-revert. +The differences between this return value and the reference +variable `auto-revert-buffer-list'. include: 1) this has more +entries when in global-auto-revert-mode; 2) this prioritizes +buffers not reverted last time due to user interruption. " + (let (remaining new + (bufs (delq nil + ;; Buffers with remote contents shall be reverted only + ;; if the connection is established already. + (mapcar + (lambda (buf) + (and (buffer-live-p buf) + (with-current-buffer buf + (and + (or (not (file-remote-p default-directory)= ) + (file-remote-p default-directory nil t= )) + buf)))) + (auto-revert--polled-buffers))))) + ;; Partition `bufs' into two halves depending on whether or not + ;; the buffers are in `auto-revert-remaining-buffers'. The two + ;; halves are then re-joined with the "remaining" buffers at the + ;; head of the list. + (dolist (buf auto-revert-remaining-buffers) + (if (memq buf bufs) + (push buf remaining))) + (dolist (buf bufs) + (if (not (memq buf remaining)) + (push buf new))) + (nreverse (nconc new remaining)))) + +(defun auto-revert-buffer (buf) + "Revert a single buffer. + +This is performed as specified by Auto-Revert and Global +Auto-Revert Modes." + (if (not (buffer-live-p buf)) + (auto-revert-remove-current-buffer buf) + (with-current-buffer buf + ;; Test if someone has turned off Auto-Revert Mode + ;; in a non-standard way, for example by changing + ;; major mode. + (and (not auto-revert-mode) + (not auto-revert-tail-mode) + (auto-revert-remove-current-buffer)) + (when (auto-revert-active-p) + ;; Enable file notification. + ;; Don't bother creating a notifier for non-file buffers + ;; unless it explicitly indicates that this works. + (when (and auto-revert-use-notify + (not auto-revert-notify-watch-descriptor) + (or buffer-file-name + buffer-auto-revert-by-notification)) + (auto-revert-notify-add-watch)) + (auto-revert-handler))))) + (defun auto-revert-buffers () "Revert buffers as specified by Auto-Revert and Global Auto-Revert Mode= . @@ -892,67 +948,19 @@ are checked first the next time this function is cal= led. This function is also responsible for removing buffers no longer in Auto-Revert Mode from `auto-revert-buffer-list', and for canceling the timer when no buffers need to be checked." - (save-match-data - (let ((bufs (auto-revert--polled-buffers)) - remaining new) - ;; Buffers with remote contents shall be reverted only if the - ;; connection is established already. - (setq bufs (delq nil - (mapcar - (lambda (buf) - (and (buffer-live-p buf) - (with-current-buffer buf - (and - (or (not (file-remote-p default-directo= ry)) - (file-remote-p default-directory ni= l t)) - buf)))) - bufs))) - ;; Partition `bufs' into two halves depending on whether or not - ;; the buffers are in `auto-revert-remaining-buffers'. The two - ;; halves are then re-joined with the "remaining" buffers at the - ;; head of the list. - (dolist (buf auto-revert-remaining-buffers) - (if (memq buf bufs) - (push buf remaining))) - (dolist (buf bufs) - (if (not (memq buf remaining)) - (push buf new))) - (setq bufs (nreverse (nconc new remaining))) + (let ((bufs (auto-revert--buffer-candidates))) (while (and bufs (not (and auto-revert-stop-on-user-input (input-pending-p)))) - (let ((buf (car bufs))) - (if (not (buffer-live-p buf)) - ;; Remove dead buffer from `auto-revert-buffer-list'. - (auto-revert-remove-current-buffer buf) - (with-current-buffer buf - ;; Test if someone has turned off Auto-Revert Mode - ;; in a non-standard way, for example by changing - ;; major mode. - (if (and (not auto-revert-mode) - (not auto-revert-tail-mode) - (memq buf auto-revert-buffer-list)) - (auto-revert-remove-current-buffer)) - (when (auto-revert-active-p) - ;; Enable file notification. - ;; Don't bother creating a notifier for non-file buffers - ;; unless it explicitly indicates that this works. - (when (and auto-revert-use-notify - (not auto-revert-notify-watch-descriptor) - (or buffer-file-name - buffer-auto-revert-by-notification)) - (auto-revert-notify-add-watch)) - (auto-revert-handler))))) - (setq bufs (cdr bufs))) + (auto-revert-buffer (pop bufs))) (setq auto-revert-remaining-buffers bufs) ;; Check if we should cancel the timer. (unless (auto-revert--need-polling-p) - (if (timerp auto-revert-timer) - (cancel-timer auto-revert-timer)) + (when (timerp auto-revert-timer) + (cancel-timer auto-revert-timer)) (setq auto-revert-timer nil))))) - ;; The end: (provide 'autorevert) --63vrc7nydud32wto-- From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 23:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Boruch Baum Cc: Glenn Morris , Michael Albinus , 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160151013212882 (code B ref 43714); Wed, 30 Sep 2020 23:56:02 +0000 Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 23:55:32 +0000 Received: from localhost ([127.0.0.1]:33372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNlwZ-0003Li-Nq for submit@debbugs.gnu.org; Wed, 30 Sep 2020 19:55:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNlwW-0003LP-BT for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 19:55:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QVaf6bd+FDxDcmFCHYOgqbPKSXonA+ScH4BHrqiFxKg=; b=bW1e9n0+YZ5mJ27P55icqsWMko 2JMcrKLBmlJFZVNYSaTfNAIwYpbQsBVR6H+MBSfgcv56MAOFdTM+Im/Ovn21Z2Ev4EzwyFojUTn1G BgPO8VwKtRJfyF8If7V+BVr0B66m6NEwsGQnQui5xaY9A4Qup/1cli3LiY9s3Zzwnofc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNlwJ-0007aa-Cv; Thu, 01 Oct 2020 01:55:21 +0200 From: Lars Ingebrigtsen References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> <20200930183343.dmmyg2l6yzmfhkyl@E15-2016.optimum.net> X-Now-Playing: LCD Soundsystem's _Someone Great_: "Us V Them (Any Color U Like Remix by Windsurf)" Date: Thu, 01 Oct 2020 01:55:13 +0200 In-Reply-To: <20200930183343.dmmyg2l6yzmfhkyl@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 30 Sep 2020 14:33:44 -0400") Message-ID: <87h7reyg4e.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: > Attached is a new version of the patch, with the 'save-match-data' > restored. Thanks again, Glenn. Now applied to Emacs 28 (with some changes). As far as I can see, it's just a refactoring of auto-revert-buffers? Normally, we don't do pure refactorings like this (because it makes code archaeology m [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: > Attached is a new version of the patch, with the 'save-match-data' > restored. Thanks again, Glenn. Now applied to Emacs 28 (with some changes). As far as I can see, it's just a refactoring of auto-revert-buffers? Normally, we don't do pure refactorings like this (because it makes code archaeology more difficult), but this one seemed pretty nice. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 30 19:55:42 2020 Received: (at control) by debbugs.gnu.org; 30 Sep 2020 23:55:42 +0000 Received: from localhost ([127.0.0.1]:33375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNlwj-0003M5-VO for submit@debbugs.gnu.org; Wed, 30 Sep 2020 19:55:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNlwi-0003Ls-ER for control@debbugs.gnu.org; Wed, 30 Sep 2020 19:55:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fZ6oKQx+by6jTuQIujSV3/UaSrFef7ek8pjliM8p9GU=; b=dW7dHY60+HoIp/aRhGx5LwLwLJ yDFqP3tMZjZqF7v1D3UqnayGhO1S6OFHB0GttExbuVJ8RoLC42UJAUTjzRUYE24/7Tazjt/KA57vf Aj1rVx32UT1SYUmVeaKHQvjOZ0pwqRqNCHENGcLrRuVuKA7b0Np+AlK777n28q328UJM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNlwa-0007an-Cq for control@debbugs.gnu.org; Thu, 01 Oct 2020 01:55:34 +0200 Date: Thu, 01 Oct 2020 01:55:31 +0200 Message-Id: <87ft6yyg3w.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43714 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43714 fixed close 43714 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43714 fixed close 43714 28.1 quit From unknown Mon Aug 18 09:06:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 05:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Lars Ingebrigtsen Cc: Glenn Morris , Michael Albinus , 43714@debbugs.gnu.org Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16015309416796 (code B ref 43714); Thu, 01 Oct 2020 05:43:01 +0000 Received: (at 43714) by debbugs.gnu.org; 1 Oct 2020 05:42:21 +0000 Received: from localhost ([127.0.0.1]:33828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNrMD-0001lX-HO for submit@debbugs.gnu.org; Thu, 01 Oct 2020 01:42:21 -0400 Received: from mout.gmx.net ([212.227.17.21]:38561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNrM9-0001lI-DA for 43714@debbugs.gnu.org; Thu, 01 Oct 2020 01:42:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601530928; bh=NvXU10oI2qe/lCuz3M5VobZVIQTgjblcCmxZtVJJjrU=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=gWZwpH33xixvEWqc2bnas6gKPZeeXrDq6tkae4fPVSTRaDcm1LHcz4n/2Pwhajplp xDFxLkuYUEDZbOv0DpWZeYCP85wNNOKkisPKrzupp5EvNsj0Gzt8XgpyekbUFiOUTA VP5w7dM7TlVqn59DARKHTYnOGvE7nndIdBFRQjTI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mof57-1kltd03OlF-00p49J; Thu, 01 Oct 2020 07:42:08 +0200 Date: Thu, 1 Oct 2020 01:42:04 -0400 From: Boruch Baum Message-ID: <20201001054204.njzu3grz5mtfeotw@E15-2016.optimum.net> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> <20200930183343.dmmyg2l6yzmfhkyl@E15-2016.optimum.net> <87h7reyg4e.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h7reyg4e.fsf@gnus.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:gM387WAV1DikBgCbTIqhDaCKs/hSnUcJC2ae5ezrnZK0jRirlvi r2fTxpIoV1GIgij2xGpk/9GYcpS/WvBa9PsXtqy1HakYmaweZMQRwJNu0bpzKDAqc0KuGOi uC661SwWT4Z7MW3I7eqZfp1EDoKyz9UnoMnI2+gbYcM8VGZKfWDHjaa0wufVX6/vKpdf0+t s5mch75p3wMcn1U9+Rf/w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/3uStJ24DPY=:Wo2XdlYitMSUjyOMXRsCDI 2juWZAbfUm1mLe+7VebVp2zUIx7fObUqvf46XZrDTnLs276Zkcf+YMbKaP4YcPI6q3eOlKR4x 8ybaZ00mqFe5yNNQKpBU04Wd66WhdcOPIy0Vz/mJWvJf/NX6Xil97e45xi6iSD+L2XlAfBHzw 3E8/dTMhyQ34tzToldmvCU2eLuGYjEpRqJAU2SngNe84gGHo0+Ss6SeZSaSzjL25YNKhm0pUv OEuuNriQxYCHVsHsVU4e2p4ikVtdzTY62yKI9Q8SsE2GLfIrumGoEbsAf8P3y1ha6NUY5ORUP AVjpIBlapg/C/QoWjY7eZC5b924LJOo6H3baUhAU6na8UtdmxvcZ7A1Epo67WgiAxKPP3UvFo XjLsYPlJd6E0rypHeBN4YrtN4FU7shQy4v45NehpAlUTKR8OlvwDa+Jjv91OiqYsRumGo0NDE 0VZfsHA6BCeVPm1S4VYTPpdjbPfg4Bps+jjVyPAOAPjlQSAT/dhuxRjLHVhelj64510HEgBu6 iGdUAbM3lTMnbogMne3K3/VKu6HbN4sO4owLVtnJh77u4QgLtEYKAJ34jBP8JfjcQMchDx+Ig TJgQQpbRRalUIThnk+aGOsBTEKRKkMFYoDK5xbraUwqDgjWPxDKnbVW74F5xlRn2OBhGMF8dG X0Dfv0Go5l1ipexygftyvZWt5ZNIkxNygc7AwFSzPBJCnjTpZslpacNvkoKLllRID9Dlf0TWH 4nbmdf7MC5E1JyWqhd3HpZfwnQZVuqSXeS/a9RNGXeor5yU2LdcwZ419KoCpmoeLgnwGMypUH g0Ca4Ut5cu6WAHOuCnhqRjOnUhAP5iZ/CfzOHgNmEHG9wKZ1Uqtei4ZBs6fmdVc3h01bsTpPv xNiiOrG60VTMJhg7xTFFrMBBhl84C80VWgGUSWZZioOjXc37OOY+36LhrPNKPsC3NyCrPoDmS wtexuMAlwP8jaRoomZ/mpI/j+3WF3KWVkeCKNH7lf7eP02gkdEtndaRQClyHYHq9zwvTyIoWf BbPJJgw+oFY4uQsvJhiAJ0Y9ZLnRKIFe5IWhT3aRE3Q1OhzN9PQIzbC0AvIpyQ9bJ+snfRaZW EfOh1L613r17YXu6MpVWLwNF7+r0fqe5yMN9qyktpvpiCuZsk6naCRBL20eOJdlSqunmlJ8DR d3TRXggwWSAhtpXvWd0MJiQ2NOmQdG26ly+EGoMXniZBStrIGUcxr2Z3wJdPgCGhq/nrtQYKm yGeK5vEWiP8eCJDIcjbGGYrXzCt8DsQzZiyMB4A== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2020-10-01 01:55, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > Now applied to Emacs 28 (with some changes). As far as I can see, it's > just a refactoring of auto-revert-buffers? Hope is, yes. > Normally, we don't do pure refactorings like this (because it makes > code archaeology more difficult), but this one seemed pretty nice. Thanks. I suspect that it may turn out to come in handy for bug #43412 'autorevert-only-if-visible', which will be a case of performing an instant auto-revert on a single buffer (or small set of buffers) without using a timer. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0