GNU bug report logs - #43702
Emacs master: Incorrect highlighting in regexp isearch.

Previous Next

Package: emacs;

Reported by: Alan Mackenzie <acm <at> muc.de>

Date: Tue, 29 Sep 2020 12:14:01 UTC

Severity: normal

Tags: fixed

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: Alan Mackenzie <acm <at> muc.de>, Lars Ingebrigtsen <larsi <at> gnus.org>, 43702 <at> debbugs.gnu.org
Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch.
Date: Mon, 12 Oct 2020 16:07:38 -0700 (PDT)
> > It's helpful in pretty much any context where regexps
> > are matched against text, IMO.
> 
> I think you are right.  So here is a patch that implements this:

It's probably not my place to criticize your patch.
But in case it helps:

I don't understand why you change the signature of
`replace-highlight' by adding parameter MATCH-DATA.

I just use (match-beginning GROUP) and (match-end GROUP),
instead of explicitly passing the match data and then
copying it all with `butlast' etc. just to find the
group's match beginning and end.

https://www.emacswiki.org/emacs/download/replace%2b.el




This bug report was last modified 4 years and 221 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.