GNU bug report logs - #43702
Emacs master: Incorrect highlighting in regexp isearch.

Previous Next

Full log

View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: Juri Linkov <juri <at> linkov.net>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Alan Mackenzie <acm <at> muc.de>, 43702 <at> debbugs.gnu.org
Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch.
Date: Thu, 1 Oct 2020 12:39:50 -0700 (PDT)

> >> Maybe better to do what Drew proposed: to distinguish the odd groups
> >> from the even groups, i.e. to have only 2 additional faces
> >> (a brighter face like the current isearch-group-1 for the odd groups,
> >> and a darker face for the even groups).
> >
> > I like the idea.
> 
> Implemented now on the trunk where isearch-group-odd is created
> from the isearch-group-1 face, and isearch-group-even
> from the isearch-group-4 face.
> 
> The result is quite nice:

Sorry, but IMO that's horrible.  And you really should
show more regexps, not just a sequence of groups, but
nested groups etc.

Regexp matching is complex.  And that's the point:
WYSIWYG visualization of a user's regexp on the fly.

My suggestion: provide a fair number of group faces,
to make it easy to identify which parts of a regexp
correspond to which parts of the current search hit.

This should be simple.  I've done it.  And used it,
for a long time.  Why reinvent the wheel, replacing
a circle with an octagon?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.