GNU bug report logs - #43702
Emacs master: Incorrect highlighting in regexp isearch.

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Alan Mackenzie <acm <at> muc.de>, 43702 <at> debbugs.gnu.org
Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch.
Date: Thu, 01 Oct 2020 22:20:07 +0300

[Message part 1 (text/plain, inline)]

>> Maybe better to do what Drew proposed: to distinguish the odd groups
>> from the even groups, i.e. to have only 2 additional faces
>> (a brighter face like the current isearch-group-1 for the odd groups,
>> and a darker face for the even groups).
>
> I like the idea.

Implemented now on the trunk where isearch-group-odd is created
from the isearch-group-1 face, and isearch-group-even
from the isearch-group-4 face.

The result is quite nice:

[search-highlight-submatches.png (image/png, inline)]

[Message part 3 (text/plain, inline)]

>> So a better solution is maybe to save match-data on the isearch stack
>> and restore in isearch-pop-state (called by isearch-delete-char).
>> I could try to do this.
>
> Please do.

I'm on it (also adding even/odd faces to lazy-isearch - optionally
on the new user option lazy-highlight-submatches).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.