GNU bug report logs - #43679
[PATCH 0/5] Add '--with-toolchain' package transformation option

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Mon, 28 Sep 2020 19:54:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludovic.courtes <at> inria.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: 43679 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [bug#43679] [PATCH v2 0/5] Add '--with-c-toolchain'
Date: Fri,  9 Oct 2020 11:12:26 +0200
Hi!

This is v2 of this patch, with these changes:

  1. ‘with-toolchain’ is replaced by ‘with-c-toolchain’ everywhere,
     with the understanding that it’s about the C/C++ toolchain
     in practice.  In the end I’m sympathetic with the argument
     that C/C++ don’t have a monopoly on toolchains.  ;-)

  2. ‘--with-c-toolchain=PACKAGE=TOOLCHAIN’ rebuilds not just
     PACKAGE with TOOLCHAIN, but also everything above PACKAGE
     with TOOLCHAIN (in v1, only PACKAGE was rebuilt with TOOLCHAIN
     but everything above it had to be rebuilt anyway.)

     The main motivation here is to reduce the changes that we’re
     introducing ABI incompatibilities that users would have to work
     around by passing on ‘--with-c-toolchain’ for each package in
     the chain.  I think it also more closely matches user
     expectations: when you see things are being rebuilt, you’re
     likely to think that’s because they’re rebuilt with the new
     toolchain, not the default one.

Feedback welcome!

Ludo’.

Ludovic Courtès (5):
  gnu: gcc-toolchain: Add 'GUIX_LOCPATH' to the search paths.
  gnu: clang-toolchain: Add 'GUIX_LOCPATH' to the search paths.
  gnu: clang-toolchain: Create 'cc' and 'c++' symlinks.
  packages: Add 'package-with-c-toolchain'.
  guix build: Add '--with-c-toolchain'.

 doc/guix.texi                 | 70 +++++++++++++++++++++++++++++
 gnu/packages/commencement.scm |  8 +++-
 gnu/packages/llvm.scm         | 12 ++++-
 guix/build-system.scm         | 35 ++++++++++++++-
 guix/packages.scm             |  9 ++++
 guix/scripts/build.scm        | 84 +++++++++++++++++++++++++++++++++++
 tests/packages.scm            | 20 +++++++++
 tests/scripts-build.scm       | 82 ++++++++++++++++++++++++++++++++++
 8 files changed, 315 insertions(+), 5 deletions(-)

-- 
2.28.0





This bug report was last modified 4 years and 224 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.