GNU bug report logs - #43677
27.1; Calc holidays off-by-one error, incorrect business day calculation

Previous Next

Package: emacs;

Reported by: Aaron Zeng <zeng.aaron.l <at> gmail.com>

Date: Mon, 28 Sep 2020 16:12:03 UTC

Severity: normal

Found in version 27.1

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Aaron Zeng <zeng.aaron.l <at> gmail.com>, 43677 <at> debbugs.gnu.org
Subject: bug#43677: 27.1; Calc holidays off-by-one error, incorrect business day calculation
Date: Wed, 30 Sep 2020 10:55:10 +0200

>>>>> On Wed, 30 Sep 2020 04:50:25 +0200, Lars Ingebrigtsen <larsi <at> gnus.org> said:

    Lars> Indeed -- applying the following patch (which numbers Monday as 0 and
    Lars> Sunday as 6) makes the test case work correctly for me.  But trying to
    Lars> follow the code makes it unclear...  er...  what's going on, and there
    Lars> aren't many comments in the Calc code to explain what they were
    Lars> thinking.

    Lars> I wondered whether this might be a US/non-US thing (with a difference in
    Lars> what day starts the week), but I couldn't really find anything in calc
    Lars> talking about that...

    Lars> Does anybody have any insight here?

Sunday is the first day of the week in the US and in France (and
others, probably). Monday is the first *business* day of the week,
which I think is what's important here.

Robert
--
This bug report was last modified 4 years and 236 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.