GNU bug report logs - #43673
[PATCH] linux-container: Reset jailed root permissions.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jelle Licht <jlicht <at> fsfe.org>
Subject: bug#43673: closed (Re: [bug#43673] [PATCH v2] linux-container:
 Reset jailed root permissions.)
Date: Thu, 01 Oct 2020 11:49:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#43673: [PATCH] linux-container: Reset jailed root permissions.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 43673 <at> debbugs.gnu.org.

-- 
43673: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43673
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jelle Licht <jlicht <at> fsfe.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 43673-done <at> debbugs.gnu.org
Subject: Re: [bug#43673] [PATCH v2] linux-container: Reset jailed root
 permissions.
Date: Thu, 01 Oct 2020 13:48:29 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Jelle Licht <jlicht <at> fsfe.org> skribis:
>
>> * gnu/build/linux-container.scm (mount-file-systems): Add 'chmod' call.
>> * tests/containers.scm
>> ("call-with-container, mnt namespace, root permissions"): New test.
>
> LGTM, thanks!
>
> Ludo’.

Pushed as e7481835 on master, thanks for the fast review!

[Message part 3 (message/rfc822, inline)]

From: Jelle Licht <jlicht <at> fsfe.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] linux-container: Reset jailed root permissions.
Date: Mon, 28 Sep 2020 16:34:33 +0200

* gnu/build/linux-container.scm (mount-file-systems): Add 'chmod' call.
---
 gnu/build/linux-container.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/build/linux-container.scm b/gnu/build/linux-container.scm
index 2d4de788df..4a8bed5a9a 100644
--- a/gnu/build/linux-container.scm
+++ b/gnu/build/linux-container.scm
@@ -170,7 +170,8 @@ for the process."
     (pivot-root root put-old)
     (chdir "/")
     (umount "real-root" MNT_DETACH)
-    (rmdir "real-root")))
+    (rmdir "real-root")
+    (chmod "/" #o755)))
 
 (define* (initialize-user-namespace pid host-uids
                                     #:key (guest-uid 0) (guest-gid 0))
-- 
2.28.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.