From unknown Fri Jun 13 11:14:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43660: icedove: "guix build --source" should produce IceDove source Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 27 Sep 2020 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43660 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 43660@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160124909613200 (code B ref -1); Sun, 27 Sep 2020 23:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Sep 2020 23:24:56 +0000 Received: from localhost ([127.0.0.1]:50662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMg2K-0003Qo-1o for submit@debbugs.gnu.org; Sun, 27 Sep 2020 19:24:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:56344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMg2H-0003Qf-AL for submit@debbugs.gnu.org; Sun, 27 Sep 2020 19:24:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMg2H-0007F5-4J for bug-guix@gnu.org; Sun, 27 Sep 2020 19:24:53 -0400 Received: from world.peace.net ([64.112.178.59]:47922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMg2F-0007Y7-9h for bug-guix@gnu.org; Sun, 27 Sep 2020 19:24:52 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMg2D-0002hC-3t; Sun, 27 Sep 2020 19:24:49 -0400 From: Mark H Weaver Date: Sun, 27 Sep 2020 19:23:28 -0400 Message-ID: <87o8lq7qic.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/27 19:24:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) At present, "guix build --source icedove" simply returns the corresponding IceCat tarball. The addition of code from upstream Thunderbird, as well as the rebranding to "IceDove", is currently done within phases. It would be good to arrange for "guix build --source icedove" to return something more appropriate. I suggest that the first step should add an 'icedove-source' variable that produces an icedove tarball, for now implemented in a way similar to 'icecat-source' and incorporating the functionality of the 'prepare-thunderbird-sources' and 'rename-to-icedove' phases of the 'icedove' package. Note that snippets are unable to do this job, because they are only able to produce tarballs with the same file name and top-level directory name as the main upstream input. In this case, we need to produce a tarball with name and top-level directory 'icedove' starting from an 'icecat' tarball. Mark