From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 27 15:07:16 2020 Received: (at submit) by debbugs.gnu.org; 27 Sep 2020 19:07:16 +0000 Received: from localhost ([127.0.0.1]:50464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMc0s-0001aG-8P for submit@debbugs.gnu.org; Sun, 27 Sep 2020 15:07:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:51058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMc0n-0001a4-Db for submit@debbugs.gnu.org; Sun, 27 Sep 2020 15:07:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMc0n-0005tn-9I for guix-patches@gnu.org; Sun, 27 Sep 2020 15:07:05 -0400 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:40804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMc0i-0004hz-GX for guix-patches@gnu.org; Sun, 27 Sep 2020 15:07:04 -0400 Received: by mail-ed1-x543.google.com with SMTP id t16so7656761edw.7 for ; Sun, 27 Sep 2020 12:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=Xe0//zdLUlBeXN50UjyWZAhYnAA1/Pk0vbhKiQBJ6SQ=; b=fGF/tp7HfysFVlUlPOZ4vAVkqWguHQuxfmZzDjWh+dkIUX8ynaCAAAd3QqCS/08xEp xGm/9Vd3oVcwaeNpWq+uuzQY1aEfRDg9QKLafm4915pQS1fAtWC9fxbBfgHksQmLqGTR Xw4kbU/QdW+xTvg+UVxu8F4srKauJ4oewsCB3whb6E0/6i/rEzKWIjK1NYltOX8yuGZ6 wcTlOgHvGn9uDJvFfo4KGTFqet72ogyZcli5sTlJbdzZN/0o8RVWKedBTzlR/UWoKGPW f8oQD7PmDVpO4EsPZNxIkBI9HgLltXVrvaHBEEdV3d4WGvbqT+qIN7dZdU6wWU245YJR Z5Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=Xe0//zdLUlBeXN50UjyWZAhYnAA1/Pk0vbhKiQBJ6SQ=; b=BKDprkSyaQ3eToYewhhN2VzEbyrBeYYfq6YSILVFPhePtatLRvRrBYHAsvwHjQWbli Btqedc6WrY8rLhZrtMUPYiWEa/PyQMaCvLqElPNwU1UOHvFozHsKCn2OR8mgiIk889ww FXNdQHE8ElTc/aCoz5VRQPFhsfTd2vBeRIh1D1MkVrUdYZRJcOGZP783KLLwQfS+kc4Q 5475QuWItBsdaMRsOD0w9YTZVJ4GhQaXcNogu1swqMk3im5QtPz/6U8xFiLfMI3h5r9J mw/Fr8XPepN0FcMFS74F7I2YobqB+6G5JQrQsbfimE5ImjXpb1SVsW4ZBkBKCUvvPycR G+ww== X-Gm-Message-State: AOAM532evzMWNoMtGROoNZ8/jDAj92lbldcLT5vAHPnAK4CxytP6UdAk bXZ4pUAbd6i6kCdBVtkVHBt9NODf6a0= X-Google-Smtp-Source: ABdhPJwQLc19+FZgeZ8qfBYZZNJK1VTItZHfOI/YZjb0vy82ax/w0eBjKDPRyxYpLaU4qF2eubvuDw== X-Received: by 2002:a05:6402:1656:: with SMTP id s22mr12680034edx.160.1601233618284; Sun, 27 Sep 2020 12:06:58 -0700 (PDT) Received: from Morphium (ip-84-118-73-55.unity-media.net. [84.118.73.55]) by smtp.gmail.com with ESMTPSA id bv8sm7316280ejb.3.2020.09.27.12.06.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 12:06:57 -0700 (PDT) From: Malte Frank Gerdes To: guix-patches@gnu.org Subject: [PATCH] Add perl-opengl Date: Sun, 27 Sep 2020 21:06:56 +0200 Message-ID: <86pn67xcmn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::543; envelope-from=malte.f.gerdes@gmail.com; helo=mail-ed1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Hi, this patch adds perl-opengl to guix. The glversion.txt is taken straight from nixpkgs (i didn't see any copyright notices, so this is ok?). This is the first time for me sending a patch to this list, i hope i haven't forgotten anything :) Malte --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=perl-opengl.patch Content-Transfer-Encoding: quoted-printable diff --git a/gnu/local.mk b/gnu/local.mk index f3b5b17e84..001b249e9e 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -37,6 +37,7 @@ # Copyright =C2=A9 2020 Brice Waegeneire # Copyright =C2=A9 2020 Tanguy Le Carrour # Copyright =C2=A9 2020 Martin Becze +# Copyright =C2=A9 2020 Malte Frank Gerdes # # This file is part of GNU Guix. # @@ -1406,6 +1407,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/pam-mount-luks2-support.patch \ %D%/packages/patches/pango-skip-libthai-test.patch \ %D%/packages/patches/pciutils-hurd-configure.patch \ + %D%/packages/patches/perl-opengl-makefile.patch \ %D%/packages/patches/ppsspp-disable-upgrade-and-gold.patch \ %D%/packages/patches/samba-fix-fcntl-hint-detection.patch \ %D%/packages/patches/sdl-pango-api_additions.patch \ diff --git a/gnu/packages/aux-files/perl-opengl/glversion.txt b/gnu/package= s/aux-files/perl-opengl/glversion.txt new file mode 100644 index 0000000000..5b5a9a911f --- /dev/null +++ b/gnu/packages/aux-files/perl-opengl/glversion.txt @@ -0,0 +1,5 @@ +GLUT=3D20801 +VERSION=3D3.0 Mesa 10.2.6 +VENDOR=3DIntel Open Source Technology Center +RENDERER=3DMesa DRI Intel(R) Ivybridge Mobile +EXTENSIONS=3DGL_ARB_multisample GL_EXT_abgr GL_EXT_bgra GL_EXT_blend_color= GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_copy_texture GL_EXT_polyg= on_offset GL_EXT_subtexture GL_EXT_texture_object GL_EXT_vertex_array GL_EX= T_compiled_vertex_array GL_EXT_texture GL_EXT_texture3D GL_IBM_rasterpos_cl= ip GL_ARB_point_parameters GL_EXT_draw_range_elements GL_EXT_packed_pixels = GL_EXT_point_parameters GL_EXT_rescale_normal GL_EXT_separate_specular_colo= r GL_EXT_texture_edge_clamp GL_SGIS_generate_mipmap GL_SGIS_texture_border_= clamp GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod GL_ARB_framebuffer_sRG= B GL_ARB_multitexture GL_EXT_framebuffer_sRGB GL_IBM_multimode_draw_arrays = GL_IBM_texture_mirrored_repeat GL_3DFX_texture_compression_FXT1 GL_ARB_text= ure_cube_map GL_ARB_texture_env_add GL_ARB_transpose_matrix GL_EXT_blend_fu= nc_separate GL_EXT_fog_coord GL_EXT_multi_draw_arrays GL_EXT_secondary_colo= r GL_EXT_texture_env_add GL_EXT_texture_filter_anisotropic GL_EXT_texture_l= od_bias GL_INGR_blend_func_separate GL_NV_blend_square GL_NV_light_max_expo= nent GL_NV_texgen_reflection GL_NV_texture_env_combine4 GL_S3_s3tc GL_SUN_m= ulti_draw_arrays GL_ARB_texture_border_clamp GL_ARB_texture_compression GL_= EXT_framebuffer_object GL_EXT_texture_compression_s3tc GL_EXT_texture_env_c= ombine GL_EXT_texture_env_dot3 GL_MESA_window_pos GL_NV_packed_depth_stenci= l GL_NV_texture_rectangle GL_ARB_depth_texture GL_ARB_occlusion_query GL_AR= B_shadow GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_text= ure_env_dot3 GL_ARB_texture_mirrored_repeat GL_ARB_window_pos GL_ATI_envmap= _bumpmap GL_EXT_stencil_two_side GL_EXT_texture_cube_map GL_NV_depth_clamp = GL_APPLE_packed_pixels GL_APPLE_vertex_array_object GL_ARB_draw_buffers GL_= ARB_fragment_program GL_ARB_fragment_shader GL_ARB_shader_objects GL_ARB_ve= rtex_program GL_ARB_vertex_shader GL_ATI_draw_buffers GL_ATI_texture_env_co= mbine3 GL_ATI_texture_float GL_EXT_shadow_funcs GL_EXT_stencil_wrap GL_MESA= _pack_invert GL_NV_primitive_restart GL_ARB_depth_clamp GL_ARB_fragment_pro= gram_shadow GL_ARB_half_float_pixel GL_ARB_occlusion_query2 GL_ARB_point_sp= rite GL_ARB_shading_language_100 GL_ARB_sync GL_ARB_texture_non_power_of_tw= o GL_ARB_vertex_buffer_object GL_ATI_blend_equation_separate GL_EXT_blend_e= quation_separate GL_OES_read_format GL_ARB_color_buffer_float GL_ARB_pixel_= buffer_object GL_ARB_texture_compression_rgtc GL_ARB_texture_float GL_ARB_t= exture_rectangle GL_EXT_packed_float GL_EXT_pixel_buffer_object GL_EXT_text= ure_compression_dxt1 GL_EXT_texture_compression_rgtc GL_EXT_texture_rectang= le GL_EXT_texture_sRGB GL_EXT_texture_shared_exponent GL_ARB_framebuffer_ob= ject GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_packed_d= epth_stencil GL_APPLE_object_purgeable GL_ARB_vertex_array_object GL_ATI_se= parate_stencil GL_EXT_draw_buffers2 GL_EXT_draw_instanced GL_EXT_gpu_progra= m_parameters GL_EXT_texture_array GL_EXT_texture_integer GL_EXT_texture_sRG= B_decode GL_EXT_timer_query GL_OES_EGL_image GL_AMD_performance_monitor GL_= ARB_copy_buffer GL_ARB_depth_buffer_float GL_ARB_draw_instanced GL_ARB_half= _float_vertex GL_ARB_instanced_arrays GL_ARB_map_buffer_range GL_ARB_textur= e_rg GL_ARB_texture_swizzle GL_ARB_vertex_array_bgra GL_EXT_texture_swizzle= GL_EXT_vertex_array_bgra GL_NV_conditional_render GL_AMD_conservative_dept= h GL_AMD_draw_buffers_blend GL_AMD_seamless_cubemap_per_texture GL_ARB_ES2_= compatibility GL_ARB_blend_func_extended GL_ARB_debug_output GL_ARB_draw_bu= ffers_blend GL_ARB_draw_elements_base_vertex GL_ARB_explicit_attrib_locatio= n GL_ARB_fragment_coord_conventions GL_ARB_provoking_vertex GL_ARB_sample_s= hading GL_ARB_sampler_objects GL_ARB_seamless_cube_map GL_ARB_shader_textur= e_lod GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_mu= ltisample GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_uniform= _buffer_object GL_ARB_vertex_type_2_10_10_10_rev GL_EXT_provoking_vertex GL= _EXT_texture_snorm GL_MESA_texture_signed_rgba GL_ARB_get_program_binary GL= _ARB_robustness GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding G= L_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_= ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ARB_con= servative_depth GL_ARB_internalformat_query GL_ARB_map_buffer_alignment GL_= ARB_shader_atomic_counters GL_ARB_shading_language_420pack GL_ARB_shading_l= anguage_packing GL_ARB_texture_storage GL_ARB_transform_feedback_instanced = GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_transform_feedback GL_AMD= _shader_trinary_minmax GL_ARB_ES3_compatibility GL_ARB_clear_buffer_object = GL_ARB_invalidate_subdata GL_ARB_texture_query_levels GL_ARB_texture_storag= e_multisample GL_ARB_texture_view GL_ARB_vertex_attrib_binding GL_KHR_debug= GL_ARB_buffer_storage GL_ARB_multi_bind GL_ARB_texture_mirror_clamp_to_edg= e GL_ARB_vertex_type_10f_11f_11f_rev GL_EXT_shader_integer_mix GL_INTEL_per= formance_query diff --git a/gnu/packages/patches/perl-opengl-makefile.patch b/gnu/packages= /patches/perl-opengl-makefile.patch new file mode 100644 index 0000000000..e782113d8b --- /dev/null +++ b/gnu/packages/patches/perl-opengl-makefile.patch @@ -0,0 +1,37 @@ +diff --git a/Makefile.PL b/Makefile.PL +index d32205d..3e8fa0a 100755 +--- a/Makefile.PL ++++ b/Makefile.PL +@@ -124,14 +124,7 @@ if ($IS_MINGW) + # Look for available libs + our @libdirs =3D qw + { +- -L/usr/lib +- -L/usr/lib/i386-linux-gnu +- -L/usr/X11R6/lib +- -L/opt/X11/lib +- -L/usr/local/lib +- -L/usr/openwin/lib +- -L/opt/csw/lib +- -L/usr/local/freeglut/lib ++@@libdirs@@ + }; + + our @check_libs =3D qw +@@ -804,7 +797,6 @@ sub get_extensions + my $exc_file =3D 'gl_exclude.h'; + unlink($exc_file) if (-e $exc_file); + my $glv_file =3D 'utils/glversion.txt'; +- unlink($glv_file) if (-e $glv_file); + + # Only run the rest if GLUT is installed + print "Testing GLUT version\n" if ($verbose); +@@ -861,7 +853,7 @@ sub get_extensions + $make_ver =3D ";make -f Makefile " . (length($lib) ? "GLUT_LIB=3D$li= b " : "") . (length($def) ? "GLUT_DEF=3D$def " : ""); + print "glversion: '$make_ver'\n" if $verbose>1; + } +- my $exec =3D 'cd utils'."$make_ver clean".$make_ver; ++ my $exec =3D 'cd utils'.$make_ver; + print "glversion: $exec\n" if ($verbose); + my $stat =3D `$exec`; + print "\n$stat\n\n" if ($verbose); diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index 1c3d999d79..093f60f9c9 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -27,6 +27,7 @@ ;;; Copyright =C2=A9 2020 Vincent Legoll ;;; Copyright =C2=A9 2020 Paul Garlick ;;; Copyright =C2=A9 2020 Nicolas Goaziou +;;; Copyright =C2=A9 2020 Malte Frank Gerdes ;;; ;;; This file is part of GNU Guix. ;;; @@ -49,6 +50,7 @@ #:use-module (gnu packages) #:use-module (guix packages) #:use-module (guix download) + #:use-module (guix gexp) #:use-module (guix git-download) #:use-module (guix utils) #:use-module (guix build-system gnu) @@ -75,6 +77,7 @@ #:use-module (gnu packages textutils) #:use-module (gnu packages video) #:use-module (gnu packages web)) + #:use-module (gnu packages xorg)) ;;; ;;; Please: Try to add new module packages in alphabetic order. @@ -11387,3 +11390,61 @@ regexp patterns in modules.") (description "Data::SExpression parses Lisp S-Expressions into Perl da= ta structures.") (license license:perl-license))) + +(define-public perl-opengl + (package + (name "perl-opengl") + (version "0.70") + (source + (origin + (method url-fetch) + (uri (string-append + "mirror://cpan/authors/id/C/CH/CHM/OpenGL-" + version + ".tar.gz")) + (sha256 + (base32 + "1q3lz168q081iwl9jg21fbzhp9la79gav9mv6nmh2jab83s2l3mj")) + (patches (search-patches "perl-opengl-makefile.patch")))) + (build-system perl-build-system) + (native-inputs + `(("xvfb" ,xorg-server-for-tests) + ("glversion-txt" ,(local-file "aux-files/perl-opengl/glversion.txt"= )))) + (inputs `(("mesa" ,mesa) + ("glu" ,glu) + ("freeglut" ,freeglut) + ("libxi" ,libxi) + ("libxmu" ,libxmu) + ("libice" ,libice))) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-before 'configure 'patch-makefile + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "Makefile.PL" + (("^@@libdirs@@") + (string-concatenate + (map (lambda (input) + (string-append "-L" (cdr input) "/lib\n")) + inputs)))) + (substitute* "utils/Makefile" + (("^all: glversion.txt") "all:")) + #t)) + (add-before 'configure 'inject-glversion + (lambda* (#:key inputs #:allow-other-keys) + (copy-file (assoc-ref inputs "glversion-txt") + "utils/glversion.txt") + #t)) + (add-before 'check 'pre-check + (lambda _ + ;; Tests require a running X server. + (system "Xvfb :1 &") + (setenv "DISPLAY" ":1") + #t)) + ))) + (home-page "https://metacpan.org/release/OpenGL") + (synopsis + "Perl bindings to the OpenGL API, GLU, and GLUT/FreeGLUT") + (description "The package provides Perl bindings to OpenGL, GLU +and FreeGLUT.") + (license license:perl-license))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 00:14:13 2020 Received: (at 43654) by debbugs.gnu.org; 2 Oct 2020 04:14:13 +0000 Received: from localhost ([127.0.0.1]:38992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOCSE-0003J1-Qt for submit@debbugs.gnu.org; Fri, 02 Oct 2020 00:14:13 -0400 Received: from mout02.posteo.de ([185.67.36.66]:43627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOCS9-0003Ij-2K for 43654@debbugs.gnu.org; Fri, 02 Oct 2020 00:13:57 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 7FC692400FB for <43654@debbugs.gnu.org>; Fri, 2 Oct 2020 06:13:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1601612026; bh=/GDDA82/hmvLCyJ1N1dHBs9UiBTSbU1sRt8Nr/l51bw=; h=From:To:Cc:Subject:Date:From; b=lQQ6jGLQVj/Bqs7GpoEZKJ/DhFhBc9Aad08n0GNt5W58m45LitkeegMdfG1odpBkL UOiycxlr6UzAh+q148uy3pSyJOxIgGaC9hNq+NQB6SSUMq3mI/4rpmnHlas6gbpl3o KLuF9HwDBljxGaWHPBb2CHnm/CZ3YqDRXBLGio2VehDOo+MpbQZe+jkztrYGXEboZA doXbf7dmDcNJ4Wc2P1JWW8xqTBlUylhAtoVQGntaWQiW7UaGHQYV3QJHDWc5shNwEn zpwdoxPAXLKBjtrxzS16ckQbiGIts1bhIIroMqW0/KMgW2Gnt1hAzUudASidZ7Avu2 rJkE3OQRQVXtA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4C2c7F2VWrz9rxG; Fri, 2 Oct 2020 06:13:45 +0200 (CEST) From: Kei Kebreau To: Malte Frank Gerdes Subject: Re: [bug#43654] [PATCH] Add perl-opengl In-Reply-To: <86pn67xcmn.fsf@gmail.com> (Malte Frank Gerdes's message of "Sun, 27 Sep 2020 21:06:56 +0200") References: <86pn67xcmn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Fri, 02 Oct 2020 00:13:43 -0400 Message-ID: <87mu15b6yw.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43654 Cc: 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Malte Frank Gerdes writes: > Hi, > Hi Malte! > this patch adds perl-opengl to guix. The glversion.txt is taken straight > from nixpkgs (i didn't see any copyright notices, so this is ok?). > I think we can assume that the same MIT license in the root directory of the nixpkgs repository also applies to the unmarked files in the repository. > This is the first time for me sending a patch to this list, i hope i > haven't forgotten anything :) > > Malte > > diff --git a/gnu/local.mk b/gnu/local.mk > index f3b5b17e84..001b249e9e 100644 > --- a/gnu/local.mk > +++ b/gnu/local.mk > @@ -37,6 +37,7 @@ > # Copyright =C2=A9 2020 Brice Waegeneire > # Copyright =C2=A9 2020 Tanguy Le Carrour > # Copyright =C2=A9 2020 Martin Becze > +# Copyright =C2=A9 2020 Malte Frank Gerdes > # > # This file is part of GNU Guix. > # > @@ -1406,6 +1407,7 @@ dist_patch_DATA =3D \ > %D%/packages/patches/pam-mount-luks2-support.patch \ > %D%/packages/patches/pango-skip-libthai-test.patch \ > %D%/packages/patches/pciutils-hurd-configure.patch \ > + %D%/packages/patches/perl-opengl-makefile.patch \ > %D%/packages/patches/ppsspp-disable-upgrade-and-gold.patch \ > %D%/packages/patches/samba-fix-fcntl-hint-detection.patch \ > %D%/packages/patches/sdl-pango-api_additions.patch \ > diff --git a/gnu/packages/aux-files/perl-opengl/glversion.txt b/gnu/packa= ges/aux-files/perl-opengl/glversion.txt > new file mode 100644 > index 0000000000..5b5a9a911f > --- /dev/null > +++ b/gnu/packages/aux-files/perl-opengl/glversion.txt > @@ -0,0 +1,5 @@ > +GLUT=3D20801 > +VERSION=3D3.0 Mesa 10.2.6 > +VENDOR=3DIntel Open Source Technology Center > +RENDERER=3DMesa DRI Intel(R) Ivybridge Mobile > +EXTENSIONS=3DGL_ARB_multisample GL_EXT_abgr GL_EXT_bgra GL_EXT_blend_col= or GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_copy_texture GL_EXT_pol= ygon_offset GL_EXT_subtexture GL_EXT_texture_object GL_EXT_vertex_array GL_= EXT_compiled_vertex_array GL_EXT_texture GL_EXT_texture3D GL_IBM_rasterpos_= clip GL_ARB_point_parameters GL_EXT_draw_range_elements GL_EXT_packed_pixel= s GL_EXT_point_parameters GL_EXT_rescale_normal GL_EXT_separate_specular_co= lor GL_EXT_texture_edge_clamp GL_SGIS_generate_mipmap GL_SGIS_texture_borde= r_clamp GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod GL_ARB_framebuffer_s= RGB GL_ARB_multitexture GL_EXT_framebuffer_sRGB GL_IBM_multimode_draw_array= s GL_IBM_texture_mirrored_repeat GL_3DFX_texture_compression_FXT1 GL_ARB_te= xture_cube_map GL_ARB_texture_env_add GL_ARB_transpose_matrix GL_EXT_blend_= func_separate GL_EXT_fog_coord GL_EXT_multi_draw_arrays GL_EXT_secondary_co= lor GL_EXT_texture_env_add GL_EXT_texture_filter_anisotropic GL_EXT_texture= _lod_bias GL_INGR_blend_func_separate GL_NV_blend_square GL_NV_light_max_ex= ponent GL_NV_texgen_reflection GL_NV_texture_env_combine4 GL_S3_s3tc GL_SUN= _multi_draw_arrays GL_ARB_texture_border_clamp GL_ARB_texture_compression G= L_EXT_framebuffer_object GL_EXT_texture_compression_s3tc GL_EXT_texture_env= _combine GL_EXT_texture_env_dot3 GL_MESA_window_pos GL_NV_packed_depth_sten= cil GL_NV_texture_rectangle GL_ARB_depth_texture GL_ARB_occlusion_query GL_= ARB_shadow GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_te= xture_env_dot3 GL_ARB_texture_mirrored_repeat GL_ARB_window_pos GL_ATI_envm= ap_bumpmap GL_EXT_stencil_two_side GL_EXT_texture_cube_map GL_NV_depth_clam= p GL_APPLE_packed_pixels GL_APPLE_vertex_array_object GL_ARB_draw_buffers G= L_ARB_fragment_program GL_ARB_fragment_shader GL_ARB_shader_objects GL_ARB_= vertex_program GL_ARB_vertex_shader GL_ATI_draw_buffers GL_ATI_texture_env_= combine3 GL_ATI_texture_float GL_EXT_shadow_funcs GL_EXT_stencil_wrap GL_ME= SA_pack_invert GL_NV_primitive_restart GL_ARB_depth_clamp GL_ARB_fragment_p= rogram_shadow GL_ARB_half_float_pixel GL_ARB_occlusion_query2 GL_ARB_point_= sprite GL_ARB_shading_language_100 GL_ARB_sync GL_ARB_texture_non_power_of_= two GL_ARB_vertex_buffer_object GL_ATI_blend_equation_separate GL_EXT_blend= _equation_separate GL_OES_read_format GL_ARB_color_buffer_float GL_ARB_pixe= l_buffer_object GL_ARB_texture_compression_rgtc GL_ARB_texture_float GL_ARB= _texture_rectangle GL_EXT_packed_float GL_EXT_pixel_buffer_object GL_EXT_te= xture_compression_dxt1 GL_EXT_texture_compression_rgtc GL_EXT_texture_recta= ngle GL_EXT_texture_sRGB GL_EXT_texture_shared_exponent GL_ARB_framebuffer_= object GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_packed= _depth_stencil GL_APPLE_object_purgeable GL_ARB_vertex_array_object GL_ATI_= separate_stencil GL_EXT_draw_buffers2 GL_EXT_draw_instanced GL_EXT_gpu_prog= ram_parameters GL_EXT_texture_array GL_EXT_texture_integer GL_EXT_texture_s= RGB_decode GL_EXT_timer_query GL_OES_EGL_image GL_AMD_performance_monitor G= L_ARB_copy_buffer GL_ARB_depth_buffer_float GL_ARB_draw_instanced GL_ARB_ha= lf_float_vertex GL_ARB_instanced_arrays GL_ARB_map_buffer_range GL_ARB_text= ure_rg GL_ARB_texture_swizzle GL_ARB_vertex_array_bgra GL_EXT_texture_swizz= le GL_EXT_vertex_array_bgra GL_NV_conditional_render GL_AMD_conservative_de= pth GL_AMD_draw_buffers_blend GL_AMD_seamless_cubemap_per_texture GL_ARB_ES= 2_compatibility GL_ARB_blend_func_extended GL_ARB_debug_output GL_ARB_draw_= buffers_blend GL_ARB_draw_elements_base_vertex GL_ARB_explicit_attrib_locat= ion GL_ARB_fragment_coord_conventions GL_ARB_provoking_vertex GL_ARB_sample= _shading GL_ARB_sampler_objects GL_ARB_seamless_cube_map GL_ARB_shader_text= ure_lod GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_= multisample GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_unifo= rm_buffer_object GL_ARB_vertex_type_2_10_10_10_rev GL_EXT_provoking_vertex = GL_EXT_texture_snorm GL_MESA_texture_signed_rgba GL_ARB_get_program_binary = GL_ARB_robustness GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding= GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 G= L_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ARB_c= onservative_depth GL_ARB_internalformat_query GL_ARB_map_buffer_alignment G= L_ARB_shader_atomic_counters GL_ARB_shading_language_420pack GL_ARB_shading= _language_packing GL_ARB_texture_storage GL_ARB_transform_feedback_instance= d GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_transform_feedback GL_A= MD_shader_trinary_minmax GL_ARB_ES3_compatibility GL_ARB_clear_buffer_objec= t GL_ARB_invalidate_subdata GL_ARB_texture_query_levels GL_ARB_texture_stor= age_multisample GL_ARB_texture_view GL_ARB_vertex_attrib_binding GL_KHR_deb= ug GL_ARB_buffer_storage GL_ARB_multi_bind GL_ARB_texture_mirror_clamp_to_e= dge GL_ARB_vertex_type_10f_11f_11f_rev GL_EXT_shader_integer_mix GL_INTEL_p= erformance_query I suppose the purpose of this glversion.txt is to avoid reproducibility issues? I see it was added as a "pretty ugly hack" in the nixpkgs repository [1]. (Interestingly enough, this text file doesn't seem to cause me any issues, even though my computer doesn't support OpenGL 3.0, so I guess it's fine.) > diff --git a/gnu/packages/patches/perl-opengl-makefile.patch b/gnu/packag= es/patches/perl-opengl-makefile.patch > new file mode 100644 > index 0000000000..e782113d8b > --- /dev/null > +++ b/gnu/packages/patches/perl-opengl-makefile.patch > @@ -0,0 +1,37 @@ > +diff --git a/Makefile.PL b/Makefile.PL > +index d32205d..3e8fa0a 100755 > +--- a/Makefile.PL > ++++ b/Makefile.PL > +@@ -124,14 +124,7 @@ if ($IS_MINGW) > + # Look for available libs > + our @libdirs =3D qw > + { > +- -L/usr/lib > +- -L/usr/lib/i386-linux-gnu > +- -L/usr/X11R6/lib > +- -L/opt/X11/lib > +- -L/usr/local/lib > +- -L/usr/openwin/lib > +- -L/opt/csw/lib > +- -L/usr/local/freeglut/lib > ++@@libdirs@@ > + }; > + > + our @check_libs =3D qw > +@@ -804,7 +797,6 @@ sub get_extensions > + my $exc_file =3D 'gl_exclude.h'; > + unlink($exc_file) if (-e $exc_file); > + my $glv_file =3D 'utils/glversion.txt'; > +- unlink($glv_file) if (-e $glv_file); > + > + # Only run the rest if GLUT is installed > + print "Testing GLUT version\n" if ($verbose); > +@@ -861,7 +853,7 @@ sub get_extensions > + $make_ver =3D ";make -f Makefile " . (length($lib) ? "GLUT_LIB=3D$= lib " : "") . (length($def) ? "GLUT_DEF=3D$def " : ""); > + print "glversion: '$make_ver'\n" if $verbose>1; > + } > +- my $exec =3D 'cd utils'."$make_ver clean".$make_ver; > ++ my $exec =3D 'cd utils'.$make_ver; > + print "glversion: $exec\n" if ($verbose); > + my $stat =3D `$exec`; > + print "\n$stat\n\n" if ($verbose); At the top of the makefile patch, could you add a brief explanation of the purpose of the patch and/or link to the source of the patch? It makes the patch much more maintainable, and you can find examples of this throughout the gnu/packages/patches subdirectory in the Guix repository. > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm > index 1c3d999d79..093f60f9c9 100644 > --- a/gnu/packages/perl.scm > +++ b/gnu/packages/perl.scm > @@ -27,6 +27,7 @@ > ;;; Copyright =C2=A9 2020 Vincent Legoll > ;;; Copyright =C2=A9 2020 Paul Garlick > ;;; Copyright =C2=A9 2020 Nicolas Goaziou > +;;; Copyright =C2=A9 2020 Malte Frank Gerdes > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -49,6 +50,7 @@ > #:use-module (gnu packages) > #:use-module (guix packages) > #:use-module (guix download) > + #:use-module (guix gexp) > #:use-module (guix git-download) > #:use-module (guix utils) > #:use-module (guix build-system gnu) > @@ -75,6 +77,7 @@ > #:use-module (gnu packages textutils) > #:use-module (gnu packages video) > #:use-module (gnu packages web)) > + #:use-module (gnu packages xorg)) There's a minor parenthesis accounting mistake on the lines above. If you delete the last right parenthesis, the indentation issue should be fixed and the code should compile. > > ;;; > ;;; Please: Try to add new module packages in alphabetic order. I almost missed this note on my first review! Please place the package definition somewhere in the file so that it leaves the file in some sort of alphabetical order. > @@ -11387,3 +11390,61 @@ regexp patterns in modules.") > (description "Data::SExpression parses Lisp S-Expressions into Perl = data > structures.") > (license license:perl-license))) > + > +(define-public perl-opengl > + (package > + (name "perl-opengl") > + (version "0.70") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "mirror://cpan/authors/id/C/CH/CHM/OpenGL-" > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "1q3lz168q081iwl9jg21fbzhp9la79gav9mv6nmh2jab83s2l3mj")) > + (patches (search-patches "perl-opengl-makefile.patch")))) > + (build-system perl-build-system) > + (native-inputs > + `(("xvfb" ,xorg-server-for-tests) > + ("glversion-txt" ,(local-file "aux-files/perl-opengl/glversion.tx= t")))) > + (inputs `(("mesa" ,mesa) > + ("glu" ,glu) > + ("freeglut" ,freeglut) > + ("libxi" ,libxi) > + ("libxmu" ,libxmu) > + ("libice" ,libice))) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (add-before 'configure 'patch-makefile > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "Makefile.PL" > + (("^@@libdirs@@") > + (string-concatenate > + (map (lambda (input) > + (string-append "-L" (cdr input) "/lib\n")) > + inputs)))) > + (substitute* "utils/Makefile" > + (("^all: glversion.txt") "all:")) > + #t)) I'd name the above phase "patch-makefiles" since you've patched multiple files, but that's just me. ;-) > + (add-before 'configure 'inject-glversion > + (lambda* (#:key inputs #:allow-other-keys) > + (copy-file (assoc-ref inputs "glversion-txt") > + "utils/glversion.txt") > + #t)) > + (add-before 'check 'pre-check > + (lambda _ > + ;; Tests require a running X server. > + (system "Xvfb :1 &") > + (setenv "DISPLAY" ":1") > + #t)) > + ))) > + (home-page "https://metacpan.org/release/OpenGL") > + (synopsis > + "Perl bindings to the OpenGL API, GLU, and GLUT/FreeGLUT") > + (description "The package provides Perl bindings to OpenGL, GLU > +and FreeGLUT.") > + (license license:perl-license))) Altogether, the code works when the small parenthesis accounting error above is corrected. Please reply to this message with an updated patch, and I'll be happy to review and approve it! Thanks for your contribution, Kei [1]: https://github.com/NixOS/nixpkgs/commit/0fc8d92e53d294f35f63a1898e9b61= f3651d0800#diff-7f99cf156dbc7368d6f642c1a72f316a --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAl92qPcACgkQ5qXuPBlG eg25bxAApdVAda1pBEPQGGypjSoodwy8riNquuC1qtldBBjUR5gdUBjrqRqSMMl2 PyM8izCRTxpilNZXBmRkLc9Rr/l8BBCEb4Y52w4tBYCpNI0XZ9T/7lI1oIBZRl6T TJo/Dj7s9RwApcpsZbZwhB1W24aqc/0HpbuHIJZDbVcV7ESf0+lMcPlhMulnu3vT 6q2S4iYa7CTBeLazVJRq5ggGYCCMw0OSVexD4gZzvzfG3udg7UdRkRuuesGtPFvi +gtb5gc+6KqCAd2u3N6tRaiTLtYdYB6qGiLeQ3xjsOgV9ISoau+PVIWiCtRdfOnT w/xoy/vLLTThBgOt8wtsEVz5v4l5P9k2uNy7ZCgRhq7woj0nGmjcWpAddkqTFF1R mNPUvk0QDpqhIgrhbWxqE+jqw72DAFF7tvD3DRxnGSZDJA2BSkbQnCyLWKAMMDg/ o41ou/4S2TGp+Ku2ckzgfYCLVDAMlx85PXRpP5c69ifAczPs08Lji4dfgW8XQt4W u14RQbG6tWy9u9xrnEPAbk3KxeF7iGAc5QPIlcRdIVuLjJaNXkULtAxUr0KQbdQa jCLiT3PbtX2Y9FSP4rkOlV8cwhKj5SKjXS7pfaFrsDv3s7pn88gsubRR8jktKInm nnCs57x5rsuzcGVuCc0xysfrZlEsrehCmVCLNqxTGZJc+JSYQOk= =hDfj -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 14:00:01 2020 Received: (at 43654) by debbugs.gnu.org; 2 Oct 2020 18:00:01 +0000 Received: from localhost ([127.0.0.1]:42502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPLW-0001hk-57 for submit@debbugs.gnu.org; Fri, 02 Oct 2020 14:00:01 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:46720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPLR-0001hU-6G for 43654@debbugs.gnu.org; Fri, 02 Oct 2020 13:59:52 -0400 Received: by mail-ed1-f65.google.com with SMTP id 33so2553730edq.13 for <43654@debbugs.gnu.org>; Fri, 02 Oct 2020 10:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XdFiYQXxGx+j+s/AH30CFInyIX6RmhcKqq7Wt2ItuhI=; b=gAcT8u+qcjCETSN8onhlSSkEwDKK0Wzt6g7EKmqvO+9dE8jFIHQUMgL3D8DG0vCGHr lAT3o6/z5qjp8SnGiD2rwYnnJw1zHRX1zChgje/p2Z4nUaZH8qmaJiR0PUGe9uS2x42U GjI6OjTSgu+9Ik1j8YUu7eVhCrwrYnvlX+3qA38a9hx3iUulkw2NCnfel095XNXKvnGo ehHQ1QvZ0WWVdYOPzMWd7oPj7ZyjTMSzhFubx6F8j9TqgxUz/h/Ctz5X6UmDn0qnUzaI 04KcItWSjxExWak8zNmsv+Ef03PQPf9kHbA/rJ9XNCFiI2VS7bGX6olR1kTzG3V4M6bi IrsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XdFiYQXxGx+j+s/AH30CFInyIX6RmhcKqq7Wt2ItuhI=; b=XHc8uZ/PJXEUu2i6vNMLgdbQa8qHPLhjv8h9MBTrNduAvaayelhYwaUmsHmc6qvGDL 3YWuzkAXBG8Rz9oV36ptRY5oXlrXg+hFuFKHHNtmvMpag2z+A3tInapUD9hHYwf0k31b G6pSgU8ZceaZStFROiI2GZSX5noiAKGwPuzVn5UxeUSavdo+k9BJa7Y3bD6otU5AdBJ3 cwZgTMPVnz86rAHOkivOUYduMIEEhvMLKre5L6DDw+Pi3o0dgzs/dejejx8wPaocBR+Z feZ4oUAZquYuquzc3YLlL9uMeCHknNJecWWQxJjbpwiZmhYl73rcVGlVrO12AAmDGlUN ruEQ== X-Gm-Message-State: AOAM5330ecX4fjXMNkZ6mGrhswE2mrLgP/WVdc51suLSN0tiEV1SKxIo pyP8CTxhonu5GJaF4addBt4u/8rl7Qk= X-Google-Smtp-Source: ABdhPJzjOL+jAuDJ2WMjrjEDayfsXOpCrVyPXOd4ousZSbDeYThwGJNzgMSnJbY24LJm9685vwqvyw== X-Received: by 2002:aa7:c394:: with SMTP id k20mr3564211edq.279.1601661583120; Fri, 02 Oct 2020 10:59:43 -0700 (PDT) Received: from Morphium (ip-84-118-73-55.unity-media.net. [84.118.73.55]) by smtp.gmail.com with ESMTPSA id a20sm1567307ejb.81.2020.10.02.10.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 10:59:41 -0700 (PDT) From: Malte Frank Gerdes To: Kei Kebreau Subject: Re: [bug#43654] [PATCH] Add perl-opengl References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> Date: Fri, 02 Oct 2020 19:59:41 +0200 In-Reply-To: <87mu15b6yw.fsf@posteo.net> (Kei Kebreau's message of "Fri, 02 Oct 2020 00:13:43 -0400") Message-ID: <867ds8se42.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43654 Cc: 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks for looking into the patch :) >I think we can assume that the same MIT license in the root directory of >the nixpkgs repository also applies to the unmarked files in the >repository. Ok. >I suppose the purpose of this glversion.txt is to avoid reproducibility >issues? I see it was added as a "pretty ugly hack" in the nixpkgs >repository [1]. Yes, exactly. I also noticed, that it doesn't matter what the VENDOR and RENDERER variables contain, it seems that it doesn't get used anyway. >(Interestingly enough, this text file doesn't seem to >cause me any issues, even though my computer doesn't support OpenGL 3.0, >so I guess it's fine.) I guess it would cause issues once a program tries to use OpenGL extensions which are not supported on a given computer, otherwise it shouldn't make any difference. As i understand it this file is supposed to contain a minimum of OpenGL extensions which are widely available, so that this (hopefully=E2=84=A2) won't happen. >At the top of the makefile patch, could you add a brief explanation of >the purpose of the patch and/or link to the source of the patch? It >makes the patch much more maintainable, and you can find examples of >this throughout the gnu/packages/patches subdirectory in the Guix >repository. Done. >There's a minor parenthesis accounting mistake on the lines above. If >you delete the last right parenthesis, the indentation issue should be >fixed and the code should compile. snap, it seems i made a mistake in magit while adding this line... >I almost missed this note on my first review! Please place the package >definition somewhere in the file so that it leaves the file in some sort >of alphabetical order. Yes, after closer inspection of that file i found the order - everything was mixed at the end so i didn't see it. >I'd name the above phase "patch-makefiles" since you've patched multiple >files, but that's just me. ;-) Makes sense =F0=9F=98=81. So i hope i have addressed all things you mentioned. Malte --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=perl-opengl-updated.patch Content-Transfer-Encoding: quoted-printable diff --git a/gnu/local.mk b/gnu/local.mk index f3b5b17e84..001b249e9e 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -37,6 +37,7 @@ # Copyright =C2=A9 2020 Brice Waegeneire # Copyright =C2=A9 2020 Tanguy Le Carrour # Copyright =C2=A9 2020 Martin Becze +# Copyright =C2=A9 2020 Malte Frank Gerdes # # This file is part of GNU Guix. # @@ -1406,6 +1407,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/pam-mount-luks2-support.patch \ %D%/packages/patches/pango-skip-libthai-test.patch \ %D%/packages/patches/pciutils-hurd-configure.patch \ + %D%/packages/patches/perl-opengl-makefile.patch \ %D%/packages/patches/ppsspp-disable-upgrade-and-gold.patch \ %D%/packages/patches/samba-fix-fcntl-hint-detection.patch \ %D%/packages/patches/sdl-pango-api_additions.patch \ diff --git a/gnu/packages/aux-files/perl-opengl/glversion.txt b/gnu/package= s/aux-files/perl-opengl/glversion.txt new file mode 100644 index 0000000000..5b5a9a911f --- /dev/null +++ b/gnu/packages/aux-files/perl-opengl/glversion.txt @@ -0,0 +1,5 @@ +GLUT=3D20801 +VERSION=3D3.0 Mesa 10.2.6 +VENDOR=3DIntel Open Source Technology Center +RENDERER=3DMesa DRI Intel(R) Ivybridge Mobile +EXTENSIONS=3DGL_ARB_multisample GL_EXT_abgr GL_EXT_bgra GL_EXT_blend_color= GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_copy_texture GL_EXT_polyg= on_offset GL_EXT_subtexture GL_EXT_texture_object GL_EXT_vertex_array GL_EX= T_compiled_vertex_array GL_EXT_texture GL_EXT_texture3D GL_IBM_rasterpos_cl= ip GL_ARB_point_parameters GL_EXT_draw_range_elements GL_EXT_packed_pixels = GL_EXT_point_parameters GL_EXT_rescale_normal GL_EXT_separate_specular_colo= r GL_EXT_texture_edge_clamp GL_SGIS_generate_mipmap GL_SGIS_texture_border_= clamp GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod GL_ARB_framebuffer_sRG= B GL_ARB_multitexture GL_EXT_framebuffer_sRGB GL_IBM_multimode_draw_arrays = GL_IBM_texture_mirrored_repeat GL_3DFX_texture_compression_FXT1 GL_ARB_text= ure_cube_map GL_ARB_texture_env_add GL_ARB_transpose_matrix GL_EXT_blend_fu= nc_separate GL_EXT_fog_coord GL_EXT_multi_draw_arrays GL_EXT_secondary_colo= r GL_EXT_texture_env_add GL_EXT_texture_filter_anisotropic GL_EXT_texture_l= od_bias GL_INGR_blend_func_separate GL_NV_blend_square GL_NV_light_max_expo= nent GL_NV_texgen_reflection GL_NV_texture_env_combine4 GL_S3_s3tc GL_SUN_m= ulti_draw_arrays GL_ARB_texture_border_clamp GL_ARB_texture_compression GL_= EXT_framebuffer_object GL_EXT_texture_compression_s3tc GL_EXT_texture_env_c= ombine GL_EXT_texture_env_dot3 GL_MESA_window_pos GL_NV_packed_depth_stenci= l GL_NV_texture_rectangle GL_ARB_depth_texture GL_ARB_occlusion_query GL_AR= B_shadow GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_text= ure_env_dot3 GL_ARB_texture_mirrored_repeat GL_ARB_window_pos GL_ATI_envmap= _bumpmap GL_EXT_stencil_two_side GL_EXT_texture_cube_map GL_NV_depth_clamp = GL_APPLE_packed_pixels GL_APPLE_vertex_array_object GL_ARB_draw_buffers GL_= ARB_fragment_program GL_ARB_fragment_shader GL_ARB_shader_objects GL_ARB_ve= rtex_program GL_ARB_vertex_shader GL_ATI_draw_buffers GL_ATI_texture_env_co= mbine3 GL_ATI_texture_float GL_EXT_shadow_funcs GL_EXT_stencil_wrap GL_MESA= _pack_invert GL_NV_primitive_restart GL_ARB_depth_clamp GL_ARB_fragment_pro= gram_shadow GL_ARB_half_float_pixel GL_ARB_occlusion_query2 GL_ARB_point_sp= rite GL_ARB_shading_language_100 GL_ARB_sync GL_ARB_texture_non_power_of_tw= o GL_ARB_vertex_buffer_object GL_ATI_blend_equation_separate GL_EXT_blend_e= quation_separate GL_OES_read_format GL_ARB_color_buffer_float GL_ARB_pixel_= buffer_object GL_ARB_texture_compression_rgtc GL_ARB_texture_float GL_ARB_t= exture_rectangle GL_EXT_packed_float GL_EXT_pixel_buffer_object GL_EXT_text= ure_compression_dxt1 GL_EXT_texture_compression_rgtc GL_EXT_texture_rectang= le GL_EXT_texture_sRGB GL_EXT_texture_shared_exponent GL_ARB_framebuffer_ob= ject GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_packed_d= epth_stencil GL_APPLE_object_purgeable GL_ARB_vertex_array_object GL_ATI_se= parate_stencil GL_EXT_draw_buffers2 GL_EXT_draw_instanced GL_EXT_gpu_progra= m_parameters GL_EXT_texture_array GL_EXT_texture_integer GL_EXT_texture_sRG= B_decode GL_EXT_timer_query GL_OES_EGL_image GL_AMD_performance_monitor GL_= ARB_copy_buffer GL_ARB_depth_buffer_float GL_ARB_draw_instanced GL_ARB_half= _float_vertex GL_ARB_instanced_arrays GL_ARB_map_buffer_range GL_ARB_textur= e_rg GL_ARB_texture_swizzle GL_ARB_vertex_array_bgra GL_EXT_texture_swizzle= GL_EXT_vertex_array_bgra GL_NV_conditional_render GL_AMD_conservative_dept= h GL_AMD_draw_buffers_blend GL_AMD_seamless_cubemap_per_texture GL_ARB_ES2_= compatibility GL_ARB_blend_func_extended GL_ARB_debug_output GL_ARB_draw_bu= ffers_blend GL_ARB_draw_elements_base_vertex GL_ARB_explicit_attrib_locatio= n GL_ARB_fragment_coord_conventions GL_ARB_provoking_vertex GL_ARB_sample_s= hading GL_ARB_sampler_objects GL_ARB_seamless_cube_map GL_ARB_shader_textur= e_lod GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_mu= ltisample GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_uniform= _buffer_object GL_ARB_vertex_type_2_10_10_10_rev GL_EXT_provoking_vertex GL= _EXT_texture_snorm GL_MESA_texture_signed_rgba GL_ARB_get_program_binary GL= _ARB_robustness GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding G= L_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_= ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ARB_con= servative_depth GL_ARB_internalformat_query GL_ARB_map_buffer_alignment GL_= ARB_shader_atomic_counters GL_ARB_shading_language_420pack GL_ARB_shading_l= anguage_packing GL_ARB_texture_storage GL_ARB_transform_feedback_instanced = GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_transform_feedback GL_AMD= _shader_trinary_minmax GL_ARB_ES3_compatibility GL_ARB_clear_buffer_object = GL_ARB_invalidate_subdata GL_ARB_texture_query_levels GL_ARB_texture_storag= e_multisample GL_ARB_texture_view GL_ARB_vertex_attrib_binding GL_KHR_debug= GL_ARB_buffer_storage GL_ARB_multi_bind GL_ARB_texture_mirror_clamp_to_edg= e GL_ARB_vertex_type_10f_11f_11f_rev GL_EXT_shader_integer_mix GL_INTEL_per= formance_query diff --git a/gnu/packages/patches/perl-opengl-makefile.patch b/gnu/packages= /patches/perl-opengl-makefile.patch new file mode 100644 index 0000000000..2f5afd95f8 --- /dev/null +++ b/gnu/packages/patches/perl-opengl-makefile.patch @@ -0,0 +1,41 @@ +This patch substitutes the harcoded library Paths from Makefile.PL to make= it +easier to insert the store paths. +It also removes the generation of utils/glversion.txt , because it gets +statically copied anyway to not rely on the build machines capabilities. +diff --git a/Makefile.PL b/Makefile.PL +index d32205d..3e8fa0a 100755 +--- a/Makefile.PL ++++ b/Makefile.PL +@@ -124,14 +124,7 @@ if ($IS_MINGW) + # Look for available libs + our @libdirs =3D qw + { +- -L/usr/lib +- -L/usr/lib/i386-linux-gnu +- -L/usr/X11R6/lib +- -L/opt/X11/lib +- -L/usr/local/lib +- -L/usr/openwin/lib +- -L/opt/csw/lib +- -L/usr/local/freeglut/lib ++@@libdirs@@ + }; + + our @check_libs =3D qw +@@ -804,7 +797,6 @@ sub get_extensions + my $exc_file =3D 'gl_exclude.h'; + unlink($exc_file) if (-e $exc_file); + my $glv_file =3D 'utils/glversion.txt'; +- unlink($glv_file) if (-e $glv_file); + + # Only run the rest if GLUT is installed + print "Testing GLUT version\n" if ($verbose); +@@ -861,7 +853,7 @@ sub get_extensions + $make_ver =3D ";make -f Makefile " . (length($lib) ? "GLUT_LIB=3D$li= b " : "") . (length($def) ? "GLUT_DEF=3D$def " : ""); + print "glversion: '$make_ver'\n" if $verbose>1; + } +- my $exec =3D 'cd utils'."$make_ver clean".$make_ver; ++ my $exec =3D 'cd utils'.$make_ver; + print "glversion: $exec\n" if ($verbose); + my $stat =3D `$exec`; + print "\n$stat\n\n" if ($verbose); diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index 1c3d999d79..853968f5f1 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -27,6 +27,7 @@ ;;; Copyright =C2=A9 2020 Vincent Legoll ;;; Copyright =C2=A9 2020 Paul Garlick ;;; Copyright =C2=A9 2020 Nicolas Goaziou +;;; Copyright =C2=A9 2020 Malte Frank Gerdes ;;; ;;; This file is part of GNU Guix. ;;; @@ -49,6 +50,7 @@ #:use-module (gnu packages) #:use-module (guix packages) #:use-module (guix download) + #:use-module (guix gexp) #:use-module (guix git-download) #:use-module (guix utils) #:use-module (guix build-system gnu) @@ -74,7 +76,8 @@ #:use-module (gnu packages sdl) #:use-module (gnu packages textutils) #:use-module (gnu packages video) - #:use-module (gnu packages web)) + #:use-module (gnu packages web) + #:use-module (gnu packages xorg)) =20 ;;; ;;; Please: Try to add new module packages in alphabetic order. @@ -7870,6 +7873,64 @@ technology to store hierarchical information such as= links to other documents within a single file.") (license (package-license perl)))) =20 +(define-public perl-opengl + (package + (name "perl-opengl") + (version "0.70") + (source + (origin + (method url-fetch) + (uri (string-append + "mirror://cpan/authors/id/C/CH/CHM/OpenGL-" + version + ".tar.gz")) + (sha256 + (base32 + "1q3lz168q081iwl9jg21fbzhp9la79gav9mv6nmh2jab83s2l3mj")) + (patches (search-patches "perl-opengl-makefile.patch")))) + (build-system perl-build-system) + (native-inputs + `(("xvfb" ,xorg-server-for-tests) + ("glversion-txt" ,(local-file "aux-files/perl-opengl/glversion.txt"= )))) + (inputs `(("mesa" ,mesa) + ("glu" ,glu) + ("freeglut" ,freeglut) + ("libxi" ,libxi) + ("libxmu" ,libxmu) + ("libice" ,libice))) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-before 'configure 'patch-makefiles + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "Makefile.PL" + (("^@@libdirs@@") + (string-concatenate + (map (lambda (input) + (string-append "-L" (cdr input) "/lib\n")) + inputs)))) + (substitute* "utils/Makefile" + (("^all: glversion.txt") "all:")) + #t)) + (add-before 'configure 'inject-glversion + (lambda* (#:key inputs #:allow-other-keys) + (copy-file (assoc-ref inputs "glversion-txt") + "utils/glversion.txt") + #t)) + (add-before 'check 'pre-check + (lambda _ + ;; Tests require a running X server. + (system "Xvfb :1 &") + (setenv "DISPLAY" ":1") + #t)) + ))) + (home-page "https://metacpan.org/release/OpenGL") + (synopsis + "Perl bindings to the OpenGL API, GLU, and GLUT/FreeGLUT") + (description "The package provides Perl bindings to OpenGL, GLU +and FreeGLUT.") + (license (package-license perl)))) + (define-public perl-package-anon (package (name "perl-package-anon") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 14:29:23 2020 Received: (at 43654) by debbugs.gnu.org; 2 Oct 2020 18:29:23 +0000 Received: from localhost ([127.0.0.1]:42550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPo3-0002Rf-De for submit@debbugs.gnu.org; Fri, 02 Oct 2020 14:29:23 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:37516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPo2-0002RX-4J for 43654@debbugs.gnu.org; Fri, 02 Oct 2020 14:29:22 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 8761AF44; Fri, 2 Oct 2020 20:29:20 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DI1Krk8JddNl; Fri, 2 Oct 2020 20:29:19 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::5f8]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 8271EE6D; Fri, 2 Oct 2020 20:29:19 +0200 (CEST) Date: Fri, 2 Oct 2020 20:29:17 +0200 From: Andreas Enge To: Kei Kebreau Subject: Re: [bug#43654] [PATCH] Add perl-opengl Message-ID: <20201002182917.GB4862@jurong> References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mu15b6yw.fsf@posteo.net> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43654 Cc: Malte Frank Gerdes , 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hello, On Fri, Oct 02, 2020 at 12:13:43AM -0400, Kei Kebreau wrote: > > @@ -0,0 +1,5 @@ > > +GLUT=20801 > > +VERSION=3.0 Mesa 10.2.6 > > +VENDOR=Intel Open Source Technology Center > > +RENDERER=Mesa DRI Intel(R) Ivybridge Mobile > I suppose the purpose of this glversion.txt is to avoid reproducibility > issues? I see it was added as a "pretty ugly hack" in the nixpkgs > repository [1]. (Interestingly enough, this text file doesn't seem to > cause me any issues, even though my computer doesn't support OpenGL 3.0, > so I guess it's fine.) I also tried to package perl-opengl (as a prerequisite for slic3r); the problem is that during the configure phase it wants to do this: In order to test your GPU's capabilities, run this make under an X11 shell freeglut (./glversion): failed to open display '' make: *** [Makefile:24: glversion.txt] Error 1 to create the file, which will presumably depend on the GPU in the build machine, a no-go. Nix works around this by providing a fixed file. I did not investigate whether this will work everywhere; it clearly leaks information on the machine where it was created. In my case, for instance, I got "Skylake" instead of "Ivybridge". It all feels a bit brittle; for instance, we have freeglut@2.8.1 and @3.2.1 in Guix; I suppose "GLUT=20801" refers to @2.8.1. Will it work with a newer version? Our mesa is @20.0.8 and not 10.2.6. But I also do not know if there is a better solution. Andreas PS: I spotted a frowned-upon "cdr" in the package ;-) From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 15:33:14 2020 Received: (at 43654) by debbugs.gnu.org; 2 Oct 2020 19:33:14 +0000 Received: from localhost ([127.0.0.1]:42602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOQnq-0003yT-5A for submit@debbugs.gnu.org; Fri, 02 Oct 2020 15:33:14 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:37599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOQno-0003yF-AC for 43654@debbugs.gnu.org; Fri, 02 Oct 2020 15:33:12 -0400 Received: by mail-ed1-f41.google.com with SMTP id n22so2872749edt.4 for <43654@debbugs.gnu.org>; Fri, 02 Oct 2020 12:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4PQuYzCpBsUrJcb44h31MMxE6CsDaGqcUiE4ti2BeNE=; b=RMXlqDWgbqmBv1vt24t28vmLb+b43L0X74wFaJE9AUxXtSpSef9v1383PGKfMlPNQB So4ubnqHtknGDfhpigpshprGCYH8MB4ObBDW+Szs1fLJ2ADmKH0zpBtFT8PEO8dampCF 3iDvKaQ1iYV2hC5LjcwaQIzZeYBWIuf+V/6cj12NkLLFAXeGUnJAOVNpNDUR+1K0Dn0J vq/NSyUjFIGSukY21MwPIFIfH/tc/KcXtJBTeH1yUsfx0Eu2CL59PDrYwu/ucNV6w55i KxMbHPKn6+WGt+/XLKskQdV15AjzLCXNBPFu2sdY495KSR7e0sGbZPilnElgczCfGSdL 4tog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4PQuYzCpBsUrJcb44h31MMxE6CsDaGqcUiE4ti2BeNE=; b=MkypIIiLmfL474oIFYlHhKZ5n5iU2nZLBtm9y5ai6huI+8n3KVh0h3jelL1bRrmSme GssDl5IAERvgIPnZ68IA2M87btC5Fib0/jMcSt5TSXAspg84StuTopQV12+YXGAQ5KuA BKemQSSXMa81LGX19vmper7aeCiG5TEEYqy6Us6UdEMnrSqliainSSe8PBnvoTh6V/fi AOgan2zyBvYOUYdoUksitoayBm2RdxaJZ5XfA+tZZ1I0MKPAUsMoGl5lE5OocQwZdS3N 0yEf3FSHZRLkxpvPsJ0GRSRPWz3RFpGmfQwGvZ2eqn8z6TsDrAsBrNNCAyx31HHHyGhB kHoQ== X-Gm-Message-State: AOAM532+5J3ufnohPu07cAicxRKGZ8jsjXMJMbcsioR/TmoSkqD1Zzbt neZqDS4UAwGIOhaTknwBa2QG+BE30fEMZw== X-Google-Smtp-Source: ABdhPJyW7Xd229F1gnDsmAFnnOdlZ4w615zhFUnE8fbWkEOxVnWqojzBzjdFddOD6ZF0cOCh89DyHA== X-Received: by 2002:a05:6402:3c1:: with SMTP id t1mr4028280edw.231.1601667185641; Fri, 02 Oct 2020 12:33:05 -0700 (PDT) Received: from Morphium (ip-84-118-73-55.unity-media.net. [84.118.73.55]) by smtp.gmail.com with ESMTPSA id bz5sm1690895ejc.83.2020.10.02.12.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 12:33:04 -0700 (PDT) From: Malte Frank Gerdes To: Andreas Enge Subject: Re: [bug#43654] [PATCH] Add perl-opengl References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> <20201002182917.GB4862@jurong> Date: Fri, 02 Oct 2020 21:33:04 +0200 In-Reply-To: <20201002182917.GB4862@jurong> (Andreas Enge's message of "Fri, 2 Oct 2020 20:29:17 +0200") Message-ID: <86362ws9sf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43654 Cc: Kei Kebreau , 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Hello, > > On Fri, Oct 02, 2020 at 12:13:43AM -0400, Kei Kebreau wrote: >> > @@ -0,0 +1,5 @@ >> > +GLUT=20801 >> > +VERSION=3.0 Mesa 10.2.6 >> > +VENDOR=Intel Open Source Technology Center >> > +RENDERER=Mesa DRI Intel(R) Ivybridge Mobile >> I suppose the purpose of this glversion.txt is to avoid reproducibility >> issues? I see it was added as a "pretty ugly hack" in the nixpkgs >> repository [1]. (Interestingly enough, this text file doesn't seem to >> cause me any issues, even though my computer doesn't support OpenGL 3.0, >> so I guess it's fine.) > > I also tried to package perl-opengl (as a prerequisite for slic3r); the > problem is that during the configure phase it wants to do this: > > In order to test your GPU's capabilities, run this make under an X11 shell > freeglut (./glversion): failed to open display '' > make: *** [Makefile:24: glversion.txt] Error 1 > > to create the file, which will presumably depend on the GPU in the build > machine, a no-go. Nix works around this by providing a fixed file. I did not > investigate whether this will work everywhere; it clearly leaks information > on the machine where it was created. In my case, for instance, I got "Skylake" > instead of "Ivybridge". It all feels a bit brittle; for instance, we have > freeglut@2.8.1 and @3.2.1 in Guix; I suppose "GLUT=20801" refers to @2.8.1. > Will it work with a newer version? Our mesa is @20.0.8 and not 10.2.6. I just tried to build with those variables set to arbitrary values: --8<---------------cut here---------------start------------->8--- GLUT=99999 VERSION=3.0 Mesa 99.99.99 VENDOR=NoVendor RENDERER=MesaRenderer --8<---------------cut here---------------end--------------->8--- the package builds and no tests fail, so those might even be irrelevant, but i cannot test it properly, because no program using perl-opengl is packaged (and i can't manage to get slic3r packaged...). Malte From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 04 04:26:24 2020 Received: (at 43654) by debbugs.gnu.org; 4 Oct 2020 08:26:24 +0000 Received: from localhost ([127.0.0.1]:44935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOzLc-0001bO-4B for submit@debbugs.gnu.org; Sun, 04 Oct 2020 04:26:24 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:47138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOzLZ-0001ax-Md for 43654@debbugs.gnu.org; Sun, 04 Oct 2020 04:26:22 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 366B426B; Sun, 4 Oct 2020 10:26:20 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jdv-qcZqMQjv; Sun, 4 Oct 2020 10:26:19 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::3f1]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 18B9B235; Sun, 4 Oct 2020 10:26:18 +0200 (CEST) Date: Sun, 4 Oct 2020 10:26:17 +0200 From: Andreas Enge To: Malte Frank Gerdes Subject: Re: [bug#43654] [PATCH] Add perl-opengl Message-ID: <20201004082617.GA1532@jurong> References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> <20201002182917.GB4862@jurong> <86362ws9sf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86362ws9sf.fsf@gmail.com> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43654 Cc: Kei Kebreau , 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On Fri, Oct 02, 2020 at 09:33:04PM +0200, Malte Frank Gerdes wrote: > I just tried to build with those variables set to arbitrary values: > > --8<---------------cut here---------------start------------->8--- > GLUT=99999 > VERSION=3.0 Mesa 99.99.99 > VENDOR=NoVendor > RENDERER=MesaRenderer > --8<---------------cut here---------------end--------------->8--- > > the package builds and no tests fail, so those might even be irrelevant, > but i cannot test it properly, because no program using perl-opengl is > packaged (and i can't manage to get slic3r packaged...). These are good news! Maybe we should keep these dummy values in then. Do you happen to know any other (easier to package) software using perl-opengl? I would feel more at ease if we could test the package before pushing it. Andreas From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 04 08:29:04 2020 Received: (at 43654) by debbugs.gnu.org; 4 Oct 2020 12:29:04 +0000 Received: from localhost ([127.0.0.1]:45057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP38S-0002AG-E5 for submit@debbugs.gnu.org; Sun, 04 Oct 2020 08:29:04 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:40861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP38Q-00029m-VZ for 43654@debbugs.gnu.org; Sun, 04 Oct 2020 08:29:03 -0400 Received: by mail-ej1-f46.google.com with SMTP id p15so7969635ejm.7 for <43654@debbugs.gnu.org>; Sun, 04 Oct 2020 05:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BPY+TFR8dBcvYqgVNs7X2BQbfmvFBVCctXsypvDas2I=; b=oXZ9qG7yhcW72wxfhJAqV2er7oss4pq6LKV1iCycaTDQXZElYyzjZFUW5VzEvLnRqI IQLTvSBt6WNifDQxfvzylsQ+2i8fzt9RateBuqItQUiJRmgLf1nhbx2nUf0zh+ui+zd8 PE54cbUmuVyBSv/kge4ep4dpGTymrM6GrG8Df66dwbiP5mE2f7XRgKD2pfzzdJGPh7fx fn9gTExqsSD0qQqWbLCxRGt9z+7VOL3Q5FFyCKFG5bX+KJ1onhuWOIgmlhjuHuslCG0l BGd843FDJ9zGXbXLw4Ys4yIg+gStZqEKZBUGqC7wVrFl6OaKeyzp4lgoS90xDJgch5CB p+Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BPY+TFR8dBcvYqgVNs7X2BQbfmvFBVCctXsypvDas2I=; b=MNTyO+UB2DWvr84R0+LEhT+529kSkSp4IPyCOF50g9B1eUVZ3LYjA/othS41DE2voK DQO74oe6a77MYPyNZUlVcjY0+xmJJYaHsY0ZMcCzgFkiaWLyDTBVGjcwwZXYFOF0Yr18 IMGhmWyX9yEuDwsVAVcltxzxZjABj4SUplTr23rmcKI67Nh+Y0qISN2BnyaKCmx5+upb LgErAoFInf5xy6MRjzmGVf84KzCQP8gxpaxziIu7Y5SAevwYeHOCgh3FQqI4mygHaN4v 8h2AnTEO7vW+GnAX7JrN0Nfz/FJCdCtLx4O1SfgX/9o4X0Bnk3eLCErCvi0rqJ/M36fT lCfQ== X-Gm-Message-State: AOAM533ioI0wJ6qBcX1gC64KqGZKte8AVHEbpMa+9JZ2cGTyJ2bcMfNd X/Y77K6QZe53BfLWHd3ZKnpLrqkcSI7RIw== X-Google-Smtp-Source: ABdhPJz9vskHEoBo18yfb0sdW+cDukeSG3KEK/oStdHxgeKz7TULaOb//29qqrwOO4fWjX0f0/BlyA== X-Received: by 2002:a17:906:6409:: with SMTP id d9mr10445785ejm.344.1601814536814; Sun, 04 Oct 2020 05:28:56 -0700 (PDT) Received: from Morphium (ip-84-118-73-55.unity-media.net. [84.118.73.55]) by smtp.gmail.com with ESMTPSA id b3sm4297155edx.27.2020.10.04.05.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2020 05:28:56 -0700 (PDT) From: Malte Frank Gerdes To: Andreas Enge Subject: Re: [bug#43654] [PATCH] Add perl-opengl References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> <20201002182917.GB4862@jurong> <86362ws9sf.fsf@gmail.com> <20201004082617.GA1532@jurong> Date: Sun, 04 Oct 2020 14:28:55 +0200 In-Reply-To: <20201004082617.GA1532@jurong> (Andreas Enge's message of "Sun, 4 Oct 2020 10:26:17 +0200") Message-ID: <86r1qeuqd4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43654 Cc: Kei Kebreau , 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas Enge writes: > On Fri, Oct 02, 2020 at 09:33:04PM +0200, Malte Frank Gerdes wrote: >> I just tried to build with those variables set to arbitrary values: >> >> --8<---------------cut here---------------start------------->8--- >> GLUT=99999 >> VERSION=3.0 Mesa 99.99.99 >> VENDOR=NoVendor >> RENDERER=MesaRenderer >> --8<---------------cut here---------------end--------------->8--- >> >> the package builds and no tests fail, so those might even be irrelevant, >> but i cannot test it properly, because no program using perl-opengl is >> packaged (and i can't manage to get slic3r packaged...). > > These are good news! Maybe we should keep these dummy values in then. > Do you happen to know any other (easier to package) software using > perl-opengl? I would feel more at ease if we could test the package > before pushing it. > > Andreas > The official repo (git clone https://git.code.sf.net/p/pogl/code pogl-code) seems to contain a test.pl file which should showcase some things if i read that correctly. I will try it out later. Malte From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 04 08:32:56 2020 Received: (at 43654) by debbugs.gnu.org; 4 Oct 2020 12:32:56 +0000 Received: from localhost ([127.0.0.1]:45062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP3CB-0002Gx-Ub for submit@debbugs.gnu.org; Sun, 04 Oct 2020 08:32:56 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:37993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP3C9-0002Gj-MQ for 43654@debbugs.gnu.org; Sun, 04 Oct 2020 08:32:54 -0400 Received: by mail-ej1-f65.google.com with SMTP id ce10so7981942ejc.5 for <43654@debbugs.gnu.org>; Sun, 04 Oct 2020 05:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kgKCAkqUt68XHJZOTUuqmBk59AigUdUA9gTwQsMMfRg=; b=uMUZuAq3Wtnbycwz6yj+s2wlL9bVXVSTEDTB0fgn/h4ZHTdDyQX75pkKdGgkEjxAQn JJsi+GGC0v+px+KjY7UlZ+52I64UNjEiL5aUuJnAiwXbQQlc+OxFRfm8jU+F/WCEf8iS YctC5Gd1ubJ+u7Z3jzcBDvrqBmXSBFi6YGRc/vWb+uybE0+6/TpZAn3xXZ4mvfkQDgvf e15AJNCVU9HGta2lbRRlBipJBJzeeJBy6Jb8h7nxSd1ONG7TmFkO/O1fnwE5XMNjeBBB g+TM1x65+b26R5sGwUyPi5S+u89QZxXJ8lPap8MDawvS5nJ6R70+96UCc03o18KVBd3v yF1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kgKCAkqUt68XHJZOTUuqmBk59AigUdUA9gTwQsMMfRg=; b=RzBnwXgtdZtEpI2/6lTLiAzzTK9pBRfJV+Pgxy62qsfnB637eu92VDdKOLmdOQ89/z HLpySdtiWyTuEiJzXxxSNIXZqH/fTzSr53MltBNhRCEAUpSUhnVTjBr72xy9IgDPGyXS ndd0C+KDyLqmbjMM9nofHY0Gay4poj4DdSI+GEtS58mj8nMvMR+x8GcEKmmSA/S5VjNA w3jInMG08LXTU+R/uzEsSNzAlz0hFn+MbMMM1CCpwvwYOJPgjtbgKlr88lSgSTkw0naZ S0Zt4b05XlAr3ny4Pzrua/rjbkbaXdARq/sbHMyIWPn1idhzQWYxVNdArsGfKI9334c2 nCNg== X-Gm-Message-State: AOAM533PIV7lr148TMegGuyfF5GeKGa/WaqzBtblfykB6t4ZxWIRuhnK U/9GqnhDIcPOyoJQwVc2B9QvrtTtJ/yWcw== X-Google-Smtp-Source: ABdhPJxuzBN+YG8LDlGMYW7hQPsAnWY0Cm7z7aIsQY18yiSIievlC5x/f4Jn50BzlijyduUkXrK9sQ== X-Received: by 2002:a17:906:cede:: with SMTP id si30mr1293820ejb.236.1601814767891; Sun, 04 Oct 2020 05:32:47 -0700 (PDT) Received: from Morphium (ip-84-118-73-55.unity-media.net. [84.118.73.55]) by smtp.gmail.com with ESMTPSA id i14sm5540685ejp.2.2020.10.04.05.32.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2020 05:32:47 -0700 (PDT) From: Malte Frank Gerdes To: Andreas Enge Subject: Re: [bug#43654] [PATCH] Add perl-opengl References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> <20201002182917.GB4862@jurong> <86362ws9sf.fsf@gmail.com> <20201004082617.GA1532@jurong> Date: Sun, 04 Oct 2020 14:32:46 +0200 In-Reply-To: <20201004082617.GA1532@jurong> (Andreas Enge's message of "Sun, 4 Oct 2020 10:26:17 +0200") Message-ID: <86mu12uq6p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43654 Cc: Kei Kebreau , 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I also totally forgot to ask: What should be used instead of a cdr - if it's bad practice? Malte From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 04:10:48 2020 Received: (at 43654) by debbugs.gnu.org; 5 Oct 2020 08:10:49 +0000 Received: from localhost ([127.0.0.1]:47767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLa4-0004CD-Lj for submit@debbugs.gnu.org; Mon, 05 Oct 2020 04:10:48 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:33451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLa2-0004Bz-MV for 43654@debbugs.gnu.org; Mon, 05 Oct 2020 04:10:47 -0400 Received: by mail-wm1-f51.google.com with SMTP id z22so1182880wmi.0 for <43654@debbugs.gnu.org>; Mon, 05 Oct 2020 01:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=ru6TcqTiab1re/mpJ/orC6h8gL9JWZ/Pit774qSxYDY=; b=DCc668e51xuiXprbWNg1GGx42k1URNP2gmDyTRE55ndi/eWesv6NbzB+S/wKMWWZUR RT1XPzt6Defs0hEEwhNmI/VP2EogeR15RFJ+YnllQcjkLjhmpRmrlU/NwIuHj2brXtBz mCiqnYXTkrHwrx8mmhptSnc7mMLcKq+O29AiSH+9l/gU+KpjkCcOT7P8a/gcn4YedRqI 1EygNWI8qEIywjCk/iUDgzl0G0DZjtxarccVvZ9/c33bp9X0NieQY2MC34AUxhKqNOqc az3pUX65ZqtTXp0sFs6vLvyr+3syoxmv+DpTJMoQYyFsQozWh4gNgGkLOhfRGZRWXlaU jUVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=ru6TcqTiab1re/mpJ/orC6h8gL9JWZ/Pit774qSxYDY=; b=sxD5UWDkGKa6fs7aUULcZsfIUYiX/aoeNO/KfN4NOqko4kkEiZQxG/GssejedXOz7f 6Iarr3p1bWZjWCldLtqKh+rS1aQKBoj8YS4iX8YWi14A5fRre71+zKV5xUuZD2D/0zid y1WkPADbSuhcTDUroqglyKzlsQEHt2N1VtaGuabMZu7iUPJBHgqJviU2eWqLfwJz1wOA 0c5BYZ1SZifxZzinBDIGSIX9G/xLDFgV6bUCykdGlgMOKU932ycxUsr4CFZUqMJCxYZ7 QNxBEpsIvlEwcyYoT+xt8MiHqP6Suvocv1sfa6h7TOXc940cn7egcbOdTyvFu2ubzzZR 0wWQ== X-Gm-Message-State: AOAM532ZfeTzPl9912havJfw1s5A/Y9Iy8k3aLdZdtNXXnHRiJgvA5fK MGz8DDZSXx85fUMFsXo9zchATO/EWzo= X-Google-Smtp-Source: ABdhPJzxKqP4KNy29AqldQuVBH7N2SDYukkKAFk73x6Ty3Dl07bJs+oBaAB89VHbr9385QpHHZCrwg== X-Received: by 2002:a05:600c:2284:: with SMTP id 4mr3267849wmf.163.1601885440653; Mon, 05 Oct 2020 01:10:40 -0700 (PDT) Received: from Morphium (ip-84-118-73-55.unity-media.net. [84.118.73.55]) by smtp.gmail.com with ESMTPSA id i16sm12167192wrq.73.2020.10.05.01.10.39 for <43654@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 01:10:39 -0700 (PDT) From: Malte Frank Gerdes To: 43654@debbugs.gnu.org Subject: [bug#43654] [PATCH] Add perl-opengl Date: Mon, 05 Oct 2020 10:10:39 +0200 Message-ID: <86h7r9um80.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43654 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain In order to run the test.pl file from the official repo those packages are also needed. Unfortunately i only get a black screen... I'm using sway so that might make a difference even though xwayland is enabled. It's also interesting that this app dynamically determines which OpenGL features and which driver is installed. And juding from the output this also gets run when perl-opengl is built. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=needed-for-perl-opengl-test.patch diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index 853968f5f1..31ddbb1e54 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -7931,6 +7931,66 @@ documents within a single file.") and FreeGLUT.") (license (package-license perl)))) +(define-public perl-opengl-shader + (package + (name "perl-opengl-shader") + (version "1.01") + (source + (origin + (method url-fetch) + (uri (string-append + "mirror://cpan/authors/id/B/BF/BFREE/OpenGL-Shader-" + version + ".tar.gz")) + (sha256 + (base32 + "0wmd76smyd9qzr3ga86vjhkzjj9ga6prqhyvdi41l1jfk0x82pcz")))) + (build-system perl-build-system) + (native-inputs + `(("xvfb" ,xorg-server-for-tests))) + (propagated-inputs + `(("perl-opengl" ,perl-opengl))) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-before 'check 'pre-check + (lambda _ + ;; Tests require a running X server. + (system "Xvfb :1 &") + (setenv "DISPLAY" ":1") + #t)) + ))) + (home-page + "https://metacpan.org/release/OpenGL-Shader") + (synopsis + "empty") + (description "empty") + (license #f))) + +(define-public perl-opengl-image + (package + (name "perl-opengl-image") + (version "1.03") + (source + (origin + (method url-fetch) + (uri (string-append + "mirror://cpan/authors/id/B/BF/BFREE/OpenGL-Image-" + version + ".tar.gz")) + (sha256 + (base32 + "1cf7c0fgba7g3r09y5hbj6ljs6dyjbzaqf9mv3qz807np3msqqa6")))) + (build-system perl-build-system) + (propagated-inputs + `(("perl-opengl" ,perl-opengl))) + (home-page + "https://metacpan.org/release/OpenGL-Image") + (synopsis + "empty") + (description "empty") + (license #f))) + (define-public perl-package-anon (package (name "perl-package-anon") --=-=-= Content-Type: text/plain Malte --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 11:01:40 2020 Received: (at 43654) by debbugs.gnu.org; 5 Oct 2020 15:01:40 +0000 Received: from localhost ([127.0.0.1]:50112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPRzg-0001rz-6T for submit@debbugs.gnu.org; Mon, 05 Oct 2020 11:01:40 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPRzd-0001l9-CS for 43654@debbugs.gnu.org; Mon, 05 Oct 2020 11:01:38 -0400 Received: by mail-wr1-f66.google.com with SMTP id m6so9998103wrn.0 for <43654@debbugs.gnu.org>; Mon, 05 Oct 2020 08:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bn3XWfjZx+7L8bDit/34/lbGx0UzPiwtktJXYuFQVJ4=; b=oWSWXoJZUGdpnLfyhX9snWTLMA1ML6LEqJrNC5WCMEEjrjHZ+aaeym7yzGPv7aJkpA sw/j8lrGClVYgwpZTBKdiE8OfKl5p1bYqBHjuLno/0tefptO9GXZpM3LbYMLpcgC9AKs 3nTxKTLErFX2nElR+T6f6eYGWhsGZ52Jg2P+2xP0ONvoShZxTeEsZZKo0rzpZ9+ZGJb7 cZcObfjgWsadXKqbZfoQE9O7/DbT/pGiqrgghNyIIbfb0KBMD2xIUSxcBfF4Oa9huZ1H m485pouqPf8/MPfcVY135y4IVeasxJU2zoyvlRnUR49XNr1yEFtOKUrZaCCfAGrloVWS Gn6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bn3XWfjZx+7L8bDit/34/lbGx0UzPiwtktJXYuFQVJ4=; b=R8rRSEzg013Xfu9B2zugtcPqvDHw6lk5TaaNFjqiFAnL2XDfggB/4JtGH1RzXYSyzK nYMtz+6paQyI6DwfAZ7OcUJN1Z10L0UbRa8RTzfKF0ztmNwZbNlQe6jsbM9dfOH8z/2B LJmT5LcHjLet31UrNKWJU1rHXVckt2aowJ0FBepVmTq9GMI6sUdVEaunCF1lwu8x636i crbJB+scvPGX+iPcciReqNPM/DL4FCNQKxg06wqDCaRunidqsESHnes4YKGflIa6IoF3 rTh+PQCbWviVSJg1cGRcvqx/CT+Ob0YMmkhLYl4qdHkVwLCqApEdIZu9it8oWXofl1Zd i0cA== X-Gm-Message-State: AOAM531gSSS0f+QDDTFcNgfc8v+gSxKjSB8xqqgg8jpPgISEn2JloukI +OkU6YUph4N1F6Z5eM/twUc= X-Google-Smtp-Source: ABdhPJyB53grml4rK9KRB7I5MO4JbAQ1LrTzWzBPKaYUkYXfwNXrXSDobkPe20QSoRTbvDrrAyPIWw== X-Received: by 2002:adf:ec06:: with SMTP id x6mr8058227wrn.404.1601910091482; Mon, 05 Oct 2020 08:01:31 -0700 (PDT) Received: from Morphium (ip-84-118-73-55.unity-media.net. [84.118.73.55]) by smtp.gmail.com with ESMTPSA id h1sm290787wrx.33.2020.10.05.08.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 08:01:30 -0700 (PDT) From: Malte Frank Gerdes To: 43654@debbugs.gnu.org Subject: Re: [bug#43654] [PATCH] Add perl-opengl References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> Date: Mon, 05 Oct 2020 17:01:29 +0200 In-Reply-To: <87mu15b6yw.fsf@posteo.net> (Kei Kebreau's message of "Fri, 02 Oct 2020 00:13:43 -0400") Message-ID: <861ricvhrq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43654 Cc: kkebreau@posteo.net, andreas@enge.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) So i now managed to test if it works :) (spoiler: it does - at least on my machine). The patch attached to my previous mail which just adds perl-opengl-shader and perl-opengl-image are not necessary (and also not complete). I did the following: 1. ./pre-inst-env guix environment perl-opengl --ad-hoc perl-opengl 2. git clone git://git.code.sf.net/p/pogl/code pogl-code 3. cd pogl-code/examples 4. for p in *.pl; do timeout 5 perl $p; done and this should result in all examples running successfully. This isn't something that can be added to the test phase, isn't it? The black screen of test.pl is a mystery (to me) though :/ Malte From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 16:05:32 2020 Received: (at 43654) by debbugs.gnu.org; 5 Oct 2020 20:05:32 +0000 Received: from localhost ([127.0.0.1]:50619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPWjV-0003tz-Kl for submit@debbugs.gnu.org; Mon, 05 Oct 2020 16:05:32 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:58078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPWjT-0003to-4z for 43654@debbugs.gnu.org; Mon, 05 Oct 2020 16:05:16 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 5820DE22; Mon, 5 Oct 2020 22:05:13 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aeeZBNDYT4-J; Mon, 5 Oct 2020 22:05:12 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::3f1]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0D6E9733; Mon, 5 Oct 2020 22:05:11 +0200 (CEST) Date: Mon, 5 Oct 2020 22:05:09 +0200 From: Andreas Enge To: Malte Frank Gerdes Subject: Re: [bug#43654] [PATCH] Add perl-opengl Message-ID: <20201005200509.GA5230@jurong> References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> <861ricvhrq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <861ricvhrq.fsf@gmail.com> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43654 Cc: kkebreau@posteo.net, 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hello Malte, On Mon, Oct 05, 2020 at 05:01:29PM +0200, Malte Frank Gerdes wrote: > The patch attached to my previous mail which just adds > perl-opengl-shader and perl-opengl-image are not necessary (and also not > complete). > > I did the following: > 1. ./pre-inst-env guix environment perl-opengl --ad-hoc perl-opengl > 2. git clone git://git.code.sf.net/p/pogl/code pogl-code > 3. cd pogl-code/examples > 4. for p in *.pl; do timeout 5 perl $p; done > > and this should result in all examples running successfully. This isn't > something that can be added to the test phase, isn't it? that is good news and reassuring, so we can go forward with the patch. The test.pl file you mention also appears in the packaged source from CPAN, so it should be possible to run tests. Concerning the replacement of "cdr", you might want to have a look at "match": https://www.gnu.org/software/guile/manual/html_node/Pattern-Matching.html I will probably not be able to get back to Guix before the weekend, so please do not hesitate to update your patch. And to send more of the perl packages - when I suggested you submit your perl package patches, I did not imagine you would start with the most difficult one ;-) Andreas From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 16:11:09 2020 Received: (at 43654) by debbugs.gnu.org; 5 Oct 2020 20:11:09 +0000 Received: from localhost ([127.0.0.1]:50634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPWpA-00042R-Vn for submit@debbugs.gnu.org; Mon, 05 Oct 2020 16:11:09 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:58124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPWp9-00042J-Bd for 43654@debbugs.gnu.org; Mon, 05 Oct 2020 16:11:07 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 22B601062; Mon, 5 Oct 2020 22:11:06 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Oyu-wOJZaEHy; Mon, 5 Oct 2020 22:11:05 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::3f1]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0DECD733; Mon, 5 Oct 2020 22:11:04 +0200 (CEST) Date: Mon, 5 Oct 2020 22:11:03 +0200 From: Andreas Enge To: Malte Frank Gerdes Subject: Re: [bug#43654] [PATCH] Add perl-opengl Message-ID: <20201005201103.GA8365@jurong> References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> <861ricvhrq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <861ricvhrq.fsf@gmail.com> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43654 Cc: kkebreau@posteo.net, 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) PS: And I would suggest to create a git commit complete with commit message in the usual style, and to use "git format-patch", see https://guix.gnu.org/manual/en/guix.html#Submitting-Patches Then it is easy to apply the patch with "git am", and your name is already attached to the contribution. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 16:51:36 2020 Received: (at 43654) by debbugs.gnu.org; 5 Oct 2020 20:51:36 +0000 Received: from localhost ([127.0.0.1]:50660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPXSK-000776-AL for submit@debbugs.gnu.org; Mon, 05 Oct 2020 16:51:36 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:58406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPXSH-00076x-HY for 43654@debbugs.gnu.org; Mon, 05 Oct 2020 16:51:35 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 195A9E14; Mon, 5 Oct 2020 22:51:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5im8K_vhSo9T; Mon, 5 Oct 2020 22:51:31 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::3f1]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 10B02297; Mon, 5 Oct 2020 22:51:30 +0200 (CEST) Date: Mon, 5 Oct 2020 22:51:29 +0200 From: Andreas Enge To: Malte Frank Gerdes Subject: Re: [bug#43654] [PATCH] Add perl-opengl Message-ID: <20201005205129.GA13742@jurong> References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> <20201002182917.GB4862@jurong> <86362ws9sf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86362ws9sf.fsf@gmail.com> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43654 Cc: Kei Kebreau , 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On Fri, Oct 02, 2020 at 09:33:04PM +0200, Malte Frank Gerdes wrote: > I just tried to build with those variables set to arbitrary values: > > --8<---------------cut here---------------start------------->8--- > GLUT=99999 > VERSION=3.0 Mesa 99.99.99 > VENDOR=NoVendor > RENDERER=MesaRenderer > --8<---------------cut here---------------end--------------->8--- Actually I just went further: FREEGLUT= GLUT= VERSION= VENDOR= RENDERER= EXTENSIONS= The package compiles, but running test.pl (which showed just a blank square before) now fails with this message: Goto undefined subroutine &AutoLoader::AUTOLOAD at /home/andreas/.guix-profile/lib/perl5/site_perl/5.30.2/x86_64-linux-thread-multi/OpenGL.pm line 6178. However, I tried several of the examples, and they work. So one option would be to disable the test ("#:tests? #f") and create the essentially empty glversion.txt file above inside a phase. There would not even be a need to store it as a an auxiliary file; see the use of "call-with-output-file" in guix/tests.scm, for instance. What do you think? Andreas From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 18:35:50 2020 Received: (at 43654) by debbugs.gnu.org; 5 Oct 2020 22:35:50 +0000 Received: from localhost ([127.0.0.1]:50734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPZ5B-0005PB-V5 for submit@debbugs.gnu.org; Mon, 05 Oct 2020 18:35:50 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:58986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPZ5A-0005P2-81 for 43654@debbugs.gnu.org; Mon, 05 Oct 2020 18:35:48 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 98BF71095; Tue, 6 Oct 2020 00:35:46 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IQnPk7W2og4d; Tue, 6 Oct 2020 00:35:45 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::3f1]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 944261062; Tue, 6 Oct 2020 00:35:45 +0200 (CEST) Date: Tue, 6 Oct 2020 00:35:43 +0200 From: Andreas Enge To: Malte Frank Gerdes Subject: Re: [bug#43654] [PATCH] Add perl-opengl Message-ID: <20201005223543.GA19912@jurong> References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> <20201002182917.GB4862@jurong> <86362ws9sf.fsf@gmail.com> <20201005205129.GA13742@jurong> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201005205129.GA13742@jurong> X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, Oct 05, 2020 at 10:51:29PM +0200, Andreas Enge wrote: > So one option would be to disable the test ("#:tests? #f") and create the > essentially empty glversion.txt file above inside a phase. T [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.0 PDS_BTC_MSGID Bitcoin ID with T_MSGID_NOFQDN2 0.5 PDS_BTC_ID FP reduced Bitcoin ID X-Debbugs-Envelope-To: 43654 Cc: Kei Kebreau , 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) On Mon, Oct 05, 2020 at 10:51:29PM +0200, Andreas Enge wrote: > So one option would be to disable the test ("#:tests? #f") and create the > essentially empty glversion.txt file above inside a phase. There would not > even be a need to store it as a an auxiliary file; see the use of > "call-with-output-file" in guix/tests.scm, for instance. Something like this: (add-before 'configure 'glversion ;; Building utils/glversion.txt fails, and is probably ;; dependent on the graphics card in the build system. ;; Replace it by a content-free file; while this breaks ;; the test, the examples in the examples/ subdirectory ;; can be run. (lambda _ (substitute* "Makefile.PL" (("unlink") "# unlink") ; prevent utils/glversion.txt ; from being deleted once... (("\\.\"\\$make_ver clean\"") "")) ; ...and twice... (substitute* "utils/Makefile" (("all: glversion.txt") "all: ")) ; ...and thrice. (call-with-output-file "utils/glversion.txt" (lambda (port) (display (string-append "FREEGLUT=\nGLUT=\nVERSION=\n" "VENDOR=\nRENDERER=\n" "EXTENSIONS=\n") port))) #t)) I tried to add the following instead of patching Makefile.PL: (add-before 'configure 'fix-interface ;; Libraries are not found in default locations, so force ;; an interface. (lambda _ (substitute* "Makefile.PL" (("die \"FreeGLUT or GLUT libraries") "$interface_lib = 'FREEGLUT'; #")) #t)) But it fails during compilation with error messages such as this one: /gnu/store/1qmd9achfkm1njzxf8hi86q53pmy9sxk-mesa-20.0.7/include/GL/glxext.h:530:169: error: unknown type name ‘GLintptr’; did you mean ‘GLint’? >From some search engine results, I surmise that I am missing the $DEFS .= " -DGL_GLEXT_LEGACY"; from line 525 of Makefile.PL. So maybe we will have to replace the "-L/what/ever" as you do it in your cdr/match phase; but instead of adding a patch that drops the "-L" in favour of some "@@libpaths@@" text, only to replace the new text again in a phase, I would use just a phase. For instance, instead of replacing "^@@libdirs@@", just replace "-L/usr/local/freeglut/lib". But it is already tomorrow, time to stop. Andreas From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 18:47:17 2020 Received: (at 43654) by debbugs.gnu.org; 5 Oct 2020 22:47:17 +0000 Received: from localhost ([127.0.0.1]:50744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPZG9-0005fu-7H for submit@debbugs.gnu.org; Mon, 05 Oct 2020 18:47:17 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:59056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPZG5-0005fj-94 for 43654@debbugs.gnu.org; Mon, 05 Oct 2020 18:47:08 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id AE32DF5; Tue, 6 Oct 2020 00:47:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R_dL2wkflptw; Tue, 6 Oct 2020 00:47:02 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::3f1]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 47E28D9; Tue, 6 Oct 2020 00:47:02 +0200 (CEST) Date: Tue, 6 Oct 2020 00:47:00 +0200 From: Andreas Enge To: Malte Frank Gerdes Subject: Re: [bug#43654] [PATCH] Add perl-opengl Message-ID: <20201005224700.GA21768@jurong> References: <86pn67xcmn.fsf@gmail.com> <87mu15b6yw.fsf@posteo.net> <20201002182917.GB4862@jurong> <86362ws9sf.fsf@gmail.com> <20201005205129.GA13742@jurong> <20201005223543.GA19912@jurong> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8t9RHnE3ZwKMSgU+" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201005223543.GA19912@jurong> X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Tue, Oct 06, 2020 at 12:35:43AM +0200, Andreas Enge wrote: > But it is already tomorrow, time to stop. Did I mention that Guix is addictive? Here is a patch that compiles and can run the examples in the subdirectory of the same name. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL blocklist [URIs: dvorsak.fr] 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL blocklist [URIs: dvorsak.fr] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) X-Debbugs-Envelope-To: 43654 Cc: Kei Kebreau , 43654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) --8t9RHnE3ZwKMSgU+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 06, 2020 at 12:35:43AM +0200, Andreas Enge wrote: > But it is already tomorrow, time to stop. Did I mention that Guix is addictive? Here is a patch that compiles and can run the examples in the subdirectory of the same name. If you feel like it, you could replace "cdr" by "match", and maybe test if all of the inputs are actually needed. Andreas --8t9RHnE3ZwKMSgU+ Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: attachment; filename="0001-gnu-Add-perl-opengl.patch" Content-Transfer-Encoding: 8bit >From c6e00eac49ce859a53c1b00a6165c009f778885d Mon Sep 17 00:00:00 2001 From: Andreas Enge Date: Tue, 6 Oct 2020 00:43:45 +0200 Subject: [PATCH] gnu: Add perl-opengl. * gnu/packages/perl.scm (perl-opengl): New variable. Co-authored-by: Malte Frank Gerdes --- gnu/packages/perl.scm | 67 +++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 65 insertions(+), 2 deletions(-) diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index e093a63770..24de203741 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -1,6 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès -;;; Copyright © 2013, 2019 Andreas Enge +;;; Copyright © 2013, 2019, 2020 Andreas Enge ;;; Copyright © 2015, 2016, 2017, 2019 Ricardo Wurmus ;;; Copyright © 2015, 2016, 2017, 2019, 2020 Eric Bavier ;;; Copyright © 2015 Eric Dvorsak @@ -27,6 +27,7 @@ ;;; Copyright © 2020 Vincent Legoll ;;; Copyright © 2020 Paul Garlick ;;; Copyright © 2020 Nicolas Goaziou +;;; Copyright © 2020 Malte Frank Gerdes ;;; ;;; This file is part of GNU Guix. ;;; @@ -74,7 +75,8 @@ #:use-module (gnu packages sdl) #:use-module (gnu packages textutils) #:use-module (gnu packages video) - #:use-module (gnu packages web)) + #:use-module (gnu packages web) + #:use-module (gnu packages xorg)) ;;; ;;; Please: Try to add new module packages in alphabetic order. @@ -7870,6 +7872,67 @@ technology to store hierarchical information such as links to other documents within a single file.") (license (package-license perl)))) +(define-public perl-opengl + (package + (name "perl-opengl") + (version "0.70") + (source + (origin + (method url-fetch) + (uri (string-append + "mirror://cpan/authors/id/C/CH/CHM/OpenGL-" + version + ".tar.gz")) + (sha256 + (base32 + "1q3lz168q081iwl9jg21fbzhp9la79gav9mv6nmh2jab83s2l3mj")))) + (build-system perl-build-system) + (inputs `(("mesa" ,mesa) ; TODO: needed? + ("glu" ,glu) ; TODO: needed? + ("freeglut" ,freeglut) ; TODO: needed? + ("libxi" ,libxi) + ("libxmu" ,libxmu))) + (arguments + '(#:tests? #f ; test.pl fails with our empty glversion.txt, while + ; the package still seems to work on the examples + #:phases + (modify-phases %standard-phases + (add-before 'configure 'glversion + ;; Building utils/glversion.txt fails, and is probably + ;; dependent on the graphics card in the build system. + ;; Replace it by a content-free file; while this breaks + ;; the tests, the examples in the examples/ subdirectory + ;; can be run. + (lambda _ + (substitute* "Makefile.PL" + (("unlink") "# unlink") ; prevent utils/glversion.txt + ; from being deleted once... + (("\\.\"\\$make_ver clean\"") "")) ; ...and twice... + (substitute* "utils/Makefile" + (("all: glversion.txt") "all: ")) ; ...and thrice. + (call-with-output-file "utils/glversion.txt" + (lambda (port) + (display (string-append "FREEGLUT=\nGLUT=\nVERSION=\n" + "VENDOR=\nRENDERER=\n" + "EXTENSIONS=\n") + port))) + #t)) + (add-before 'configure 'fix-library-flags + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "Makefile.PL" + (("-L/usr/local/freeglut/lib") + (string-concatenate + (map (lambda (input) + (string-append "-L" (cdr input) "/lib\n")) + inputs)))) + #t))))) + (home-page "https://metacpan.org/release/OpenGL") + (synopsis + "Perl bindings to the OpenGL API, GLU, and GLUT/FreeGLUT") + (description "The package provides Perl bindings to OpenGL, GLU +and FreeGLUT.") + (license (package-license perl)))) + (define-public perl-package-anon (package (name "perl-package-anon") -- 2.28.0 --8t9RHnE3ZwKMSgU+-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 07 14:21:11 2020 Received: (at 43654) by debbugs.gnu.org; 7 Oct 2020 18:21:12 +0000 Received: from localhost ([127.0.0.1]:58045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQE3i-0006a5-Q5 for submit@debbugs.gnu.org; Wed, 07 Oct 2020 14:21:11 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:45663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQE3e-0006ZE-OZ for 43654@debbugs.gnu.org; Wed, 07 Oct 2020 14:21:02 -0400 Received: by mail-ej1-f67.google.com with SMTP id dt13so4329314ejb.12 for <43654@debbugs.gnu.org>; Wed, 07 Oct 2020 11:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=C8+MMHauUZgAOZ1/LOYgZED4TUWt1nK//pkkVfdteng=; b=RJcjF/ti9lhoMWo/55o80Jo+Dhk7Dko0//X9qlNizjARjVVXsVnMw8nSM7XcJ77PN0 OzDB2dmGdBsZ4Wvh5cITNhHIMVSF+Sr05V53ae/VRRXId6F4rErTiti/0CDHfzttXrhT JAjQ7qimNS4bg1JwvEgyHK88n5hmbpwQubgx7cH9X2noCXx7h0I5B7YQ5dYuF8rQl5Py dE5J4lLMCRkslI0uuzyYpILQzL65HHPcIAlQ36v2ahwuHkBMgoUEtkVlwtmYVyndjoJw IGx4STh2rNs0TNNWnesnhwmEYLJ46TULZ1VQ+sbq9JdtO/0CFQeXmALm9JKzAtCL27x8 BfIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=C8+MMHauUZgAOZ1/LOYgZED4TUWt1nK//pkkVfdteng=; b=VhjI5YjEi3qmyB4Y6THDGNDPBVv99mIB9SEbhzigiqBZmrV6Ty7D8wzT5Fm4crLY+j TDRbymCS8wkVXqEdqpzCU/JR5sdDpKwzw2SsptgAhMqgG8HvIIjKxgg+5SlMKWdF+Lt2 TVMoRuD/TSn0MdBpaw5HbgZF9fjN1YK4kObGCLBvblojflAM1qcvh1gVMRt9mw05eR3T RyDSf89EWo53VHCmrYOC1pVgfdEkAhKzMKeYqb5uwgYownehkxj0x5wpCfy/Y8HaVs45 1RVUDhCMiim/iQWc7RI4a59s93yDEYIgLyzTQYIKDe1+XEIKcxixXydqf+YFC2L9/OD6 HcMA== X-Gm-Message-State: AOAM533BiP7t0E9yM+FxbIvNhrsJCYm8MxDsGjhdJk3g/xi9qiWgniAN J4CtoOM/yfnp6e9G0JmoaDxFEVzWT2c= X-Google-Smtp-Source: ABdhPJyjyTPFBjNjNXDk2T5UWfbqQ04fyOlH20FQJsdMJ7DU5b1y4pcfxMtP6t5BkQT5oU3zdPp+yg== X-Received: by 2002:a17:906:4ec7:: with SMTP id i7mr4088416ejv.439.1602094852310; Wed, 07 Oct 2020 11:20:52 -0700 (PDT) Received: from Morphium (ip-84-118-73-55.unity-media.net. [84.118.73.55]) by smtp.gmail.com with ESMTPSA id qw1sm1576580ejb.44.2020.10.07.11.20.51 for <43654@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 11:20:51 -0700 (PDT) From: Malte Frank Gerdes To: 43654@debbugs.gnu.org Subject: Re: [bug#43654] [PATCH] Add perl-opengl Date: Wed, 07 Oct 2020 20:20:51 +0200 Message-ID: <86pn5t6gos.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Forgot to Cc the list... Andreas Enge writes: > On Fri, Oct 02, 2020 at 09:33:04PM +0200, Malte Frank Gerdes wrote: >> I just tried to build with those variables set to arbitrary values: >> >> --8 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Forgot to Cc the list... Andreas Enge writes: > On Fri, Oct 02, 2020 at 09:33:04PM +0200, Malte Frank Gerdes wrote: >> I just tried to build with those variables set to arbitrary values: >>=20 >> --8<---------------cut here---------------start------------->8--- >> GLUT=3D99999 >> VERSION=3D3.0 Mesa 99.99.99 >> VENDOR=3DNoVendor >> RENDERER=3DMesaRenderer >> --8<---------------cut here---------------end--------------->8--- > > Actually I just went further: > FREEGLUT=3D > GLUT=3D > VERSION=3D > VENDOR=3D > RENDERER=3D > EXTENSIONS=3D Nice! (I didn't even think of leaving them empty ...) > The package compiles, but running test.pl (which showed just a blank squa= re > before) now fails with this message: > Goto undefined subroutine &AutoLoader::AUTOLOAD at > /home/andreas/.guix-profile/lib/perl5/site_perl/5.30.2/x86_64-linux-threa= d-multi/OpenGL.pm > line 6178. > > However, I tried several of the examples, and they work. > > So one option would be to disable the test ("#:tests? #f") and create the > essentially empty glversion.txt file above inside a phase. There would not > even be a need to store it as a an auxiliary file; see the use of > "call-with-output-file" in guix/tests.scm, for instance. > > What do you think? > > Andreas > IMHO disabling the tests is the best solution then - it didn't /really/ test the libraries functionality it seems, because the examples do much more different things.=20 > Something like this: > (add-before 'configure 'glversion > ;; Building utils/glversion.txt fails, and is probably > ;; dependent on the graphics card in the build system. > ;; Replace it by a content-free file; while this breaks > ;; the test, the examples in the examples/ subdirectory > ;; can be run. > (lambda _ > (substitute* "Makefile.PL" > (("unlink") "# unlink") ; prevent utils/glversion.txt > ; from being deleted once... > (("\\.\"\\$make_ver clean\"") "")) ; ...and twice... > (substitute* "utils/Makefile" > (("all: glversion.txt") "all: ")) ; ...and thrice. > (call-with-output-file "utils/glversion.txt" > (lambda (port) > (display (string-append "FREEGLUT=3D\nGLUT=3D\nVERSION= =3D\n" > "VENDOR=3D\nRENDERER=3D\n" > "EXTENSIONS=3D\n") > port))) > #t)) >=20 > I tried to add the following instead of patching Makefile.PL: > (add-before 'configure 'fix-interface > ;; Libraries are not found in default locations, so force > ;; an interface. > (lambda _ > (substitute* "Makefile.PL" > (("die \"FreeGLUT or GLUT libraries") > "$interface_lib =3D 'FREEGLUT'; #")) > #t)) >=20 > But it fails during compilation with error messages such as this one: > /gnu/store/1qmd9achfkm1njzxf8hi86q53pmy9sxk-mesa-20.0.7/include/GL/glxext= .h:530:169: error: unknown type name =E2=80=98GLintptr=E2=80=99; did you me= an =E2=80=98GLint=E2=80=99? > From some search engine results, I surmise that I am missing the > $DEFS .=3D " -DGL_GLEXT_LEGACY"; > from line 525 of Makefile.PL. >=20 > So maybe we will have to replace the "-L/what/ever" as you do it in your > cdr/match phase; but instead of adding a patch that drops the "-L" in > favour of some "@@libpaths@@" text, only to replace the new text again > in a phase, I would use just a phase. For instance, instead of replacing > "^@@libdirs@@", just replace "-L/usr/local/freeglut/lib". Makes sense that it's pointless to replace the text twice. > On Tue, Oct 06, 2020 at 12:35:43AM +0200, Andreas Enge wrote: > > But it is already tomorrow, time to stop. >=20 > Did I mention that Guix is addictive? I feel you =F0=9F=98=82. It just makes fun to do things in Guix. > If you feel like it, you could replace "cdr" by "match", and maybe test > if all of the inputs are actually needed. After all it seems glu and mesa are not necessary as inputs because freeglut propagates them anyway. Is it ok to rely on propagated inputs? They still need to be added to the library search dir though. Attached is a updated version of your patch :) Malte > From 1fdc8885e04bdad9fee886c58dea9c8c712b5848 Mon Sep 17 00:00:00 2001 From: Andreas Enge Date: Tue, 6 Oct 2020 00:43:45 +0200 Subject: [PATCH] gnu: Add perl-opengl. * gnu/packages/perl.scm (perl-opengl): New variable. Co-authored-by: Malte Frank Gerdes --- gnu/packages/perl.scm | 64 +++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 62 insertions(+), 2 deletions(-) diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm index 1c3d999d79..9916c579e4 100644 --- a/gnu/packages/perl.scm +++ b/gnu/packages/perl.scm @@ -1,6 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Court=C3= =A8s -;;; Copyright =C2=A9 2013, 2019 Andreas Enge +;;; Copyright =C2=A9 2013, 2019, 2020 Andreas Enge ;;; Copyright =C2=A9 2015, 2016, 2017, 2019 Ricardo Wurmus ;;; Copyright =C2=A9 2015, 2016, 2017, 2019, 2020 Eric Bavier ;;; Copyright =C2=A9 2015 Eric Dvorsak @@ -27,6 +27,7 @@ ;;; Copyright =C2=A9 2020 Vincent Legoll ;;; Copyright =C2=A9 2020 Paul Garlick ;;; Copyright =C2=A9 2020 Nicolas Goaziou +;;; Copyright =C2=A9 2020 Malte Frank Gerdes ;;; ;;; This file is part of GNU Guix. ;;; @@ -74,7 +75,8 @@ #:use-module (gnu packages sdl) #:use-module (gnu packages textutils) #:use-module (gnu packages video) - #:use-module (gnu packages web)) + #:use-module (gnu packages web) + #:use-module (gnu packages xorg)) =20 ;;; ;;; Please: Try to add new module packages in alphabetic order. @@ -7870,6 +7872,64 @@ technology to store hierarchical information such as= links to other documents within a single file.") (license (package-license perl)))) =20 +(define-public perl-opengl + (package + (name "perl-opengl") + (version "0.70") + (source + (origin + (method url-fetch) + (uri (string-append + "mirror://cpan/authors/id/C/CH/CHM/OpenGL-" + version + ".tar.gz")) + (sha256 + (base32 + "1q3lz168q081iwl9jg21fbzhp9la79gav9mv6nmh2jab83s2l3mj")))) + (build-system perl-build-system) + (inputs `(("freeglut" ,freeglut) + ("libxi" ,libxi) + ("libxmu" ,libxmu))) + (arguments + '(#:tests? #f ; test.pl fails with our empty glversion.txt, while + ; the package still seems to work on the examples + #:phases + (modify-phases %standard-phases + (add-before 'configure 'glversion + ;; Building utils/glversion.txt fails, and is probably + ;; dependent on the graphics card in the build system. + ;; Replace it by a content-free file; while this breaks + ;; the tests, the examples in the examples/ subdirectory + ;; can be run. + (lambda _ + (substitute* "Makefile.PL" + (("unlink") "# unlink") ; prevent utils/glversion.txt + ; from being deleted once... + (("\\.\"\\$make_ver clean\"") "")) ; ...and twice... + (substitute* "utils/Makefile" + (("all: glversion.txt") "all: ")) ; ...and thrice. + (call-with-output-file "utils/glversion.txt" + (lambda (port) + (display (string-append "FREEGLUT=3D\nGLUT=3D\nVERSION=3D= \n" + "VENDOR=3D\nRENDERER=3D\n" + "EXTENSIONS=3D\n") + port))) + #t)) + (add-before 'configure 'fix-library-flags + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "Makefile.PL" + (("-L/usr/local/freeglut/lib") + (string-append "-L" (assoc-ref inputs "freeglut") "/lib\n" + "-L" (assoc-ref inputs "glu") "/lib\n" + "-L" (assoc-ref inputs "mesa") "/lib\n"))) + #t))))) + (home-page "https://metacpan.org/release/OpenGL") + (synopsis + "Perl bindings to the OpenGL API, GLU, and GLUT/FreeGLUT") + (description "The package provides Perl bindings to OpenGL, GLU +and FreeGLUT.") + (license (package-license perl)))) + (define-public perl-package-anon (package (name "perl-package-anon") --=20 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 10 09:09:15 2020 Received: (at 43654-done) by debbugs.gnu.org; 10 Oct 2020 13:09:15 +0000 Received: from localhost ([127.0.0.1]:37098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kREcd-0005eh-5N for submit@debbugs.gnu.org; Sat, 10 Oct 2020 09:09:15 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:38798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kREcb-0005eZ-Tb for 43654-done@debbugs.gnu.org; Sat, 10 Oct 2020 09:09:14 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 05A41112A; Sat, 10 Oct 2020 15:09:12 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U34PYgT0A2Tl; Sat, 10 Oct 2020 15:09:11 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::891]) by hera.aquilenet.fr (Postfix) with ESMTPSA id D7EFC1127; Sat, 10 Oct 2020 15:09:10 +0200 (CEST) Date: Sat, 10 Oct 2020 15:09:09 +0200 From: Andreas Enge To: Malte Frank Gerdes Subject: Re: [bug#43654] [PATCH] Add perl-opengl Message-ID: <20201010130909.GA14919@jurong> References: <86pn67xcmn.fsf@gmail.com> <86pn5t6gos.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86pn5t6gos.fsf@gmail.com> X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 43654-done Cc: 43654-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On Wed, Oct 07, 2020 at 08:20:51PM +0200, Malte Frank Gerdes wrote: > After all it seems glu and mesa are not necessary as inputs because > freeglut propagates them anyway. Is it ok to rely on propagated inputs? > They still need to be added to the library search dir though. That is weird, I did not realise they would be added to the "inputs" variable; I would have added them a second time to be sure they are available in the build recipe. Anyway, it is working, and I just pushed the patch. Thanks a lot! I will give slic3r another quick try then. Closing this bug. Andreas From unknown Tue Jun 24 17:27:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 08 Nov 2020 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator