From unknown Mon Jun 23 18:28:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43651 <43651@debbugs.gnu.org> To: bug#43651 <43651@debbugs.gnu.org> Subject: Status: 27.1; compile.el should not parse its own header for errors Reply-To: bug#43651 <43651@debbugs.gnu.org> Date: Tue, 24 Jun 2025 01:28:47 +0000 retitle 43651 27.1; compile.el should not parse its own header for errors reassign 43651 emacs submitter 43651 David Landell severity 43651 normal tag 43651 fixed confirmed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 27 12:38:05 2020 Received: (at submit) by debbugs.gnu.org; 27 Sep 2020 16:38:05 +0000 Received: from localhost ([127.0.0.1]:50299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMZga-0006Ul-1k for submit@debbugs.gnu.org; Sun, 27 Sep 2020 12:38:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:52116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMUBz-0007vu-9W for submit@debbugs.gnu.org; Sun, 27 Sep 2020 06:46:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMUBx-0000X8-Kp for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2020 06:46:07 -0400 Received: from aibo.runbox.com ([91.220.196.211]:60254) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMUBt-0005Bk-PS for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2020 06:46:05 -0400 Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kMUBj-0008Js-N4 for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2020 12:45:51 +0200 Received: by submission02.runbox with esmtpsa [Authenticated alias (666394)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kMUBR-0008Ps-6c for bug-gnu-emacs@gnu.org; Sun, 27 Sep 2020 12:45:33 +0200 From: David Landell To: bug-gnu-emacs@gnu.org Subject: 27.1; compile.el should not parse its own header for errors Date: Sun, 27 Sep 2020 12:45:24 +0200 Message-ID: <87blhrzeez.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=91.220.196.211; envelope-from=david.landell@sunnyhill.email; helo=aibo.runbox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/27 06:45:52 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 27 Sep 2020 12:38:02 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hi, I noticed that compilation-mode parses and successfully detect errors according to set regexp int the compilation buffer header, iow in text inserted by the mode itself. This is weird since there isn't any error there to visit. Reproduce: emacs -Q -l reproduce.el Expected output: No error fontification of header line: Compilation started at Sun Sep 27 11:48:24 Actual output: Error fontified line: Compilation started at Sun Sep 27 11:48:24 I noticed this in my own package rg.el which is similar to grep.el in that it reuses compilation mode and has similar regexps for parsing file name and line number that happens to match the "$CMD started at..." line. The attached test case somewhat emulates what happens in those packages. The command output is unrelated though. Looking at the code in compile.el, my impression is that this would be taken care of by compilation-filter but for some reason that doesn't happen. Best regards, David Landell --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=reproduce.el Content-Transfer-Encoding: quoted-printable Content-Description: reproduce (setq compilation-error-regexp-alist-alist (list (list 'custom-regexp "^\\(.+?\\):\\([1-9][0-9]*\\):" 1 2))) (setq compilation-error-regexp-alist (mapcar 'car compilation-error-regexp-= alist-alist)) (compilation-start "ls /tmp") --=-=-= Content-Type: text/plain In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2020-09-19 built on lgw01-amd64-054 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Linux Mint 19 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Compilation finished Making completion list... [2 times] Configured using: 'configure --build=x86_64-linux-gnu --prefix=/usr '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' --sysconfdir=/etc --localstatedir=/var --disable-silent-rules '--libdir=${prefix}/lib/x86_64-linux-gnu' '--libexecdir=${prefix}/lib/x86_64-linux-gnu' --disable-maintainer-mode --disable-dependency-tracking --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/27.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/share/emacs/site-lisp --program-suffix=27 --with-modules --with-file-notification=inotify --with-mailutils --with-harfbuzz --with-json --with-x=yes --with-x-toolkit=gtk3 --with-lcms2 --with-cairo --with-xpm=yes --with-gif=yes --with-gnutls=yes --with-jpeg=yes --with-png=yes --with-tiff=yes --with-xwidgets 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs27-YwD3ZV/emacs27-27.1~1.git86d8d76aa3=. -fstack-protector-strong -Wformat -Werror=format-security -no-pie' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro -no-pie'' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LC_MONETARY: sv_SE.UTF-8 value of $LC_NUMERIC: sv_SE.UTF-8 value of $LC_TIME: sv_SE.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils compile comint ansi-color ring tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting xwidget-internal cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 49811 10033) (symbols 48 6530 1) (strings 32 16934 2193) (string-bytes 1 560626) (vectors 16 10055) (vector-slots 8 133282 9060) (floats 8 23 180) (intervals 56 311 4) (buffers 1000 13)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 27 17:44:00 2020 Received: (at 43651) by debbugs.gnu.org; 27 Sep 2020 21:44:00 +0000 Received: from localhost ([127.0.0.1]:50601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMeSe-0007QI-EV for submit@debbugs.gnu.org; Sun, 27 Sep 2020 17:44:00 -0400 Received: from aibo.runbox.com ([91.220.196.211]:45752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMZyE-0006wi-IC for 43651@debbugs.gnu.org; Sun, 27 Sep 2020 12:56:18 -0400 Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kMZyC-0008JI-EI for 43651@debbugs.gnu.org; Sun, 27 Sep 2020 18:56:16 +0200 Received: by submission03.runbox with esmtpsa [Authenticated alias (666394)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kMZy7-0004n4-AF for 43651@debbugs.gnu.org; Sun, 27 Sep 2020 18:56:11 +0200 From: David Landell To: 43651@debbugs.gnu.org Subject: Re: bug#43651: Acknowledgement (27.1; compile.el should not parse its own header for errors) In-Reply-To: References: <87blhrzeez.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> Date: Sun, 27 Sep 2020 18:56:10 +0200 Message-ID: <877dsfyx91.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43651 X-Mailman-Approved-At: Sun, 27 Sep 2020 17:43:59 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Sorry, the test case regexp was not crafted for reproducibility so attaching a new that should be independent of the current time. --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=reproduce.el Content-Transfer-Encoding: quoted-printable Content-Description: reproduce (setq compilation-error-regexp-alist-alist (list (list 'custom-regexp "^\\(.+?\\):\\([0-9]+\\):" 1 2))) (setq compilation-error-regexp-alist (mapcar 'car compilation-error-regexp-= alist-alist)) (compilation-start "ls /tmp") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 28 09:44:38 2020 Received: (at control) by debbugs.gnu.org; 28 Sep 2020 13:44:38 +0000 Received: from localhost ([127.0.0.1]:51933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMtSI-0003ug-Fn for submit@debbugs.gnu.org; Mon, 28 Sep 2020 09:44:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMtSG-0003uK-Mw for control@debbugs.gnu.org; Mon, 28 Sep 2020 09:44:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mGQFwcYkxRAZXv4voeFRYG0Bxktv/ZrLbZJBO9vKm1A=; b=A0blPbRzCnm8H3iKwsuI3crV7+ 8cKzYhmnYiDxKo/ppPrvuUpxoJLno7yuPhwTY3tR8ZAfFFBnM7chdFiQbS23PfQvEB79DMGqNouMF DIpAZj5wa19rAHqiiM/9CUCWjLqAkOqKdEKQQ0a+rDEkVEdo391CH0Gg1FkeMQMsfT5Q=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMtS8-0007fU-79 for control@debbugs.gnu.org; Mon, 28 Sep 2020 15:44:30 +0200 Date: Mon, 28 Sep 2020 15:44:26 +0200 Message-Id: <87pn66uibp.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43651 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43651 + confirmed quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43651 + confirmed quit From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 28 09:46:40 2020 Received: (at 43651) by debbugs.gnu.org; 28 Sep 2020 13:46:40 +0000 Received: from localhost ([127.0.0.1]:51957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMtUF-0003zu-Td for submit@debbugs.gnu.org; Mon, 28 Sep 2020 09:46:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMtUE-0003zc-BC for 43651@debbugs.gnu.org; Mon, 28 Sep 2020 09:46:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MumrWGCnz39aJ7HsSw4GfzyfKUkdv8e8Gw4Z6G2jW6U=; b=satUhML+EMRW/0XOFWqEWjZe46 GZIWZNPUhlb1Td6UyTRNLpxPRw46V/SyfCCXDcnW0YyLSU+7Yxw5s12M2Ycpipz4suDJ6/8tzRwFJ K//viVHdez1+YIDS5qF/SuB2mrtIoqxsBQj+zSh0+710vmVb++PRsR3DJK4hSd6nfJ7k=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMtU6-0007g9-94; Mon, 28 Sep 2020 15:46:32 +0200 From: Lars Ingebrigtsen To: David Landell Subject: Re: bug#43651: 27.1; compile.el should not parse its own header for errors References: <87blhrzeez.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> X-Now-Playing: Neneh Cherry & The Thing's _The Cherry Thing_: "What Reason" Date: Mon, 28 Sep 2020 15:46:28 +0200 In-Reply-To: <87blhrzeez.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> (David Landell's message of "Sun, 27 Sep 2020 12:45:24 +0200") Message-ID: <87lfguui8b.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: David Landell writes: > Expected output: > No error fontification of header line: Compilation started at Sun Sep > 27 11:48:24 > > Actual output: > Error fontified line: Compilation started at Sun Sep 27 11:48:24 Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43651 Cc: 43651@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) David Landell writes: > Expected output: > No error fontification of header line: Compilation started at Sun Sep > 27 11:48:24 > > Actual output: > Error fontified line: Compilation started at Sun Sep 27 11:48:24 I can reproduce this in Emacs 28, too, and I'm not sure how to fix it. You'd think there'd be a way to tell the font-locking mechanism (which I assume is used here?) to stay away from certain regions of the buffer, but reading the documentation, I couldn't find anything. But there surely must be. Anybody know? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 28 10:40:58 2020 Received: (at 43651) by debbugs.gnu.org; 28 Sep 2020 14:40:59 +0000 Received: from localhost ([127.0.0.1]:53710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMuKo-0007sG-Iv for submit@debbugs.gnu.org; Mon, 28 Sep 2020 10:40:58 -0400 Received: from aibo.runbox.com ([91.220.196.211]:60212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMuKm-0007s4-TQ for 43651@debbugs.gnu.org; Mon, 28 Sep 2020 10:40:57 -0400 Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kMuKf-00087H-S5; Mon, 28 Sep 2020 16:40:49 +0200 Received: by submission01.runbox with esmtpsa [Authenticated alias (666394)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kMuKc-0008Dp-Ry; Mon, 28 Sep 2020 16:40:47 +0200 From: David Landell To: Lars Ingebrigtsen Subject: Re: bug#43651: 27.1; compile.el should not parse its own header for errors In-Reply-To: <87lfguui8b.fsf@gnus.org> References: <87blhrzeez.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> <87lfguui8b.fsf@gnus.org> Date: Mon, 28 Sep 2020 16:40:45 +0200 Message-ID: <874kniynf6.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43651 Cc: 43651@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hi, This is actually not restricted to font locking as demonstrated by the test case. My initial report was a bit unclear about that. It also affects settings like: (setq compilation-scroll-output 'first-error) where the jump is done to the header instead of first error. My impression from reading the code is that we would want to avoid running (compilation--parse-region) on the header to avoid problems like this. I am attaching a patch that superficially seems to fix these issues. I have a hard time judging if this fix has any bad side effects or similar though. I am definitely missing a bit of context how the related functions are invoked. In testing of my own package I have seen what seems to be multiple rounds of font locking that erase previous rounds, probably coming from buffer changes in my downstream filter-function. In that setup, the jump to first error has been a more stable way of reproducing. /David --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Don-t-parse-compilation-buffer-header-for-errors.patch >From 4f30436f99537925f4ec83ed759e3ae098f63d3c Mon Sep 17 00:00:00 2001 From: David Landell Date: Sun, 27 Sep 2020 16:52:44 +0200 Subject: [PATCH] Don't parse compilation buffer header for errors * lisp/progmodes/compile.el (compilation-header-size): New var. (compilation--ensure-parse): Init compilation--parsed with start of process output instead of (point-min). (compilation-start): Calculate header size. --- lisp/progmodes/compile.el | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index a408d16e37..4fd2ce88bc 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1573,7 +1573,7 @@ compilation--ensure-parse ;; grep.el) don't need to flush-parse when they modify the buffer ;; in a way that impacts buffer positions but does not require ;; re-parsing. - (setq compilation--parsed (point-min-marker))) + (setq compilation--parsed (copy-marker (+ (point-min) compilation-header-size)))) (when (< compilation--parsed limit) (let ((start (max compilation--parsed (point-min)))) (move-marker compilation--parsed limit) @@ -1710,6 +1710,9 @@ compilation--update-in-progress-mode-line ;; buffers when it changes from nil to non-nil or vice-versa. (unless compilation-in-progress (force-mode-line-update t))) +(defvar compilation-header-size 0 + "Size of the inserted compilation header.") + ;;;###autoload (defun compilation-start (command &optional mode name-function highlight-regexp) "Run compilation command COMMAND (low level interface). @@ -1810,14 +1813,16 @@ compilation-start (eq compilation-scroll-output 'first-error)) (set (make-local-variable 'compilation-auto-jump-to-next) t)) ;; Output a mode setter, for saving and later reloading this buffer. - (insert "-*- mode: " name-of-mode - "; default-directory: " - (prin1-to-string (abbreviate-file-name default-directory)) - " -*-\n" - (format "%s started at %s\n\n" - mode-name - (substring (current-time-string) 0 19)) - command "\n") + (let ((header (concat "-*- mode: " name-of-mode + "; default-directory: " + (prin1-to-string (abbreviate-file-name default-directory)) + " -*-\n" + (format "%s started at %s\n\n" + mode-name + (substring (current-time-string) 0 19)) + command "\n"))) + (insert header) + (setq compilation-header-size (length header))) (setq thisdir default-directory)) (set-buffer-modified-p nil)) ;; Pop up the compilation buffer. -- 2.17.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 29 10:02:13 2020 Received: (at 43651) by debbugs.gnu.org; 29 Sep 2020 14:02:13 +0000 Received: from localhost ([127.0.0.1]:56753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNGCq-0000SY-Pz for submit@debbugs.gnu.org; Tue, 29 Sep 2020 10:02:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNGCo-0000SJ-NH for 43651@debbugs.gnu.org; Tue, 29 Sep 2020 10:02:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=egVqQnx0R8/pSqlb2W9SfBM9q8RNBJOWm/13EGk7x+k=; b=OCho4tkNHRgIn6kVzKH/qQRbiu xtUwh/p+JrVyfmRu9jFSxW9Tz6v146Velsq0WoaEx6RfREzLoyLsrt7J8etz0HVyB7aIk6YChcxEh 5LKrlNz7o9jEeCvK3KEw/DW2a9wePyi5cTWibHKbkg8gVYxWUhUolC7pTOxw6/2HUmYs=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNGCb-0007YZ-LI; Tue, 29 Sep 2020 16:02:04 +0200 From: Lars Ingebrigtsen To: David Landell Subject: Re: bug#43651: 27.1; compile.el should not parse its own header for errors References: <87blhrzeez.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> <87lfguui8b.fsf@gnus.org> <874kniynf6.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> X-Now-Playing: 23 Skidoo's _Seven Songs_: "Kundalini" Date: Tue, 29 Sep 2020 16:01:56 +0200 In-Reply-To: <874kniynf6.fsf@xwing.i-did-not-set--mail-host-address--so-tickle-me> (David Landell's message of "Mon, 28 Sep 2020 16:40:45 +0200") Message-ID: <875z7wel63.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: David Landell writes: > I am attaching a patch that superficially seems to fix these issues. > I have a hard time judging if this fix has any bad side effects or > similar though. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43651 Cc: 43651@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) David Landell writes: > I am attaching a patch that superficially seems to fix these issues. > I have a hard time judging if this fix has any bad side effects or > similar though. Thanks for the analysis -- your patch was basically correct, I think, but a bit brittle. Instead of doing the marking with a variable, I've now made compile mark the end of the header with a text property, and that's then used to find the end of the header when pasing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 29 10:02:17 2020 Received: (at control) by debbugs.gnu.org; 29 Sep 2020 14:02:17 +0000 Received: from localhost ([127.0.0.1]:56756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNGCv-0000Sn-4w for submit@debbugs.gnu.org; Tue, 29 Sep 2020 10:02:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNGCt-0000SP-LO for control@debbugs.gnu.org; Tue, 29 Sep 2020 10:02:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=390ekD00LmIn/L9Yqo+sHy4fBAueqfm9MsEH/+XYmc8=; b=MFwuiAZi8Xw0o/Auo4Snk7tRSC Ox0FueNpgsQvsdg7lAXnnfuNt3ORwLjE470UpPGwj6y9xdVTMpN/kplHsoOxDW5158rGwsM6HTzFP LuKtl65NYnCQeUc+2f3iNpDfO+fy+Hi9iNJCLDTTZ8VQ6HKHiMyCvF+cACI0IMlsoQCs=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNGCl-0007Yk-Pg for control@debbugs.gnu.org; Tue, 29 Sep 2020 16:02:10 +0200 Date: Tue, 29 Sep 2020 16:02:06 +0200 Message-Id: <874kngel5t.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43651 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43651 fixed close 43651 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43651 fixed close 43651 28.1 quit From unknown Mon Jun 23 18:28:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 28 Oct 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator