GNU bug report logs - #43645
26.3; emacsclient -c does not open to correct window

Previous Next

Full log

Message #38 received at 43645 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, martin rudalics <rudalics <at> gmx.at>
Cc: bluetrack121 <at> gmail.com, 43645 <at> debbugs.gnu.org
Subject: Re: bug#43645: 26.3; emacsclient -c does not open to correct window
Date: Mon, 28 Sep 2020 16:43:20 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Mon, 28 Sep 2020 15:16:16 +0200
> Cc: 43645 <at> debbugs.gnu.org
> 
> This patch fixes the problem, but I'm hesitating to apply it even if it
> looks kinda-sorta "obviously correct": It changes the logic to only
> check whether the buffer is displayed in the current frame, which makes
> emacsclient -c work.  But why was the all-frame argument added?  It's
> been there since at least the 90s...
> 
> I can't see any adverse affects on emacsclient -t either.
> 
> Anybody with any insight here?
> 
> diff --git a/lisp/server.el b/lisp/server.el
> index 436a6ca0c7..f24f8d2b7c 100644
> --- a/lisp/server.el
> +++ b/lisp/server.el
> @@ -1602,7 +1602,7 @@ server-switch-buffer
>        ;; OK, we know next-buffer is live, let's display and select it.
>        (if (functionp server-window)
>  	  (funcall server-window next-buffer)
> -	(let ((win (get-buffer-window next-buffer 0)))
> +	(let ((win (get-buffer-window next-buffer)))
>  	  (if (and win (not server-window))
>  	      ;; The buffer is already displayed: just reuse the
>  	      ;; window.  If FILEPOS is non-nil, use it to replace the
> 

Martin, any comments on this?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.