Subject: Re: bug#43644: Double quote missing from exec-shell-cmd button command when run

From: Robert Weiner <[email-masked]>
Date: Sun, 22 Nov 2020 12:47:42 -0500

This has been resolved in the latest master git branch of Hyperbole and
will be integrated into the next release.

If you replace this function in "${hyperb:dir}/hpath.el" with this version,
reload and
then modify your global button, {C-h h g m}, so the shell command is
correct, and then re-activate the button it should work.

-- Bob

(defun hpath:trim (path)
  "Return PATH with any [\" \t\n\r] characters trimmed from its start and
end."
  ;; Trim only matching starting and ending quoted double quotes (must
  ;; be a single line string).
  (setq path (string-trim path))
  (when (string-match "\\`\".*\"\\'" path)
    (setq path (string-trim path "\"" "\"")))
  path)

On Sun, Sep 27, 2020 at 12:47 PM Robert Weiner <[email-masked]> wrote:

> Thanks for the report.  We will look into fixing this.
>
> > On Sep 27, 2020, at 5:43 AM, Natalie Jones <[email-masked]> wrote:
> >
> > I'm using hyperbole 7.1.3 on Emacs 26.1 on Debian buster.
> >
> > To reproduce
> >
> > 1. Create new personal button file
> >
> > 2. Create a new explicit button, action type: exec-shell-command, shell
> cmd: notify-send "test", select no for the rest of the questions
> >
> > 3. Activate the button
> >
> > What you see:
> >
> > notify-send "test
> >
> > What you should see:
> >
> > notify-send "test"
> >
> >
> > The second double quote is missing for some reason and the notification
> won't send.
> >
> >
> >
> >
> > _______________________________________________
> > Bug-hyperbole mailing list
> > [email-masked]
> > https://lists.gnu.org/mailman/listinfo/bug-hyperbole
>