Subject: Re: [bug#43635] [PATCH] gnu: Add emacs-sqlite.

From: Nicolas Goaziou <[email-masked]>
Date: Sun, 27 Sep 2020 14:31:57 +0200

Hello,

Adam Kandur via Guix-patches via <[email-masked]> writes:

> Subject: [PATCH] gnu: Add emacs-sqlite.
>
> * gnu/packages/emacs-xyz.scm (emacs-sqlite): New variable.

Thank you!

Some comments follow.

> +(define-public emacs-sqlite.el

The same should be emacs-sqlite.

> +  (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797")
> +	(revision "1"))

You need to provide a comment explaining why you're choosing a specific
commit instead of a tagged release (in this case, that's because there
is no tagged commit).

Also, mind the indentation. (revision ...) should be vertically aligned
with (commit ...)

> +    (package
> +      (name "emacs-sqlite.el")

See above.

> +      (build-system emacs-build-system)
> +      (version (git-version "0.0.0" revision commit))

The base version is "1.0" per keyword in the main Elisp file, not
"0.0.0".

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +	       (url "https://gitlab.com/cnngimenez/sqlite.el.git")

You can drop the ".git" suffix in the URL.

> +	       (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256 (base32 "06ln4vijl8kii3nzc5cscgsadx1fqgxksflijd3ain83bn8g4wrd"))))

(base32 ...) should be moved on the line below.

> +      (home-page "https://gitlab.com/cnngimenez/sqlite.el.git")

Likewise, please drop the ".git" suffix.

> +      (synopsis "SQLite Interface for EmasLisp")

There's a typo in EmacsLisp, which I suggest to write "Emacs Lisp".

> +      (description "This code was retrieved from the EmacsWiki at Dicember 26, 2013. At that point was two developers:
> +    @cnngimenez
> +    @KIDD (Raimon Grau)")

This description is not useful. I suggest to use the one from EmacsWiki,
quoted here:

  @code{sqlite.el} is a simple SqliteInterface for connecting and retrieving
  information using the SQLite program through Elisp programming.  It is
  not intended as a user interface.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou