Subject: bug#43635: closed (Re: [bug#43635] hope, this is right)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 01 Oct 2020 13:43:02 +0000

Your bug report

#43635: [PATCH] gnu: Add emacs-sqlite.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
43635: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43635
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#43635] hope, this is right
From: Nicolas Goaziou <[email-masked]>
To: Adam Kandur via Guix-patches via <[email-masked]>
Cc: [email-masked], Adam Kandur <[email-masked]>
Date: Thu, 01 Oct 2020 15:42:17 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Adam Kandur via Guix-patches via <[email-masked]> writes:

> Subject: [PATCH] gnu: Add emacs-sqlite.el

Thank you. I applied your patch with the changes detailed below.

> +  (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797") ;; there is no tagged commit
> +	(revision "0"))

I moved the comment on the line above since comments starting with two
semicolons are expected to stand by their own line.

> +    (package
> +      (name "emacs-sqlite.el")

I changed the name to "emacs-sqlite". Ditto for the name of the variable.

> +      (synopsis "SQLite Interface for Emas Lisp")

I fixed the type and changed case for "Interface".

> +      (description "@code{sqlite.el} is a simple SqliteInterface for connecting and retrieving
> +information using the SQLite program through Elisp programming.  It
> is  not intended as a user interface.")

I fixed spacing and renamed the package.

I also moved the package elsewhere, since adding a package at the end of
the file is more likely to cause merge conflicts.

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] gnu: Add emacs-sqlite.
From: Adam Kandur <[email-masked]>
To: Guix Patches <[email-masked]>
Date: Sat, 26 Sep 2020 22:36:58 +0200 (CEST)
List-Id: <debbugs-submit.debbugs.gnu.org>

>From 3b06aaabbee774c6dc7fef7b81a96c0ef72db46a Mon Sep 17 00:00:00 2001
From: Adam <[email-masked]>
Date: Sat, 26 Sep 2020 23:32:14 +0300
Subject: [PATCH] gnu: Add emacs-sqlite.

* gnu/packages/emacs-xyz.scm (emacs-sqlite): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cfef767..52744b1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24733,3 +24733,25 @@ web development.")
       ;; file and the header of the main elisp file which indicates
       ;; that it is licensed under the GPL version 3 or later.
       (license (list license:mpl2.0 license:gpl3+)))))
+
+(define-public emacs-sqlite.el
+  (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797")
+	(revision "1"))
+    (package
+      (name "emacs-sqlite.el")
+      (build-system emacs-build-system)
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+	       (url "https://gitlab.com/cnngimenez/sqlite.el.git")
+	       (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256 (base32 "06ln4vijl8kii3nzc5cscgsadx1fqgxksflijd3ain83bn8g4wrd"))))
+      (home-page "https://gitlab.com/cnngimenez/sqlite.el.git")
+      (synopsis "SQLite Interface for EmasLisp")
+      (description "This code was retrieved from the EmacsWiki at Dicember 26, 2013. At that point was two developers:
+    @cnngimenez
+    @KIDD (Raimon Grau)")
+      (license license:gpl3+))))
-- 
2.28.0