From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 26 16:37:06 2020 Received: (at submit) by debbugs.gnu.org; 26 Sep 2020 20:37:06 +0000 Received: from localhost ([127.0.0.1]:47815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMGwM-0008A7-7x for submit@debbugs.gnu.org; Sat, 26 Sep 2020 16:37:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:41416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMGwL-0008A0-0N for submit@debbugs.gnu.org; Sat, 26 Sep 2020 16:37:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMGwK-0000gV-P2 for guix-patches@gnu.org; Sat, 26 Sep 2020 16:37:04 -0400 Received: from w4.tutanota.de ([81.3.6.165]:42418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMGwI-0002N0-R9 for guix-patches@gnu.org; Sat, 26 Sep 2020 16:37:04 -0400 Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 89DC41060148 for ; Sat, 26 Sep 2020 20:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1601152618; s=s1; d=tuta.io; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:Sender; bh=25n9sIEhZ38ogRidvemVXk6TxQw8uBsSdt2telcMqwU=; b=ybIb3NWgXVp9GM3OhTwOm9gxjzuXin0M0hHDzbErVM9+wEUBg7ifgEQrbVz9eQnr ZtDcSZ+cQuNknhdEBTkCXxgs6k3JRupRKqYP7z8U/rbfF+5Qk3N2nsxSbtW+duqQ0uF jao5Ubt5t0t+LhhN/sh8sGSl2fDMy1CSvd7NHS8YMcPmFebzNINGoLGNc8SCMVwB/j2 pFwvHaN+nTsPIh8Zegrsk1YM6KT+sLCH1EdRKtqd5OzifZZpg9wjHx+dXgKweDApVGw YfMZpJCzIG0QkaVlIba1CUfG6xNuTQnVjuDsHuVghCUdyEKzGnpY8jMGuZK19nylWn0 VM9Nwek/jg== Date: Sat, 26 Sep 2020 22:36:58 +0200 (CEST) From: Adam Kandur To: Guix Patches Message-ID: Subject: [PATCH] gnu: Add emacs-sqlite. MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_47796_1615934309.1601152618549" Received-SPF: pass client-ip=81.3.6.165; envelope-from=rndd@tuta.io; helo=w4.tutanota.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/26 16:36:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) ------=_Part_47796_1615934309.1601152618549 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ------=_Part_47796_1615934309.1601152618549 Content-Type: text/x-patch; charset=us-ascii; name=0001-gnu-Add-emacs-sqlite.patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-Add-emacs-sqlite.patch >From 3b06aaabbee774c6dc7fef7b81a96c0ef72db46a Mon Sep 17 00:00:00 2001 From: Adam Date: Sat, 26 Sep 2020 23:32:14 +0300 Subject: [PATCH] gnu: Add emacs-sqlite. * gnu/packages/emacs-xyz.scm (emacs-sqlite): New variable. --- gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index cfef767..52744b1 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -24733,3 +24733,25 @@ web development.") ;; file and the header of the main elisp file which indicates ;; that it is licensed under the GPL version 3 or later. (license (list license:mpl2.0 license:gpl3+))))) + +(define-public emacs-sqlite.el + (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797") + (revision "1")) + (package + (name "emacs-sqlite.el") + (build-system emacs-build-system) + (version (git-version "0.0.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.com/cnngimenez/sqlite.el.git") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 (base32 "06ln4vijl8kii3nzc5cscgsadx1fqgxksflijd3ain83bn8g4wrd")))) + (home-page "https://gitlab.com/cnngimenez/sqlite.el.git") + (synopsis "SQLite Interface for EmasLisp") + (description "This code was retrieved from the EmacsWiki at Dicember 26, 2013. At that point was two developers: + @cnngimenez + @KIDD (Raimon Grau)") + (license license:gpl3+)))) -- 2.28.0 ------=_Part_47796_1615934309.1601152618549-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 27 08:32:14 2020 Received: (at submit) by debbugs.gnu.org; 27 Sep 2020 12:32:14 +0000 Received: from localhost ([127.0.0.1]:48585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMVqg-0004FF-49 for submit@debbugs.gnu.org; Sun, 27 Sep 2020 08:32:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:58418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMVqf-0004F6-CJ for submit@debbugs.gnu.org; Sun, 27 Sep 2020 08:32:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMVqe-0007J2-Lu for guix-patches@gnu.org; Sun, 27 Sep 2020 08:32:13 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:40163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMVqc-0008Av-7l for guix-patches@gnu.org; Sun, 27 Sep 2020 08:32:12 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id D6D67200002; Sun, 27 Sep 2020 12:32:05 +0000 (UTC) From: Nicolas Goaziou To: Adam Kandur via Guix-patches via Subject: Re: [bug#43635] [PATCH] gnu: Add emacs-sqlite. References: Date: Sun, 27 Sep 2020 14:31:57 +0200 In-Reply-To: (Adam Kandur via Guix-patches via's message of "Sat, 26 Sep 2020 22:36:58 +0200 (CEST)") Message-ID: <87o8lr4czm.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.232; envelope-from=mail@nicolasgoaziou.fr; helo=relay12.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/27 06:35:51 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit Cc: 43635@debbugs.gnu.org, Adam Kandur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Hello, Adam Kandur via Guix-patches via writes: > Subject: [PATCH] gnu: Add emacs-sqlite. > > * gnu/packages/emacs-xyz.scm (emacs-sqlite): New variable. Thank you! Some comments follow. > +(define-public emacs-sqlite.el The same should be emacs-sqlite. > + (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797") > + (revision "1")) You need to provide a comment explaining why you're choosing a specific commit instead of a tagged release (in this case, that's because there is no tagged commit). Also, mind the indentation. (revision ...) should be vertically aligned with (commit ...) > + (package > + (name "emacs-sqlite.el") See above. > + (build-system emacs-build-system) > + (version (git-version "0.0.0" revision commit)) The base version is "1.0" per keyword in the main Elisp file, not "0.0.0". > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.com/cnngimenez/sqlite.el.git") You can drop the ".git" suffix in the URL. > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 (base32 "06ln4vijl8kii3nzc5cscgsadx1fqgxksflijd3ain83bn8g4wrd")))) (base32 ...) should be moved on the line below. > + (home-page "https://gitlab.com/cnngimenez/sqlite.el.git") Likewise, please drop the ".git" suffix. > + (synopsis "SQLite Interface for EmasLisp") There's a typo in EmacsLisp, which I suggest to write "Emacs Lisp". > + (description "This code was retrieved from the EmacsWiki at Dicember 26, 2013. At that point was two developers: > + @cnngimenez > + @KIDD (Raimon Grau)") This description is not useful. I suggest to use the one from EmacsWiki, quoted here: @code{sqlite.el} is a simple SqliteInterface for connecting and retrieving information using the SQLite program through Elisp programming. It is not intended as a user interface. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 27 09:18:31 2020 Received: (at 43635) by debbugs.gnu.org; 27 Sep 2020 13:18:31 +0000 Received: from localhost ([127.0.0.1]:48689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMWZS-0003OV-OB for submit@debbugs.gnu.org; Sun, 27 Sep 2020 09:18:31 -0400 Received: from w4.tutanota.de ([81.3.6.165]:54602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMWZQ-0003OH-GG for 43635@debbugs.gnu.org; Sun, 27 Sep 2020 09:18:29 -0400 Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 9891D106026C for <43635@debbugs.gnu.org>; Sun, 27 Sep 2020 13:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1601212702; s=s1; d=tuta.io; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:Sender; bh=X2Gyinum5xp21mBP7cL4rz+7O27NxYyXApzx4aCb82Y=; b=ENCcWVkcrnMm2FWJQzLcjYLtwWqgmG/pI1pie2aWrdAzOOBVWzSW+xwquKvsLMpb eL2+t84OpxDFiYLgSwS3Tsai17rbi6BI1UCi5Ey+pFYxe1AXtbMLLhVEwj7yPH+u4mf cur+pc17WFvNPadQL1CSv0VbBql+P0ewLGmPSaL66VwGPism5KUl87M2avhB9bAmcs4 u7plHGdW6JuVdFFNoIecNuHOAlEvL82OZ0jG13gMTdz9r6cgT7D15kLEpzxRlz0qDaT fymcKtGmJpTJrDbLZJl8LyjtIfThCa52B27mjnZnWVNa0ijT03gMvwsoyq0B/2OcCMG zoXm0oD+tA== Date: Sun, 27 Sep 2020 15:18:22 +0200 (CEST) From: Adam Kandur To: 43635@debbugs.gnu.org Message-ID: Subject: hope, this is right MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_64203_399687922.1601212702609" X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 43635 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) ------=_Part_64203_399687922.1601212702609 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ------=_Part_64203_399687922.1601212702609 Content-Type: text/x-patch; charset=us-ascii; name=0001-gnu-Add-emacs-sqlite.el.patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-Add-emacs-sqlite.el.patch >From 9ebce09ce3fd6d502598fc00c0456943897b8ba9 Mon Sep 17 00:00:00 2001 From: Adam Date: Sun, 27 Sep 2020 16:16:11 +0300 Subject: [PATCH] gnu: Add emacs-sqlite.el * gnu/packages/emacs-xyz.scm (emacs-sqlite.el): New variable. --- gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 4ea5be4..9e91f6f 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -24755,3 +24755,25 @@ web development.") ;; file and the header of the main elisp file which indicates ;; that it is licensed under the GPL version 3 or later. (license (list license:mpl2.0 license:gpl3+))))) + +(define-public emacs-sqlite.el + (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797") ;; there is no tagged commit + (revision "0")) + (package + (name "emacs-sqlite.el") + (build-system emacs-build-system) + (version (git-version "1.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.com/cnngimenez/sqlite.el") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "06ln4vijl8kii3nzc5cscgsadx1fqgxksflijd3ain83bn8g4wrd")))) + (home-page "https://gitlab.com/cnngimenez/sqlite.el") + (synopsis "SQLite Interface for Emas Lisp") + (description "@code{sqlite.el} is a simple SqliteInterface for connecting and retrieving +information using the SQLite program through Elisp programming. It is not intended as a user interface.") + (license license:gpl3+)))) -- 2.28.0 ------=_Part_64203_399687922.1601212702609-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 01 09:42:39 2020 Received: (at submit) by debbugs.gnu.org; 1 Oct 2020 13:42:39 +0000 Received: from localhost ([127.0.0.1]:34860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNyr1-0001iC-0Z for submit@debbugs.gnu.org; Thu, 01 Oct 2020 09:42:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:49342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNyqy-0001hx-Bn for submit@debbugs.gnu.org; Thu, 01 Oct 2020 09:42:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNyqy-0000TH-2f for guix-patches@gnu.org; Thu, 01 Oct 2020 09:42:36 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:59119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNyqv-00027w-Og for guix-patches@gnu.org; Thu, 01 Oct 2020 09:42:35 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 2A787E0009; Thu, 1 Oct 2020 13:42:27 +0000 (UTC) From: Nicolas Goaziou To: Adam Kandur via Guix-patches via Subject: Re: [bug#43635] hope, this is right References: Date: Thu, 01 Oct 2020 15:42:17 +0200 In-Reply-To: (Adam Kandur via Guix-patches via's message of "Sun, 27 Sep 2020 15:18:22 +0200 (CEST)") Message-ID: <87d02212rq.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.196; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/01 09:42:29 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 43635-done@debbugs.gnu.org, Adam Kandur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Adam Kandur via Guix-patches via writes: > Subject: [PATCH] gnu: Add emacs-sqlite.el Thank you. I applied your patch with the changes detailed below. > + (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797") ;; there is no tagged commit > + (revision "0")) I moved the comment on the line above since comments starting with two semicolons are expected to stand by their own line. > + (package > + (name "emacs-sqlite.el") I changed the name to "emacs-sqlite". Ditto for the name of the variable. > + (synopsis "SQLite Interface for Emas Lisp") I fixed the type and changed case for "Interface". > + (description "@code{sqlite.el} is a simple SqliteInterface for connecting and retrieving > +information using the SQLite program through Elisp programming. It > is not intended as a user interface.") I fixed spacing and renamed the package. I also moved the package elsewhere, since adding a package at the end of the file is more likely to cause merge conflicts. Regards, -- Nicolas Goaziou From unknown Mon Jun 23 18:30:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 30 Oct 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator