GNU bug report logs - #4362
23.1: proced -- Mode help lists 'd' as mark command (prefer 'm')

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> jurta.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 4362 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm')
Date: Fri, 11 Sep 2009 04:17:04 +0300

>> But now `C-h m' displays:
>>
>> m		proced-mark
>> d		proced-mark-alt
>>
>> that causes a false impression that these commands are different.
>
> Perhaps C-h m should merge aliases like where-is seems to do.
>
>> A simpler fix would be just changing the order of `d' and `m' bindings
>> in `proced-mode-map' like:
>
> I just copied the undo/advertised-undo approach. Please feel free to
> change this as you see fit.

Using the `:advertised-binding' property just implemented by Stefan is
a nice solution.  But other changes in `where-is-internal' broke preferred
key bindings in docstrings.  For example, compare the old and new
output of `C-h f Info-mode RET':

- h	Invoke the Info tutorial.
+ M-x Info-help	Invoke the Info tutorial.

- u	Move "up" from this node.
+ ^	Move "up" from this node.

- t	Go to the Top node of this file.
+ <	Go to the Top node of this file.

- b	Go to beginning of node.
+ .	Go to beginning of node.

- w	Put name of current Info node in the kill ring.
+ c	Put name of current Info node in the kill ring.

Should we put `:advertised-binding' for all old preferred key bindings
explicitly?

-- 
Juri Linkov
http://www.jurta.org/emacs/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.