From jari.aalto@cante.net Sun Sep 6 10:28:16 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 6 Sep 2009 17:28:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.8 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from emh07.mail.saunalahti.fi (emh07.mail.saunalahti.fi [62.142.5.117]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n86HSFE4020272 for ; Sun, 6 Sep 2009 10:28:16 -0700 Received: from saunalahti-vams (vs3-11.mail.saunalahti.fi [62.142.5.95]) by emh07-2.mail.saunalahti.fi (Postfix) with SMTP id 8D89518D2CD for ; Sun, 6 Sep 2009 20:28:13 +0300 (EEST) Received: from emh05.mail.saunalahti.fi ([62.142.5.111]) by vs3-11.mail.saunalahti.fi ([62.142.5.95]) with SMTP (gateway) id A02A5A8AA2B; Sun, 06 Sep 2009 20:28:13 +0300 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh05.mail.saunalahti.fi (Postfix) with ESMTP id 7FBDC27D83 for ; Sun, 6 Sep 2009 20:28:12 +0300 (EEST) Received: from [192.168.1.7] (helo=jondo.cante.net) by picasso.cante.net with esmtp (Exim 4.69) (envelope-from ) id 1MkLX8-00029x-4U for submit@emacsbugs.donarmstrong.com; Sun, 06 Sep 2009 20:28:10 +0300 Received: from jaalto by jondo.cante.net with local (Exim 4.69) (envelope-from ) id 1MkLX9-0007mU-Kg for submit@emacsbugs.donarmstrong.com; Sun, 06 Sep 2009 20:28:11 +0300 From: Jari Aalto To: Emacs bug BTS Subject: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') Date: Sun, 06 Sep 2009 20:28:11 +0300 Message-ID: <87bplonftg.fsf@jondo.cante.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SA-Exim-Connect-IP: 192.168.1.7 X-SA-Exim-Mail-From: jari.aalto@cante.net X-SA-Exim-Scanned: No (on picasso.cante.net); SAEximRunCond expanded to false X-Antivirus: VAMS M-x proced C-h m Proced: user by -PU mode: Mode for displaying UNIX system processes and sending signals to them. Type M-x proced to start a Proced session. In a Proced buffer >> type d to mark a process for later commands. Type x to send signals to marked processes. SUGGESITON PLease prefer listing the 'm' as the mark command in the mode help listing. 'd' and 'm' both seem to mark lines, but for mode help, listing the 'm' would better follow the convention used in other buffers like buffer list, dired etc. From rgm@gnu.org Sun Sep 6 19:36:00 2009 Received: (at 4362-done) by emacsbugs.donarmstrong.com; 7 Sep 2009 02:36:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.7 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n872ZxHo023492 for <4362-done@emacsbugs.donarmstrong.com>; Sun, 6 Sep 2009 19:36:00 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MkU5G-00042H-AJ; Sun, 06 Sep 2009 22:35:58 -0400 From: Glenn Morris To: 4362-done@debbugs.gnu.org Subject: Re: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') References: <87bplonftg.fsf@jondo.cante.net> X-Spook: Consul pink noise NORAD Afghanistan weapons of mass X-Ran: )Rcv/EvFkA33x.^zQb?g!edv&5|W0AAVj(rW}kI4|fqq$pP7aE/I:oy3Nq8Bw`[d7p'RP% X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sun, 06 Sep 2009 22:35:58 -0400 In-Reply-To: <87bplonftg.fsf@jondo.cante.net> (Jari Aalto's message of "Sun, 06 Sep 2009 20:28:11 +0300") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii * proced.el (proced-mode-map): Bind "d" to proced-mark-alt. (proced-mark-alt): New alias, to control the advertised key. (Bug#4362) From juri@jurta.org Tue Sep 8 20:14:19 2009 Received: (at 4362) by emacsbugs.donarmstrong.com; 9 Sep 2009 03:14:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n893EHRf016756 for <4362@emacsbugs.donarmstrong.com>; Tue, 8 Sep 2009 20:14:19 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.28.177.cable.starman.ee [82.131.28.177]) by mx2.starman.ee (Postfix) with ESMTP id 1572F3F4296; Wed, 9 Sep 2009 06:14:11 +0300 (EEST) From: Juri Linkov To: 4362@debbugs.gnu.org Cc: Glenn Morris , Jari Aalto Subject: Re: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') Organization: JURTA References: <87bplonftg.fsf@jondo.cante.net> Date: Wed, 09 Sep 2009 03:57:38 +0300 In-Reply-To: (Emacs bug Tracking System's message of "Mon, 07 Sep 2009 02:45:04 +0000") Message-ID: <87iqfs25rp.fsf_-_@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > M-x proced > C-h m > Proced: user by -PU mode: > Mode for displaying UNIX system processes and sending signals to them. > Type M-x proced to start a Proced session. In a Proced buffer >>> type d to mark a process for later commands. > Type x to send signals to marked processes. > > SUGGESITON > > PLease prefer listing the 'm' as the mark command in the mode help > listing. 'd' and 'm' both seem to mark lines, but for mode help, listing > the 'm' would better follow the convention used in other buffers like buffer > list, dired etc. > > From: Glenn Morris > To: 4362-done@emacsbugs.donarmstrong.com > Date: Sun, 06 Sep 2009 22:35:58 -0400 > > * proced.el (proced-mode-map): Bind "d" to proced-mark-alt. > (proced-mark-alt): New alias, to control the advertised key. (Bug#4362) But now `C-h m' displays: m proced-mark d proced-mark-alt that causes a false impression that these commands are different. A simpler fix would be just changing the order of `d' and `m' bindings in `proced-mode-map' like: @@ -459,8 +459,8 @@ (define-key km [down] 'next-line) (define-key km [up] 'previous-line) ;; marking - (define-key km "d" 'proced-mark) ; Dired compatibility ("delete") (define-key km "m" 'proced-mark) + (define-key km "d" 'proced-mark) ; Dired compatibility ("delete") (define-key km "u" 'proced-unmark) (define-key km "\177" 'proced-unmark-backward) (define-key km "M" 'proced-mark-all) But really I don't understand why `m' should be preferred to `d'? In Proced like in Dired, `d' flags a process for deletion, and `x' commits the operation. `m' is an alias for `d' because currently there is no more dired-like operations on processes. The only reason to prefer `m' over `d' in the documentation now is the fact that proced-mark marks a process with the "*" character (like dired's `m' does) instead of "D" (like dired's "d" does) until someone comes with an idea of different operations for `m' and `d' in Proced like in Buffer-menu where they are bound to different commands: m -- mark current line's buffer to be displayed. d -- mark that buffer to be deleted, and move down. x -- delete or save marked buffers. -- Juri Linkov http://www.jurta.org/emacs/ From juri@jurta.org Wed Sep 9 18:57:22 2009 Received: (at 4362) by emacsbugs.donarmstrong.com; 10 Sep 2009 01:57:22 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8A1vKgI029075 for <4362@emacsbugs.donarmstrong.com>; Wed, 9 Sep 2009 18:57:21 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.30.70.cable.starman.ee [82.131.30.70]) by mx1.starman.ee (Postfix) with ESMTP id A3EB03F4368; Thu, 10 Sep 2009 04:57:14 +0300 (EEST) From: Juri Linkov To: 4362@debbugs.gnu.org Cc: Jari Aalto Subject: Re: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') Organization: JURTA References: <87bplonftg.fsf@jondo.cante.net> <87iqfs25rp.fsf_-_@mail.jurta.org> Date: Thu, 10 Sep 2009 04:16:05 +0300 In-Reply-To: <87iqfs25rp.fsf_-_@mail.jurta.org> (Juri Linkov's message of "Wed, 09 Sep 2009 03:57:38 +0300") Message-ID: <873a6vtwmp.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > @@ -459,8 +459,8 @@ > (define-key km [down] 'next-line) > (define-key km [up] 'previous-line) > ;; marking > - (define-key km "d" 'proced-mark) ; Dired compatibility ("delete") > (define-key km "m" 'proced-mark) > + (define-key km "d" 'proced-mark) ; Dired compatibility ("delete") > (define-key km "u" 'proced-unmark) > (define-key km "\177" 'proced-unmark-backward) > (define-key km "M" 'proced-mark-all) Hmm, the trick with changing the order of key bindings doesn't work in `Buffer-menu-mode-map'. It would be more preferable to mention "d" instead of "k" as the key to mark that buffer to be deleted in the *Buffer List*, but changing the order of (define-key map "d" 'Buffer-menu-delete) (define-key map "k" 'Buffer-menu-delete) has no effect of the output of `C-h m' in the *Buffer List*. -- Juri Linkov http://www.jurta.org/emacs/ From rgm@gnu.org Wed Sep 9 23:27:52 2009 Received: (at 4362) by emacsbugs.donarmstrong.com; 10 Sep 2009 06:27:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.7 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8A6RoFQ003903 for <4362@emacsbugs.donarmstrong.com>; Wed, 9 Sep 2009 23:27:52 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Mld8H-0007za-C0; Thu, 10 Sep 2009 02:27:49 -0400 From: Glenn Morris To: Juri Linkov Cc: 4362@debbugs.gnu.org, Jari Aalto Subject: Re: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') References: <87bplonftg.fsf@jondo.cante.net> <87iqfs25rp.fsf_-_@mail.jurta.org> X-Spook: North Korea defense information warfare offensive X-Ran: 4d@4;:^;nTvYjM}69qU68&YgVwHg/S(@bx8*^GPaMU,)RHEyzA$bZz;28]&^C2pn!~[fmA X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 10 Sep 2009 02:27:49 -0400 Message-ID: <15r5ufxqje.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Juri Linkov wrote: > But now `C-h m' displays: > > m proced-mark > d proced-mark-alt > > that causes a false impression that these commands are different. Perhaps C-h m should merge aliases like where-is seems to do. > A simpler fix would be just changing the order of `d' and `m' bindings > in `proced-mode-map' like: I just copied the undo/advertised-undo approach. Please feel free to change this as you see fit. From juri@jurta.org Thu Sep 10 19:30:24 2009 Received: (at 4362) by emacsbugs.donarmstrong.com; 11 Sep 2009 02:30:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8B2UMBW024866 for <4362@emacsbugs.donarmstrong.com>; Thu, 10 Sep 2009 19:30:24 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.28.110.cable.starman.ee [82.131.28.110]) by mx2.starman.ee (Postfix) with ESMTP id 823AD3F4193; Fri, 11 Sep 2009 05:30:15 +0300 (EEST) From: Juri Linkov To: Glenn Morris Cc: 4362@debbugs.gnu.org, Stefan Monnier Subject: Re: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') Organization: JURTA References: <87bplonftg.fsf@jondo.cante.net> <87iqfs25rp.fsf_-_@mail.jurta.org> <15r5ufxqje.fsf@fencepost.gnu.org> Date: Fri, 11 Sep 2009 04:17:04 +0300 In-Reply-To: <15r5ufxqje.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu, 10 Sep 2009 02:27:49 -0400") Message-ID: <873a6ukyw3.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> But now `C-h m' displays: >> >> m proced-mark >> d proced-mark-alt >> >> that causes a false impression that these commands are different. > > Perhaps C-h m should merge aliases like where-is seems to do. > >> A simpler fix would be just changing the order of `d' and `m' bindings >> in `proced-mode-map' like: > > I just copied the undo/advertised-undo approach. Please feel free to > change this as you see fit. Using the `:advertised-binding' property just implemented by Stefan is a nice solution. But other changes in `where-is-internal' broke preferred key bindings in docstrings. For example, compare the old and new output of `C-h f Info-mode RET': - h Invoke the Info tutorial. + M-x Info-help Invoke the Info tutorial. - u Move "up" from this node. + ^ Move "up" from this node. - t Go to the Top node of this file. + < Go to the Top node of this file. - b Go to beginning of node. + . Go to beginning of node. - w Put name of current Info node in the kill ring. + c Put name of current Info node in the kill ring. Should we put `:advertised-binding' for all old preferred key bindings explicitly? -- Juri Linkov http://www.jurta.org/emacs/ From monnier@iro.umontreal.ca Thu Sep 10 22:13:38 2009 Received: (at 4362) by emacsbugs.donarmstrong.com; 11 Sep 2009 05:13:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.pppoe.ca [206.248.154.183] (may be forged)) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8B5DavM023685 for <4362@emacsbugs.donarmstrong.com>; Thu, 10 Sep 2009 22:13:38 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEADx5qUpFpZBe/2dsb2JhbACBU9t3hBgFh3E X-IronPort-AV: E=Sophos;i="4.44,368,1249272000"; d="scan'208";a="45552872" Received: from 69-165-144-94.dsl.teksavvy.com (HELO ceviche.home) ([69.165.144.94]) by ironport2-out.pppoe.ca with ESMTP; 11 Sep 2009 01:11:59 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 6E4D87043F; Fri, 11 Sep 2009 01:13:30 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: Glenn Morris , 4362@debbugs.gnu.org Subject: Re: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') Message-ID: References: <87bplonftg.fsf@jondo.cante.net> <87iqfs25rp.fsf_-_@mail.jurta.org> <15r5ufxqje.fsf@fencepost.gnu.org> <873a6ukyw3.fsf@mail.jurta.org> Date: Fri, 11 Sep 2009 01:13:30 -0400 In-Reply-To: <873a6ukyw3.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 11 Sep 2009 04:17:04 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Using the `:advertised-binding' property just implemented by Stefan is > a nice solution. But other changes in `where-is-internal' broke preferred > key bindings in docstrings. For example, compare the old and new > output of `C-h f Info-mode RET': > - h Invoke the Info tutorial. > + M-x Info-help Invoke the Info tutorial. I just fixed this one. It was a plain bug. > - u Move "up" from this node. > + ^ Move "up" from this node. > - t Go to the Top node of this file. > + < Go to the Top node of this file. > - b Go to beginning of node. > + . Go to beginning of node. > - w Put name of current Info node in the kill ring. > + c Put name of current Info node in the kill ring. These are trickier. I still haven't figured out why the preference order has changed. Admittedly, this order was arbitrary (doesn't even depend on the order of calls to define-key since these bindings are stored in the vector part of a dense map) and is also arbitrary in the new code, but it would be better to preserve the old order. > Should we put `:advertised-binding' for all old preferred key bindings > explicitly? Arguably, it would be good, yes. But first, I'll try to adjust the code to get back the original behavior. Thanks for bringing it up. Stefan From monnier@iro.umontreal.ca Fri Sep 11 11:56:26 2009 Received: (at 4362-done) by emacsbugs.donarmstrong.com; 11 Sep 2009 18:56:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from tomts5-srv.bellnexxia.net (tomts5-srv.bellnexxia.net [209.226.175.25]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8BIuNGk005355 for <4362-done@emacsbugs.donarmstrong.com>; Fri, 11 Sep 2009 11:56:26 -0700 Received: from toip6.srvr.bell.ca ([209.226.175.125]) by tomts5-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20090911185623.PAKL7787.tomts5-srv.bellnexxia.net@toip6.srvr.bell.ca> for <4362-done@emacsbugs.donarmstrong.com>; Fri, 11 Sep 2009 14:56:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgwFAD84qkpGN458/2dsb2JhbACBU9wWhBgF Received: from bas1-montreal42-1178046076.dsl.bell.ca (HELO ceviche.home) ([70.55.142.124]) by toip6.srvr.bell.ca with ESMTP; 11 Sep 2009 14:48:51 -0400 Received: by ceviche.home (Postfix, from userid 20848) id D0138B40D4; Fri, 11 Sep 2009 14:56:21 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: Glenn Morris Subject: Re: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') Message-ID: References: <87bplonftg.fsf@jondo.cante.net> <87iqfs25rp.fsf_-_@mail.jurta.org> <15r5ufxqje.fsf@fencepost.gnu.org> <873a6ukyw3.fsf@mail.jurta.org> Date: Fri, 11 Sep 2009 14:56:21 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 11 Sep 2009 01:13:30 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> - u Move "up" from this node. >> + ^ Move "up" from this node. >> - t Go to the Top node of this file. >> + < Go to the Top node of this file. >> - b Go to beginning of node. >> + . Go to beginning of node. >> - w Put name of current Info node in the kill ring. >> + c Put name of current Info node in the kill ring. > These are trickier. I still haven't figured out why the preference > order has changed. Admittedly, this order was arbitrary (doesn't even > depend on the order of calls to define-key since these bindings are > stored in the vector part of a dense map) and is also arbitrary in the > new code, but it would be better to preserve the old order. Actually, having investigated it some more, I see that the source of the discrepency is that the new code unifies different paths which previously traversed the keymaps in different orders. I.e. in Emacs-23, the where-is-internal code traversed the keymaps slightly differently depending on whether or not the cache was used. So, in the above example, C-h m (which calls where-is-internal in a way that doesn't use the cache) returned "u" for Info-up, but the menu-bar entry for "Info => Up" listed "^" as the corresponding keybinding. This explains why I didn't notice this difference: I mostly tested my code by comparing the bindings listed in the menus. >> Should we put `:advertised-binding' for all old preferred key bindings >> explicitly? > Arguably, it would be good, yes. But first, I'll try to adjust the code > to get back the original behavior. Thanks for bringing it up. So in the end I don't think the original behavior (i.e. inconsistent between very slightly different situations) is desirable. If people really prefer "u" over "^", then they'll have to add an :advertised-binding to it. I personally do care either way. Stefan PS: Note that the advantage of the :advertised-binding feature over the use of "advertised-foo" aliases is that it doesn't suffer from as many drawbacks, so it can be used more liberally. The main drawback was of course that (where-is 'undo) listed a whole bunch of bindings, but ironically not the "advertised" one. PPS: As for the actual proced-mark binding, I've just added a :advertised-binding, which should fix this bug. From unknown Sat Jun 21 10:24:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 10 Oct 2009 14:24:12 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator