GNU bug report logs - #4359
23.1.50; ^G in M-x grep mode with git grep

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Dan Nicolaescu <dann <at> gnu.org>
Cc: 15775 <at> debbugs.gnu.org, Jan Djärv <jan.h.d <at> swipnet.se>, schwab <at> linux-m68k.org, Ulrich Neumerkel <ulrich <at> complang.tuwien.ac.at>, 4359 <at> debbugs.gnu.org
Subject: bug#4359: bug#15775: 24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell
Date: Sat, 4 Jun 2022 20:37:31 +0300

On 02.06.2022 16:07, Lars Ingebrigtsen wrote:
> Lars Ingebrigtsen<larsi <at> gnus.org>  writes:
> 
>> This change makes "git grep" work as a grep command with `M-x grep' (if
>> you remove --null).  It's shouldn't have a negative impact on much
>> anything else (because no pagers should be used anywhere here), but
>> perhaps it should be done in grep.el instead of compile.el...
>>
>> Anybody got any comments?
> [...]
> 
>> +              ;; Some external programs (like "git grep") use a pager;
>> +              ;; defeat that.
>> +              (list "PAGER=")
> Nobody had any comments, and it doesn't seem likely that this will
> regress anything, so I've now pushed this to Emacs 29.

Hi Lars,

Back when I filed bug#15775, Glenn merged it with bug#4359.

Looks like you are fixing only the latter bug here.

The package I mentioned in the original report, inf-ruby, derives from 
comint-mode.

It doesn't derive from compilation-mode, so the pushed change can't 
affect it or fix the problem there.

N.B.: Even a decade later, I still have

  (setenv "PAGER" (executable-find "cat"))

in my init script.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.