GNU bug report logs - #43576
[PATCH] gnu: nng: Update to build as shared library

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#43576: closed ([PATCH] gnu: nng: Update to build as shared
 library)
Date: Wed, 23 Sep 2020 09:15:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 23 Sep 2020 12:14:12 +0300
with message-id <20200923091412.GI896 <at> E5400>
and subject line Re: [bug#43576] [PATCH] gnu: nng: Update to build as shared library
has caused the debbugs.gnu.org bug report #43576,
regarding [PATCH] gnu: nng: Update to build as shared library
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
43576: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43576
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: nng: Update to build as shared library
Date: Wed, 23 Sep 2020 11:41:25 +0330

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 89e47a6726..a5aac7b878 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -419,7 +419,9 @@ at the link-layer level.")
     (arguments
      `(#:configure-flags
        (list "-DNNG_ENABLE_COVERAGE=ON"
-             "-DNNG_ENABLE_TLS=ON")
+             "-DNNG_ENABLE_TLS=ON"
+             ;; To building as shared library
+             "-DBUILD_SHARED_LIBS=ON")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'disable-failing-tests

[Message part 3 (message/rfc822, inline)]

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Hamzeh Nasajpour <h.nasajpour <at> pantherx.org>
Cc: 43576-done <at> debbugs.gnu.org
Subject: Re: [bug#43576] [PATCH] gnu: nng: Update to build as shared library
Date: Wed, 23 Sep 2020 12:14:12 +0300

[Message part 4 (text/plain, inline)]

On Wed, Sep 23, 2020 at 11:41:25AM +0330, Hamzeh Nasajpour wrote:
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 89e47a6726..a5aac7b878 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -419,7 +419,9 @@ at the link-layer level.")
>      (arguments
>       `(#:configure-flags
>         (list "-DNNG_ENABLE_COVERAGE=ON"
> -             "-DNNG_ENABLE_TLS=ON")
> +             "-DNNG_ENABLE_TLS=ON"
> +             ;; To building as shared library

This comment isn't really necessary

> +             "-DBUILD_SHARED_LIBS=ON")
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'disable-failing-tests
> 

I created a whole commit message, added a copyright line for you
and pushed the patch. Thanks!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.