Subject: bug#43576: closed (Re: [bug#43576] [PATCH] gnu: nng: Update to build as shared library)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 23 Sep 2020 09:15:02 +0000

Your bug report

#43576: [PATCH] gnu: nng: Update to build as shared library

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
43576: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43576
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#43576] [PATCH] gnu: nng: Update to build as shared library
From: Efraim Flashner <[email-masked]>
To: Hamzeh Nasajpour <[email-masked]>
Cc: [email-masked]
Date: Wed, 23 Sep 2020 12:14:12 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

On Wed, Sep 23, 2020 at 11:41:25AM +0330, Hamzeh Nasajpour wrote:
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 89e47a6726..a5aac7b878 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -419,7 +419,9 @@ at the link-layer level.")
>      (arguments
>       `(#:configure-flags
>         (list "-DNNG_ENABLE_COVERAGE=ON"
> -             "-DNNG_ENABLE_TLS=ON")
> +             "-DNNG_ENABLE_TLS=ON"
> +             ;; To building as shared library

This comment isn't really necessary

> +             "-DBUILD_SHARED_LIBS=ON")
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'disable-failing-tests
> 

I created a whole commit message, added a copyright line for you
and pushed the patch. Thanks!

-- 
Efraim Flashner   <[email-masked]>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Subject: [PATCH] gnu: nng: Update to build as shared library
From: "Hamzeh Nasajpour" <[email-masked]>
To: [email-masked]
Date: Wed, 23 Sep 2020 11:41:25 +0330
List-Id: <debbugs-submit.debbugs.gnu.org>

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 89e47a6726..a5aac7b878 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -419,7 +419,9 @@ at the link-layer level.")
     (arguments
      `(#:configure-flags
        (list "-DNNG_ENABLE_COVERAGE=ON"
-             "-DNNG_ENABLE_TLS=ON")
+             "-DNNG_ENABLE_TLS=ON"
+             ;; To building as shared library
+             "-DBUILD_SHARED_LIBS=ON")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'disable-failing-tests