From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 20 03:16:59 2020 Received: (at submit) by debbugs.gnu.org; 20 Sep 2020 07:16:59 +0000 Received: from localhost ([127.0.0.1]:48583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJtak-0007YK-S1 for submit@debbugs.gnu.org; Sun, 20 Sep 2020 03:16:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:57018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJtai-0007YD-Re for submit@debbugs.gnu.org; Sun, 20 Sep 2020 03:16:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJtai-0007bE-LP for bug-grep@gnu.org; Sun, 20 Sep 2020 03:16:56 -0400 Received: from mailgw03.kcn.ne.jp ([61.86.7.210]:37664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJtad-0005dm-6f for bug-grep@gnu.org; Sun, 20 Sep 2020 03:16:56 -0400 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw03.kcn.ne.jp (Postfix) with ESMTP id B329D13F63B for ; Sun, 20 Sep 2020 16:16:44 +0900 (JST) X-matriXscan-loop-detect: cc40df5c6865fb0a88af3556fba09f8890f9fd52 Received: from mail10.kcn.ne.jp ([61.86.6.128]) by mxs01-s with ESMTP; Sun, 20 Sep 2020 16:16:43 +0900 (JST) Received: from [10.120.1.110] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail10.kcn.ne.jp (Postfix) with ESMTPA id 4A6D8409761C for ; Sun, 20 Sep 2020 16:16:43 +0900 (JST) Date: Sun, 20 Sep 2020 16:16:43 +0900 From: Norihiro Tanaka To: Subject: [PATCH] grep: avoid unneeded compilation of regex Message-Id: <20200920161642.AE44.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5F66F8E200000000AE3C_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.75.01 [ja] X-matriXscan-msec-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized Received-SPF: pass client-ip=61.86.7.210; envelope-from=noritnk@kcn.ne.jp; helo=mailgw03.kcn.ne.jp X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/20 03:16:45 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --------_5F66F8E200000000AE3C_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Hi, Performace for as following case is fixed in bug#43040. $ yes 0 | head -100000 | sed '$s/././' >pat $ grep -vf pat /dev/null However, still slow and a lot of memory wasted for the following cases. $ grep -vf /usr/share/dict/linux.words /usr/share/dict/linux.words This bug is introduced in commit abb7f4f2325f26f930ff59b702fe42568a8e81e7. Though it's an optimization for patterns with backreferences, it seems to cause performance degradation in many cases due to regex implementation issues. grep needs regex engine when patterns is not supported by DFA engine, and when either given only matching (-o) or color option (--color) is given. In other words, if none of them are met, grep only uses regex to check the syntax. grep avoids compilation of regex not to check syntax by this patch. --------_5F66F8E200000000AE3C_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-grep-avoid-unneeded-compilation-of-regex.patch" Content-Disposition: attachment; filename="0001-grep-avoid-unneeded-compilation-of-regex.patch" Content-Transfer-Encoding: base64 RnJvbSA3MWQ1NGFjYjcwN2I1Yzk2MDgwZDJjMThjMDM0ZWQwYzkzMDVhMzVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTdW4sIDIwIFNlcCAyMDIwIDE1OjM5OjEzICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogYXZvaWQgdW5uZWVkZWQgY29tcGlsYXRpb24gb2YgcmVnZXgKCmdyZXAgbmVlZHMgcmVnZXgg ZW5naW5lIHdoZW4gcGF0dGVybnMgaXMgbm90IHN1cHBvcnRlZCBieSBERkEgZW5naW5lLCBhbmQK d2hlbiBlaXRoZXIgZ2l2ZW4gb25seSBtYXRjaGluZyAoLW8pIG9yIGNvbG9yIG9wdGlvbiAoLS1j b2xvcikgaXMgZ2l2ZW4uCgpJbiBvdGhlciB3b3JkcywgaWYgbm9uZSBvZiB0aGVtIGFyZSBtZXQs IGdyZXAgb25seSB1c2VzIHJlZ2V4IHRvIGNoZWNrIHRoZQpzeW50YXguICBncmVwIGF2b2lkcyBj b21waWxhdGlvbiBvZiByZWdleCBhdm9pZCBub3QgdG8gY2hlY2sgc3ludGF4LgoKKiBzcmMvZGZh c2VhcmNoLmMgKEdFQWNvbXBpbGUpOiBBZGQgbmV3IGFyZ3VtZW50LCBhbmQgYXZvaWQgdW5uZWVk ZWQKY29tcGlsYXRpb24gb2YgcmVnZXguCiogc3JjL2dyZXAuYyAoY29tcGlsZV9mcF90KTogVXBk YXRlIHByb3RvdHlwZS4KKG1haW4pOiBVcGRhdGUgY2FsbGVyLgoqIHNyYy9rd3NlYXJjaC5jIChG Y29tcGlsZSk6IFVwZGF0ZSBjYWxsZXIgYW5kIGFkZCBuZXcgYXJndW1lbnQuCiogc3JjL3BjcmVz ZWFyY2guYyAoUGNvbXBpbGUpOiBBZGQgbmV3IGFyZ3VtZW50LgoqIHNyYy9zZWFyY2guaCAoR0VB Y29tcGlsZSwgRmNvbXBpbGUsIFBjb21waWxlKTogVXBkYXRlIHByb3RvdHlwZS4KLS0tCiBzcmMv ZGZhc2VhcmNoLmMgIHwgICAzMCArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KIHNyYy9n cmVwLmMgICAgICAgfCAgICA3ICsrKystLS0KIHNyYy9rd3NlYXJjaC5jICAgfCAgICA2ICsrKy0t LQogc3JjL3BjcmVzZWFyY2guYyB8ICAgIDIgKy0KIHNyYy9zZWFyY2guaCAgICAgfCAgICA2ICsr Ky0tLQogNSBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9zcmMvZGZhc2VhcmNoLmMgYi9zcmMvZGZhc2VhcmNoLmMKaW5kZXggMzU0 ODc4Zi4uODEyYTBkYyAxMDA2NDQKLS0tIGEvc3JjL2RmYXNlYXJjaC5jCisrKyBiL3NyYy9kZmFz ZWFyY2guYwpAQCAtMTc5LDcgKzE3OSw4IEBAIHJlZ2V4X2NvbXBpbGUgKHN0cnVjdCBkZmFfY29t cCAqZGMsIGNoYXIgY29uc3QgKnAsIHB0cmRpZmZfdCBsZW4sCiAgICBSZXR1cm4gYSBkZXNjcmlw dGlvbiBvZiB0aGUgY29tcGlsZWQgcGF0dGVybi4gICovCiAKIHZvaWQgKgotR0VBY29tcGlsZSAo Y2hhciAqcGF0dGVybiwgc2l6ZV90IHNpemUsIHJlZ19zeW50YXhfdCBzeW50YXhfYml0cykKK0dF QWNvbXBpbGUgKGNoYXIgKnBhdHRlcm4sIHNpemVfdCBzaXplLCByZWdfc3ludGF4X3Qgc3ludGF4 X2JpdHMsCisgICAgICAgICAgICBib29sIGV4YWN0KQogewogICBjaGFyICptb3RpZjsKICAgc3Ry dWN0IGRmYV9jb21wICpkYyA9IHhjYWxsb2MgKDEsIHNpemVvZiAoKmRjKSk7CkBAIC0yNzQsMTgg KzI3NSw2IEBAIEdFQWNvbXBpbGUgKGNoYXIgKnBhdHRlcm4sIHNpemVfdCBzaXplLCByZWdfc3lu dGF4X3Qgc3ludGF4X2JpdHMpCiAgICAgICAgIH0KICAgICB9CiAKLSAgaWYgKGJ1ZiAhPSBOVUxM KQotICAgIHsKLSAgICAgIGRjLT5wYXR0ZXJucy0tOwotICAgICAgZGMtPnBjb3VudCsrOwotCi0g ICAgICBpZiAoIXJlZ2V4X2NvbXBpbGUgKGRjLCBidWYsIGJ1ZmxlbiwgMCwgLTEsIGZhbHNlKSkK LSAgICAgICAgYWJvcnQgKCk7Ci0KLSAgICAgIGlmIChidWYgIT0gcGF0dGVybikKLSAgICAgICAg ZnJlZSAoYnVmKTsKLSAgICB9Ci0KICAgLyogSW4gdGhlIG1hdGNoX3dvcmRzIGFuZCBtYXRjaF9s aW5lcyBjYXNlcywgd2UgdXNlIGEgZGlmZmVyZW50IHBhdHRlcm4KICAgICAgZm9yIHRoZSBERkEg bWF0Y2hlciB0aGF0IHdpbGwgcXVpY2tseSB0aHJvdyBvdXQgY2FzZXMgdGhhdCB3b24ndCB3b3Jr LgogICAgICBUaGVuIGlmIERGQSBzdWNjZWVkcyB3ZSBkbyBzb21lIGhhaXJ5IHN0dWZmIHVzaW5n IHRoZSByZWdleCBtYXRjaGVyCkBAIC0zMjEsNiArMzEwLDIxIEBAIEdFQWNvbXBpbGUgKGNoYXIg KnBhdHRlcm4sIHNpemVfdCBzaXplLCByZWdfc3ludGF4X3Qgc3ludGF4X2JpdHMpCiAgIGt3c211 c3RzIChkYyk7CiAgIGRmYWNvbXAgKE5VTEwsIDAsIGRjLT5kZmEsIDEpOwogCisgIGlmIChidWYg IT0gTlVMTCkKKyAgICB7CisgICAgICBpZiAoZXhhY3QgfHwgIWRmYXN1cHBvcnRlZCAoZGMtPmRm YSkpCisgICAgICAgIHsKKyAgICAgICAgICBkYy0+cGF0dGVybnMtLTsKKyAgICAgICAgICBkYy0+ cGNvdW50Kys7CisKKyAgICAgICAgICBpZiAoIXJlZ2V4X2NvbXBpbGUgKGRjLCBidWYsIGJ1Zmxl biwgMCwgLTEsIGZhbHNlKSkKKyAgICAgICAgICAgIGFib3J0ICgpOworICAgICAgICB9CisKKyAg ICAgIGlmIChidWYgIT0gcGF0dGVybikKKyAgICAgICAgZnJlZSAoYnVmKTsKKyAgICB9CisKICAg ZnJlZSAobW90aWYpOwogCiAgIHJldHVybiBkYzsKZGlmZiAtLWdpdCBhL3NyYy9ncmVwLmMgYi9z cmMvZ3JlcC5jCmluZGV4IDNiNDBiYmIuLjE0NTNiMTQgMTAwNjQ0Ci0tLSBhL3NyYy9ncmVwLmMK KysrIGIvc3JjL2dyZXAuYwpAQCAtNjM1LDcgKzYzNSw3IEBAIHN0YXRpYyBib29sIHNlZWtfZmFp bGVkOwogc3RhdGljIGJvb2wgc2Vla19kYXRhX2ZhaWxlZDsKIAogLyogRnVuY3Rpb25zIHdlJ2xs IHVzZSB0byBzZWFyY2guICovCi10eXBlZGVmIHZvaWQgKigqY29tcGlsZV9mcF90KSAoY2hhciAq LCBzaXplX3QsIHJlZ19zeW50YXhfdCk7Cit0eXBlZGVmIHZvaWQgKigqY29tcGlsZV9mcF90KSAo Y2hhciAqLCBzaXplX3QsIHJlZ19zeW50YXhfdCwgYm9vbCk7CiB0eXBlZGVmIHNpemVfdCAoKmV4 ZWN1dGVfZnBfdCkgKHZvaWQgKiwgY2hhciBjb25zdCAqLCBzaXplX3QsIHNpemVfdCAqLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFyIGNvbnN0ICopOwogc3RhdGljIGV4ZWN1 dGVfZnBfdCBleGVjdXRlOwpAQCAtMjk3Myw4ICsyOTczLDkgQEAgbWFpbiAoaW50IGFyZ2MsIGNo YXIgKiphcmd2KQogICAgIG1hdGNoZXIgPSB0cnlfZmdyZXBfcGF0dGVybiAobWF0Y2hlciwga2V5 cywgJmtleWNjKTsKIAogICBleGVjdXRlID0gbWF0Y2hlcnNbbWF0Y2hlcl0uZXhlY3V0ZTsKLSAg Y29tcGlsZWRfcGF0dGVybiA9IG1hdGNoZXJzW21hdGNoZXJdLmNvbXBpbGUgKGtleXMsIGtleWNj LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWF0Y2hl cnNbbWF0Y2hlcl0uc3ludGF4KTsKKyAgY29tcGlsZWRfcGF0dGVybiA9CisgICAgbWF0Y2hlcnNb bWF0Y2hlcl0uY29tcGlsZSAoa2V5cywga2V5Y2MsIG1hdGNoZXJzW21hdGNoZXJdLnN5bnRheCwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvbmx5X21hdGNoaW5nIHwgY29sb3Jfb3B0 aW9uKTsKICAgLyogV2UgbmVlZCBvbmUgYnl0ZSBwcmlvciBhbmQgb25lIGFmdGVyLiAgKi8KICAg Y2hhciBlb2xieXRlc1szXSA9IHsgMCwgZW9sYnl0ZSwgMCB9OwogICBzaXplX3QgbWF0Y2hfc2l6 ZTsKZGlmZiAtLWdpdCBhL3NyYy9rd3NlYXJjaC5jIGIvc3JjL2t3c2VhcmNoLmMKaW5kZXggNzA4 MTA2MC4uMTE3NGRiYyAxMDA2NDQKLS0tIGEvc3JjL2t3c2VhcmNoLmMKKysrIGIvc3JjL2t3c2Vh cmNoLmMKQEAgLTQ3LDcgKzQ3LDcgQEAgc3RydWN0IGt3c2VhcmNoCiAgICBmb2xsb3dlZCBieSAn XG4nLiAgUmV0dXJuIGEgZGVzY3JpcHRpb24gb2YgdGhlIGNvbXBpbGVkIHBhdHRlcm4uICAqLwog CiB2b2lkICoKLUZjb21waWxlIChjaGFyICpwYXR0ZXJuLCBzaXplX3Qgc2l6ZSwgcmVnX3N5bnRh eF90IGlnbm9yZWQpCitGY29tcGlsZSAoY2hhciAqcGF0dGVybiwgc2l6ZV90IHNpemUsIHJlZ19z eW50YXhfdCBpZ25vcmVkLCBib29sIGV4YWN0KQogewogICBrd3NldF90IGt3c2V0OwogICBjaGFy ICpidWYgPSBOVUxMOwpAQCAtMTc4LDcgKzE3OCw3IEBAIEZleGVjdXRlICh2b2lkICp2Y3AsIGNo YXIgY29uc3QgKmJ1Ziwgc2l6ZV90IHNpemUsIHNpemVfdCAqbWF0Y2hfc2l6ZSwKICAgICAgICAg ICAgIHsKICAgICAgICAgICAgICAgZmdyZXBfdG9fZ3JlcF9wYXR0ZXJuICgma3dzZWFyY2gtPnBh dHRlcm4sICZrd3NlYXJjaC0+c2l6ZSk7CiAgICAgICAgICAgICAgIGt3c2VhcmNoLT5yZSA9IEdF QWNvbXBpbGUgKGt3c2VhcmNoLT5wYXR0ZXJuLCBrd3NlYXJjaC0+c2l6ZSwKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUkVfU1lOVEFYX0dSRVApOworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBSRV9TWU5UQVhfR1JFUCwgISFzdGFydF9w dHIpOwogICAgICAgICAgICAgfQogICAgICAgICAgIHJldHVybiBFR2V4ZWN1dGUgKGt3c2VhcmNo LT5yZSwgYnVmLCBzaXplLCBtYXRjaF9zaXplLCBzdGFydF9wdHIpOwogICAgICAgICB9CkBAIC0y NDUsNyArMjQ1LDcgQEAgRmV4ZWN1dGUgKHZvaWQgKnZjcCwgY2hhciBjb25zdCAqYnVmLCBzaXpl X3Qgc2l6ZSwgc2l6ZV90ICptYXRjaF9zaXplLAogICAgICAgICAgICAgICAgICAgICBmZ3JlcF90 b19ncmVwX3BhdHRlcm4gKCZrd3NlYXJjaC0+cGF0dGVybiwgJmt3c2VhcmNoLT5zaXplKTsKICAg ICAgICAgICAgICAgICAgICAga3dzZWFyY2gtPnJlID0gR0VBY29tcGlsZSAoa3dzZWFyY2gtPnBh dHRlcm4sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGt3 c2VhcmNoLT5zaXplLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBSRV9TWU5UQVhfR1JFUCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFJFX1NZTlRBWF9HUkVQLCAhIXN0YXJ0X3B0cik7CiAgICAgICAgICAgICAg ICAgICB9CiAgICAgICAgICAgICAgICAgaWYgKGJlZyArIGxlbiA8IGJ1ZiArIHNpemUpCiAgICAg ICAgICAgICAgICAgICB7CmRpZmYgLS1naXQgYS9zcmMvcGNyZXNlYXJjaC5jIGIvc3JjL3BjcmVz ZWFyY2guYwppbmRleCBhNjY4YzQ1Li42Nzk4OTY3IDEwMDY0NAotLS0gYS9zcmMvcGNyZXNlYXJj aC5jCisrKyBiL3NyYy9wY3Jlc2VhcmNoLmMKQEAgLTExMyw3ICsxMTMsNyBAQCBqaXRfZXhlYyAo c3RydWN0IHBjcmVfY29tcCAqcGMsIGNoYXIgY29uc3QgKnN1YmplY3QsIGludCBzZWFyY2hfYnl0 ZXMsCiAgICBmb2xsb3dlZCBieSAnXG4nLiAgUmV0dXJuIGEgZGVzY3JpcHRpb24gb2YgdGhlIGNv bXBpbGVkIHBhdHRlcm4uICAqLwogCiB2b2lkICoKLVBjb21waWxlIChjaGFyICpwYXR0ZXJuLCBz aXplX3Qgc2l6ZSwgcmVnX3N5bnRheF90IGlnbm9yZWQpCitQY29tcGlsZSAoY2hhciAqcGF0dGVy biwgc2l6ZV90IHNpemUsIHJlZ19zeW50YXhfdCBpZ25vcmVkLCBib29sIGV4YWN0KQogewogICBp bnQgZTsKICAgY2hhciBjb25zdCAqZXA7CmRpZmYgLS1naXQgYS9zcmMvc2VhcmNoLmggYi9zcmMv c2VhcmNoLmgKaW5kZXggMWQ4NWE3ZS4uYWY4MWRjYiAxMDA2NDQKLS0tIGEvc3JjL3NlYXJjaC5o CisrKyBiL3NyYy9zZWFyY2guaApAQCAtNTYsMTUgKzU2LDE1IEBAIGV4dGVybiBwdHJkaWZmX3Qg bWJfZ29iYWNrIChjaGFyIGNvbnN0ICoqLCBzaXplX3QgKiwgY2hhciBjb25zdCAqLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNoYXIgY29uc3QgKik7CiAKIC8qIGRmYXNlYXJjaC5jICov Ci1leHRlcm4gdm9pZCAqR0VBY29tcGlsZSAoY2hhciAqLCBzaXplX3QsIHJlZ19zeW50YXhfdCk7 CitleHRlcm4gdm9pZCAqR0VBY29tcGlsZSAoY2hhciAqLCBzaXplX3QsIHJlZ19zeW50YXhfdCwg Ym9vbCk7CiBleHRlcm4gc2l6ZV90IEVHZXhlY3V0ZSAodm9pZCAqLCBjaGFyIGNvbnN0ICosIHNp emVfdCwgc2l6ZV90ICosIGNoYXIgY29uc3QgKik7CiAKIC8qIGt3c2VhcmNoLmMgKi8KLWV4dGVy biB2b2lkICpGY29tcGlsZSAoY2hhciAqLCBzaXplX3QsIHJlZ19zeW50YXhfdCk7CitleHRlcm4g dm9pZCAqRmNvbXBpbGUgKGNoYXIgKiwgc2l6ZV90LCByZWdfc3ludGF4X3QsIGJvb2wpOwogZXh0 ZXJuIHNpemVfdCBGZXhlY3V0ZSAodm9pZCAqLCBjaGFyIGNvbnN0ICosIHNpemVfdCwgc2l6ZV90 ICosIGNoYXIgY29uc3QgKik7CiAKIC8qIHBjcmVzZWFyY2guYyAqLwotZXh0ZXJuIHZvaWQgKlBj b21waWxlIChjaGFyICosIHNpemVfdCwgcmVnX3N5bnRheF90KTsKK2V4dGVybiB2b2lkICpQY29t cGlsZSAoY2hhciAqLCBzaXplX3QsIHJlZ19zeW50YXhfdCwgYm9vbCk7CiBleHRlcm4gc2l6ZV90 IFBleGVjdXRlICh2b2lkICosIGNoYXIgY29uc3QgKiwgc2l6ZV90LCBzaXplX3QgKiwgY2hhciBj b25zdCAqKTsKIAogLyogZ3JlcC5jICovCi0tIAoxLjcuMQoK --------_5F66F8E200000000AE3C_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-dfa-change-dfasupported-to-global-function.patch" Content-Disposition: attachment; filename="0001-dfa-change-dfasupported-to-global-function.patch" Content-Transfer-Encoding: base64 RnJvbSBjYTBkMGM5ZTc5NDc4ZGY0NjQ1YzE1YTVhODg1OTU1ZDFjNjIyMWM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTdW4sIDIwIFNlcCAyMDIwIDE2OjAwOjA0ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZGZh OiBjaGFuZ2UgZGZhc3VwcG9ydGVkKCkgdG8gZ2xvYmFsIGZ1bmN0aW9uCgoqIGxpYi9kZmEuYyAo ZGZhc3VwcG9ydGVkKTogUmVuYW1lLCBhbmQgY2hhbmdlIGl0IHRvIGdsb2JhbCBmdW5jdGlvbi4K VXBkYXRlIGNhbGxlci4KKiBsaWIvZGZhLmggKGRmYXN1cHBvcnRlZCk6IEFkZCBwcm90b3R5cGUu Ci0tLQogbGliL2RmYS5jIHwgICAgNiArKystLS0KIGxpYi9kZmEuaCB8ICAgIDMgKysrCiAyIGZp bGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9saWIvZGZhLmMgYi9saWIvZGZhLmMKaW5kZXggYzI1YTM5MS4uNGRmNWIwMCAxMDA2NDQKLS0t IGEvbGliL2RmYS5jCisrKyBiL2xpYi9kZmEuYwpAQCAtMzY1Nyw4ICszNjU3LDggQEAgZnJlZV9t YmRhdGEgKHN0cnVjdCBkZmEgKmQpCiB9CiAKIC8qIFJldHVybiB0cnVlIGlmIGV2ZXJ5IGNvbnN0 cnVjdCBpbiBEIGlzIHN1cHBvcnRlZCBieSB0aGlzIERGQSBtYXRjaGVyLiAgKi8KLXN0YXRpYyBi b29sIF9HTF9BVFRSSUJVVEVfUFVSRQotZGZhX3N1cHBvcnRlZCAoc3RydWN0IGRmYSBjb25zdCAq ZCkKK2Jvb2wKK2RmYXN1cHBvcnRlZCAoc3RydWN0IGRmYSBjb25zdCAqZCkKIHsKICAgZm9yIChp ZHhfdCBpID0gMDsgaSA8IGQtPnRpbmRleDsgaSsrKQogICAgIHsKQEAgLTM4MTQsNyArMzgxNCw3 IEBAIGRmYWNvbXAgKGNoYXIgY29uc3QgKnMsIGlkeF90IGxlbiwgc3RydWN0IGRmYSAqZCwgYm9v bCBzZWFyY2hmbGFnKQogCiAgIGRmYXNzYnVpbGQgKGQpOwogCi0gIGlmIChkZmFfc3VwcG9ydGVk IChkKSkKKyAgaWYgKGRmYXN1cHBvcnRlZCAoZCkpCiAgICAgewogICAgICAgbWF5YmVfZGlzYWJs ZV9zdXBlcnNldF9kZmEgKGQpOwogICAgICAgZGZhYW5hbHl6ZSAoZCwgc2VhcmNoZmxhZyk7CmRp ZmYgLS1naXQgYS9saWIvZGZhLmggYi9saWIvZGZhLmgKaW5kZXggYzViZmY4OS4uMmY3N2YyNiAx MDA2NDQKLS0tIGEvbGliL2RmYS5oCisrKyBiL2xpYi9kZmEuaApAQCAtMTEzLDYgKzExMyw5IEBA IGV4dGVybiBzdHJ1Y3QgZGZhICpkZmFzdXBlcnNldCAoc3RydWN0IGRmYSBjb25zdCAqZCkgX0dM X0FUVFJJQlVURV9QVVJFOwogLyogVGhlIERGQSBpcyBsaWtlbHkgdG8gYmUgZmFzdC4gICovCiBl eHRlcm4gYm9vbCBkZmFpc2Zhc3QgKHN0cnVjdCBkZmEgY29uc3QgKikgX0dMX0FUVFJJQlVURV9Q VVJFOwogCisvKiBSZXR1cm4gdHJ1ZSBpZiBldmVyeSBjb25zdHJ1Y3QgaW4gRCBpcyBzdXBwb3J0 ZWQgYnkgdGhpcyBERkEgbWF0Y2hlci4gICovCitleHRlcm4gYm9vbCBkZmFzdXBwb3J0ZWQgKHN0 cnVjdCBkZmEgY29uc3QgKikgX0dMX0FUVFJJQlVURV9QVVJFOworCiAvKiBGcmVlIHRoZSBzdG9y YWdlIGhlbGQgYnkgdGhlIGNvbXBvbmVudHMgb2YgYSBzdHJ1Y3QgZGZhLiAqLwogZXh0ZXJuIHZv aWQgZGZhZnJlZSAoc3RydWN0IGRmYSAqKTsKIAotLSAKMS43LjEKCg== --------_5F66F8E200000000AE3C_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 20 21:34:22 2020 Received: (at 43527) by debbugs.gnu.org; 21 Sep 2020 01:34:22 +0000 Received: from localhost ([127.0.0.1]:52999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKAik-0008C0-2w for submit@debbugs.gnu.org; Sun, 20 Sep 2020 21:34:22 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:40498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKAij-0008Bq-6U for 43527@debbugs.gnu.org; Sun, 20 Sep 2020 21:34:21 -0400 Received: by mail-wr1-f50.google.com with SMTP id j2so11000932wrx.7 for <43527@debbugs.gnu.org>; Sun, 20 Sep 2020 18:34:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y/IO/dmNqgN5zwjy1igrIb9TdfARVxsbNWmDsW9nCCE=; b=RYxU2ci8RpKQXJJBI6aQyfDVsGa7JMlgxpirMb7HG0NbgpfZw98AQpNtXescWFcsLs 4ecQPo+Jy54PhbV6cIZ/p/xXcLoClONECd5LXCf1gRAuFkGCcgmD0SuMMKuQegBIizz8 3pP3ZnX3c/FEgD7CfX0xK+h6Jko6EXtelCUrBUBb2ovL55VEMMWclEfK83RhIicb7Zqn ICa/93xEb8y9ybNF6d/k9vL01Efegffi5tnM7PiYBL9v0RcyqiGKTKRZm9tPToL58LrJ tdkZpBl4zTmOrqqYLCn90V2BCRZpSDRmH+9UAaVjJEI/dZ/hZxgqWhpMukgPLUO1B7Vf KE6g== X-Gm-Message-State: AOAM532u0OPQfKuPRhNA3+6nVd5zps2lVB6Z/R6EbduTD0B02VCPyTQG pa9DHd0Cx9G7X2l9kXsy7LalNxWg846lFb+4uJY= X-Google-Smtp-Source: ABdhPJzQAIgApoFkLvXwfMKH+CQNbGBvfDRo/VtFvXpoPYnsFk6lRmO8HRH5PuNsNhHwUa0POSDkB7K9Q3DaSekcfo0= X-Received: by 2002:adf:d4c1:: with SMTP id w1mr49764592wrk.108.1600652053997; Sun, 20 Sep 2020 18:34:13 -0700 (PDT) MIME-Version: 1.0 References: <20200920161642.AE44.27F6AC2D@kcn.ne.jp> In-Reply-To: <20200920161642.AE44.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Sun, 20 Sep 2020 18:34:02 -0700 Message-ID: Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex To: Norihiro Tanaka Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43527 Cc: 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sun, Sep 20, 2020 at 12:17 AM Norihiro Tanaka wrote: > Hi, > Performace for as following case is fixed in bug#43040. > > $ yes 0 | head -100000 | sed '$s/././' >pat > $ grep -vf pat /dev/null > > However, still slow and a lot of memory wasted for the following cases. > > $ grep -vf /usr/share/dict/linux.words /usr/share/dict/linux.words > > This bug is introduced in commit abb7f4f2325f26f930ff59b702fe42568a8e81e7. > Though it's an optimization for patterns with backreferences, it seems > to cause performance degradation in many cases due to regex > implementation issues. > > grep needs regex engine when patterns is not supported by DFA engine, > and when either given only matching (-o) or color option (--color) is > given. > > In other words, if none of them are met, grep only uses regex to check > the syntax. grep avoids compilation of regex not to check syntax by this > patch. Yikes. Thank you! That exposes (and fixes in this common case) a problem that makes grep require memory that is quadratic in the number of regular expressions. To illustrate, I ran some timings. With only 80,000 lines of /usr/share/dict/linux.words, the following would use 100GB of RSS and take 3 minutes. With the fix, it used less than 400MB and took less than one second. head -$N /usr/share/dict/linux.words > w; grep -vf w w N Mem(k): Old New 20000 6341188 (2.4s) 103168 40000 25241288 (9.29s) 199188 (0.31s) 80000 100547432 (180s) 392872 (0.66s) I've just pushed the gnulib-adjusting patch and will push the other soon. I'll also add a test and a NEWS item in a separate patch. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 21 20:33:46 2020 Received: (at 43527) by debbugs.gnu.org; 22 Sep 2020 00:33:46 +0000 Received: from localhost ([127.0.0.1]:56760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKWFd-0007UH-Ug for submit@debbugs.gnu.org; Mon, 21 Sep 2020 20:33:46 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:40854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKWFc-0007U4-Ld for 43527@debbugs.gnu.org; Mon, 21 Sep 2020 20:33:45 -0400 Received: by mail-wr1-f68.google.com with SMTP id j2so15130681wrx.7 for <43527@debbugs.gnu.org>; Mon, 21 Sep 2020 17:33:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XbiT0/jqvBGiNVs2NkGfd5kUupw6lpWdNEzC43bWAzQ=; b=uDYe7a2uGE2ujhHMKM/GWidgxH6uVgteh4pa57ctwD6PCJVmR7ICZ1mrsoMVOPqGOx Cp2R+l9PQ2U/p0c8+aYWOxWuO4EdoJz5Jb1XRMhj76LAlOEwMcQOnPprL1yQBJitPen3 LVjdezQ/4GJ2FUdx3Zvxaq9sUOj6hkpdhnyhO9K9Ly/4OVFVDnpZygD9e/1BbIxtW2yh dxyzpRgOfa2rGeJEyKJFYhJbOXLcK6BzYX8ir2ZBv4WR3fcv+ITAX197dkl1V3wWHVbo +R5CjD5aXhB0S7U+ws9Htks52tkDruvT8trFpC+8uUirEhCRP7DH2gxgA9sfgjhuvv19 x+tQ== X-Gm-Message-State: AOAM5324NE+jassKxtTQIRigECFk0NKNxYRv1t3C31yuoMG751pzPE5g SUqEzuXLf2Ny6AOIy34nDuDIeVuBs8JRs7Pq8F0= X-Google-Smtp-Source: ABdhPJyTatMIINq8WAvPw4fyg39ONAPbyLuELt60GFvWaIj2B5EhrHNCYzMR0edIJhmW5lZGjTFrlaYrInrWwMDds7E= X-Received: by 2002:adf:83c3:: with SMTP id 61mr2223428wre.287.1600734818748; Mon, 21 Sep 2020 17:33:38 -0700 (PDT) MIME-Version: 1.0 References: <20200920161642.AE44.27F6AC2D@kcn.ne.jp> In-Reply-To: From: Jim Meyering Date: Mon, 21 Sep 2020 17:33:25 -0700 Message-ID: Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex To: Norihiro Tanaka Content-Type: multipart/mixed; boundary="00000000000040c6d205afdc1ee6" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43527 Cc: 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --00000000000040c6d205afdc1ee6 Content-Type: text/plain; charset="UTF-8" On Sun, Sep 20, 2020 at 6:34 PM Jim Meyering wrote: > > On Sun, Sep 20, 2020 at 12:17 AM Norihiro Tanaka wrote: > > Hi, > > Performace for as following case is fixed in bug#43040. > > > > $ yes 0 | head -100000 | sed '$s/././' >pat > > $ grep -vf pat /dev/null > > > > However, still slow and a lot of memory wasted for the following cases. > > > > $ grep -vf /usr/share/dict/linux.words /usr/share/dict/linux.words > > > > This bug is introduced in commit abb7f4f2325f26f930ff59b702fe42568a8e81e7. > > Though it's an optimization for patterns with backreferences, it seems > > to cause performance degradation in many cases due to regex > > implementation issues. > > > > grep needs regex engine when patterns is not supported by DFA engine, > > and when either given only matching (-o) or color option (--color) is > > given. > > > > In other words, if none of them are met, grep only uses regex to check > > the syntax. grep avoids compilation of regex not to check syntax by this > > patch. > > Yikes. Thank you! > That exposes (and fixes in this common case) a problem that makes grep > require memory that is quadratic in the number of regular expressions. > > To illustrate, I ran some timings. > With only 80,000 lines of /usr/share/dict/linux.words, the following > would use 100GB of RSS and take 3 minutes. With the fix, it used less > than 400MB and took less than one second. > > head -$N /usr/share/dict/linux.words > w; grep -vf w w > > N Mem(k): Old New > 20000 6341188 (2.4s) 103168 > 40000 25241288 (9.29s) 199188 (0.31s) > 80000 100547432 (180s) 392872 (0.66s) > > I've just pushed the gnulib-adjusting patch and will push the other soon. > I'll also add a test and a NEWS item in a separate patch. Here are the two patches (tested on top of a third that updates to latest gnulib). I'll await an 'ok' from Norihiro Tanaka before pushing, since commit-log metadata is essentially immutable once pushed. --00000000000040c6d205afdc1ee6 Content-Type: application/octet-stream; name="0002-tests-test-for-many-regexp-N-2-RSS-regression.patch" Content-Disposition: attachment; filename="0002-tests-test-for-many-regexp-N-2-RSS-regression.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kfd85w721 RnJvbSA3ODU2ZGY5ZWNkMjYxMDJiNTI1ZDgxNDA0MjVmMTRjZjlmYmNlYTc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog TW9uLCAyMSBTZXAgMjAyMCAxMzowNjoxNSAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSB0ZXN0 czogdGVzdCBmb3IgbWFueS1yZWdleHAgTl4yIFJTUyByZWdyZXNzaW9uCgoqIHRlc3RzL21hbnkt cmVnZXgtcGVyZm9ybWFuY2U6IE5ldyB0ZXN0IGZvciB0aGlzIHBlcmZvcm1hbmNlCnJlZ3Jlc3Np b24uCiogdGVzdHMvTWFrZWZpbGUuYW06IEFkZCBpdC4KKiBORVdTIChCdWcgZml4ZXMpOiBEZXNj cmliZSBpdC4KLS0tCiBORVdTICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDggKysrKwogdGVz dHMvTWFrZWZpbGUuYW0gICAgICAgICAgICB8ICAxICsKIHRlc3RzL21hbnktcmVnZXgtcGVyZm9y bWFuY2UgfCA3OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMg Y2hhbmdlZCwgODggaW5zZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNzU1IHRlc3RzL21hbnkt cmVnZXgtcGVyZm9ybWFuY2UKCmRpZmYgLS1naXQgYS9ORVdTIGIvTkVXUwppbmRleCA3OWI5ZGIw Li40NDJkNGQyIDEwMDY0NAotLS0gYS9ORVdTCisrKyBiL05FV1MKQEAgLTM5LDYgKzM5LDE0IEBA IEdOVSBncmVwIE5FV1MgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtKi0gb3V0 bGluZSAtKi0KICAgQSBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIHdpdGggbWFueSBkdXBsaWNhdGUg cGF0dGVybnMgaGFzIGJlZW4gZml4ZWQuCiAgIFtCdWcjNDMwNDAgaW50cm9kdWNlZCBpbiBncmVw IDMuNF0KCisgIEFuIE5eMiBSU1MgcGVyZm9ybWFuY2UgcmVncmVzc2lvbiB3aXRoIG1hbnkgcGF0 dGVybnMgaGFzIGJlZW4gZml4ZWQKKyAgaW4gY29tbW9uIGNhc2VzIChubyBiYWNrcmVmLCBhbmQg bm8gdXNlIG9mIC1vIG9yIC0tY29sb3IpLgorICBXaXRoIG9ubHkgODAsMDAwIGxpbmVzIG9mIC91 c3Ivc2hhcmUvZGljdC9saW51eC53b3JkcywgdGhlIGZvbGxvd2luZworICB3b3VsZCB1c2UgMTAw R0Igb2YgUlNTIGFuZCB0YWtlIDMgbWludXRlcy4gV2l0aCB0aGUgZml4LCBpdCB1c2VkIGxlc3MK KyAgdGhhbiA0MDBNQiBhbmQgdG9vayBsZXNzIHRoYW4gb25lIHNlY29uZDoKKyAgICBoZWFkIC04 MDAwMCAvdXNyL3NoYXJlL2RpY3QvbGludXgud29yZHMgPiB3OyBncmVwIC12ZiB3IHcKKyAgW0J1 ZyM0MzUyNyBpbnRyb2R1Y2VkIGluIGdyZXAgMy40XQorCiAqKiBCdWlsZC1yZWxhdGVkCgogICAi bWFrZSBkaXN0IiBidWlsZHMgLnRhci5neiBmaWxlcyBhZ2FpbiwgYXMgdGhleSBhcmUgc3RpbGwg dXNlZCBpbgpkaWZmIC0tZ2l0IGEvdGVzdHMvTWFrZWZpbGUuYW0gYi90ZXN0cy9NYWtlZmlsZS5h bQppbmRleCA5ZDQ5ZTQwLi44M2U3MDg3IDEwMDY0NAotLS0gYS90ZXN0cy9NYWtlZmlsZS5hbQor KysgYi90ZXN0cy9NYWtlZmlsZS5hbQpAQCAtMTIwLDYgKzEyMCw3IEBAIFRFU1RTID0JCQkJCQlc CiAgIGt3c2V0LWFidXNlCQkJCQlcCiAgIGxvbmctbGluZS12cy0yR2lCLXJlYWQJCQlcCiAgIGxv bmctcGF0dGVybi1wZXJmCQkJCVwKKyAgbWFueS1yZWdleC1wZXJmb3JtYW5jZQkJCVwKICAgbWF0 Y2gtbGluZXMJCQkJCVwKICAgbWF4LWNvdW50LW92ZXJyZWFkCQkJCVwKICAgbWF4LWNvdW50LXZz LWNvbnRleHQJCQkJXApkaWZmIC0tZ2l0IGEvdGVzdHMvbWFueS1yZWdleC1wZXJmb3JtYW5jZSBi L3Rlc3RzL21hbnktcmVnZXgtcGVyZm9ybWFuY2UKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXgg MDAwMDAwMC4uZWU2OGEwNAotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3RzL21hbnktcmVnZXgtcGVy Zm9ybWFuY2UKQEAgLTAsMCArMSw3OSBAQAorIyEvYmluL3NoCisjIFRlc3QgZm9yIHRoaXMgcGVy Zm9ybWFuY2UgcmVncmVzc2lvbjoKKyMgZ3JlcC0zLjQgd291bGQgcmVxdWlyZSBPKE5eMikgUlNT IGZvciBOIHJlZ2V4cHMKKyMgZ3JlcC0zLjUgcmVxdWlyZXMgTyhOKSBpbiB0aGUgbW9zdCBjb21t b24gY2FzZXMuCisKKyMgQ29weXJpZ2h0IDIwMjAgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJ bmMuCisKKyMgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU6IHlvdSBjYW4gcmVkaXN0cmli dXRlIGl0IGFuZC9vciBtb2RpZnkKKyMgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyMgdGhlIEZyZWUgU29mdHdhcmUg Rm91bmRhdGlvbiwgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3IKKyMgKGF0IHlv dXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKworIyBUaGlzIHByb2dyYW0gaXMgZGlzdHJp YnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyMgYnV0IFdJVEhPVVQg QU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyMgTUVS Q0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRo ZQorIyBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCisjIFlv dSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBM aWNlbnNlCisjIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHBzOi8v d3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworLiAiJHtzcmNkaXI9Ln0vaW5pdC5zaCI7IHBhdGhf cHJlcGVuZF8gLi4vc3JjCisKK2ZhaWw9MAorCisjIFRoaXMgdGVzdCBpcyBzdXNjZXB0aWJsZSB0 byBmYWlsdXJlIGR1ZSB0byBkaWZmZXJlbmNlcyBpbgorIyBzeXN0ZW0gbG9hZCBkdXJpbmcgdGhl IHR3byB0ZXN0IHJ1bnMsIHNvIHdlJ2xsIG1hcmsgaXQgYXMKKyMgImV4cGVuc2l2ZSIsIG1ha2lu ZyBpdCBsZXNzIGxpa2VseSB0byBiZSBydW4gYnkgcmVndWxhciB1c2Vycy4KK2V4cGVuc2l2ZV8K KworIyBNYWtlIHRoZSBxdWljay9zbWFsbCBpbnB1dCBsYXJnZSBlbm91Z2ggc28gdGhhdCBldmVu IG9uIGhpZ2gtZW5kCisjIHN5c3RlbXMgdGhpcyBmaXJzdCBpbnZvY2F0aW9uIHRha2VzIGF0IGxl YXN0IDEwbXMgb2YgdXNlciB0aW1lLgord29yZF9saXN0PS91c3Ivc2hhcmUvZGljdC9saW51eC53 b3JkcworCisjIElmICR3b3JkX2xpc3QgZG9lcyBub3QgZXhpc3QsIGdlbmVyYXRlIGFuIGlucHV0 IHRoYXQgZXhpYmhpdHMKKyMgc2ltaWxhciBwZXJmb3JtYW5jZSBjaGFyYWN0ZXJpc3RpY3MuCitp ZiAhIHRlc3QgLWYgJHdvcmRfbGlzdDsgdGhlbgorICAjIEdlbmVyYXRlIGRhdGEgY29tcHJhYmxl IHRvIHRoYXQgd29yZCBsaXN0LgorICAjIE5vdGUgaG93IGFsbCAid29yZHMiIHN0YXJ0IHdpdGgg ImEiLCBhbmQgdGhhdCB0aGVyZSBpcworICAjIGEgc21hbGwgcGVyY2VudGFnZSBvZiBsaW5lcyB3 aXRoIGF0IGxlYXN0IG9uZSAiLiIgbWV0YWNoYXIuCisgICMgVGhpcyByZXF1aXJlcyAvZGV2L3Vy YW5kb20sIHNvIGlmIGl0J3Mgbm90IHByZXNlbnQsIHNraXAKKyAgIyB0aGlzIHRlc3QuIElmIGRl c3BlcmF0ZSwgd2UgY291bGQgZmFsbCBiYWNrIHRvIHVzaW5nCisgICMgdGFyK2NvbXByZXNzZWQg bGliLyouYyBhcyB0aGUgZGF0YSBzb3VyY2UuCisgIHRlc3QgLXIgL2Rldi91cmFuZG9tIFwKKyAg ICB8fCBza2lwXyAndGhpcyBzeXN0ZW0gaGFzIG5laXRoZXIgd29yZCBsaXN0IG5vciB3b3JraW5n IC9kZXYvdXJhbmRvbScKKyAgd29yZF9saXN0PXdvcmRfbGlzdAorICAoIGVjaG8gYTsgY2F0IC9k ZXYvdXJhbmRvbQkJXAorICAgIHwgTENfQUxMPUMgdHIgLWRjICdhLXpBLVowLTlfJwlcCisgICAg fCBoZWFkIC1jNTAwMDAwCQkJXAorICAgIHwgc2VkICdzL1woLi4uLi4uLi5cKS9cMVxuL2cnCVwK KyAgICB8IHNlZCBzL3JzLy4vCQkJXAorICAgIHwgc2VkIHMvLi9hLwkJCVwKKyAgICB8IHNvcnQJ CQkJXAorICApID4gJHdvcmRfbGlzdAorZmkKKworbl9saW5lcz0yMDAwCit3aGlsZSA6OyBkbwor ICBzZWQgJHtuX2xpbmVzfXEgPCAkd29yZF9saXN0ID4gaW4gfHwgZnJhbWV3b3JrX2ZhaWx1cmVf CisgIHNtYWxsX21zPSQoTENfQUxMPUMgdXNlcl90aW1lXyAxIGdyZXAgLS1maWxlPWluIC12IGlu KSB8fCBmYWlsPTEKKyAgdGVzdCAkc21hbGxfbXMgLWdlIDEwICYmIGJyZWFrCisgIG5fbGluZXM9 JChleHByICRuX2xpbmVzICsgMjAwMCkKK2RvbmUKKworIyBOb3csIHJ1biBpdCBhZ2FpbiwgYnV0 IHdpdGggMjAgdGltZXMgYXMgbWFueSBsaW5lcy4KK25fbGluZXM9JChleHByICRuX2xpbmVzIFwq IDIwKQorc2VkICR7bl9saW5lc31xIDwgJHdvcmRfbGlzdCA+IGluIHx8IGZyYW1ld29ya19mYWls dXJlXworbGFyZ2VfbXM9JChMQ19BTEw9QyB1c2VyX3RpbWVfIDEgZ3JlcCAtLWZpbGU9aW4gLXYg aW4pIHx8IGZhaWw9MQorCisjIERlbGliZXJhdGVseSByZWNvcmRpbmcgaW4gYW4gdW51c2VkIHZh cmlhYmxlIHNvIGl0CisjIHNob3dzIHVwIGluIHNldCAteCBvdXRwdXQsIGluIGNhc2UgdGhpcyB0 ZXN0IGZhaWxzLgorcmF0aW89JChleHByICIkbGFyZ2VfbXMiIC8gIiRzbWFsbF9tcyIpCisKKyMg VGhlIGR1cmF0aW9uIG9mIHRoZSBsYXJnZXIgcnVuIG11c3QgYmUgbm8gbW9yZSB0aGFuIDYwIHRp bWVzCisjIHRoYXQgb2YgdGhlIHNtYWxsIG9uZS4gIFVzaW5nIHJlY2VudCB2ZXJzaW9ucyBwcmlv ciB0byB0aGlzIGZpeCwKKyMgdGhpcyB0ZXN0IHdvdWxkIGZhaWwgZHVlIHRvIHJhdGlvcyBsYXJn ZXIgdGhhbiAzMDAuICBVc2luZyB0aGUKKyMgZml4ZWQgdmVyc2lvbiwgaXQncyBjb21tb24gdG8g c2VlIGEgcmF0aW8gb2YgMjAtMzAuCityZXR1cm5zXyAxIGV4cHIgJHNtYWxsX21zICc8JyAkbGFy Z2VfbXMgLyA2MCB8fCBmYWlsPTEKKworRXhpdCAkZmFpbAotLSAKMi4yOC4wLjU0Ni5nMzg1YzE3 MWEwMQoK --00000000000040c6d205afdc1ee6 Content-Type: application/octet-stream; name="0001-grep-avoid-unnecessary-regex-compilation.patch" Content-Disposition: attachment; filename="0001-grep-avoid-unnecessary-regex-compilation.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kfd85w6w0 RnJvbSBjMTYwMzUwOGEyMGIyNjI1MzliNGE0ODI5N2E3MjliNGIxYjI5YTE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTdW4sIDIwIFNlcCAyMDIwIDE1OjM5OjEzICswOTAwClN1YmplY3Q6IFtQQVRDSCAxLzJd IGdyZXA6IGF2b2lkIHVubmVjZXNzYXJ5IHJlZ2V4IGNvbXBpbGF0aW9uCgpHcmVwIHJlc29ydHMg dG8gdXNpbmcgdGhlIHJlZ2V4IGVuZ2luZSB3aGVuIHRoZSBwcmVjaXNpb24gb2YgZWl0aGVyCi1v IG9yIC0tY29sb3IgaXMgcmVxdWlyZWQsIG9yIHdoZW4gdGhlIHBhdHRlcm4gaXMgbm90IHN1cHBv cnRlZCBieQpvdXIgREZBIGVuZ2luZSAoZS5nLiwgYmFja3JlZikuIE90aGVyd2lzZSwgZ3JlcCB3 b3VsZCBwZXJmb3JtIHJlZ2V4CmNvbXBpbGF0aW9uIHNvbGVseSB0byBjaGVjayB0aGUgc3ludGF4 LiBUaGlzIGNoYW5nZSBtYWtlcyBncmVwIHNraXAKdGhhdCBjb21waWxhdGlvbiBpbiB0aGUgY29t bW9uIGNhc2UgZm9yIHdoaWNoIGl0IGlzIHVubmVjZXNzYXJ5LgoKVGhlIGNvbXBpbGF0aW9uIHdl IGFyZSBhdm9pZGluZyBpcyBxdWl0ZSBjb3N0bHksIGNvbnN1bWluZyBPKE5eMikKUlNTIGZvciBO IHJlZ3VsYXIgZXhwcmVzc2lvbnMuCgoqIHNyYy9kZmFzZWFyY2guYyAoR0VBY29tcGlsZSk6IEFk ZCBuZXcgYXJndW1lbnQsIGFuZCBhdm9pZCB1bm5lZWRlZApjb21waWxhdGlvbiBvZiByZWdleC4K KiBzcmMvZ3JlcC5jIChjb21waWxlX2ZwX3QpOiBVcGRhdGUgcHJvdG90eXBlLgoobWFpbik6IFVw ZGF0ZSBjYWxsZXIuCiogc3JjL2t3c2VhcmNoLmMgKEZjb21waWxlKTogVXBkYXRlIGNhbGxlciBh bmQgYWRkIG5ldyBhcmd1bWVudC4KKiBzcmMvcGNyZXNlYXJjaC5jIChQY29tcGlsZSk6IEFkZCBu ZXcgYXJndW1lbnQuCiogc3JjL3NlYXJjaC5oIChHRUFjb21waWxlLCBGY29tcGlsZSwgUGNvbXBp bGUpOiBVcGRhdGUgcHJvdG90eXBlLgotLS0KIHNyYy9kZmFzZWFyY2guYyAgfCAzMCArKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0KIHNyYy9ncmVwLmMgICAgICAgfCAgNyArKysrLS0tCiBz cmMva3dzZWFyY2guYyAgIHwgIDYgKysrLS0tCiBzcmMvcGNyZXNlYXJjaC5jIHwgIDIgKy0KIHNy Yy9zZWFyY2guaCAgICAgfCAgNiArKystLS0KIDUgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9u cygrKSwgMjMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2RmYXNlYXJjaC5jIGIvc3Jj L2RmYXNlYXJjaC5jCmluZGV4IDRkM2Y0YjIuLmEyZmVkYTcgMTAwNjQ0Ci0tLSBhL3NyYy9kZmFz ZWFyY2guYworKysgYi9zcmMvZGZhc2VhcmNoLmMKQEAgLTE3OSw3ICsxNzksOCBAQCByZWdleF9j b21waWxlIChzdHJ1Y3QgZGZhX2NvbXAgKmRjLCBjaGFyIGNvbnN0ICpwLCBwdHJkaWZmX3QgbGVu LAogICAgUmV0dXJuIGEgZGVzY3JpcHRpb24gb2YgdGhlIGNvbXBpbGVkIHBhdHRlcm4uICAqLwoK IHZvaWQgKgotR0VBY29tcGlsZSAoY2hhciAqcGF0dGVybiwgc2l6ZV90IHNpemUsIHJlZ19zeW50 YXhfdCBzeW50YXhfYml0cykKK0dFQWNvbXBpbGUgKGNoYXIgKnBhdHRlcm4sIHNpemVfdCBzaXpl LCByZWdfc3ludGF4X3Qgc3ludGF4X2JpdHMsCisgICAgICAgICAgICBib29sIGV4YWN0KQogewog ICBjaGFyICptb3RpZjsKICAgc3RydWN0IGRmYV9jb21wICpkYyA9IHhjYWxsb2MgKDEsIHNpemVv ZiAoKmRjKSk7CkBAIC0yNzQsMTggKzI3NSw2IEBAIEdFQWNvbXBpbGUgKGNoYXIgKnBhdHRlcm4s IHNpemVfdCBzaXplLCByZWdfc3ludGF4X3Qgc3ludGF4X2JpdHMpCiAgICAgICAgIH0KICAgICB9 CgotICBpZiAoYnVmICE9IE5VTEwpCi0gICAgewotICAgICAgZGMtPnBhdHRlcm5zLS07Ci0gICAg ICBkYy0+cGNvdW50Kys7Ci0KLSAgICAgIGlmICghcmVnZXhfY29tcGlsZSAoZGMsIGJ1ZiwgYnVm bGVuLCAwLCAtMSwgZmFsc2UpKQotICAgICAgICBhYm9ydCAoKTsKLQotICAgICAgaWYgKGJ1ZiAh PSBwYXR0ZXJuKQotICAgICAgICBmcmVlIChidWYpOwotICAgIH0KLQogICAvKiBJbiB0aGUgbWF0 Y2hfd29yZHMgYW5kIG1hdGNoX2xpbmVzIGNhc2VzLCB3ZSB1c2UgYSBkaWZmZXJlbnQgcGF0dGVy bgogICAgICBmb3IgdGhlIERGQSBtYXRjaGVyIHRoYXQgd2lsbCBxdWlja2x5IHRocm93IG91dCBj YXNlcyB0aGF0IHdvbid0IHdvcmsuCiAgICAgIFRoZW4gaWYgREZBIHN1Y2NlZWRzIHdlIGRvIHNv bWUgaGFpcnkgc3R1ZmYgdXNpbmcgdGhlIHJlZ2V4IG1hdGNoZXIKQEAgLTMyMSw2ICszMTAsMjEg QEAgR0VBY29tcGlsZSAoY2hhciAqcGF0dGVybiwgc2l6ZV90IHNpemUsIHJlZ19zeW50YXhfdCBz eW50YXhfYml0cykKICAga3dzbXVzdHMgKGRjKTsKICAgZGZhY29tcCAoTlVMTCwgMCwgZGMtPmRm YSwgMSk7CgorICBpZiAoYnVmICE9IE5VTEwpCisgICAgeworICAgICAgaWYgKGV4YWN0IHx8ICFk ZmFzdXBwb3J0ZWQgKGRjLT5kZmEpKQorICAgICAgICB7CisgICAgICAgICAgZGMtPnBhdHRlcm5z LS07CisgICAgICAgICAgZGMtPnBjb3VudCsrOworCisgICAgICAgICAgaWYgKCFyZWdleF9jb21w aWxlIChkYywgYnVmLCBidWZsZW4sIDAsIC0xLCBmYWxzZSkpCisgICAgICAgICAgICBhYm9ydCAo KTsKKyAgICAgICAgfQorCisgICAgICBpZiAoYnVmICE9IHBhdHRlcm4pCisgICAgICAgIGZyZWUg KGJ1Zik7CisgICAgfQorCiAgIGZyZWUgKG1vdGlmKTsKCiAgIHJldHVybiBkYzsKZGlmZiAtLWdp dCBhL3NyYy9ncmVwLmMgYi9zcmMvZ3JlcC5jCmluZGV4IDQ5Nzc4MGUuLmNhMjk1YTUgMTAwNjQ0 Ci0tLSBhL3NyYy9ncmVwLmMKKysrIGIvc3JjL2dyZXAuYwpAQCAtNjM1LDcgKzYzNSw3IEBAIHN0 YXRpYyBib29sIHNlZWtfZmFpbGVkOwogc3RhdGljIGJvb2wgc2Vla19kYXRhX2ZhaWxlZDsKCiAv KiBGdW5jdGlvbnMgd2UnbGwgdXNlIHRvIHNlYXJjaC4gKi8KLXR5cGVkZWYgdm9pZCAqKCpjb21w aWxlX2ZwX3QpIChjaGFyICosIHNpemVfdCwgcmVnX3N5bnRheF90KTsKK3R5cGVkZWYgdm9pZCAq KCpjb21waWxlX2ZwX3QpIChjaGFyICosIHNpemVfdCwgcmVnX3N5bnRheF90LCBib29sKTsKIHR5 cGVkZWYgc2l6ZV90ICgqZXhlY3V0ZV9mcF90KSAodm9pZCAqLCBjaGFyIGNvbnN0ICosIHNpemVf dCwgc2l6ZV90ICosCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNoYXIgY29uc3Qg Kik7CiBzdGF0aWMgZXhlY3V0ZV9mcF90IGV4ZWN1dGU7CkBAIC0yOTY5LDggKzI5NjksOSBAQCBt YWluIChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgICAgbWF0Y2hlciA9IHRyeV9mZ3JlcF9wYXR0 ZXJuIChtYXRjaGVyLCBrZXlzLCAma2V5Y2MpOwoKICAgZXhlY3V0ZSA9IG1hdGNoZXJzW21hdGNo ZXJdLmV4ZWN1dGU7Ci0gIGNvbXBpbGVkX3BhdHRlcm4gPSBtYXRjaGVyc1ttYXRjaGVyXS5jb21w aWxlIChrZXlzLCBrZXljYywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIG1hdGNoZXJzW21hdGNoZXJdLnN5bnRheCk7CisgIGNvbXBpbGVkX3BhdHRlcm4g PQorICAgIG1hdGNoZXJzW21hdGNoZXJdLmNvbXBpbGUgKGtleXMsIGtleWNjLCBtYXRjaGVyc1tt YXRjaGVyXS5zeW50YXgsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb25seV9tYXRj aGluZyB8IGNvbG9yX29wdGlvbik7CiAgIC8qIFdlIG5lZWQgb25lIGJ5dGUgcHJpb3IgYW5kIG9u ZSBhZnRlci4gICovCiAgIGNoYXIgZW9sYnl0ZXNbM10gPSB7IDAsIGVvbGJ5dGUsIDAgfTsKICAg c2l6ZV90IG1hdGNoX3NpemU7CmRpZmYgLS1naXQgYS9zcmMva3dzZWFyY2guYyBiL3NyYy9rd3Nl YXJjaC5jCmluZGV4IDcwODEwNjAuLjExNzRkYmMgMTAwNjQ0Ci0tLSBhL3NyYy9rd3NlYXJjaC5j CisrKyBiL3NyYy9rd3NlYXJjaC5jCkBAIC00Nyw3ICs0Nyw3IEBAIHN0cnVjdCBrd3NlYXJjaAog ICAgZm9sbG93ZWQgYnkgJ1xuJy4gIFJldHVybiBhIGRlc2NyaXB0aW9uIG9mIHRoZSBjb21waWxl ZCBwYXR0ZXJuLiAgKi8KCiB2b2lkICoKLUZjb21waWxlIChjaGFyICpwYXR0ZXJuLCBzaXplX3Qg c2l6ZSwgcmVnX3N5bnRheF90IGlnbm9yZWQpCitGY29tcGlsZSAoY2hhciAqcGF0dGVybiwgc2l6 ZV90IHNpemUsIHJlZ19zeW50YXhfdCBpZ25vcmVkLCBib29sIGV4YWN0KQogewogICBrd3NldF90 IGt3c2V0OwogICBjaGFyICpidWYgPSBOVUxMOwpAQCAtMTc4LDcgKzE3OCw3IEBAIEZleGVjdXRl ICh2b2lkICp2Y3AsIGNoYXIgY29uc3QgKmJ1Ziwgc2l6ZV90IHNpemUsIHNpemVfdCAqbWF0Y2hf c2l6ZSwKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgZmdyZXBfdG9fZ3JlcF9wYXR0ZXJu ICgma3dzZWFyY2gtPnBhdHRlcm4sICZrd3NlYXJjaC0+c2l6ZSk7CiAgICAgICAgICAgICAgIGt3 c2VhcmNoLT5yZSA9IEdFQWNvbXBpbGUgKGt3c2VhcmNoLT5wYXR0ZXJuLCBrd3NlYXJjaC0+c2l6 ZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUkVfU1lOVEFYX0dS RVApOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBSRV9TWU5UQVhf R1JFUCwgISFzdGFydF9wdHIpOwogICAgICAgICAgICAgfQogICAgICAgICAgIHJldHVybiBFR2V4 ZWN1dGUgKGt3c2VhcmNoLT5yZSwgYnVmLCBzaXplLCBtYXRjaF9zaXplLCBzdGFydF9wdHIpOwog ICAgICAgICB9CkBAIC0yNDUsNyArMjQ1LDcgQEAgRmV4ZWN1dGUgKHZvaWQgKnZjcCwgY2hhciBj b25zdCAqYnVmLCBzaXplX3Qgc2l6ZSwgc2l6ZV90ICptYXRjaF9zaXplLAogICAgICAgICAgICAg ICAgICAgICBmZ3JlcF90b19ncmVwX3BhdHRlcm4gKCZrd3NlYXJjaC0+cGF0dGVybiwgJmt3c2Vh cmNoLT5zaXplKTsKICAgICAgICAgICAgICAgICAgICAga3dzZWFyY2gtPnJlID0gR0VBY29tcGls ZSAoa3dzZWFyY2gtPnBhdHRlcm4sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGt3c2VhcmNoLT5zaXplLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBSRV9TWU5UQVhfR1JFUCk7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFJFX1NZTlRBWF9HUkVQLCAhIXN0YXJ0X3B0cik7 CiAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgaWYgKGJlZyArIGxlbiA8IGJ1 ZiArIHNpemUpCiAgICAgICAgICAgICAgICAgICB7CmRpZmYgLS1naXQgYS9zcmMvcGNyZXNlYXJj aC5jIGIvc3JjL3BjcmVzZWFyY2guYwppbmRleCBhNjY4YzQ1Li42Nzk4OTY3IDEwMDY0NAotLS0g YS9zcmMvcGNyZXNlYXJjaC5jCisrKyBiL3NyYy9wY3Jlc2VhcmNoLmMKQEAgLTExMyw3ICsxMTMs NyBAQCBqaXRfZXhlYyAoc3RydWN0IHBjcmVfY29tcCAqcGMsIGNoYXIgY29uc3QgKnN1YmplY3Qs IGludCBzZWFyY2hfYnl0ZXMsCiAgICBmb2xsb3dlZCBieSAnXG4nLiAgUmV0dXJuIGEgZGVzY3Jp cHRpb24gb2YgdGhlIGNvbXBpbGVkIHBhdHRlcm4uICAqLwoKIHZvaWQgKgotUGNvbXBpbGUgKGNo YXIgKnBhdHRlcm4sIHNpemVfdCBzaXplLCByZWdfc3ludGF4X3QgaWdub3JlZCkKK1Bjb21waWxl IChjaGFyICpwYXR0ZXJuLCBzaXplX3Qgc2l6ZSwgcmVnX3N5bnRheF90IGlnbm9yZWQsIGJvb2wg ZXhhY3QpCiB7CiAgIGludCBlOwogICBjaGFyIGNvbnN0ICplcDsKZGlmZiAtLWdpdCBhL3NyYy9z ZWFyY2guaCBiL3NyYy9zZWFyY2guaAppbmRleCAxZDg1YTdlLi5hZjgxZGNiIDEwMDY0NAotLS0g YS9zcmMvc2VhcmNoLmgKKysrIGIvc3JjL3NlYXJjaC5oCkBAIC01NiwxNSArNTYsMTUgQEAgZXh0 ZXJuIHB0cmRpZmZfdCBtYl9nb2JhY2sgKGNoYXIgY29uc3QgKiosIHNpemVfdCAqLCBjaGFyIGNv bnN0ICosCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2hhciBjb25zdCAqKTsKCiAvKiBk ZmFzZWFyY2guYyAqLwotZXh0ZXJuIHZvaWQgKkdFQWNvbXBpbGUgKGNoYXIgKiwgc2l6ZV90LCBy ZWdfc3ludGF4X3QpOworZXh0ZXJuIHZvaWQgKkdFQWNvbXBpbGUgKGNoYXIgKiwgc2l6ZV90LCBy ZWdfc3ludGF4X3QsIGJvb2wpOwogZXh0ZXJuIHNpemVfdCBFR2V4ZWN1dGUgKHZvaWQgKiwgY2hh ciBjb25zdCAqLCBzaXplX3QsIHNpemVfdCAqLCBjaGFyIGNvbnN0ICopOwoKIC8qIGt3c2VhcmNo LmMgKi8KLWV4dGVybiB2b2lkICpGY29tcGlsZSAoY2hhciAqLCBzaXplX3QsIHJlZ19zeW50YXhf dCk7CitleHRlcm4gdm9pZCAqRmNvbXBpbGUgKGNoYXIgKiwgc2l6ZV90LCByZWdfc3ludGF4X3Qs IGJvb2wpOwogZXh0ZXJuIHNpemVfdCBGZXhlY3V0ZSAodm9pZCAqLCBjaGFyIGNvbnN0ICosIHNp emVfdCwgc2l6ZV90ICosIGNoYXIgY29uc3QgKik7CgogLyogcGNyZXNlYXJjaC5jICovCi1leHRl cm4gdm9pZCAqUGNvbXBpbGUgKGNoYXIgKiwgc2l6ZV90LCByZWdfc3ludGF4X3QpOworZXh0ZXJu IHZvaWQgKlBjb21waWxlIChjaGFyICosIHNpemVfdCwgcmVnX3N5bnRheF90LCBib29sKTsKIGV4 dGVybiBzaXplX3QgUGV4ZWN1dGUgKHZvaWQgKiwgY2hhciBjb25zdCAqLCBzaXplX3QsIHNpemVf dCAqLCBjaGFyIGNvbnN0ICopOwoKIC8qIGdyZXAuYyAqLwotLSAKMi4yOC4wLjU0Ni5nMzg1YzE3 MWEwMQoK --00000000000040c6d205afdc1ee6-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 22 10:54:26 2020 Received: (at 43527) by debbugs.gnu.org; 22 Sep 2020 14:54:26 +0000 Received: from localhost ([127.0.0.1]:32851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKjgY-0000ZN-Dw for submit@debbugs.gnu.org; Tue, 22 Sep 2020 10:54:26 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:55651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKjgV-0000Z7-HJ for 43527@debbugs.gnu.org; Tue, 22 Sep 2020 10:54:24 -0400 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id E71EA80515 for <43527@debbugs.gnu.org>; Tue, 22 Sep 2020 23:54:15 +0900 (JST) X-matriXscan-loop-detect: 4d3a19354b6f0e7668e6c8ecb50c2cba2415cc2a Received: from mail10.kcn.ne.jp ([61.86.6.128]) by mxs01-s with ESMTP; Tue, 22 Sep 2020 23:54:11 +0900 (JST) Received: from [10.120.1.110] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail10.kcn.ne.jp (Postfix) with ESMTPA id 0565741A8F4D; Tue, 22 Sep 2020 23:54:10 +0900 (JST) Date: Tue, 22 Sep 2020 23:54:10 +0900 From: Norihiro Tanaka To: Jim Meyering Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex In-Reply-To: References: Message-Id: <20200922235410.A1D8.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.75.01 [ja] X-matriXscan-msec-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43527 Cc: 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 21 Sep 2020 17:33:25 -0700 Jim Meyering wrote: > On Sun, Sep 20, 2020 at 6:34 PM Jim Meyering wrote: > > > > On Sun, Sep 20, 2020 at 12:17 AM Norihiro Tanaka wrote: > > > Hi, > > > Performace for as following case is fixed in bug#43040. > > > > > > $ yes 0 | head -100000 | sed '$s/././' >pat > > > $ grep -vf pat /dev/null > > > > > > However, still slow and a lot of memory wasted for the following cases. > > > > > > $ grep -vf /usr/share/dict/linux.words /usr/share/dict/linux.words > > > > > > This bug is introduced in commit abb7f4f2325f26f930ff59b702fe42568a8e81e7. > > > Though it's an optimization for patterns with backreferences, it seems > > > to cause performance degradation in many cases due to regex > > > implementation issues. > > > > > > grep needs regex engine when patterns is not supported by DFA engine, > > > and when either given only matching (-o) or color option (--color) is > > > given. > > > > > > In other words, if none of them are met, grep only uses regex to check > > > the syntax. grep avoids compilation of regex not to check syntax by this > > > patch. > > > > Yikes. Thank you! > > That exposes (and fixes in this common case) a problem that makes grep > > require memory that is quadratic in the number of regular expressions. > > > > To illustrate, I ran some timings. > > With only 80,000 lines of /usr/share/dict/linux.words, the following > > would use 100GB of RSS and take 3 minutes. With the fix, it used less > > than 400MB and took less than one second. > > > > head -$N /usr/share/dict/linux.words > w; grep -vf w w > > > > N Mem(k): Old New > > 20000 6341188 (2.4s) 103168 > > 40000 25241288 (9.29s) 199188 (0.31s) > > 80000 100547432 (180s) 392872 (0.66s) > > > > I've just pushed the gnulib-adjusting patch and will push the other soon. > > I'll also add a test and a NEWS item in a separate patch. > > Here are the two patches (tested on top of a third that updates to > latest gnulib). I'll await an 'ok' from Norihiro Tanaka before > pushing, since commit-log metadata is essentially immutable once > pushed. Great, thank you. I confirmed it. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 22 11:50:22 2020 Received: (at 43527) by debbugs.gnu.org; 22 Sep 2020 15:50:22 +0000 Received: from localhost ([127.0.0.1]:33023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKkYg-0002Db-5T for submit@debbugs.gnu.org; Tue, 22 Sep 2020 11:50:22 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKkYf-0002DN-6R for 43527@debbugs.gnu.org; Tue, 22 Sep 2020 11:50:21 -0400 Received: by mail-wm1-f68.google.com with SMTP id e17so3872097wme.0 for <43527@debbugs.gnu.org>; Tue, 22 Sep 2020 08:50:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YRPWftoHYJkcDYdNN5PJMJh2P2B2GhxQYL9BHMuNOpw=; b=Sf+0xNb2rfVcsyrw7Gr0kW0NBzJuwTANVYpuOLEyWps3rTuojKekX0NabjTK2dmF/1 2jaCQearvSYUyAQd1mp4nPSvI6ZJiCpAaTvVHBCYSLDyjtDWLc0ocWWKjf7PI3jxPtVt lbQgPza3JOTl3sQ3WDT/cyYKHchwl9m/cYnnNEBj8OZ3jd/i//+OGP4XJeSF8FjXEcIf v4iVuaqoyKtsluTFK8HAe4Jm8ZkzM/XiM3bPtYD2SXdJrY9SRM/5jyw+8bBHI2hT2KUo L6RI87nmNhNULPJFvJYSoWgqcWyJ2qaVMuKnt/AOYceGkwQcmG2bgn1I82MLg6MBmPdo O5Xg== X-Gm-Message-State: AOAM533tPLgYrPIcy5MwNN4/0rH+0C3gQX72hfs1R+IUappsfn9mPaLg JizX2nX1l3OKiVvF7pAthVKoCdz5d35syKBTRqfmgQcJ X-Google-Smtp-Source: ABdhPJycRgkTBMiU8nFckG+OHiNgiBzwhcPzExuCvuvZIexj5ee6pfIQ3P190/WVVvVleX1fbZOWNIKFA6FvJUH/ciY= X-Received: by 2002:a1c:5f46:: with SMTP id t67mr1659301wmb.71.1600789815359; Tue, 22 Sep 2020 08:50:15 -0700 (PDT) MIME-Version: 1.0 References: <20200922235410.A1D8.27F6AC2D@kcn.ne.jp> In-Reply-To: <20200922235410.A1D8.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Tue, 22 Sep 2020 08:50:03 -0700 Message-ID: Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex To: Norihiro Tanaka Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43527 Cc: 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Tue, Sep 22, 2020 at 7:54 AM Norihiro Tanaka wrote: > On Mon, 21 Sep 2020 17:33:25 -0700 > Jim Meyering wrote: ... > > Here are the two patches (tested on top of a third that updates to > > latest gnulib). I'll await an 'ok' from Norihiro Tanaka before > > pushing, since commit-log metadata is essentially immutable once > > pushed. > > Great, thank you. I confirmed it. Thanks. Pushed. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 22 13:20:04 2020 Received: (at control) by debbugs.gnu.org; 22 Sep 2020 17:20:04 +0000 Received: from localhost ([127.0.0.1]:33236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKlxU-0006gU-1r for submit@debbugs.gnu.org; Tue, 22 Sep 2020 13:20:04 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKlxQ-0006fU-0G for control@debbugs.gnu.org; Tue, 22 Sep 2020 13:20:02 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BD8D31600F3 for ; Tue, 22 Sep 2020 10:19:53 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id GbotY53HxTZu for ; Tue, 22 Sep 2020 10:19:53 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2AF23160101 for ; Tue, 22 Sep 2020 10:19:53 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hQ_5p2pi1n5b for ; Tue, 22 Sep 2020 10:19:53 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0A27E1600F3 for ; Tue, 22 Sep 2020 10:19:53 -0700 (PDT) To: control@debbugs.gnu.org From: Paul Eggert Subject: 43527 is fixed Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDVlFRVEFRZ0FQ d0liQXdZTApDUWdIQXdJR0ZRZ0NDUW9MQkJZQ0F3RUNIZ0VDRjRBV0lRUitONUtwMkt6MzFq TzhGWWp0bCtrT1lxcCtOQVVDClh5Vzlsd1VKRks0THN3QUtDUkR0bCtrT1lxcCtOS05WRC85 SE1zSTE2MDZuMFV1VFhId0lUc3lPakFJOVNET1QKK0MzRFV2NnFsTTVCSDJuV0FNVGlJaXlB NXVnbHNKdjkzb2kydk50RmYvUS9tLzFjblpXZ25WbkV4a3lMSTRFTgpTZDF1QnZyMC9sQ1Nk UGxQME1nNkdXU3BYTXUreDB2ZFQwQWFaTk9URTBGblB1b2xkYzNYRDc2QzJxZzhzWC9pCmF4 WFRLSHk5UCtCbEFxL0NzNy9weERRMEV6U24wVVNaMkMwbDV2djRQTXBBL3BpY25TNks2MDlK dkRHYU9SbXcKWmVYSVpxUU5aVitaUXMrVVl0Vm9ndURUcWJ5M0lVWTFJOEJsWEhScHRhajlB TW40VW9oL0NxcFFsVm9qb3lXbApIcWFGbm5KQktlRjBodko5U0F5YWx3dXpBakc3dlFXMDdN WW5jYU9GbTB3b2lLYmc1SkxPOEY0U0JUSWt1TzBECkNmOW5MQWF5NlZzQjRyendkRWZSd2pQ TFlBbjdNUjNmdkhDRXpmcmtsZFRyYWlCTzFUMGllREs4MEk3c0xmNnAKTWVDWUkxOXBVbHgw L05STUdDZGRpRklRZGZ0aEtXWEdSUzVMQXM4andCZjhINkc1UFdpblByRUlhb21JUDIxaQp2 dWhRRDA3YllxOUlpSWRlbGpqVWRIY0dJMGkvQjRNNTZaYWE4RmYzOGluaU9sckRZQ21ZV1I0 ZENXWml1UWVaCjNPZ3FlUXM5YTZqVHZnZERHVm1SVnFZK2p6azhQbGFIZmNvazhST2hGY0hL a2NmaHVCaEwyNWhsUklzaFJET0UKc2tYcUt3bnpyYnFnYTNHWFpYZnNYQW9GYnpOaExkTHY5 QStMSkFZU2tYUDYvNXFkVHBFTFZHb3N5SDg4NFZkYgpCcGtHSTA0b1lWcXVsYmtDRFFSTWdI SmtBUkFBcG9YcnZ4UDNESWZqQ05PdFhVL1Bkd01TaEtkWC9SbFNzNVBmCnVuVjF3YktQOGhl clhIcnZRZEZWcUVDYVRTeG1saHpiazhYMFBrWTlnY1ZhVTJPNDlUM3FzT2QxY0hlRjUyWUYK R0V0MExoc0JlTWpnTlg1dVoxVjc2cjhneWVWbEZwV1diMFNJd0pVQkhyRFhleEY2N3VwZVJi MnZkSEJqWUROZQp5U24rMEI3Z0ZFcXZWbVp1K0xhZHVkRHA2a1FMamF0RnZIUUhVU0dOc2hC bmtrY2FUYmlJOVBzdDBHQ2MyYWl6Cm5CaVBQQTJXUXhBUGxQUmgzT0dUc241VEhBRG1ianFZ NkZFTUxhc1ZYOERTQ2JsTXZMd05lTy84U3h6aUJpZGgKcUxwSkNxZFFSV0hrdTVYeGdJa0dl S096NU9MRHZYSFdKeWFmckVZamprUzZBazZCNXo2c3ZLbGlDbFduakhRYwpqbFB6eW9GRmdL VEVmY3FEeENqNFJZMEQwRGd0RkQwTmZ5ZU9pZHJTQi9TelRlMmh3cnlRRTNycFNpcW8rMGNH CmR6aDR5QUhLWUorVXJYWjRwOTNaaGpHZktEMXhsck5ZRGxXeVc5UEdtYnZxRnVEbWlJQVFm OVdEL3d6RWZJQ2MKK0YrdURESSt1WWtSeFVGcDkyeWttZGhERUZnMXlqWXNVOGlHVTY5YUh5 dmhxMzZ6NHpjdHZicWhSTnpPV0IxYgpWSi9kSU1EdnNFeEdjWFFWRElUN3NETlh2MHdFM2pL U0twcDdOREcxb1hVWEwrMitTRjk5S2p5NzUzQWJRU0FtCkg2MTdmeUJOd2hKV3ZRWWcrbVV2 UHBpR090c2VzOUVYVUkzbFM0djBNRWFQRzQzZmxFczFVUisxcnBGUVdWSG8KMXkxT08rc0FF UUVBQVlrQ1BBUVlBUWdBSmdJYkRCWWhCSDQza3FuWXJQZldNN3dWaU8yWDZRNWlxbjQwQlFK ZgpKYjJ6QlFrVXJndlBBQW9KRU8yWDZRNWlxbjQwY25NUC8xN0NnVWtYVDlhSUpyaVBNOHdi Y2VZcmNsNytiZFlFCmY3OVNsd1NiYkhON1I0Q29JSkZPbE45Uy8zNHR5cEdWWXZwZ21DSkRZ RlRCeHlQTzkyaU1YRGdBNCtjV0h6dDUKVDFhWU85aHNLaGg3dkR0Sys2UHJvWkdjKzA4Z1VU WEhoYjk3aE1NUWhrbkpsbmZqcFNFQzllbTkwNkZVK0k5MwpUMWZUR3VwbkJhM2FXY0s4ak0w SmFCR2J5MmhHMVMzb2xhRExTVHRCSU5OQlltdnVXUjlNS09oaHFEcmxrNWN3CkZESkxoNU5y WHRlRVkwOFdBemNMekczcGtyWFBIa0ZlTVF0ZnFrMGpMZEdHdkdDM05DSWtxWXJkTGhpUnZH cHIKdTM4QzI2UkVuNWY0STB2R0UzVmZJWEhlOFRNQ05tUXV0MU50TXVVbXBESXkxYUx4R3p1 cHRVaG5PSk4vL3IrVgpqRFBvaTNMT3lTTllwaHFlL2RNdWJzZlVyNm9oUDQxbUtGODFGdXdJ NGFtcUp0cnFJTDJ5cWF4M2EwcWxmd0N4ClhmdGllcUpjdWVrWCtlQ1BEQ0tyWU1YUjBGWWd3 cEcySVRaVUd0ckVqRVNsRTZEc2N4NzM0SEtkcjVPUklvY0wKVVVLRU9HZWlVNkRHaEdGZGI1 VHd1MFNuK3UxbVVQRE4wTSsrQ2RNdkNsSUU4a2xvNEc5MUVPSW11MVVwYjh4YwpPUFF3eGgx andxU3JVNVF3b05tU1llZ1FTSExwSVV1ckZ6MWlRVWgxdnBQWHpLaW5rV0VxdjRJcUExY2lM K0x5CnlTdUxrcDdNc0pwVlJNYldKQ05XT09TYmFING9EQko1ZEhNR2MzNXg1bW9zQ2s5MFBY a251RkREc1lIZkRvNXMKbWY5bG82WVh4N045Cj0zTGFJCi0tLS0tRU5EIFBHUCBQVUJMSUMg S0VZIEJMT0NLLS0tLS0K Organization: UCLA Computer Science Department Message-ID: Date: Tue, 22 Sep 2020 10:19:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 43527 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 22 18:57:46 2020 Received: (at 43527) by debbugs.gnu.org; 22 Sep 2020 22:57:46 +0000 Received: from localhost ([127.0.0.1]:33693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKrEE-0006ce-NW for submit@debbugs.gnu.org; Tue, 22 Sep 2020 18:57:46 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:54926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKrEC-0006cP-Nt for 43527@debbugs.gnu.org; Tue, 22 Sep 2020 18:57:41 -0400 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 5FC5780754 for <43527@debbugs.gnu.org>; Wed, 23 Sep 2020 07:57:33 +0900 (JST) X-matriXscan-loop-detect: 7abd499cf073e2fd7c55e3477bd8e8c2eb66c3ed Received: from mail14.kcn.ne.jp ([61.86.6.132]) by mxs01-s with ESMTP; Wed, 23 Sep 2020 07:57:31 +0900 (JST) Received: from [10.120.1.110] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail14.kcn.ne.jp (Postfix) with ESMTPA id 3771340E32C7; Wed, 23 Sep 2020 07:57:31 +0900 (JST) Date: Wed, 23 Sep 2020 07:57:30 +0900 From: Norihiro Tanaka To: Jim Meyering Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex In-Reply-To: References: <20200922235410.A1D8.27F6AC2D@kcn.ne.jp> Message-Id: <20200923075730.64FF.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5F6A8045000000006506_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.75.01 [ja] X-matriXscan-msec-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43527 Cc: 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --------_5F6A8045000000006506_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On Tue, 22 Sep 2020 08:50:03 -0700 Jim Meyering wrote: > On Tue, Sep 22, 2020 at 7:54 AM Norihiro Tanaka wrote: > > On Mon, 21 Sep 2020 17:33:25 -0700 > > Jim Meyering wrote: > ... > > > Here are the two patches (tested on top of a third that updates to > > > latest gnulib). I'll await an 'ok' from Norihiro Tanaka before > > > pushing, since commit-log metadata is essentially immutable once > > > pushed. > > > > Great, thank you. I confirmed it. > > Thanks. Pushed. Oh, I found a bug for this fix. If Fexecute is called first without start_ptr and next with start_ptr, it may break. --------_5F6A8045000000006506_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-grep-fix-a-bug-in-the-previous-commit.patch" Content-Disposition: attachment; filename="0001-grep-fix-a-bug-in-the-previous-commit.patch" Content-Transfer-Encoding: base64 RnJvbSA1Mjk5NmRhNDFjOWQ0MzBhYzRkOWE2OTMyNjM0ZmQxMjQ5NWJiOGYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBXZWQsIDIzIFNlcCAyMDIwIDA3OjMzOjMyICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogZml4IGEgYnVnIGluIHRoZSBwcmV2aW91cyBjb21taXQKCiogc3JjL2t3c2VhcmNoLmMgKHN0 cnVjdCBrd3NlYXJjaCk6IEFkZCBuZXcgbWVtYmVyLgooRmV4ZWN1dGUpOiBVc2UgaXQuCi0tLQog c3JjL2t3c2VhcmNoLmMgfCAgICA4ICsrKysrKy0tCiAxIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMva3dzZWFyY2guYyBiL3Ny Yy9rd3NlYXJjaC5jCmluZGV4IDExNzRkYmMuLjgyMDM1MmIgMTAwNjQ0Ci0tLSBhL3NyYy9rd3Nl YXJjaC5jCisrKyBiL3NyYy9rd3NlYXJjaC5jCkBAIC0zOCw2ICszOCw5IEBAIHN0cnVjdCBrd3Nl YXJjaAogICBjaGFyICpwYXR0ZXJuOwogICBzaXplX3Qgc2l6ZTsKIAorICAvKiBUcnVlIHdoZW4g dGhlIHByZWNpc2lvbiBvZiBlaXRoZXIgLW8gb3IgLS1jb2xvciBpcyByZXF1aXJlZC4gICovCisg IGJvb2wgZXhhY3Q7CisKICAgLyogVGhlIHVzZXIncyBwYXR0ZXJuIGNvbXBpbGVkIGFzIGEgcmVn dWxhciBleHByZXNzaW9uLAogICAgICBvciBudWxsIGlmIGl0IGhhcyBub3QgYmVlbiBjb21waWxl ZC4gICovCiAgIHZvaWQgKnJlOwpAQCAtMTI4LDYgKzEzMSw3IEBAIEZjb21waWxlIChjaGFyICpw YXR0ZXJuLCBzaXplX3Qgc2l6ZSwgcmVnX3N5bnRheF90IGlnbm9yZWQsIGJvb2wgZXhhY3QpCiAg IGt3c2VhcmNoLT53b3JkcyA9IHdvcmRzOwogICBrd3NlYXJjaC0+cGF0dGVybiA9IHBhdHRlcm47 CiAgIGt3c2VhcmNoLT5zaXplID0gc2l6ZTsKKyAga3dzZWFyY2gtPmV4YWN0ID0gZXhhY3Q7CiAg IGt3c2VhcmNoLT5yZSA9IE5VTEw7CiAgIHJldHVybiBrd3NlYXJjaDsKIH0KQEAgLTE3OCw3ICsx ODIsNyBAQCBGZXhlY3V0ZSAodm9pZCAqdmNwLCBjaGFyIGNvbnN0ICpidWYsIHNpemVfdCBzaXpl LCBzaXplX3QgKm1hdGNoX3NpemUsCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgIGZncmVw X3RvX2dyZXBfcGF0dGVybiAoJmt3c2VhcmNoLT5wYXR0ZXJuLCAma3dzZWFyY2gtPnNpemUpOwog ICAgICAgICAgICAgICBrd3NlYXJjaC0+cmUgPSBHRUFjb21waWxlIChrd3NlYXJjaC0+cGF0dGVy biwga3dzZWFyY2gtPnNpemUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFJFX1NZTlRBWF9HUkVQLCAhIXN0YXJ0X3B0cik7CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIFJFX1NZTlRBWF9HUkVQLCBrd3NlYXJjaC0+ZXhhY3QpOwogICAg ICAgICAgICAgfQogICAgICAgICAgIHJldHVybiBFR2V4ZWN1dGUgKGt3c2VhcmNoLT5yZSwgYnVm LCBzaXplLCBtYXRjaF9zaXplLCBzdGFydF9wdHIpOwogICAgICAgICB9CkBAIC0yNDUsNyArMjQ5 LDcgQEAgRmV4ZWN1dGUgKHZvaWQgKnZjcCwgY2hhciBjb25zdCAqYnVmLCBzaXplX3Qgc2l6ZSwg c2l6ZV90ICptYXRjaF9zaXplLAogICAgICAgICAgICAgICAgICAgICBmZ3JlcF90b19ncmVwX3Bh dHRlcm4gKCZrd3NlYXJjaC0+cGF0dGVybiwgJmt3c2VhcmNoLT5zaXplKTsKICAgICAgICAgICAg ICAgICAgICAga3dzZWFyY2gtPnJlID0gR0VBY29tcGlsZSAoa3dzZWFyY2gtPnBhdHRlcm4sCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGt3c2VhcmNoLT5z aXplLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBSRV9T WU5UQVhfR1JFUCwgISFzdGFydF9wdHIpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBSRV9TWU5UQVhfR1JFUCwga3dzZWFyY2gtPmV4YWN0KTsKICAgICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBpZiAoYmVnICsgbGVuIDwgYnVmICsgc2l6 ZSkKICAgICAgICAgICAgICAgICAgIHsKLS0gCjEuNy4xCgo= --------_5F6A8045000000006506_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 22 19:25:27 2020 Received: (at 43527) by debbugs.gnu.org; 22 Sep 2020 23:25:27 +0000 Received: from localhost ([127.0.0.1]:33730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKrf5-0007IP-F2 for submit@debbugs.gnu.org; Tue, 22 Sep 2020 19:25:27 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKrf2-0007IB-Sb for 43527@debbugs.gnu.org; Tue, 22 Sep 2020 19:25:25 -0400 Received: by mail-wm1-f66.google.com with SMTP id z9so5063790wmk.1 for <43527@debbugs.gnu.org>; Tue, 22 Sep 2020 16:25:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8uOaheBG/G+dXGtKodWkXrRVtAiNn0nuY0i/VD0BV7E=; b=Z4BLMtokjyajV8Nvd1takHNQw2qzAWce/swKObWM0Ap91eNaGZ75NzUb7oBcK22zm8 i+pyZpZn4cIlAqaUS33MjQp4KYVgMYJ3huzpZt7UwIFB0yRZ6M+RgcBlk4oXH1ustnNE 7FkMpJ1pirKP2GigXJKq7ltTss3h0GyS3O0HVJXz/r1/qsYUrCFv9qmf1/ef1lWvyqrk zUP81LDIZdHDZOFUSN0zyQ/alZ/POsKrWYd9gc11KVnXHgk5XnWg+h74b9kEX3lfTAuS yPGPpTgC3/aLs/I6DwH1hwwuAzYAKU+UgBpDsAs4nMscJg3gFMbfzSNtIeaUBt+drBw1 Z24A== X-Gm-Message-State: AOAM532g1lJ3PDceF38nGtAetu47Tzja9QzghN9M5ugx164vQsgRFQO8 N8oJcraS1jeeG//4lY8mVRIODDwr/2B92OX65Qg= X-Google-Smtp-Source: ABdhPJyPD/XlAcXYDZ+NZV13z9wEPM+WBc/nHK62kmp06tz75OArB1advAkTdY1q6tckJhJ72iP8Wa/oVzb2Eianb8s= X-Received: by 2002:a1c:8109:: with SMTP id c9mr3358464wmd.130.1600817119058; Tue, 22 Sep 2020 16:25:19 -0700 (PDT) MIME-Version: 1.0 References: <20200922235410.A1D8.27F6AC2D@kcn.ne.jp> <20200923075730.64FF.27F6AC2D@kcn.ne.jp> In-Reply-To: <20200923075730.64FF.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Tue, 22 Sep 2020 16:25:06 -0700 Message-ID: Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex To: Norihiro Tanaka Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43527 Cc: 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Tue, Sep 22, 2020 at 3:57 PM Norihiro Tanaka wrote: > On Tue, 22 Sep 2020 08:50:03 -0700 > Jim Meyering wrote: > > > On Tue, Sep 22, 2020 at 7:54 AM Norihiro Tanaka wrote: > > > On Mon, 21 Sep 2020 17:33:25 -0700 > > > Jim Meyering wrote: > > ... > > > > Here are the two patches (tested on top of a third that updates to > > > > latest gnulib). I'll await an 'ok' from Norihiro Tanaka before > > > > pushing, since commit-log metadata is essentially immutable once > > > > pushed. > > > > > > Great, thank you. I confirmed it. > > > > Thanks. Pushed. > > Oh, I found a bug for this fix. If Fexecute is called first without > start_ptr and next with start_ptr, it may break. Oh! Good timing. I was about to make a new snapshot. Do you happen to have a test case handy that demonstrates the failure? From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 22 23:04:40 2020 Received: (at 43527) by debbugs.gnu.org; 23 Sep 2020 03:04:40 +0000 Received: from localhost ([127.0.0.1]:34104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKv5E-0004Ti-CF for submit@debbugs.gnu.org; Tue, 22 Sep 2020 23:04:40 -0400 Received: from mailgw03.kcn.ne.jp ([61.86.7.210]:57985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKv5A-0004TH-5t for 43527@debbugs.gnu.org; Tue, 22 Sep 2020 23:04:39 -0400 Received: from mxs02-s (mailgw2.kcn.ne.jp [61.86.15.234]) by mailgw03.kcn.ne.jp (Postfix) with ESMTP id DDFAF13F6E4 for <43527@debbugs.gnu.org>; Wed, 23 Sep 2020 12:04:28 +0900 (JST) X-matriXscan-loop-detect: c15b5a539c0be2816e94b14613392eb5a20549b4 Received: from mail13.kcn.ne.jp ([61.86.6.131]) by mxs02-s with ESMTP; Wed, 23 Sep 2020 12:04:27 +0900 (JST) Received: from [10.120.1.110] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail13.kcn.ne.jp (Postfix) with ESMTPA id 36FF241330B9; Wed, 23 Sep 2020 12:04:27 +0900 (JST) Date: Wed, 23 Sep 2020 12:04:26 +0900 From: Norihiro Tanaka To: Jim Meyering Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex In-Reply-To: References: <20200923075730.64FF.27F6AC2D@kcn.ne.jp> Message-Id: <20200923112259.6507.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5F6AAFFE000000006513_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.75.01 [ja] X-matriXscan-msec-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43527 Cc: 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --------_5F6AAFFE000000006513_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On Tue, 22 Sep 2020 16:25:06 -0700 Jim Meyering wrote: > Oh! Good timing. I was about to make a new snapshot. > Do you happen to have a test case handy that demonstrates the failure? I added test case to previous patch. By the way, I found the following bug in making the test case, and it's still left. $ env LC_ALL=tr_TR.utf8 grep -Fio i in Aborted (core dumped) (gdb) bt #0 0x0000003b8d032495 in raise () from /lib64/libc.so.6 #1 0x0000003b8d033c75 in abort () from /lib64/libc.so.6 #2 0x000000000040cdde in kwsinit (mb_trans=true) at searchutils.c:64 #3 0x0000000000409624 in Fcompile (pattern=0x23c1240 "i\n", size=1, ignored=0, exact=true) at kwsearch.c:56 #4 0x0000000000409378 in main (argc=4, argv=0x7ffe76048388) at grep.c:2977 --------_5F6AAFFE000000006513_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-grep-fix-a-bug-in-the-previous-commit.patch" Content-Disposition: attachment; filename="0001-grep-fix-a-bug-in-the-previous-commit.patch" Content-Transfer-Encoding: base64 RnJvbSA2MTE4YzNlZTE0YzYxMzFlYzU0NDI0NGIxZmFiZjA1YzNhOTEzYmQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBXZWQsIDIzIFNlcCAyMDIwIDA3OjMzOjMyICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogZml4IGEgYnVnIGluIHRoZSBwcmV2aW91cyBjb21taXQKCiogc3JjL2t3c2VhcmNoLmMgKHN0 cnVjdCBrd3NlYXJjaCk6IEFkZCBuZXcgbWVtYmVyLgooRmV4ZWN1dGUpOiBVc2UgaXQuCiogdGVz dHMvaW5jb21wbGV0ZS1yZWdleDogQWRkIHRlc3QgZm9yIHRoZSBjaGFuZ2VzLgoqIHRlc3RzL01h a2VmaWxlLmFtOiBSdW4gdGhlIG5ldyB0ZXN0LgotLS0KIHNyYy9rd3NlYXJjaC5jICAgICAgICAg fCAgICA4ICsrKysrKy0tCiB0ZXN0cy9NYWtlZmlsZS5hbSAgICAgIHwgICAgMSArCiB0ZXN0cy9p bmNvbXBsZXRlLXJlZ2V4IHwgICAyMCArKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFu Z2VkLCAyNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNzU1 IHRlc3RzL2luY29tcGxldGUtcmVnZXgKCmRpZmYgLS1naXQgYS9zcmMva3dzZWFyY2guYyBiL3Ny Yy9rd3NlYXJjaC5jCmluZGV4IDExNzRkYmMuLjgyMDM1MmIgMTAwNjQ0Ci0tLSBhL3NyYy9rd3Nl YXJjaC5jCisrKyBiL3NyYy9rd3NlYXJjaC5jCkBAIC0zOCw2ICszOCw5IEBAIHN0cnVjdCBrd3Nl YXJjaAogICBjaGFyICpwYXR0ZXJuOwogICBzaXplX3Qgc2l6ZTsKIAorICAvKiBUcnVlIHdoZW4g dGhlIHByZWNpc2lvbiBvZiBlaXRoZXIgLW8gb3IgLS1jb2xvciBpcyByZXF1aXJlZC4gICovCisg IGJvb2wgZXhhY3Q7CisKICAgLyogVGhlIHVzZXIncyBwYXR0ZXJuIGNvbXBpbGVkIGFzIGEgcmVn dWxhciBleHByZXNzaW9uLAogICAgICBvciBudWxsIGlmIGl0IGhhcyBub3QgYmVlbiBjb21waWxl ZC4gICovCiAgIHZvaWQgKnJlOwpAQCAtMTI4LDYgKzEzMSw3IEBAIEZjb21waWxlIChjaGFyICpw YXR0ZXJuLCBzaXplX3Qgc2l6ZSwgcmVnX3N5bnRheF90IGlnbm9yZWQsIGJvb2wgZXhhY3QpCiAg IGt3c2VhcmNoLT53b3JkcyA9IHdvcmRzOwogICBrd3NlYXJjaC0+cGF0dGVybiA9IHBhdHRlcm47 CiAgIGt3c2VhcmNoLT5zaXplID0gc2l6ZTsKKyAga3dzZWFyY2gtPmV4YWN0ID0gZXhhY3Q7CiAg IGt3c2VhcmNoLT5yZSA9IE5VTEw7CiAgIHJldHVybiBrd3NlYXJjaDsKIH0KQEAgLTE3OCw3ICsx ODIsNyBAQCBGZXhlY3V0ZSAodm9pZCAqdmNwLCBjaGFyIGNvbnN0ICpidWYsIHNpemVfdCBzaXpl LCBzaXplX3QgKm1hdGNoX3NpemUsCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgIGZncmVw X3RvX2dyZXBfcGF0dGVybiAoJmt3c2VhcmNoLT5wYXR0ZXJuLCAma3dzZWFyY2gtPnNpemUpOwog ICAgICAgICAgICAgICBrd3NlYXJjaC0+cmUgPSBHRUFjb21waWxlIChrd3NlYXJjaC0+cGF0dGVy biwga3dzZWFyY2gtPnNpemUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFJFX1NZTlRBWF9HUkVQLCAhIXN0YXJ0X3B0cik7CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIFJFX1NZTlRBWF9HUkVQLCBrd3NlYXJjaC0+ZXhhY3QpOwogICAg ICAgICAgICAgfQogICAgICAgICAgIHJldHVybiBFR2V4ZWN1dGUgKGt3c2VhcmNoLT5yZSwgYnVm LCBzaXplLCBtYXRjaF9zaXplLCBzdGFydF9wdHIpOwogICAgICAgICB9CkBAIC0yNDUsNyArMjQ5 LDcgQEAgRmV4ZWN1dGUgKHZvaWQgKnZjcCwgY2hhciBjb25zdCAqYnVmLCBzaXplX3Qgc2l6ZSwg c2l6ZV90ICptYXRjaF9zaXplLAogICAgICAgICAgICAgICAgICAgICBmZ3JlcF90b19ncmVwX3Bh dHRlcm4gKCZrd3NlYXJjaC0+cGF0dGVybiwgJmt3c2VhcmNoLT5zaXplKTsKICAgICAgICAgICAg ICAgICAgICAga3dzZWFyY2gtPnJlID0gR0VBY29tcGlsZSAoa3dzZWFyY2gtPnBhdHRlcm4sCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGt3c2VhcmNoLT5z aXplLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBSRV9T WU5UQVhfR1JFUCwgISFzdGFydF9wdHIpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBSRV9TWU5UQVhfR1JFUCwga3dzZWFyY2gtPmV4YWN0KTsKICAgICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBpZiAoYmVnICsgbGVuIDwgYnVmICsgc2l6 ZSkKICAgICAgICAgICAgICAgICAgIHsKZGlmZiAtLWdpdCBhL3Rlc3RzL01ha2VmaWxlLmFtIGIv dGVzdHMvTWFrZWZpbGUuYW0KaW5kZXggODNlNzA4Ny4uYTRkOWE4MCAxMDA2NDQKLS0tIGEvdGVz dHMvTWFrZWZpbGUuYW0KKysrIGIvdGVzdHMvTWFrZWZpbGUuYW0KQEAgLTExMyw2ICsxMTMsNyBA QCBURVNUUyA9CQkJCQkJXAogICBoaWdoLWJpdC1yYW5nZQkJCQlcCiAgIGluLWVxLW91dC1pbmZs b29wCQkJCVwKICAgaW5jbHVkZS1leGNsdWRlCQkJCVwKKyAgaW5jb21wbGV0ZS1yZWdleAkJCQlc CiAgIGluY29uc2lzdGVudC1yYW5nZQkJCQlcCiAgIGluaXRpYWwtdGFiCQkJCQlcCiAgIGludmFs aWQtbXVsdGlieXRlLWluZmxvb3AJCQlcCmRpZmYgLS1naXQgYS90ZXN0cy9pbmNvbXBsZXRlLXJl Z2V4IGIvdGVzdHMvaW5jb21wbGV0ZS1yZWdleApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAw MDAwMDAwLi5kNWJmMzc1Ci0tLSAvZGV2L251bGwKKysrIGIvdGVzdHMvaW5jb21wbGV0ZS1yZWdl eApAQCAtMCwwICsxLDIwIEBACisjISAvYmluL3NoCisjIFRlc3QgZm9yIHRoZSBidWcgaW4gZ3Jl cCAtRmlvCisjCisjIENvcHlyaWdodCAoQykgMjAyMCBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24s IEluYy4KKyMKKyMgQ29weWluZyBhbmQgZGlzdHJpYnV0aW9uIG9mIHRoaXMgZmlsZSwgd2l0aCBv ciB3aXRob3V0IG1vZGlmaWNhdGlvbiwKKyMgYXJlIHBlcm1pdHRlZCBpbiBhbnkgbWVkaXVtIHdp dGhvdXQgcm95YWx0eSBwcm92aWRlZCB0aGUgY29weXJpZ2h0CisjIG5vdGljZSBhbmQgdGhpcyBu b3RpY2UgYXJlIHByZXNlcnZlZC4KKworLiAiJHtzcmNkaXI9Ln0vaW5pdC5zaCI7IHBhdGhfcHJl cGVuZF8gLi4vc3JjCityZXF1aXJlX2VuX3V0ZjhfbG9jYWxlXworCitmYWlsPTAKKworcHJpbnRm ICdcMzA0XDI2MVxuJyA+aW4gfHwgZnJhbWV3b3JrX2ZhaWx1cmVfCisKK0xDX0FMTD1lbl9VUy5V VEYtOCBncmVwIC1GaW8gaSBpbiA+b3V0Citjb21wYXJlIGluIG91dCB8fCBmYWlsPTEKKworRXhp dCAkZmFpbAotLSAKMS43LjEKCg== --------_5F6AAFFE000000006513_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 23 23:00:31 2020 Received: (at 43527) by debbugs.gnu.org; 24 Sep 2020 03:00:31 +0000 Received: from localhost ([127.0.0.1]:38301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLHUl-0003Rs-Id for submit@debbugs.gnu.org; Wed, 23 Sep 2020 23:00:31 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLHUj-0003Rf-7k for 43527@debbugs.gnu.org; Wed, 23 Sep 2020 23:00:30 -0400 Received: by mail-wr1-f66.google.com with SMTP id s12so2061617wrw.11 for <43527@debbugs.gnu.org>; Wed, 23 Sep 2020 20:00:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=z7tizDxgbcL/TvZLwynb8VegKIJkme9yerY/fhG2yEY=; b=lDZXiuVZm8V4m8WMIxq11uvag//dTGgHr+Usf0nk4FEqOgcoKZQOjmcaFghOLoClTh d9FTdI3o2SK+tbtJAgrsMYwHQWwCY6omVf88MHRvvoLnHvhw7x8KH5y28mqaX/tIk73l /nBNudqJvyaRE6qwPLRkvvaSKHhUH0p8CgxoZBBDm3VMbArzxpcYU0oyPMH8tjQ3JX8+ OMlECL9DmBPs6jqXSFvYdSv2uVbIhezXpWgi2R2H1QG4YtSTmu8jAmOgQWt/9h6bOToy N7y49WoIAxHxSKlJxQcMFJNHQ26hQBzzV9wZFRXU6U4850jFZp0Z9+IvSwvzeMPnJnmw s1xg== X-Gm-Message-State: AOAM533j0uJBO3axhdUcy5gMcacilc83DCOdYNBsgX2B9VhuFNStuRv8 uAjQ1UNnCP3CcPu0cg2kGL3CjBrEOE4WqGYi2G0= X-Google-Smtp-Source: ABdhPJzcxJgLAkSlBYTsrBsUVZAc5l5sO4N35QEMNsVHkU8mloOJG+07G9YupdCB1BEkK/WRb3JSbt9ynvRMamV1AMA= X-Received: by 2002:adf:9e43:: with SMTP id v3mr2617162wre.306.1600916423246; Wed, 23 Sep 2020 20:00:23 -0700 (PDT) MIME-Version: 1.0 References: <20200923075730.64FF.27F6AC2D@kcn.ne.jp> <20200923112259.6507.27F6AC2D@kcn.ne.jp> In-Reply-To: <20200923112259.6507.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Wed, 23 Sep 2020 20:00:11 -0700 Message-ID: Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex To: Norihiro Tanaka Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43527 Cc: 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Tue, Sep 22, 2020 at 8:04 PM Norihiro Tanaka wrote: > On Tue, 22 Sep 2020 16:25:06 -0700 > Jim Meyering wrote: > > > Oh! Good timing. I was about to make a new snapshot. > > Do you happen to have a test case handy that demonstrates the failure? > > I added test case to previous patch. Thank you, I expect to push it shortly, along with a gnulib-sync diff, to pull in Paul's regex fixes. > By the way, I found the following bug in making the test case, and it's > still left. > > $ env LC_ALL=3Dtr_TR.utf8 grep -Fio i in > Aborted (core dumped) > > (gdb) bt > #0 0x0000003b8d032495 in raise () from /lib64/libc.so.6 > #1 0x0000003b8d033c75 in abort () from /lib64/libc.so.6 > #2 0x000000000040cdde in kwsinit (mb_trans=3Dtrue) at searchutils.c:64 > #3 0x0000000000409624 in Fcompile (pattern=3D0x23c1240 "i\n", size=3D1, = ignored=3D0, exact=3Dtrue) at kwsearch.c:56 > #4 0x0000000000409378 in main (argc=3D4, argv=3D0x7ffe76048388) at grep.= c:2977 Please tell us what is in your input file named "in" and what type of system you're using. If I guess it's the "in" file from the turkish-eyes test, and try the following (using both your and Paul's patches), I see no failure: $ i=3D$(printf '\304\261') I=3D$(printf '\304\260'); data=3D"I:$I $i:i"; echo "$data" > in; env LC_ALL=3Dtr_TR.utf8 src/grep -Fio i in =C4=B0 i From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 23 23:16:58 2020 Received: (at 43527) by debbugs.gnu.org; 24 Sep 2020 03:16:58 +0000 Received: from localhost ([127.0.0.1]:38311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLHkg-0003om-4j for submit@debbugs.gnu.org; Wed, 23 Sep 2020 23:16:58 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLHkd-0003oY-Lc for 43527@debbugs.gnu.org; Wed, 23 Sep 2020 23:16:56 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 19CF5160089; Wed, 23 Sep 2020 20:16:49 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id xGj-v1DdUnZo; Wed, 23 Sep 2020 20:16:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2094716008D; Wed, 23 Sep 2020 20:16:48 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id aNXx-5wf6LWh; Wed, 23 Sep 2020 20:16:48 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E81E2160089; Wed, 23 Sep 2020 20:16:47 -0700 (PDT) Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex To: Jim Meyering References: <20200923075730.64FF.27F6AC2D@kcn.ne.jp> <20200923112259.6507.27F6AC2D@kcn.ne.jp> From: Paul Eggert Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDVlFRVEFRZ0FQ d0liQXdZTApDUWdIQXdJR0ZRZ0NDUW9MQkJZQ0F3RUNIZ0VDRjRBV0lRUitONUtwMkt6MzFq TzhGWWp0bCtrT1lxcCtOQVVDClh5Vzlsd1VKRks0THN3QUtDUkR0bCtrT1lxcCtOS05WRC85 SE1zSTE2MDZuMFV1VFhId0lUc3lPakFJOVNET1QKK0MzRFV2NnFsTTVCSDJuV0FNVGlJaXlB NXVnbHNKdjkzb2kydk50RmYvUS9tLzFjblpXZ25WbkV4a3lMSTRFTgpTZDF1QnZyMC9sQ1Nk UGxQME1nNkdXU3BYTXUreDB2ZFQwQWFaTk9URTBGblB1b2xkYzNYRDc2QzJxZzhzWC9pCmF4 WFRLSHk5UCtCbEFxL0NzNy9weERRMEV6U24wVVNaMkMwbDV2djRQTXBBL3BpY25TNks2MDlK dkRHYU9SbXcKWmVYSVpxUU5aVitaUXMrVVl0Vm9ndURUcWJ5M0lVWTFJOEJsWEhScHRhajlB TW40VW9oL0NxcFFsVm9qb3lXbApIcWFGbm5KQktlRjBodko5U0F5YWx3dXpBakc3dlFXMDdN WW5jYU9GbTB3b2lLYmc1SkxPOEY0U0JUSWt1TzBECkNmOW5MQWF5NlZzQjRyendkRWZSd2pQ TFlBbjdNUjNmdkhDRXpmcmtsZFRyYWlCTzFUMGllREs4MEk3c0xmNnAKTWVDWUkxOXBVbHgw L05STUdDZGRpRklRZGZ0aEtXWEdSUzVMQXM4andCZjhINkc1UFdpblByRUlhb21JUDIxaQp2 dWhRRDA3YllxOUlpSWRlbGpqVWRIY0dJMGkvQjRNNTZaYWE4RmYzOGluaU9sckRZQ21ZV1I0 ZENXWml1UWVaCjNPZ3FlUXM5YTZqVHZnZERHVm1SVnFZK2p6azhQbGFIZmNvazhST2hGY0hL a2NmaHVCaEwyNWhsUklzaFJET0UKc2tYcUt3bnpyYnFnYTNHWFpYZnNYQW9GYnpOaExkTHY5 QStMSkFZU2tYUDYvNXFkVHBFTFZHb3N5SDg4NFZkYgpCcGtHSTA0b1lWcXVsYmtDRFFSTWdI SmtBUkFBcG9YcnZ4UDNESWZqQ05PdFhVL1Bkd01TaEtkWC9SbFNzNVBmCnVuVjF3YktQOGhl clhIcnZRZEZWcUVDYVRTeG1saHpiazhYMFBrWTlnY1ZhVTJPNDlUM3FzT2QxY0hlRjUyWUYK R0V0MExoc0JlTWpnTlg1dVoxVjc2cjhneWVWbEZwV1diMFNJd0pVQkhyRFhleEY2N3VwZVJi MnZkSEJqWUROZQp5U24rMEI3Z0ZFcXZWbVp1K0xhZHVkRHA2a1FMamF0RnZIUUhVU0dOc2hC bmtrY2FUYmlJOVBzdDBHQ2MyYWl6Cm5CaVBQQTJXUXhBUGxQUmgzT0dUc241VEhBRG1ianFZ NkZFTUxhc1ZYOERTQ2JsTXZMd05lTy84U3h6aUJpZGgKcUxwSkNxZFFSV0hrdTVYeGdJa0dl S096NU9MRHZYSFdKeWFmckVZamprUzZBazZCNXo2c3ZLbGlDbFduakhRYwpqbFB6eW9GRmdL VEVmY3FEeENqNFJZMEQwRGd0RkQwTmZ5ZU9pZHJTQi9TelRlMmh3cnlRRTNycFNpcW8rMGNH CmR6aDR5QUhLWUorVXJYWjRwOTNaaGpHZktEMXhsck5ZRGxXeVc5UEdtYnZxRnVEbWlJQVFm OVdEL3d6RWZJQ2MKK0YrdURESSt1WWtSeFVGcDkyeWttZGhERUZnMXlqWXNVOGlHVTY5YUh5 dmhxMzZ6NHpjdHZicWhSTnpPV0IxYgpWSi9kSU1EdnNFeEdjWFFWRElUN3NETlh2MHdFM2pL U0twcDdOREcxb1hVWEwrMitTRjk5S2p5NzUzQWJRU0FtCkg2MTdmeUJOd2hKV3ZRWWcrbVV2 UHBpR090c2VzOUVYVUkzbFM0djBNRWFQRzQzZmxFczFVUisxcnBGUVdWSG8KMXkxT08rc0FF UUVBQVlrQ1BBUVlBUWdBSmdJYkRCWWhCSDQza3FuWXJQZldNN3dWaU8yWDZRNWlxbjQwQlFK ZgpKYjJ6QlFrVXJndlBBQW9KRU8yWDZRNWlxbjQwY25NUC8xN0NnVWtYVDlhSUpyaVBNOHdi Y2VZcmNsNytiZFlFCmY3OVNsd1NiYkhON1I0Q29JSkZPbE45Uy8zNHR5cEdWWXZwZ21DSkRZ RlRCeHlQTzkyaU1YRGdBNCtjV0h6dDUKVDFhWU85aHNLaGg3dkR0Sys2UHJvWkdjKzA4Z1VU WEhoYjk3aE1NUWhrbkpsbmZqcFNFQzllbTkwNkZVK0k5MwpUMWZUR3VwbkJhM2FXY0s4ak0w SmFCR2J5MmhHMVMzb2xhRExTVHRCSU5OQlltdnVXUjlNS09oaHFEcmxrNWN3CkZESkxoNU5y WHRlRVkwOFdBemNMekczcGtyWFBIa0ZlTVF0ZnFrMGpMZEdHdkdDM05DSWtxWXJkTGhpUnZH cHIKdTM4QzI2UkVuNWY0STB2R0UzVmZJWEhlOFRNQ05tUXV0MU50TXVVbXBESXkxYUx4R3p1 cHRVaG5PSk4vL3IrVgpqRFBvaTNMT3lTTllwaHFlL2RNdWJzZlVyNm9oUDQxbUtGODFGdXdJ NGFtcUp0cnFJTDJ5cWF4M2EwcWxmd0N4ClhmdGllcUpjdWVrWCtlQ1BEQ0tyWU1YUjBGWWd3 cEcySVRaVUd0ckVqRVNsRTZEc2N4NzM0SEtkcjVPUklvY0wKVVVLRU9HZWlVNkRHaEdGZGI1 VHd1MFNuK3UxbVVQRE4wTSsrQ2RNdkNsSUU4a2xvNEc5MUVPSW11MVVwYjh4YwpPUFF3eGgx andxU3JVNVF3b05tU1llZ1FTSExwSVV1ckZ6MWlRVWgxdnBQWHpLaW5rV0VxdjRJcUExY2lM K0x5CnlTdUxrcDdNc0pwVlJNYldKQ05XT09TYmFING9EQko1ZEhNR2MzNXg1bW9zQ2s5MFBY a251RkREc1lIZkRvNXMKbWY5bG82WVh4N045Cj0zTGFJCi0tLS0tRU5EIFBHUCBQVUJMSUMg S0VZIEJMT0NLLS0tLS0K Organization: UCLA Computer Science Department Message-ID: Date: Wed, 23 Sep 2020 20:16:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43527 Cc: Norihiro Tanaka , 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 9/23/20 8:00 PM, Jim Meyering wrote: > Thank you, I expect to push it shortly, along with a gnulib-sync diff, > to pull in Paul's regex fixes. Ouch, it looks like we had dueling commits prepared, as I read your email just after pushing a more-extensive patch. I looked at Norihiro's recent "grep: fix a bug in the previous commit" patch . Although the test case added by that patch exposed a bug in Savannah grep before I installed the "grep: fix more Turkish-eyes bugs" patch just now, that test case works with current grep master on Savannah (commit 8577dda638ebfee2b77342a4d07252745ec42a3a). This isn't surprising, as the "grep: fix more Turkish-eyes bugs" patch tests the same thing plus some more stuff. It'd be good to have a different test case to demonstrate why the "grep: fix a bug in the previous commit" patch is needed to kwsearch.c. I'll take a look at that. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 23 23:42:00 2020 Received: (at 43527) by debbugs.gnu.org; 24 Sep 2020 03:42:00 +0000 Received: from localhost ([127.0.0.1]:38325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLI8u-0004PL-D3 for submit@debbugs.gnu.org; Wed, 23 Sep 2020 23:42:00 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLI8s-0004P6-LM for 43527@debbugs.gnu.org; Wed, 23 Sep 2020 23:41:59 -0400 Received: by mail-wm1-f66.google.com with SMTP id l15so5825758wmh.1 for <43527@debbugs.gnu.org>; Wed, 23 Sep 2020 20:41:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V4SM0Fpu4DyvkUHuWva9nOux5xtPfyxnNoFiq6kktlw=; b=qCAOTLXWPJ0W+qx6duVu4gaYLB+/lVeCfLjLDt/AO1fVZFFO/+5xsrkWGv9G+PIvJG atNCd1HbelDyN1ylZ8po/WWtO0su2rMD67paDZ71fjvFZLGCyQwHTAFiFOTA01P/wsPE Z0A8WRU+DkAXBs7bbwSHFsK7wqD4G5CY+fMhGZMeSsb/XUtGFsZL6XFY3zEQajl66rBk Ty9u98u0zTw8sDElBADfQu46aT8spRudbx6nDDK/qP6PIQCgZhyZxWjSgtD+wL50eXdJ PhTRGK+RhxYQeQYnfppku1YSVmz1OM0xTd8nkn8q1ElDid5M74zyMFQfXCEEpyNM4q7n Idyg== X-Gm-Message-State: AOAM531TcwpdFQTRg9J+EC34jfR3VJupCVAd9LnBHkXa0qGiX8EKiT9a FNfujbwMWzPckMQN+RKQdIlTB6gTxieU+DtzS+c= X-Google-Smtp-Source: ABdhPJxEUBkSrzonfiANZx8SCLzg+4cp302gfI6TJOwfNzc+0KXx0Mb1sxfZEpZI2with/z9R2pxy2lwO9so3zQJJvM= X-Received: by 2002:a7b:c847:: with SMTP id c7mr2439850wml.149.1600918912488; Wed, 23 Sep 2020 20:41:52 -0700 (PDT) MIME-Version: 1.0 References: <20200923075730.64FF.27F6AC2D@kcn.ne.jp> <20200923112259.6507.27F6AC2D@kcn.ne.jp> In-Reply-To: From: Jim Meyering Date: Wed, 23 Sep 2020 20:41:40 -0700 Message-ID: Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex To: Paul Eggert Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 43527 Cc: Norihiro Tanaka , 43527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Wed, Sep 23, 2020 at 8:16 PM Paul Eggert wrote: > On 9/23/20 8:00 PM, Jim Meyering wrote: > > Thank you, I expect to push it shortly, along with a gnulib-sync diff, > > to pull in Paul's regex fixes. > > Ouch, it looks like we had dueling commits prepared, as I read your email just > after pushing a more-extensive patch. I noticed, but it wasn't a problem. Thanks for all the work (from both you and Norihiro) that went into those changes. > I looked at Norihiro's recent "grep: fix a bug in the previous commit" patch > . Although the test case added by that patch > exposed a bug in Savannah grep before I installed the "grep: fix more > Turkish-eyes bugs" patch just now, that test case works with current grep master > on Savannah (commit 8577dda638ebfee2b77342a4d07252745ec42a3a). This isn't > surprising, as the "grep: fix more Turkish-eyes bugs" patch tests the same thing > plus some more stuff. > > It'd be good to have a different test case to demonstrate why the "grep: fix a > bug in the previous commit" patch is needed to kwsearch.c. I'll take a look at that. I agree. Hoping to make the next snapshot soon, but not before tomorrow (Thu) evening. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 26 16:48:38 2020 Received: (at 43527-done) by debbugs.gnu.org; 26 Sep 2020 20:48:38 +0000 Received: from localhost ([127.0.0.1]:47831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMH7W-0008Ry-54 for submit@debbugs.gnu.org; Sat, 26 Sep 2020 16:48:38 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMH7T-0008Rj-8B for 43527-done@debbugs.gnu.org; Sat, 26 Sep 2020 16:48:36 -0400 Received: by mail-wr1-f65.google.com with SMTP id g4so7591245wrs.5 for <43527-done@debbugs.gnu.org>; Sat, 26 Sep 2020 13:48:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fb6k7bc9+jmSjWmEiVnwHlo1BKG8zuR9x7sS3T3EzD4=; b=QbeuUD3P8GThtHAJtd3Z8emPbHeW5JwSl5ATq8m4jfy6nGL8c6mDs/k2nKpROzgwfF Uz0msZ1LVuAfLgGWJ2YaMf9yf7Z6KwGm91tWzbSXZ7Efv0bfn059L4suncQXkfCRoCEM +U9CL9gsLBLDe9QvBjECIDF4Krys4jij/R7utI/Fm1Xg5wwY9hwLcgFhteNBwa7Cr6BH uX8lNgHFhSZgDxb+DB8lJIjITRDHbJAlxTLvLK3Ev9wM2SOBB1P+7xAESF+gVK7EN79P WYNkvGDT10skdHhP1XC368mHqjrkyDrBZXlwC3ZW3/bqa00ffhFcWpphdVabbhGZ4UTL mhlw== X-Gm-Message-State: AOAM530OFE4KhgB+6r8Zm9UrIQrjTUBJlzqA1XaAJdqXsGXcwFzvbCfC liSKh9TV4ISQCHp73KiOULQQdwPbFdtIjqeyMGfVCsimcWo= X-Google-Smtp-Source: ABdhPJyhvhQOUVE+mG1PaBXvMhlINYW7T6w2s8W7xBdyvEdcHTfb60cIFQD60ODHd5VRwF9vhoI3PnQTqZZVVyEpgO0= X-Received: by 2002:adf:83c3:: with SMTP id 61mr10577420wre.287.1601153309402; Sat, 26 Sep 2020 13:48:29 -0700 (PDT) MIME-Version: 1.0 References: <20200923075730.64FF.27F6AC2D@kcn.ne.jp> <20200923112259.6507.27F6AC2D@kcn.ne.jp> In-Reply-To: <20200923112259.6507.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Sat, 26 Sep 2020 13:48:16 -0700 Message-ID: Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex To: Norihiro Tanaka Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43527-done Cc: 43527-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Tue, Sep 22, 2020 at 8:04 PM Norihiro Tanaka wrote: > On Tue, 22 Sep 2020 16:25:06 -0700 > Jim Meyering wrote: > > > Oh! Good timing. I was about to make a new snapshot. > > Do you happen to have a test case handy that demonstrates the failure? > > I added test case to previous patch. > > By the way, I found the following bug in making the test case, and it's > still left. > > $ env LC_ALL=tr_TR.utf8 grep -Fio i in > Aborted (core dumped) > > (gdb) bt > #0 0x0000003b8d032495 in raise () from /lib64/libc.so.6 > #1 0x0000003b8d033c75 in abort () from /lib64/libc.so.6 > #2 0x000000000040cdde in kwsinit (mb_trans=true) at searchutils.c:64 > #3 0x0000000000409624 in Fcompile (pattern=0x23c1240 "i\n", size=1, ignored=0, exact=true) at kwsearch.c:56 > #4 0x0000000000409378 in main (argc=4, argv=0x7ffe76048388) at grep.c:2977 Using the latest sources plus that patch, I ran all of the tests with an assertion that kwsearch->exact == !!start_ptr before each use of that new member, and the assertion never failed. As far as I can see, this patch is not necessary (also, I could not reproduce your abort), so I'm closing this issue. Please reopen if you can demonstrate its utility. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 26 21:12:49 2020 Received: (at 43527-done) by debbugs.gnu.org; 27 Sep 2020 01:12:49 +0000 Received: from localhost ([127.0.0.1]:48077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMLFA-0002Bv-Qd for submit@debbugs.gnu.org; Sat, 26 Sep 2020 21:12:49 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMLF7-0002Bf-9z for 43527-done@debbugs.gnu.org; Sat, 26 Sep 2020 21:12:47 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E3C5916007A; Sat, 26 Sep 2020 18:12:38 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SXffVH3Iagzr; Sat, 26 Sep 2020 18:12:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2B24F160091; Sat, 26 Sep 2020 18:12:38 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RdgMPlVJ4V80; Sat, 26 Sep 2020 18:12:38 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E521616007A; Sat, 26 Sep 2020 18:12:37 -0700 (PDT) Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex To: Jim Meyering , Norihiro Tanaka References: <20200923075730.64FF.27F6AC2D@kcn.ne.jp> <20200923112259.6507.27F6AC2D@kcn.ne.jp> From: Paul Eggert Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDVlFRVEFRZ0FQ d0liQXdZTApDUWdIQXdJR0ZRZ0NDUW9MQkJZQ0F3RUNIZ0VDRjRBV0lRUitONUtwMkt6MzFq TzhGWWp0bCtrT1lxcCtOQVVDClh5Vzlsd1VKRks0THN3QUtDUkR0bCtrT1lxcCtOS05WRC85 SE1zSTE2MDZuMFV1VFhId0lUc3lPakFJOVNET1QKK0MzRFV2NnFsTTVCSDJuV0FNVGlJaXlB NXVnbHNKdjkzb2kydk50RmYvUS9tLzFjblpXZ25WbkV4a3lMSTRFTgpTZDF1QnZyMC9sQ1Nk UGxQME1nNkdXU3BYTXUreDB2ZFQwQWFaTk9URTBGblB1b2xkYzNYRDc2QzJxZzhzWC9pCmF4 WFRLSHk5UCtCbEFxL0NzNy9weERRMEV6U24wVVNaMkMwbDV2djRQTXBBL3BpY25TNks2MDlK dkRHYU9SbXcKWmVYSVpxUU5aVitaUXMrVVl0Vm9ndURUcWJ5M0lVWTFJOEJsWEhScHRhajlB TW40VW9oL0NxcFFsVm9qb3lXbApIcWFGbm5KQktlRjBodko5U0F5YWx3dXpBakc3dlFXMDdN WW5jYU9GbTB3b2lLYmc1SkxPOEY0U0JUSWt1TzBECkNmOW5MQWF5NlZzQjRyendkRWZSd2pQ TFlBbjdNUjNmdkhDRXpmcmtsZFRyYWlCTzFUMGllREs4MEk3c0xmNnAKTWVDWUkxOXBVbHgw L05STUdDZGRpRklRZGZ0aEtXWEdSUzVMQXM4andCZjhINkc1UFdpblByRUlhb21JUDIxaQp2 dWhRRDA3YllxOUlpSWRlbGpqVWRIY0dJMGkvQjRNNTZaYWE4RmYzOGluaU9sckRZQ21ZV1I0 ZENXWml1UWVaCjNPZ3FlUXM5YTZqVHZnZERHVm1SVnFZK2p6azhQbGFIZmNvazhST2hGY0hL a2NmaHVCaEwyNWhsUklzaFJET0UKc2tYcUt3bnpyYnFnYTNHWFpYZnNYQW9GYnpOaExkTHY5 QStMSkFZU2tYUDYvNXFkVHBFTFZHb3N5SDg4NFZkYgpCcGtHSTA0b1lWcXVsYmtDRFFSTWdI SmtBUkFBcG9YcnZ4UDNESWZqQ05PdFhVL1Bkd01TaEtkWC9SbFNzNVBmCnVuVjF3YktQOGhl clhIcnZRZEZWcUVDYVRTeG1saHpiazhYMFBrWTlnY1ZhVTJPNDlUM3FzT2QxY0hlRjUyWUYK R0V0MExoc0JlTWpnTlg1dVoxVjc2cjhneWVWbEZwV1diMFNJd0pVQkhyRFhleEY2N3VwZVJi MnZkSEJqWUROZQp5U24rMEI3Z0ZFcXZWbVp1K0xhZHVkRHA2a1FMamF0RnZIUUhVU0dOc2hC bmtrY2FUYmlJOVBzdDBHQ2MyYWl6Cm5CaVBQQTJXUXhBUGxQUmgzT0dUc241VEhBRG1ianFZ NkZFTUxhc1ZYOERTQ2JsTXZMd05lTy84U3h6aUJpZGgKcUxwSkNxZFFSV0hrdTVYeGdJa0dl S096NU9MRHZYSFdKeWFmckVZamprUzZBazZCNXo2c3ZLbGlDbFduakhRYwpqbFB6eW9GRmdL VEVmY3FEeENqNFJZMEQwRGd0RkQwTmZ5ZU9pZHJTQi9TelRlMmh3cnlRRTNycFNpcW8rMGNH CmR6aDR5QUhLWUorVXJYWjRwOTNaaGpHZktEMXhsck5ZRGxXeVc5UEdtYnZxRnVEbWlJQVFm OVdEL3d6RWZJQ2MKK0YrdURESSt1WWtSeFVGcDkyeWttZGhERUZnMXlqWXNVOGlHVTY5YUh5 dmhxMzZ6NHpjdHZicWhSTnpPV0IxYgpWSi9kSU1EdnNFeEdjWFFWRElUN3NETlh2MHdFM2pL U0twcDdOREcxb1hVWEwrMitTRjk5S2p5NzUzQWJRU0FtCkg2MTdmeUJOd2hKV3ZRWWcrbVV2 UHBpR090c2VzOUVYVUkzbFM0djBNRWFQRzQzZmxFczFVUisxcnBGUVdWSG8KMXkxT08rc0FF UUVBQVlrQ1BBUVlBUWdBSmdJYkRCWWhCSDQza3FuWXJQZldNN3dWaU8yWDZRNWlxbjQwQlFK ZgpKYjJ6QlFrVXJndlBBQW9KRU8yWDZRNWlxbjQwY25NUC8xN0NnVWtYVDlhSUpyaVBNOHdi Y2VZcmNsNytiZFlFCmY3OVNsd1NiYkhON1I0Q29JSkZPbE45Uy8zNHR5cEdWWXZwZ21DSkRZ RlRCeHlQTzkyaU1YRGdBNCtjV0h6dDUKVDFhWU85aHNLaGg3dkR0Sys2UHJvWkdjKzA4Z1VU WEhoYjk3aE1NUWhrbkpsbmZqcFNFQzllbTkwNkZVK0k5MwpUMWZUR3VwbkJhM2FXY0s4ak0w SmFCR2J5MmhHMVMzb2xhRExTVHRCSU5OQlltdnVXUjlNS09oaHFEcmxrNWN3CkZESkxoNU5y WHRlRVkwOFdBemNMekczcGtyWFBIa0ZlTVF0ZnFrMGpMZEdHdkdDM05DSWtxWXJkTGhpUnZH cHIKdTM4QzI2UkVuNWY0STB2R0UzVmZJWEhlOFRNQ05tUXV0MU50TXVVbXBESXkxYUx4R3p1 cHRVaG5PSk4vL3IrVgpqRFBvaTNMT3lTTllwaHFlL2RNdWJzZlVyNm9oUDQxbUtGODFGdXdJ NGFtcUp0cnFJTDJ5cWF4M2EwcWxmd0N4ClhmdGllcUpjdWVrWCtlQ1BEQ0tyWU1YUjBGWWd3 cEcySVRaVUd0ckVqRVNsRTZEc2N4NzM0SEtkcjVPUklvY0wKVVVLRU9HZWlVNkRHaEdGZGI1 VHd1MFNuK3UxbVVQRE4wTSsrQ2RNdkNsSUU4a2xvNEc5MUVPSW11MVVwYjh4YwpPUFF3eGgx andxU3JVNVF3b05tU1llZ1FTSExwSVV1ckZ6MWlRVWgxdnBQWHpLaW5rV0VxdjRJcUExY2lM K0x5CnlTdUxrcDdNc0pwVlJNYldKQ05XT09TYmFING9EQko1ZEhNR2MzNXg1bW9zQ2s5MFBY a251RkREc1lIZkRvNXMKbWY5bG82WVh4N045Cj0zTGFJCi0tLS0tRU5EIFBHUCBQVUJMSUMg S0VZIEJMT0NLLS0tLS0K Organization: UCLA Computer Science Department Message-ID: <3245381a-8883-ed50-3098-2715089a5ec7@cs.ucla.edu> Date: Sat, 26 Sep 2020 18:12:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 43527-done Cc: 43527-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) On 9/26/20 1:48 PM, Jim Meyering wrote: > As far as I can see, this patch is not necessary (also, I could not > reproduce your abort), so I'm closing this issue. Please reopen if you > can demonstrate its utility. When I looked into it last week, I did the same thing with an assert with the same results that you got. In looking at the source code I thought that the patch wasn't needed for current 'grep' and so could wait until after the release. The patch should be harmless (though this fact isn't trivial) and I can see it being useful for plausible future performance improvements, so it would make sense to install it after the next release. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 26 22:19:21 2020 Received: (at 43527-done) by debbugs.gnu.org; 27 Sep 2020 02:19:21 +0000 Received: from localhost ([127.0.0.1]:48103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMMHY-0003mK-Q3 for submit@debbugs.gnu.org; Sat, 26 Sep 2020 22:19:21 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:51870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMMHV-0003m5-OE for 43527-done@debbugs.gnu.org; Sat, 26 Sep 2020 22:19:19 -0400 Received: from mxs02-s (mailgw2.kcn.ne.jp [61.86.15.234]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id CB92B8072C for <43527-done@debbugs.gnu.org>; Sun, 27 Sep 2020 11:19:10 +0900 (JST) X-matriXscan-loop-detect: ddc7adcc4e3dc24eb4f9896f0d1bed79cf12537f Received: from mail10.kcn.ne.jp ([61.86.6.128]) by mxs02-s with ESMTP; Sun, 27 Sep 2020 11:19:09 +0900 (JST) Received: from [10.120.1.105] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail10.kcn.ne.jp (Postfix) with ESMTPA id 1462F40E373C; Sun, 27 Sep 2020 11:19:09 +0900 (JST) Date: Sun, 27 Sep 2020 11:19:08 +0900 From: Norihiro Tanaka To: Paul Eggert Subject: Re: bug#43527: [PATCH] grep: avoid unneeded compilation of regex In-Reply-To: <3245381a-8883-ed50-3098-2715089a5ec7@cs.ucla.edu> References: <3245381a-8883-ed50-3098-2715089a5ec7@cs.ucla.edu> Message-Id: <20200927111908.D911.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.75.01 [ja] X-matriXscan-msec-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43527-done Cc: Jim Meyering , 43527-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 26 Sep 2020 18:12:37 -0700 Paul Eggert wrote: > The patch should be harmless (though this fact isn't trivial) and I can > see it being useful for plausible future performance improvements, so it > would make sense to install it after the next release. No longer need the patch. This bug occurs when the last argument of the first GEAcompile () is executed with 'false' and regex search is requested for the compiled pattern. However, with a recent fix by Paul, the first GEAcompile() no longer seems to run in any case. From unknown Fri Sep 05 23:26:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 Oct 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator