GNU bug report logs - #43511
27.1; [PATCH] Files with lowercase doctype are not in mhtml-mode by default

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43511 in the body.
You can then email your comments to 43511 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.1; [PATCH] Files with lowercase doctype are not in mhtml-mode by
 default
Date: Sat, 19 Sep 2020 16:35:14 +0200

[Message part 1 (text/plain, inline)]

This is a regression caused by the fix for bug 36401.

Steps to reproduce:

emacs -Q
M-x browse-url-emacs RET https://www.gnu.org/software/emacs/ RET

Expected results:

The HTML contents of the Emacs website are shown, and the buffer is in
mhtml-mode.

Actual results:

The HTML contents of the Emacs website are shown, but the buffer is in
fundamental-mode.

The proposed solution to accomodate both wanted behaviors is to extend
the regular expression to cover a "DOCTYPE" in a case-insensitive
way. The standard says that's also supported:
https://html.spec.whatwg.org/multipage/syntax.html#the-doctype

I've attached a patch with the proposed solution, on top of
emacs-27. Let me know if you'd want to apply it on top of master
instead.

Thanks.

[0001-Put-files-in-mhtml-mode-when-they-have-DOCTYPE-case-.patch (text/x-patch, attachment)]

Message #8 received at 43511 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: 43511 <at> debbugs.gnu.org
Subject: Re: bug#43511: 27.1; [PATCH] Files with lowercase doctype are not
 in mhtml-mode by default
Date: Sat, 19 Sep 2020 19:17:08 +0200

Daniel Martín <mardani29 <at> yahoo.es> writes:

> I've attached a patch with the proposed solution, on top of
> emacs-27. Let me know if you'd want to apply it on top of master
> instead.

Thanks; I've applied it to Emacs 28.  While this is a regression, I
don't think the impact it has is large enough to warrant putting it in
Emacs 27.2.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.