GNU bug report logs - #43503
Patch: Improvements regarding commands like find-file-other-tab.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43503 in the body.
You can then email your comments to 43503 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ej32u <at> protonmail.com
To: bug-gnu-emacs <at> gnu.org
Subject: Patch: Improvements regarding commands like find-file-other-tab.
Date: Fri, 18 Sep 2020 21:41:41 +0000

[Message part 1 (text/plain, inline)]

Hello.

This is what the patch does:

1. Document existing command `ffap-other-tab'.
2. Create `find-file-read-only-other-tab' and `ffap-read-only-other-tab'.
3. Bind "\C-r" to `find-file-read-only-other-tab', like how "\C-f" is
    bound to `find-file-other-tab'.
4. Document `ffap-read-only-other-tab' in misc.texi.

I don't really know the Texinfo format, so I just copied the mark-up used for 
other items.

Is there anything that should be changed?

Thank you.

[0001-Improvements-regarding-like-find-file-other-tab.patch (text/x-patch, attachment)]

Message #8 received at 43503 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: ej32u <at> protonmail.com
Cc: 43503 <at> debbugs.gnu.org
Subject: Re: bug#43503: Patch: Improvements regarding commands like
 find-file-other-tab.
Date: Sat, 19 Sep 2020 16:34:34 +0200

ej32u <at> protonmail.com writes:

> 1. Document existing command `ffap-other-tab'.
> 2. Create `find-file-read-only-other-tab' and `ffap-read-only-other-tab'.
> 3. Bind "\C-r" to `find-file-read-only-other-tab', like how "\C-f" is
>     bound to `find-file-other-tab'.
> 4. Document `ffap-read-only-other-tab' in misc.texi.
>
> I don't really know the Texinfo format, so I just copied the mark-up used for 
> other items.

Look OK to me.

> +(defun find-file-read-only-other-tab (filename &optional wildcards)
> +  "Edit file FILENAME, in another tab, but don't allow changes.
> +Like \\[find-file-other-frame] (which see), but creates a new tab.
> +
> +Like C-x t C-f, but marks buffer as read-only.
> +Use C-x C-q to permit editing."

This should probably refer to the functions, not the keystrokes?

But anyway -- I'm not really sure I understand the use case here -- is
opening files in read-only mode a thing that people do a lot?  I mean,
we have `C-x C-r', so adding tab-opening versions of that would be
logical, but...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 43503 <at> debbugs.gnu.org (full text, mbox):

From: ej32u <at> protonmail.com
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43503 <at> debbugs.gnu.org
Subject: Re: bug#43503: Patch: Improvements regarding commands like
 find-file-other-tab.
Date: Sat, 19 Sep 2020 18:19:20 +0000

[Message part 1 (text/plain, inline)]

On 9/19/20 10:34 AM, Lars Ingebrigtsen wrote:
>> +(defun find-file-read-only-other-tab (filename &optional wildcards)
>> +  "Edit file FILENAME, in another tab, but don't allow changes.
>> +Like \\[find-file-other-frame] (which see), but creates a new tab.
>> +
>> +Like C-x t C-f, but marks buffer as read-only.
>> +Use C-x C-q to permit editing."
> This should probably refer to the functions, not the keystrokes?
You are right. I fixed that.
> But anyway -- I'm not really sure I understand the use case here -- is
> opening files in read-only mode a thing that people do a lot?  I mean,
> we have `C-x C-r', so adding tab-opening versions of that would be
> logical, but...
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>     bloggy blog: http://lars.ingebrigtsen.no

I do this only occasionally. I think having them is no different from having the 
`-other-frame' and `-other-window' versions of `find-file-read-only'.

I really only want the FFAP versions of these commands, but I think the other 
versions should exist for consistency.

[0001-Improvements-regarding-like-find-file-other-tab.patch (text/x-patch, attachment)]

Message #14 received at 43503 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: ej32u <at> protonmail.com
Cc: 43503 <at> debbugs.gnu.org
Subject: Re: bug#43503: Patch: Improvements regarding commands like
 find-file-other-tab.
Date: Sun, 20 Sep 2020 11:30:46 +0200

ej32u <at> protonmail.com writes:

> I do this only occasionally. I think having them is no different from
> having the
> `-other-frame' and `-other-window' versions of `find-file-read-only'.

Yeah, I guess consistency has a charm of it's own, and I guess there's
no other way to do this than add a bunch of tab-equivalent versions of
all these commands, annoyingly enough.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 43503 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: ej32u <at> protonmail.com
Cc: 43503 <at> debbugs.gnu.org
Subject: Re: bug#43503: Patch: Improvements regarding commands like
 find-file-other-tab.
Date: Sun, 20 Sep 2020 11:37:12 +0200

I've now applied the patch to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.