From unknown Mon Aug 18 18:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43496: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 21:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 43496@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160046494629477 (code B ref -1); Fri, 18 Sep 2020 21:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Sep 2020 21:35:46 +0000 Received: from localhost ([127.0.0.1]:44689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJO2k-0007fN-Dj for submit@debbugs.gnu.org; Fri, 18 Sep 2020 17:35:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:40588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJO2j-0007fF-8w for submit@debbugs.gnu.org; Fri, 18 Sep 2020 17:35:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJO2i-000533-Vn for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 17:35:45 -0400 Received: from 50-0-39-243.dsl.static.fusionbroadband.com ([50.0.39.243]:44428 helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJO2h-0003R2-1C for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 17:35:44 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.lapseofthought.com (Postfix) with ESMTP id 4BtRvm3s34z3jhxj for ; Fri, 18 Sep 2020 14:35:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at lapseofthought.com Received: from mail.lapseofthought.com ([127.0.0.1]) by localhost (mail.lapseofthought.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MTaz3ZF8kY1k for ; Fri, 18 Sep 2020 14:35:31 -0700 (PDT) Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:d2d:93ad:8c01:3409]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4BtRvl57Jsz3jhhc for ; Fri, 18 Sep 2020 14:35:31 -0700 (PDT) From: Alex Bochannek Date: Fri, 18 Sep 2020 14:35:31 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: softfail client-ip=50.0.39.243; envelope-from=alex@bochannek.com; helo=mail.lapseofthought.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 17:35:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, FORGED_SPF_HELO=1, KHOP_HELO_FCRDNS=0.4, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665, TVD_RCVD_IP=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain The gnus-summary-catchup-from-here function also marks the current article, which it fails to do if that article is the last one in the summary buffer. --=-=-= Content-Type: text/x-patch; name=gnus-sum.el.diff Content-Disposition: inline Content-Description: Fix edge case in gnus-summary-catchup-from-here diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index 2f0ea0c58f..8e27a94e5b 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -11537,7 +11537,7 @@ gnus-summary-catchup-from-here (gnus-save-hidden-threads (let ((beg (point))) ;; We check that there are unread articles. - (when (or all (gnus-summary-find-next)) + (when (or all (gnus-summary-last-article-p) (gnus-summary-find-next)) (gnus-summary-catchup all t beg nil t))))) (gnus-summary-position-point)) --=-=-= Content-Type: text/plain -- Alex. --=-=-=-- From unknown Mon Aug 18 18:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43496: 28.0.50; [PATCH] Fix edge case in gnus-summary-catchup-from-here Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Bochannek Cc: 43496@debbugs.gnu.org Received: via spool by 43496-submit@debbugs.gnu.org id=B43496.160052700723239 (code B ref 43496); Sat, 19 Sep 2020 14:51:02 +0000 Received: (at 43496) by debbugs.gnu.org; 19 Sep 2020 14:50:07 +0000 Received: from localhost ([127.0.0.1]:47768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJeBi-00062l-Tq for submit@debbugs.gnu.org; Sat, 19 Sep 2020 10:50:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJeBg-00061y-Vf for 43496@debbugs.gnu.org; Sat, 19 Sep 2020 10:50:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+i6ed8LwvwYswChfbPq0AdkAv4NO4xSHb/c7uQCzwIQ=; b=UYm6Alor2V0tBOxZ72cSBuEjPn vVeL/6HY8VIzWqZhKD7rSmFU2IRmf+2DkP8KA5fSZarHtHqoSePOoXUFPeGKKun26qOt0uiqOo+DI /OqrRumeyqaIPbk4N2b3OneXJZCT//mF0GuksG8CZDRCvxZ5D3BZByWtaY5JcXF1qfnw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJeBU-0005SN-Ts; Sat, 19 Sep 2020 16:49:58 +0200 From: Lars Ingebrigtsen References: X-Now-Playing: Propaganda's _A Secret Wish (2)_: "P:Machinery (Goodnight 32)" Date: Sat, 19 Sep 2020 16:49:51 +0200 In-Reply-To: (Alex Bochannek's message of "Fri, 18 Sep 2020 14:35:31 -0700") Message-ID: <87tuvtq0s0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Bochannek writes: > The gnus-summary-catchup-from-here function also marks the current > article, which it fails to do if that article is the last one in the > summary buffer. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Bochannek writes: > The gnus-summary-catchup-from-here function also marks the current > article, which it fails to do if that article is the last one in the > summary buffer. Thanks; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 19 10:50:14 2020 Received: (at control) by debbugs.gnu.org; 19 Sep 2020 14:50:14 +0000 Received: from localhost ([127.0.0.1]:47771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJeBq-000636-3t for submit@debbugs.gnu.org; Sat, 19 Sep 2020 10:50:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJeBp-00062t-16 for control@debbugs.gnu.org; Sat, 19 Sep 2020 10:50:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rLqfZHXgz65TD/kNjodUZsMWNgT6AZdwixAD8aVtYk0=; b=CLwpd7z3WoH1vxuVedsQS+SWII Lsh5BtAyA9QNYRGw3TQK+vdfQUIWOHvN78U8R9ttTu/cc3goUhQ/ISAnh9H+hleVqyYwWiTnF5FPO LlQILBBjpG3G6XB56yTrtgFEAg4AkxFy9wGxrltUzLVowDW3eqH0JlqCbNdqthhevmYM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJeBh-0005Sy-9T for control@debbugs.gnu.org; Sat, 19 Sep 2020 16:50:07 +0200 Date: Sat, 19 Sep 2020 16:50:04 +0200 Message-Id: <87sgbdq0rn.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43496 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43496 fixed close 43496 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43496 fixed close 43496 28.1 quit