GNU bug report logs - #43494
[PATCH 0/4] Add package and services for the Guix Build Coordinator

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#43494: closed ([PATCH 0/4] Add package and services for the
 Guix Build Coordinator)
Date: Mon, 05 Oct 2020 17:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 05 Oct 2020 18:16:22 +0100
with message-id <87a6x01tll.fsf <at> cbaines.net>
and subject line Re: [bug#43494] [PATCH v2 4/4] services: guix: Add guix-build-coordinator-queue-builds-service-type.
has caused the debbugs.gnu.org bug report #43494,
regarding [PATCH 0/4] Add package and services for the Guix Build Coordinator
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
43494: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43494
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/4] Add package and services for the Guix Build Coordinator
Date: Fri, 18 Sep 2020 19:34:47 +0100

[Message part 3 (text/plain, inline)]

This patch series is not particularly well tested, like the Guix Build
Coordinator itself, but it should hopefully still work at least in some
configurations.


Christopher Baines (4):
  gnu: Add guix-build-coordinator.
  services: guix: Add guix-build-coordinator-service-type.
  services: guix: Add guix-build-coordinator-agent-service-type.
  services: guix: Add guix-build-coordinator-queue-builds-service-type.

 doc/guix.texi                       | 143 +++++++++
 gnu/packages/package-management.scm |  89 ++++++
 gnu/services/guix.scm               | 433 +++++++++++++++++++++++++++-
 gnu/tests/guix.scm                  |  75 ++++-
 4 files changed, 736 insertions(+), 4 deletions(-)

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 43494-done <at> debbugs.gnu.org
Subject: Re: [bug#43494] [PATCH v2 4/4] services: guix: Add
 guix-build-coordinator-queue-builds-service-type.
Date: Mon, 05 Oct 2020 18:16:22 +0100

[Message part 6 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Chris,
>
> Sorry for the delay.  Patches 1–3 LGTM!  One minor comment on patch 4:
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> * gnu/services/guix.scm (<guix-build-coordinator-queue-builds-configuration>):
>> New record type.
>> (guix-build-coordinator-queue-builds-configuration,
>> guix-build-coordinator-queue-builds-configuration?,
>> guix-build-coordinator-queue-builds-configuration-package,
>> guix-build-coordinator-queue-builds-configuration-user,
>> guix-build-coordinator-queue-builds-coordinator,
>> guix-build-coordinator-queue-builds-configuration-systems,
>> guix-build-coordinator-queue-builds-configuration-system-and-targets,
>> guix-build-coordinator-queue-builds-configuration-guix-data-service,
>> guix-build-coordinator-queue-builds-configuration-processed-commits-file,
>> guix-build-coordinator-queue-builds-shepherd-services,
>> guix-build-coordinator-queue-builds-activation,
>> guix-build-coordinator-queue-builds-account): New procedures.
>> (guix-build-coordinator-queue-builds-service-type): New variable.
>
> [...]
>
>>  
>> +@defvar {Scheme Variable} guix-build-coordinator-queue-builds-service-type
>> +Service type for the
>> +guix-build-coordinator-queue-builds-from-guix-data-service script.  Its
>> +value must be a @code{guix-build-coordinator-queue-builds-configuration}
>> +object.
>> +@end defvar
>
> Could you add a paragraph right above this explaining what this service
> is about?
>
>> +(define guix-build-coordinator-queue-builds-service-type
>> +  (service-type
>> +   (name 'guix-build-coordinator-queue-builds)
>> +   (extensions
>> +    (list
>> +     (service-extension shepherd-root-service-type
>> +                        guix-build-coordinator-queue-builds-shepherd-services)
>> +     (service-extension activation-service-type
>> +                        guix-build-coordinator-queue-builds-activation)
>> +     (service-extension account-service-type
>> +                        guix-build-coordinator-queue-builds-account)))
>> +   (description
>> +    "Run the Guix Build Coordinator queue builds script.")))
>
> Likewise it’d be great if you could add a few works here.
>
> OK to push with these changes, thank you!

I've tried to add some clarity in the places you mention. I'm still very
tempted to make a separate repository/package for the queue builds from
Guix Data Service script... I'm not quite decided yet though.

Anyway, thanks for taking another look. I've gone ahead and pushed these
patches as c14714cbbfe9239410aec2ed73282192a64fbbdc. I did tweak the
package definition a bit though to move closer to being able to
cross-compile it (you can now if you tweak the inputs).

Thanks again,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.