Subject: Re: [bug#43494] [PATCH 1/4] gnu: Add guix-build-coordinator.

From: Ludovic Courtès <[email-masked]>
Date: Fri, 18 Sep 2020 22:08:56 +0200

Hi!

Christopher Baines <[email-masked]> skribis:

> * gnu/packages/package-management.scm (guix-build-coordinator): New variable.

[...]

> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin"))
> +                    (guile (assoc-ref inputs "guile"))
> +                    (guile-effective-version
> +                     (read-line
> +                      (open-pipe* OPEN_READ
> +                                  (string-append guile "/bin/guile")
> +                                  "-c" "(display (effective-version))")))

Maybe use ‘target-guile-effective-version’ from (guix build
guile-build-system).

> +                  (wrap-program (string-append bin "/" file)
> +                    `("PATH" ":" prefix
> +                      (,bin ,(assoc-ref inputs "sqitch")))
> +                    `("PERL5LIB" ":" prefix
> +                      (,(getenv "PERL5LIB")))

Do we really need PERL5LIB here?  Shouldn’t it be done in the wrapper of
‘sqitch’ directly?

> +                (scandir bin
> +                         (match-lambda
> +                           ((or "." "..") #f)
> +                           (_ #t))))

I think you could just use (find-files bin).

> +    (inputs
> +     `(("guile" ,guile-3.0-latest)

Rather ,@(assoc-ref (package-native-inputs guix) "guile").

> +       ("sqitch" ,sqitch)
> +       ("perl-dbd-sqlite" ,perl-dbd-sqlite)))

Shouldn’t perl-dbd-sqlite be a dependency of sqitch?

> +    (home-page "https://git.cbaines.net/guile/guix/build-coordinator")
> +    (synopsis "")
> +    (description
> +     "")

Missing!  :-)

LGTM with changes along these lines!

Ludo’.