GNU bug report logs - #43489
[PATCH] Don't signal scan-error when moving by sexp interactively

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 43489 <at> debbugs.gnu.org
Subject: bug#43489: [PATCH] Don't signal scan-error when moving by sexp interactively
Date: Wed, 23 Sep 2020 15:40:01 +0200

Mattias Engdegård <mattiase <at> acm.org> writes:

> But my personal flaws should not impede progress. How about I push
> what I've got (latest patch attached for reference) since we seem to
> agree that it's an improvement over what's in master, and if then you
> or anyone else want to further adjust the messages then I have no
> objections.

Sure.  The only thing is this:

> -(defun backward-sexp (&optional arg)
> +obstacle.  If NOERROR is non-nil, as it is interactively,
> +do not signal an error."
> +  (interactive "^p\nd")
> +  (if noerror
> +      (condition-case _
> +          (forward-sexp arg nil)
> +        (scan-error (user-error (if (> arg 0)
> +                                    "No next sexp"
> +                                  "No previous sexp"))))

The parameter is NOERROR, but now it does signal an error.  :-)

So perhaps the parameter should be USER-ERROR/TERSE-ERROR or something
and the doc strings adjusted?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.