From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 12:42:05 2020 Received: (at submit) by debbugs.gnu.org; 17 Sep 2020 16:42:05 +0000 Received: from localhost ([127.0.0.1]:38841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwyy-0006GT-KV for submit@debbugs.gnu.org; Thu, 17 Sep 2020 12:42:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:51250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kItwv-0004vK-UM for submit@debbugs.gnu.org; Thu, 17 Sep 2020 09:27:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kItwv-0000DK-EH for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 09:27:45 -0400 Received: from smtp-gw-07.oit.duke.edu ([152.3.189.233]:53438 helo=mail-gw-07.oit.duke.edu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kItws-00041Z-MD for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 09:27:44 -0400 Received: from smtpgw-06.oit.duke.edu (smtpgw-06.oit.duke.edu [10.136.225.90]) by mail-gw-07.oit.duke.edu (8.16.0.42/8.16.0.42) with ESMTPS id 08HDRepW001937 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 Sep 2020 09:27:40 -0400 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-co1nam04lp2050.outbound.protection.outlook.com [104.47.45.50]) by smtpgw-06.oit.duke.edu (8.16.0.42/8.16.0.42) with ESMTPS id 08HDRdre012141 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 Sep 2020 09:27:40 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IbaZ4oDPUzLdel8GxMaVdP1p3yMFHKEBdO08+FL4M9oY8gcnYOEH/Vhn0yhxEjfsM5uWIOqj/F2p3KvkguIbHQCOtPa0yGycbn/jW9gzuKsl6Rh4jfDWf2ZDDC52vupeqJhOnB+RveWfxhgp/EkkMN2P4eVMElS+TLccI9k0swHxTpy7VKMutmbFJaYyDY8BfovWUec/cbUt/8OrkKZcMUdiLMkBw/JBAKM/frALwUpk5kRf1PEO6ZoxvY05Atk9fcGPKI8ccHgp8QgS6JpkrG3pEH9S3zTBJD3eHsng6E9GRYxr39anLfU8UxX2sOg/c5GWACvSqdmFimi6SpNYXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TrzNND81/eD2HaUSquflXK3XC/GqUg7z6zCNSExqkIg=; b=dvM2zDSccpMn97OoVSw+NF9YLqCGwSLA4D3QdLGV77n9Gh2Cnjt8uJmYFzskkKCXnEPYT9MHLLWSy4a282SRSoyOKfxEFm/X4bTifX2754RLoYzYvGDkx+v+ex2kXHAmBAzgSTRgxE088fHOAvYzbxSk6+gmlCJHB2fBwaL9Jl7tXzQOi8MJuDXqBjS4Nat4uIhCUTGh1dF5bob4LZwvn3sorH8CgxtbgwdaVxbRymMBcAeBaG+7JTXIVJZmWVJAw4jA1gLtVDbRcd6itUeXmkf2IGNCKjb4YiECpE2v1XrYR6iGpXJsFlFxHzFdCYuC8H7AqEqbL5zoT0yJhbPSyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=duke.edu; dmarc=pass action=none header.from=duke.edu; dkim=pass header.d=duke.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=duke.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TrzNND81/eD2HaUSquflXK3XC/GqUg7z6zCNSExqkIg=; b=UcXBDm6BogAa0POij5kK96jLnJPmjxXNoyLtg8G1XQfNrTPk0wd8wuhR1OnfIanXi30+fvIu5gOPP/JMZvCZRaLxpJVadBg+j0WqSSP9J4iDdrpzzlDXH1hpU126g0xoLXYHrgG0nuaq1ikv9+QvXFrp7ITuYYYID2+5jr5UzwI= Received: from BL0PR05MB5587.namprd05.prod.outlook.com (2603:10b6:208:6c::28) by BLAPR05MB7409.namprd05.prod.outlook.com (2603:10b6:208:294::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.4; Thu, 17 Sep 2020 13:27:39 +0000 Received: from BL0PR05MB5587.namprd05.prod.outlook.com ([fe80::196d:ac30:b2f6:f3d4]) by BL0PR05MB5587.namprd05.prod.outlook.com ([fe80::196d:ac30:b2f6:f3d4%7]) with mapi id 15.20.3412.006; Thu, 17 Sep 2020 13:27:38 +0000 From: "Paul Magwene, Ph.D." To: "bug-gnu-emacs@gnu.org" Subject: 27.1; Drag and Drop not working properly in 27.1 on OSX Thread-Topic: 27.1; Drag and Drop not working properly in 27.1 on OSX Thread-Index: AQHWjPZPFOqEx7a4akCbMzcFeQjc4g== Date: Thu, 17 Sep 2020 13:27:38 +0000 Message-ID: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=duke.edu; x-originating-ip: [107.15.37.134] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4071589a-78bb-4350-f0bb-08d85b0d729e x-ms-traffictypediagnostic: BLAPR05MB7409: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0GklCgf2tFpU1Uym0khugBFAnV788hO9ycf7Xsp2aWiuEo6AAGDYrVwn7mKFjD7E0bae723ub+ciyQ+/Qdygb2L2yDXggthoLGBb5K2LcEN3B60diObHUPNp8+jMKuJwtvnQkIiulTB3+cd5Doy3AekfDOT0up1L6ZxUspAiGlWI/JY9kMhKUXLvkGRtVWUGIfzK/dQN8COOodPNKWayF4v12Av7+TzKaSCvPO1D+rBiAjNhrzDUWsYE9z1JznqoLAOzqfXs8BVLuclHjlGgJw1khhfE7BRBkirelsNgu4Z1WILJDHX3fBBxLku8hgm4pHTCh58lkk/gujjlr9Pe/zdgufJVHtzuPKsiATUpuuiBBK75QpuaFgW91tOWqZEZVbqmwF98X/oFchKYt6oBCyQy1TrwYPSDWCrcf0rhZ7oMgYzgI9+OHi8couQy9u5j x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR05MB5587.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(136003)(396003)(39860400002)(8936002)(2616005)(71200400001)(83380400001)(186003)(75432002)(8676002)(26005)(786003)(86362001)(316002)(478600001)(6512007)(6916009)(33656002)(36756003)(6486002)(966005)(2906002)(5660300002)(66476007)(64756008)(66946007)(66556008)(66446008)(6506007)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: kXK/PE7ugaxOlpnuoSQgZl7n7Pt+3EfXUhEyuXCFQFwBKwKhLXM6QyOw3I7vQA2bz/YSEjuHJy7AQ8zy1YJx+kNHUbwEltF2UlRirPX0BfzFMH5rAmTWuFbM831dQ3g+9RiPTJW5FPNgkY+RGZvW2mLrp9cllyCXVRtWAFT2INBh484/uAIvT8J+hchNJRPnEt7HbpreVwgWmJQadIzgrDOgGZLz657ARhVjTU3Bt1lAe77E3+RdpSWJ/G0DXBywyglw2vX4vsIfp/01Kqour+pKDHfELpOTAYYjM2vGYU+W2VEI61QZzA2sz3o99hRsi2IjWKwFeYspM9r06KuVYVmkAUYqHDkmHZki9XsxTuny6o1ePUReEW6g7n06jdvhaB2tQ0yiXLsXy6EKDEdDxGgGWRM3ffir4CMfNt88qUl+4VbqgWhzQOF/JZV1+nndUKj7g/62cIzjl/Mm4LnChUcuVwNSXoPjlcVg2SxmvY6YIfCl4W8IsHl4OMwWI5WkIupDrtzvDmTkAsL55RAsGDF8+9n4vKytYHiJu+tqf5z+LcRilFhJ91hj8PxEyjokrIy0f9Q6wfiqe3iNgPUzzRKKbS8NENCWTnAElrWxaPEuqyt14qTPb+o6U3l2Qv6oi5pE9uE9psME7dvPhOguTQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <7905E3C9E0C9784084043DFD2DF5CB66@namprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: duke.edu X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR05MB5587.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4071589a-78bb-4350-f0bb-08d85b0d729e X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2020 13:27:38.6457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: cb72c54e-4a31-4d9e-b14a-1ea36dfac94c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aXCseR9biPqsyf+Fb+Ybft/D2Mi/DMZA1qoBRj/250bOZUhuNzlWDZ3iDD8l3YXX X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR05MB7409 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-17_09:2020-09-16, 2020-09-17 signatures=0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-17_09:2020-09-16, 2020-09-17 signatures=0 X-Proofpoint-Spam-Reason: safe Received-SPF: pass client-ip=152.3.189.233; envelope-from=paul.magwene@duke.edu; helo=mail-gw-07.oit.duke.edu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/17 09:27:40 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 17 Sep 2020 12:42:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * Drag and drop events no longer appear to work properly in Emacs 27.1 on Mac OS X. * When I run Emacs from the command line I see the message: `Invalid data type in dragging pasteboard` when trying to drag text or URLs from a webbro= wser (firefox or safari) into an Emacs buffer. * I've tested this with two different builds of 27.1 -- from https://emacsformacosx.com and the "emacs plus" formula under homebrew (https://github.com/d12frosted/homebrew-emacs-plus) on both OS X 10.14.6 (Mavericks) and 10.15.6 (Catalina) * Reverting to Emacs 26.3 resolves this issue In GNU Emacs 27.1 (build 1, x86_64-apple-darwin19.5.0, NS appkit-1894.50 Ve= rsion 10.15.5 (Build 19F101)) of 2020-08-27 built on d12frosted.local Windowing system distributor 'Apple', version 10.3.1894 System Description: Mac OS X 10.15.6 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Composing main Info directory...done Beginning of buffer [18 times] Mark saved where search started Beginning of buffer [24 times] Making completion list... user-error: End of history; no default available Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=3D/usr/local/share/emacs/site-lisp --infodir=3D/usr/local/Cellar/emacs-plus@27/27.1/share/info/emacs --prefix=3D/usr/local/Cellar/emacs-plus@27/27.1 --with-xml2 --with-gnutls --without-dbus --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained' Configured features: RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils thingatpt jka-compr time-date subr-x misearch multi-isearch info help-mode easymenu cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 77707 9630) (symbols 48 6474 1) (strings 32 20721 1816) (string-bytes 1 627785) (vectors 16 11181) (vector-slots 8 157770 17782) (floats 8 31 51) (intervals 56 4895 0) (buffers 1000 15)) Paul Magwene Associate Professor Department of Biology Duke University From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 13:46:54 2020 Received: (at 43470) by debbugs.gnu.org; 17 Sep 2020 17:46:54 +0000 Received: from localhost ([127.0.0.1]:38941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxzi-00015B-4W for submit@debbugs.gnu.org; Thu, 17 Sep 2020 13:46:54 -0400 Received: from wilbur.contactoffice.com ([212.3.242.68]:60624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxzf-0000yA-7o for 43470@debbugs.gnu.org; Thu, 17 Sep 2020 13:46:52 -0400 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id A503BB5E; Thu, 17 Sep 2020 19:46:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600364804; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=946; bh=RCR/1d3AJ6VNsigNVwrIhVyY87WfY6+K7CVn3GRm4IM=; b=gJYc4frueXD+FXC8UBd4XXmSxuPrmDBNA/SDB3xvrfNMCijUlpOfrXmrKksM1/aE 1yuvePRg4hTz3CUoTYIUc7KqW5iE7lNSMEBuj+v65XlgIRF+qYRUbQcrq4tFXZU6bgf KExey9WpQbcZHoJE33EMMRzuc+A7bXT477FurXlLPUBSAcLJStbOHgFUOycZTLM58HA WbJotS4tPXiVbuXwxEYsM9qFif3zmVHLjBDgt0qIURQV1u6WEU/yw/ARWzqqWZvAJX1 LugUSwzv/N2gTJ4RSwW75mxWaG/PCyAV8DCMmOzMIZp1XS6HR0CTugip3T4H92obsWn NfPVqB/r6A== Received: by smtp.mailfence.com with ESMTPA ; Thu, 17 Sep 2020 19:46:41 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 784C920255F66D; Thu, 17 Sep 2020 18:46:40 +0100 (BST) Date: Thu, 17 Sep 2020 18:46:40 +0100 From: Alan Third To: "Paul Magwene, Ph.D." Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Message-ID: <20200917174640.GB635@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.20 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43470 Cc: 43470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Sep 17, 2020 at 01:27:38PM +0000, Paul Magwene, Ph.D. wrote: > > > * Drag and drop events no longer appear to work properly in Emacs 27.1 on > Mac OS X. > > * When I run Emacs from the command line I see the message: `Invalid data > type in dragging pasteboard` when trying to drag text or URLs from a webbrowser > (firefox or safari) into an Emacs buffer. > > * I've tested this with two different builds of 27.1 -- from > https://emacsformacosx.com and the "emacs plus" formula under homebrew > (https://github.com/d12frosted/homebrew-emacs-plus) on both OS X 10.14.6 > (Mavericks) and 10.15.6 (Catalina) > > * Reverting to Emacs 26.3 resolves this issue Confirmed. Annoyingly I could've sworn this worked just a few months ago. I wonder if Apple have changed something in their libraries to completely deprecate the old methods. Anyway, It'll need to be almost completely rewritten (again!). -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 14:13:10 2020 Received: (at 43470) by debbugs.gnu.org; 17 Sep 2020 18:13:10 +0000 Received: from localhost ([127.0.0.1]:39005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyP8-0004Rr-C8 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 14:13:10 -0400 Received: from sonic312-26.consmr.mail.ir2.yahoo.com ([77.238.178.97]:38292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyP6-0004RQ-6k for 43470@debbugs.gnu.org; Thu, 17 Sep 2020 14:13:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1600366381; bh=TBvCIOKEbIrb729MqlsPxZYxL5J3Uj15wRuRMaXo/UM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=EWLCVls4zIdiOPQvwGE5kIyYkg5sJsk6Clbkbrdxf25vgva23jo7VBQ5knQgdnFqd2zHkjwbl2Z2sev6uJWqKbO9/R4zAxNfux+wwZ28tn3D7TtVYzjOLFskcOkPcJAntdKEqGEAli7oT/X9C18MfNpzcjbC3ASKPLq0IMxrW8x2xH0L1ZQZD4l/wj+JtTpU7Cbj65MEw+kiPJFXKd14witEaVv7aUgje4g6eBIo6/r5n7uvTnsCUx+k+1iyIyDpyF5eAscgPjXl+x9ExgvahRtmBJA0rpr4zd+zw3OMbq6/lFGBcZ88GqcUop/GgFhm1TV/pRL9OfaTJBegb2ij+A== X-YMail-OSG: lv4.dPUVM1k1amcFmSyjrnbyBco59siE6fig11JNz53I6dduCCR7CRaCLLmK7hf PWfzbVk5gnJrhaEKR2pGa706FPIMceJoxVM1pZ35RHMLOF9g9jXG8CwjUnCbPiR3CRuRWtcFOBTN WTNp8SOob59u3tCzxspuFGISxQ6g0CkVg9ntDLPxn6YF2CSZBNhgyeZR5Zunfz8qVwBE58Sg1vnH _PfyxDv0yTFmTjXknKpDsV9zaB0iLzuSnMFSlh7rUFan5.MLKbWayTESTfXkIdvt4lgYDRt.gYRY _pAgkO7s4Q9ZJ32WbYtNmrQfSmV9i9c3F7SeKZABmqzZyB6BvD4f9gZQ2yaKtGoDLxy45F0_x02S Vi9BgpL0MVFsjy7eYNPrca.HtUW0dEuF7U_5fp3w40gZimmddtl7S0ZbJR5YuMa_RToorQ.9Nj_1 2pWh492suDWWftMX_ExrCD0V9bpU_vrWFGeT_IHTzs6nkBG_Hy9d9BEpH7z7X38VlEYS7o7Q0tlf MUknaNzjZL14JcOPwRPFB08wUluIN.IVhjc_xUyotKAfWsuyRtmWoG3slSoJWxaCaHBUstVykDz6 S1ZgnLoeu.KmbiVAkib.h9ZoNXdHoDyR9ZBiT2aPlPy0v5SUV2HCaKSaQ8XjvO85ylnR3xEQsia3 NN8_Z2qrNmAUL.UGHdA7BmONa5OW9KerD1xmRLQ3zwP_mUNVvq9E0BoOWVkKk1gf.we640_OupKk Q6vtnitG3dIiiaw7Kgz73P1x6zAss_S9.qQLEyL1o9MW5gSVTyl4nbEBop5uww8iOtM4.iwQ2.wn uk7wOwHaHY6VFCYvz20QVio26vG6EVOjs7.WeyDfZ1xWhzd1HTUZbb_zw2ApgQ4vi1i.duInKCbK 0lBUaLpYfqgvauLhwVaGk7u81YlOHz.jiapKHND9Mp6YnFVpxXtEyMzStUn2xv9qOqLFPbmWx4HO NHPXFTlWLI4eBnZu5djKBvERb6sNiueMQxb6sQJ2Rx0jQ4_QO3gN9Xie.wlfr_uJvaizV4zXHUtP d6L1t9j89vkcc9BcRfleWofYwhi3wQ58zyuRr7fhePBf9VbIpVUN4tOicZP2Rx3Rj8MI46zWJzKm b3oupxfrexwl4l9tKHqy28GGcfGQ0i4jgvu4yTS4jozgyXdjbK6.K6B_cY4L.Xy2nJ9df1uzsdTe rsOJHZqA1CNd8jjBnYoEFviHcYCO8yfsYLB2AncvfcrfFq7NgFiUyfu2gHaKCzM9sxGuF6Q6rSZn 9zh67pud1ZQfmwVoI13KCo.EOxQdM.KAI0MZfycSXPMjPhTh_X6MxazTSc.s.LFYd.Ov64bE6idi XmCEy4BQR6wwHzg3LubOSO_d4FmKDlca0DGM5AHgFnB3du1R7rQ2G5u35KOwF6.6cDgfCJkfIIHi XLdsoJS_pAR2HhHz8eJ9.sCpMz6vnM39bdrJmD9NlAiOTQZa9ALGQTMIrCq8L5lNNhA43vy36Uxj O9juzJDZfPye.CZcyN6HwOTT_QVMyT9gkJaDgfOg0J9z38kwHFsEtmtOP2Om65EPMRrBudg-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Thu, 17 Sep 2020 18:13:01 +0000 Received: by smtp409.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 7045f220e0d039d4230704eaefd55b5c; Thu, 17 Sep 2020 18:12:57 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Alan Third Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> Date: Thu, 17 Sep 2020 20:12:56 +0200 In-Reply-To: <20200917174640.GB635@breton.holly.idiocy.org> (Alan Third's message of "Thu, 17 Sep 2020 18:46:40 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Content-Length: 2478 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43470 Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Alan Third writes: > > Confirmed. > > Annoyingly I could've sworn this worked just a few months ago. I > wonder if Apple have changed something in their libraries to > completely deprecate the old methods. > > Anyway, It'll need to be almost completely rewritten (again!). Hi, Alan: Could it be caused by an incomplete rename done at https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9624f609493da7c08016ba00d6895bad0fe26a0e? The following patch fixes the reported bug for me on 10.15.6 and Emacs 28.0.50, and also fixes some compilation warnings as well: diff --git a/src/nsterm.m b/src/nsterm.m index 26059ab67c..c40f790e0f 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -5648,7 +5648,7 @@ Needs to be here because ns_initialize_display_info () uses AppKit classes. ns_drag_types = [[NSArray arrayWithObjects: NSPasteboardTypeString, NSPasteboardTypeTabularText, - NSFilenamesPboardType, + NSPasteboardTypeFileURL, NSPasteboardTypeURL, nil] retain]; /* If fullscreen is in init/default-frame-alist, focus isn't set @@ -8592,10 +8592,7 @@ -(BOOL)performDragOperation: (id ) sender { return NO; } - /* FIXME: NSFilenamesPboardType is deprecated in 10.14, but the - NSURL method can only handle one file at a time. Stick with the - existing code at the moment. */ - else if ([type isEqualToString: NSFilenamesPboardType]) + else if ([type isEqualToString: NSPasteboardTypeFileURL]) { NSArray *files; NSEnumerator *fenum; @@ -8610,7 +8607,7 @@ -(BOOL)performDragOperation: (id ) sender while ( (file = [fenum nextObject]) ) strings = Fcons ([file lispString], strings); } - else if ([type isEqualToString: NSURLPboardType]) + else if ([type isEqualToString: NSPasteboardTypeURL]) { NSURL *url = [NSURL URLFromPasteboard: pb]; if (url == nil) return NO; @@ -8619,8 +8616,8 @@ -(BOOL)performDragOperation: (id ) sender strings = list1 ([[url absoluteString] lispString]); } - else if ([type isEqualToString: NSStringPboardType] - || [type isEqualToString: NSTabularTextPboardType]) + else if ([type isEqualToString: NSPasteboardTypeString] + || [type isEqualToString: NSPasteboardTypeTabularText]) { NSString *data; From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 15:46:52 2020 Received: (at 43470) by debbugs.gnu.org; 17 Sep 2020 19:46:52 +0000 Received: from localhost ([127.0.0.1]:39161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIzro-0006wZ-Fe for submit@debbugs.gnu.org; Thu, 17 Sep 2020 15:46:52 -0400 Received: from wilbur.contactoffice.com ([212.3.242.68]:37686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIzrl-0006wK-PL for 43470@debbugs.gnu.org; Thu, 17 Sep 2020 15:46:50 -0400 Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by wilbur.contactoffice.com (Postfix) with ESMTP id 412761106; Thu, 17 Sep 2020 21:46:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600372003; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=1346; bh=cVpER9HRrUokLguCZH4d/bLuxjam0AGsR36//lHdX24=; b=eEibHnJuzqjrxPUo8N36tUhRdC+2FVxeQeiPJHrtLEsZ4T5B9OyxE96KOhyE25NK yL+Vv0OHYTG3wdLr89kUW/Exo4xev8MK2MU0y6QEdJicaxHC5xUbzqjr31DJHUR0EvQ UgUp9y/11t9nwzEGjUszZOkFr7g/ZGWMpzkoWMYEpXgcjuME58+X93pGMgbCdnqeKbW gd/ZuEgMsRTKKe9W7o6ucxrfmgh5kelM+gGVThFCofo7IRXifQSIW+85W0EUoMVGdlU PNdLU1RGtk8iitK+bupmSYmGWwKUwzRtof2ldyjZ4sevvOUfq6klzb0+YTWcizNjVp2 90LcV6+PNw== Received: by smtp.mailfence.com with ESMTPA ; Thu, 17 Sep 2020 21:46:38 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 92712202563B6E; Thu, 17 Sep 2020 20:46:37 +0100 (BST) Date: Thu, 17 Sep 2020 20:46:37 +0100 From: Alan Third To: Daniel =?iso-8859-1?B?TWFydMM/wm4=?= Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Message-ID: <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> Mail-Followup-To: Alan Third , Daniel =?iso-8859-1?B?TWFydMM/wm4=?= , "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.1 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43470 Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Sep 17, 2020 at 08:12:56PM +0200, Daniel MartÃ?­n via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Alan Third writes: > > > > Confirmed. > > > > Annoyingly I could've sworn this worked just a few months ago. I > > wonder if Apple have changed something in their libraries to > > completely deprecate the old methods. > > > > Anyway, It'll need to be almost completely rewritten (again!). > > Hi, Alan: > > Could it be caused by an incomplete rename done at > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9624f609493da7c08016ba00d6895bad0fe26a0e? > > The following patch fixes the reported bug for me on 10.15.6 and Emacs > 28.0.50, and also fixes some compilation warnings as well: IIRC (and I could definitely be wrong here) a simple find/replace breaks the ability to handle more than one file being dragged at a time, which is why I left it (it used to work fine even though it was flagged as deprecated). Obviously that doesn't matter if it now no longer works at all, but we need to retain backwards compatibility so any patch will have to work on GNUstep and older versions of macOS. The bottom of nsterm.h shows how we've handled that with previous deprecations. Can you check whether your patch handles the multi-file case? -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 08:00:32 2020 Received: (at 43470) by debbugs.gnu.org; 18 Sep 2020 12:00:32 +0000 Received: from localhost ([127.0.0.1]:41127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJF44-0006zu-2B for submit@debbugs.gnu.org; Fri, 18 Sep 2020 08:00:32 -0400 Received: from sonic313-20.consmr.mail.ir2.yahoo.com ([77.238.179.187]:37741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJF41-0006ze-HH for 43470@debbugs.gnu.org; Fri, 18 Sep 2020 08:00:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1600430422; bh=X9VUk/kvqAK6NrRWsJ4kerqzLEfAOUtTKE6WJmHul1Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=Z533XKZr+3mxOp5XIX4GkLRGNwXa+T6xx+nLBK9EENh/qkozUXRbVL0UdS3jPNPJFrb0ZFachhU0OOyf7GX+TsyVkZdh0M7/4g9fmzTkDmvbgIVgvaMpskIEkdT8osVofGmjyrxqZBbHpuEPn+QQNWopcxEH6Y3Nu8DbhQBQpFMrQbstWWwdIAiisqrZ02qGDGFYmOvoQmTyH6ueIJce71ROR0SYJwP0I9/7SvG9LkHiKZEFgLddUHnDtfhj0g9W9pmXmjDQVJse0rAymV5C2i7h+XElM9asdlD7OlFy6H76ATdFI7fTmqu+tilK86UW0FEKPnt/kdoW7HznuyMt+Q== X-YMail-OSG: GB3pXtcVM1mytzqg5KYlPNne1sCxrSrcmsTEQKlSCf6nlygfNbG7uVzL0fl0x3t gzMuPeh3gs9al2HFlXxhku_VpIxhwyDzDxRCPXDAKXR8zPLQQgw7mybwMcqOO_Ijm6vSzdd669z5 a6qwwpNI6SMox2WF5y6XrjH9oC9bIonjfzxi0hIrbekHoS.wRdjRkajJFE1YdiJHRena7CSw1R9V Sk9269qWaQNcd6MoSIO3sGy8x19w.qaF9H5IMGqJEjf8.R596NIbmF6QBRRkUvq6c0oou1mJ.wq3 CfPgyAzOJ4WbebM5A5elg7AHiudHVukxhySOv_sogDCaFmkxg6fex_Uk1zfctVXs0b8iKIe5ePHM 6XWXy2UCrMw5WK_4B0sOBSgmvf5rMX0kmcQofXnv_kllSdIWeR6HJ8COFsNV0i9RitLJTrgRxIZc KBKkQPOnaYb1Gk6DZo0QEvSav.5XuPieOLKYaVzOETiafcDFrQoUZeBObX4dDzCPnzpI9Yfr96MN K8Ama0E.j9spqOg3GmyyWkCvDwMaNzIkwQQymtCSo9wngz7DSlcpKwWxMSP2bUcincEmf8eR1FeX 0GhfsUk5axGwMJdQa7HV_ocXhii6wjPze1_ZP5W.6Ltw_COCWSrTD7Yp1LRm_fFeTxsRKhJYeeDD uobj6q.4Szz42ZJBgeB.gGOMHtVdnGtEV5qgNd_jIzk.dtLaoF9Bvj.OiU6LT8lalzli9c8pueq0 1E8IIwWAJvUPx1_Umms5hszGb63Gc6UxT2KW6vCnsOEjrXY9zBeCsINirFvDTth5jxPbZafOG1Rk U5ngcg9OYk1620vwfVEcs5Chc87SR4XrWzkIH.dpL6XD94omn_zUVzzRLpYGa.2WuXiwBRPn2P5d GPClIJ3pVdxB3Eug5AtEqmcCapUpTjbheXGcgqDj8c6bg4rlyMNiXJXxMG1s.k30zJiCG2mJRJ2. GD4ijP4OGlCE3iJai2AqZ03vjpv_rKrQD8qCVjZY5UE89Gaxs19MWSoVFoKaQZY6g.aYqn4ek4cd Lgl8tP9MxtHpW3r8LKUhQdPfXzIiGnF8kQ.9pTB4o.g6gwL43FQsflETFIdY6X9I.nf867TxZptI cYoIcfMtgdjlPTUOTfAjYh2hf3CEPoxwQm1qXVUYEcA_IUckWx5oxy5ZZ.6PLLEhCZtskn_y4KDt B.hdbkSY0a5wlj25OolvqnyVQHeJSk9axW.a09OGtubn9.sba6vcTP9ia9TS3qNavfUHlJdFJHpB 56d2spxTtOFdwnDkyiv01veudX1D2YvRvZQhtXlR1uZzw3zKjB2l_wgJpiiukeieiQJtx80buT86 3l2uMfqmYRY0NzHBnRU4tjDNP74bQX08CUweSAfpPlowtd9cGj3y9h7FnZFWvzteOT0G_bofAR5. D4HxYKOAhTRys8790ZLThAImbXqtV2CNsS9SnsVd0VdcJmSISIiYTtrzLZjTEhUqEVUBz73k8sN5 xkcDlLlAH3Xr1ByOcNY5bq6Itiz0dRFQ42lyBP_TadKAJC2lmxDT8Z3WlQO55sRcEOUxGiA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Fri, 18 Sep 2020 12:00:22 +0000 Received: by smtp401.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 01cd9b9724bc67aeec54e4895fab3101; Fri, 18 Sep 2020 12:00:18 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Alan Third Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> Date: Fri, 18 Sep 2020 14:00:16 +0200 In-Reply-To: <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> (Alan Third's message of "Thu, 17 Sep 2020 20:46:37 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Content-Length: 2706 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43470 Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Alan Third writes: > IIRC (and I could definitely be wrong here) a simple find/replace > breaks the ability to handle more than one file being dragged at a > time, which is why I left it (it used to work fine even though it was > flagged as deprecated). You're right. I also misread the FIXME, which mentions this particular problem. That part of the patch is not correct. I think we need to use the same constant names as those that are included in the ns_drag_types array, at least until we implement proper support for the new pasteboard API. This means that three constant names should be renamed in nsterm.m. I've attached a new patch that implements this idea. I've tested the following drag and drop operations work correctly after the patch is applied: - Drag a URL. - Drag arbitrary text from another application. - Drag tabular text from another application. - Drag a couple of files from the OS file manager. It correctly creates a couple of buffers in Emacs that visit those files. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-modern-constant-names-for-the-NS-pasteboard.patch >From 8d50e8c08600306a6355014d90eb21b1b15af59e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Fri, 18 Sep 2020 13:36:47 +0200 Subject: [PATCH] Use modern constant names for the NS pasteboard Use the same pasteboard constant names defined in ns_drag_types. (Bug#43470). * src/nsterm.m: Rename NSURLPboardType to NSPasteboardTypeURL, NSStringPboardType to NSPasteboardTypeString, and NSTabularTextPboardType to NSPasteboardTypeTabularText --- src/nsterm.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index 26059ab67c..bab7a0abb9 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -8610,7 +8610,7 @@ -(BOOL)performDragOperation: (id ) sender while ( (file = [fenum nextObject]) ) strings = Fcons ([file lispString], strings); } - else if ([type isEqualToString: NSURLPboardType]) + else if ([type isEqualToString: NSPasteboardTypeURL]) { NSURL *url = [NSURL URLFromPasteboard: pb]; if (url == nil) return NO; @@ -8619,8 +8619,8 @@ -(BOOL)performDragOperation: (id ) sender strings = list1 ([[url absoluteString] lispString]); } - else if ([type isEqualToString: NSStringPboardType] - || [type isEqualToString: NSTabularTextPboardType]) + else if ([type isEqualToString: NSPasteboardTypeString] + || [type isEqualToString: NSPasteboardTypeTabularText]) { NSString *data; -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 08:54:40 2020 Received: (at 43470) by debbugs.gnu.org; 18 Sep 2020 12:54:40 +0000 Received: from localhost ([127.0.0.1]:41208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJFuS-0008Jv-67 for submit@debbugs.gnu.org; Fri, 18 Sep 2020 08:54:40 -0400 Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:46070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJFuP-0008Jh-DD for 43470@debbugs.gnu.org; Fri, 18 Sep 2020 08:54:38 -0400 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id A00C515AF; Fri, 18 Sep 2020 14:54:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600433670; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=1560; bh=6f3JkgsLFJCV5SVoDTvymTwHyudXUELFTHHuSKrVCl0=; b=Udq1chqmb4Hfkg+KXGWxE/kxZOCHNcgnL79DY1K/p/9KI1xhI91sKXsBMXjeSYe2 tyIuw/csNFe7A18eNCQBYIHkFr3V0taxmlPExB9AaSLFyXWOzd2WupQKP4FBOCXypR5 m6K8WDdwBLpQKPN2SOw+cI1BjN3D0oyzPcfamaPEcNgsNX3UGWGlTDAQDRr8AL6yHfE SJ6upwJFbljYAspLW6woJaCODNjhxocKT6t82R7vBsT2Z393tXqpiFpyHi7Q6H8m6Oi sRaQxbwISFLw11A6TrNioA3NZAaGmqGSQV5rzbnsx2sfpAnj1NdYiZda0Je/mCojsUQ LOE7GwnyXg== Received: by smtp.mailfence.com with ESMTPA ; Fri, 18 Sep 2020 14:54:26 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 30ED020256B8D7; Fri, 18 Sep 2020 13:54:24 +0100 (BST) Date: Fri, 18 Sep 2020 13:54:24 +0100 From: Alan Third To: Daniel =?iso-8859-1?Q?Mart=EDn?= Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Message-ID: <20200918125424.GF635@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , Daniel =?iso-8859-1?Q?Mart=EDn?= , "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.1 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43470 Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Sep 18, 2020 at 02:00:16PM +0200, Daniel Martín wrote: > Alan Third writes: > > > IIRC (and I could definitely be wrong here) a simple find/replace > > breaks the ability to handle more than one file being dragged at a > > time, which is why I left it (it used to work fine even though it was > > flagged as deprecated). > > You're right. I also misread the FIXME, which mentions this particular > problem. That part of the patch is not correct. > > I think we need to use the same constant names as those that are > included in the ns_drag_types array, at least until we implement proper > support for the new pasteboard API. This means that three constant names > should be renamed in nsterm.m. I'll have to have a look at the new API again, I can't remember anything about it or why I didn't use it the last time I worked on this. If you fancy giving it a go, feel free. > I've attached a new patch that implements this idea. I've tested the > following drag and drop operations work correctly after the patch is > applied: > > - Drag a URL. > - Drag arbitrary text from another application. > - Drag tabular text from another application. > - Drag a couple of files from the OS file manager. It correctly creates > a couple of buffers in Emacs that visit those files. This looks good to me. I think we'll want to apply it to Emacs 27 since this is a regression from Emacs 26 and the fix is minimal, so can you please rebase against emacs-27 and I'll push it there. Thanks! -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 14:34:48 2020 Received: (at 43470) by debbugs.gnu.org; 18 Sep 2020 18:34:48 +0000 Received: from localhost ([127.0.0.1]:44375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJLDc-0003Eh-5r for submit@debbugs.gnu.org; Fri, 18 Sep 2020 14:34:48 -0400 Received: from sonic302-21.consmr.mail.ir2.yahoo.com ([87.248.110.84]:42141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJLDZ-0003EN-2n for 43470@debbugs.gnu.org; Fri, 18 Sep 2020 14:34:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1600454077; bh=dzxGWK3pAyj83K1RCJApC8SFgWX9FaG5kZypiTZdVtA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=e64EHbQgmtGgKGl8wBMJxONMdahw2FW+fN0hsnipZYtM+lto2cwgoX18/xfIKUGDIe05Kskp4sl+0FZ2nTd4CjbBtHegXDnOrY3ScRVswC2M9LC2V1iJzJ+Jd5ixJIqrKt1o3hyTrOnButOcwmENqz2lKmF+mk5a7xoIwlxzHZ2DLU59pIkw1DuwZuoppScSQbyoBNyokqkC5XhU1IeXBjVcSeOupOJtcw7sl4fXhDDLiqNtdNo6eP1qZG15jy2k0FOjEDqaIYUyjOdTBLgN8fcwtWkDzlrS7FzUUE9AosKRPNpaqQkwhYItfXJ3EFQAoFZIvkjlMASY0Xxj1oL0pw== X-YMail-OSG: SJruLNAVM1kXMZwGrkYP45Q09L7vn.hjAQHv57tVOZJa2vpLfNV2wYMSfvjeW1w .NA0a1CQj3Fq9HVBbfiXG.BXFYJ7_FRY1i1qJ6afHyQHd6WkUpAnryRA81mIUsPNj0Xsf2H.10aE 4Bw6p3jB.qLj85fHgPyPLhc.ISUI4TiqIlLM9pFXS_PFBqZo5dzAsU0Od2jnxvYch8ld_X4q6ncM skBEUwicucC8pHPTNNKOr.TS0kFzbjcUHc.sIjJBFF5rrufqNClIb9YPtRdUNRnvBXVfMxHgYNAv 4iQyk7v_Ly4FCkDk5VXXOxQb0s86lQEKUeTSuFPlJ05XNs2h5OekwXBpzqtq7uFocXn02mZHhO9Y wIIDhqDooBw09UuoAX4gb6fMTPcuEKVVDA.P25d15MV.rp8msW5xOXFH8sl7jM.yTin8DaJikLtD DlCvqATtgnJGHDVm5Pg2fEi05Pbc.YSJ0sSkM0gKH2qYjOkQ8vZVXCJbaqFmzhOaquwhSVQZYWh7 QM5i.20MKKkv.XP5mC_CerR9ogppKK1d_D0O3Yg_a7H4W0U4QaH62QjWB.Gx3b6tF.E4XiR4Vlaj CCBpAKuYOy8uFvE9xBYnXFeMAm7NPl4chj_Mc10sSQ2sy6mFRTlhfpZ286VTp7lfh9PY2JYOF._i TLK8x2QIyxRlxXauJL9dkPJyjZRZKG9XJwNYTmgyJ7C.cx3Sa_Xg6q.p4XmM2Ryfeji3cn1WQDGM nKQJVrDQ_xFESMrBbbe.a3QNJ5HEMeAC_pPmZp4kkeDKpCVG.8ZAv6srLx7uIp94ojQIcrpEF.tr Bli4V8lU7vyqeBY9PJhlRe5dDSWJqCZ7CbixdnSrq4irdMgaDSnYyPWJkShOahikLXjZ043qas_J h7UlznNNBgL9BfXE6Kz0PIPk6JkKJxzmpu9cyYMtdy9rQXNMvaj_tFnxrG.ouiPbV027dB40PPls HJwQu7Dy.SEDiAxLzJAjhL2vSuhbM5ruJ9To9iIgZ0do680HH5rLPhB_cyMSWyEfHF.qT62WqOoS DhXG3libe_7YTn3gOdAn6KtbJwWpSB_RFbBqXOYJ6nkNj67rU.XSpgG80l2RW6wbNOPyWw4y4zzu MN.ftjVHpecIFbF6ONjdfYeij26FSzpq9YoTFQ976PWoWUbFvObQFUwQpeOWTg.2sSVUEJ7iBAyR aNaehGADvt9KwmO1BueI6poL_K6R0WkNNWeLZYr1KZOYGlOD_szp.HMwCpKx3BRoBUsZjmSVXAGO 7ZdT0PeNlchg5ikLfO9gs7fBzXlvoGfsTuvsmBYmn7eWR2vxwuWePV3v4ozLdl.ygS64FHHDSZDY aO7ydUYkz87yz.TGLgGSSgbKqF6LqiclPmafYe5UwJObDhi13VyuPwC.URr.o0dOVgsi0ow6DmOT Xz3Ossaaj46N_Qm6IqkMeKGZRsiMMojDeHNdyscXx36p8D9b4ikw7Vzx_wE2WomTOBeBiFhQGnQx Ixo4V..6eQ7aP8hjVL5zquJvbwS0l0W_T.QSk_j6WOF3S2Rk1v8hO2HSNxzmkXGqDaZ2LbhtV Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Fri, 18 Sep 2020 18:34:37 +0000 Received: by smtp422.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID af085012336e8c77b7adfe0d4cda1222; Fri, 18 Sep 2020 18:34:32 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Alan Third Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> Date: Fri, 18 Sep 2020 20:34:30 +0200 In-Reply-To: <20200918125424.GF635@breton.holly.idiocy.org> (Alan Third's message of "Fri, 18 Sep 2020 13:54:24 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Content-Length: 2043 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43470 Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Alan Third writes: > > This looks good to me. I think we'll want to apply it to Emacs 27 > since this is a regression from Emacs 26 and the fix is minimal, so > can you please rebase against emacs-27 and I'll push it there. > > Thanks! Here's the same patch applied on top of the emacs-27 branch. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-modern-constant-names-for-the-NS-pasteboard.patch >From 4e3dc31ab100467fb39bce6e687aef029f0d3225 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Fri, 18 Sep 2020 13:36:47 +0200 Subject: [PATCH] Use modern constant names for the NS pasteboard Use the same pasteboard constant names defined in ns_drag_types. (Bug#43470). * src/nsterm.m: Rename NSURLPboardType to NSPasteboardTypeURL, NSStringPboardType to NSPasteboardTypeString, and NSTabularTextPboardType to NSPasteboardTypeTabularText --- src/nsterm.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index ac467840a2..3dd915e370 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -8363,7 +8363,7 @@ -(BOOL)performDragOperation: (id ) sender while ( (file = [fenum nextObject]) ) strings = Fcons (build_string ([file UTF8String]), strings); } - else if ([type isEqualToString: NSURLPboardType]) + else if ([type isEqualToString: NSPasteboardTypeURL]) { NSURL *url = [NSURL URLFromPasteboard: pb]; if (url == nil) return NO; @@ -8372,8 +8372,8 @@ -(BOOL)performDragOperation: (id ) sender strings = list1 (build_string ([[url absoluteString] UTF8String])); } - else if ([type isEqualToString: NSStringPboardType] - || [type isEqualToString: NSTabularTextPboardType]) + else if ([type isEqualToString: NSPasteboardTypeString] + || [type isEqualToString: NSPasteboardTypeTabularText]) { NSString *data; -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 15:11:21 2020 Received: (at 43470-done) by debbugs.gnu.org; 18 Sep 2020 19:11:21 +0000 Received: from localhost ([127.0.0.1]:44426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJLmy-00048Y-SJ for submit@debbugs.gnu.org; Fri, 18 Sep 2020 15:11:21 -0400 Received: from wilbur.contactoffice.com ([212.3.242.68]:49752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJLmw-00048K-S8 for 43470-done@debbugs.gnu.org; Fri, 18 Sep 2020 15:11:19 -0400 Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by wilbur.contactoffice.com (Postfix) with ESMTP id 414181717; Fri, 18 Sep 2020 21:11:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600456272; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=737; bh=NBGnKGzQjZsDwdkT+nHaTzS3NI2uev5t5xAihG9oaoc=; b=Z5T+FYBhtrwzwmmItjBx9Wqw5d9yN5nN78K7IRjyVKTbKihL7vBCRJ4uXXBJqG12 76dlXFPHNdLLAX4SPvzo75Gy46FSofsUr12WVZUB7yNq1zYJB7M/i770ZMCiiKMSpdz ycCLqMm8TVSlYHaxHaghgLgj+XujY+yYxsQ72KA9lUaHrMJW9mjGcLPVZteJw0o6o2O 8hhk1SkFpeOkr8B1x666s8eJeGqrdpactB83Os5CAx9BwjNpceCDis8jIhvurlcUL67 6XCnjYxAk/RzbTDROUDevZJBexqxS5ACZRIjNwv0iZ4jMlC0Zu6G4WLcnGRznGejAs3 NEBS+XfVMQ== Received: by smtp.mailfence.com with ESMTPA ; Fri, 18 Sep 2020 21:11:08 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id BCE5C20256F8CA; Fri, 18 Sep 2020 20:11:06 +0100 (BST) Date: Fri, 18 Sep 2020 20:11:06 +0100 From: Alan Third To: Daniel =?iso-8859-1?B?TWFydMODwq1u?= Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Message-ID: <20200918191106.GH635@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , Daniel =?iso-8859-1?B?TWFydMODwq1u?= , "Paul Magwene, Ph.D." , 43470-done@debbugs.gnu.org References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.20 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43470-done Cc: "Paul Magwene, Ph.D." , 43470-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Sep 18, 2020 at 08:34:30PM +0200, Daniel MartÃ?­n via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Alan Third writes: > > > > This looks good to me. I think we'll want to apply it to Emacs 27 > > since this is a regression from Emacs 26 and the fix is minimal, so > > can you please rebase against emacs-27 and I'll push it there. > > > > Thanks! > > Here's the same patch applied on top of the emacs-27 branch. Thanks. Thanks! I've pushed it to emacs-27 and it will be merged into master in due course. I'll close this bug report now and if anyone wants to modernise the drag and drop code they can create a new one with the patch or whatever. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 17:27:28 2020 Received: (at 43470-done) by debbugs.gnu.org; 18 Sep 2020 21:27:28 +0000 Received: from localhost ([127.0.0.1]:44611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJNui-0007Q3-4F for submit@debbugs.gnu.org; Fri, 18 Sep 2020 17:27:28 -0400 Received: from smtp-gw-11.oit.duke.edu ([152.3.189.237]:41440 helo=mail-gw-11.oit.duke.edu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJNug-0007Pq-3L for 43470-done@debbugs.gnu.org; Fri, 18 Sep 2020 17:27:26 -0400 Received: from smtpgw-05.oit.duke.edu (fitz-bigip-0102-ltm-a-mx-gw-floater.oit.duke.edu [10.136.241.66]) by mail-gw-11.oit.duke.edu (8.16.0.42/8.16.0.42) with ESMTPS id 08ILRKqG026006 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 17:27:20 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) by smtpgw-05.oit.duke.edu (8.16.0.42/8.16.0.42) with ESMTPS id 08ILRJh9010033 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 17:27:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O0TdQEDISSDcsHpRX4Y/oeljhjsemtxDzeelCh4fOnrvTDCOzanUOeLFnGb/Eyj+c9N2c8SjBYbWhtOxKbW5BkBx9Jpg+bQeq+Or159sZgXcQdJiO3D9RmKIEpIfbm3RNq6P3MGeRKswVd8ya8cviXmIoj9NmqBIPzp+LNyDlYdN0q2Nqqqw9L1CFuaCA1v9SHci8dSHQF0g3FDFUT5LVYs9IxNyexw0TB3bWHOvGVGRmw01+fdFCcWEKFJijMiJPIjycVAhsOI8/GrO3X+vZavaFq1rImnWYjLpQxmH/KTNPH8PHShXi21P9+QYIs8PzPuAA4Hao/V7y4+P/sRNIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dL0s8Ptgx6Y9j5L/32i6GrBbQ0c67Ls9Aty2pL31Arw=; b=OqX+C6QlV9N3Sbj8bImOrBVSSU24wRhY4ejpOjPT/lJRXH+y0gzw1qeVEXEYQIUWu5VGg2i1OfgaRuj2dLHWtB+lJNtxELHdial0O9bk1moopok11Q24I9tZ7rp7TyOIXe+kfDvEQGnoVeTSRjJKE6aiozlFTo3WhI3Q3wGTbPxYrxBjSaRYMPzKTARl2Bl0gvwO+btCpnw7OL3zDpAGsaqFUr9RSamMh2Bq9LI4TMPqSmRvsa/VswKQ3cZWxJkyruAHLAq+EVSZqNrrbyf+t56K59eJIUNRY8Kh4Mdy4W1XzLYc12pKgx8rljP60rU7jqkTdEd04Izmz/UeJ2jWWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=duke.edu; dmarc=pass action=none header.from=duke.edu; dkim=pass header.d=duke.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=duke.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dL0s8Ptgx6Y9j5L/32i6GrBbQ0c67Ls9Aty2pL31Arw=; b=cQn1BmA0DozAwZvzibyg6HdfkR2dDp8szlr4Odz5qqXWA3jLPXaZ7sCXXin8KjB6fAhkfKY2A0pln4eIu6vHW/oRJr/ZT8e4b7QRGnJdJe3416kFiovOZfQXmzrZMIGHQf9xSj7AK/Iqva+IXXJo4mKGskaRq/Zj5/phJxNrD1Q= Authentication-Results: debbugs.gnu.org; dkim=none (message not signed) header.d=none;debbugs.gnu.org; dmarc=none action=none header.from=duke.edu; Received: from BL0PR05MB5587.namprd05.prod.outlook.com (2603:10b6:208:6c::28) by BLAPR05MB7492.namprd05.prod.outlook.com (2603:10b6:208:293::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.8; Fri, 18 Sep 2020 21:27:19 +0000 Received: from BL0PR05MB5587.namprd05.prod.outlook.com ([fe80::196d:ac30:b2f6:f3d4]) by BL0PR05MB5587.namprd05.prod.outlook.com ([fe80::196d:ac30:b2f6:f3d4%7]) with mapi id 15.20.3412.006; Fri, 18 Sep 2020 21:27:19 +0000 Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX To: Alan Third , =?UTF-8?B?RGFuaWVsIE1hcnTDg8aSw4Igbg==?= , 43470-done@debbugs.gnu.org References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> From: Paul Magwene Message-ID: <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> Date: Fri, 18 Sep 2020 17:27:17 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 In-Reply-To: <20200918191106.GH635@breton.holly.idiocy.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [107.15.37.134] X-ClientProxiedBy: MN2PR16CA0019.namprd16.prod.outlook.com (2603:10b6:208:134::32) To BL0PR05MB5587.namprd05.prod.outlook.com (2603:10b6:208:6c::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.0.0.2] (107.15.37.134) by MN2PR16CA0019.namprd16.prod.outlook.com (2603:10b6:208:134::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19 via Frontend Transport; Fri, 18 Sep 2020 21:27:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0085a9ed-76fa-41f4-0359-08d85c199f42 X-MS-TrafficTypeDiagnostic: BLAPR05MB7492: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UeQNK/nUDxGuvuUPjlhZ7a6kzjEHSMnKtptprHbMatH+AgC/9pwmaZWsx2dyFanHtfxaK4SqY0pnpETsoeCaYnckgXxl0OFfn3ngsmXkXm8JuPiJFyc+wc9uWsP2L5KWmhMjPtn8dM1lR7D9j0ThgjZ5T9/gEpjKmOuyjzy7IswB5RKq4CVPF9rE5afxrsr7g8ou4Ojo1cx0oCWRSIDPEJEoaxpZe2MBrRY6syaktNRfxhtPzGPqvDPhn1Tsx/PccHabB/TFl97WS2GUgmgLL4oDZZ+z1n8T0uoUjSzqdcGWEFn0d/KZuU6W9Nim+VjjAaF//RkNx6ksZwO27sesoE0Hk68kjkwyXw1UiSaLoarNn4LRUMf6GwB5ZegBz7D89pG9uD2vctrok0Y+Tpajo+oZiCpdoI52RtsfPMnhH4N+gF/5cRDSfzjMYgOYUNkdfBMc3i5J4dnRw45Yql64xQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR05MB5587.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(376002)(396003)(346002)(186003)(53546011)(31696002)(2906002)(110136005)(86362001)(75432002)(66476007)(66556008)(66946007)(66574015)(83380400001)(5660300002)(36756003)(16526019)(52116002)(26005)(956004)(8676002)(44832011)(8936002)(478600001)(31686004)(6486002)(316002)(786003)(16576012)(2616005)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: jjIu8k5q+kMO4VOx8DPwLA6zDj8z54LlpvBdfKUW4jWPiTZEvYBA10X/je+HvdHIyYPKGV85ZyVLFll9PrpjeuJwQc0agLVcR/K74IoSLWCxxrvWGXBSRHyMOp8d7eoa7yjfd31nRxbIpvGCkAId2Qmk15V4b440mPrUvVQEwB9oI0PHzH1F+7VSAvxtIQ4CilnNzPIW+XYo11qFSQiYCcStuj4Aja9TiX5+to+9sdG2UO797NX8v9aUtAc4i12a/WI6j5lYT5+LFoHwqMw/onVnCf5EEHQguLs9+J8H/uQsCrjv7dpD07+fn+98J755YnRZAqIqJSEKeWxnGTnSZpn3SWVPSJSmi8iNc4IrdLDeAJ4ZL/pfInESVf2I4gxOUrws1nVX31q3X9+nQUYBQQaRPghsJyAMpkHHkHEIlEeqtFcUsb5EYf/SdjJI8/Flun6qQjDvzBWs/yAJBduP9mrLOBiJJ7mLWoYjUy6V818i2Sscevmj6tCTyl32xNxRwewL3PBy9LjE+7QQKHnNwAQUBDZ77NwzQTRo7JXDb9dFadx8hGTn7ECybgEtFH97HQ6JUi9UjNIVQuWDIMrc9WiIzg1P9NUmk0wGOzSR5lLvKVAloj+dX4HNGZvnf+1UNjzQFzq4qwaVoJAlqDbuhw== X-OriginatorOrg: duke.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 0085a9ed-76fa-41f4-0359-08d85c199f42 X-MS-Exchange-CrossTenant-AuthSource: BL0PR05MB5587.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2020 21:27:19.1435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: cb72c54e-4a31-4d9e-b14a-1ea36dfac94c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: apJcsFcssq2YJcYmEJhf3gKo37SISbDI5AnPWGIgBUWKoxqTTC4U5WgUmgI7lRAQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR05MB7492 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-18_17:2020-09-16, 2020-09-18 signatures=0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-18_17:2020-09-16, 2020-09-18 signatures=0 X-Proofpoint-Spam-Reason: safe X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 43470-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) On 9/18/2020 3:11 PM, Alan Third wrote: > On Fri, Sep 18, 2020 at 08:34:30PM +0200, Daniel MartÃ?­n via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >> Alan Third writes: >>> >>> This looks good to me. I think we'll want to apply it to Emacs 27 >>> since this is a regression from Emacs 26 and the fix is minimal, so >>> can you please rebase against emacs-27 and I'll push it there. >>> >>> Thanks! >> >> Here's the same patch applied on top of the emacs-27 branch. Thanks. > > Thanks! I've pushed it to emacs-27 and it will be merged into master > in due course. > > I'll close this bug report now and if anyone wants to modernise the > drag and drop code they can create a new one with the patch or > whatever. > Hi Alan and Daniel, I can confirm this patch restores basic drag-and-drop functionality -- for example I can drag URLs from a browser into emacs. However, there still seems to be regression with respect to the behavior of the package org-download (https://github.com/abo-abo/org-download) -- images dragged from a web browser are no longer recognized as attachments, only their URLs are getting pasted. Best, Paul From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 18:15:41 2020 Received: (at 43470-done) by debbugs.gnu.org; 18 Sep 2020 22:15:41 +0000 Received: from localhost ([127.0.0.1]:44729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJOfM-00009e-JJ for submit@debbugs.gnu.org; Fri, 18 Sep 2020 18:15:40 -0400 Received: from wilbur.contactoffice.com ([212.3.242.68]:55206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJOfJ-00009C-DM for 43470-done@debbugs.gnu.org; Fri, 18 Sep 2020 18:15:39 -0400 Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by wilbur.contactoffice.com (Postfix) with ESMTP id C9D7B17DF; Sat, 19 Sep 2020 00:15:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600467330; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=1265; bh=t6/HewAwsj6CIPihj/MCNURRmhHgZgrEJkznKXHzz4A=; b=XnxKFHTdXb/6U7Oc7k7ziQrjjHtTg0uCbJH/+K0cWamKUCxFov+Ar9icxopmzfQW mf31/bequ5Rr24LZul80bs5Bf3tzv+yTfZ8FZhCiggxBcQajAiLUseHU49WCgZgVZCb rertQgcW/TaRESNqbj3+t40N4JdpCCOV9PS9C05AQK5yBtgUGRc6BR0Ljm7+mRmeCow HFKhS33DGKhofFegT+thklGen014SrR/4UIFhRtsr2WzQHdM+g8HoKXjrrbNvmMwYEo Zq1mbxR/n4ZHYVKPdxVB17HdoKHKWVtV61g8Ib7PN5m8438+YZaT3AIOYcd4Gc8DqwT OsP77GpNBw== Received: by smtp.mailfence.com with ESMTPA ; Sat, 19 Sep 2020 00:15:26 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 0FBA92025708DE; Fri, 18 Sep 2020 23:15:24 +0100 (BST) Date: Fri, 18 Sep 2020 23:15:24 +0100 From: Alan Third To: Paul Magwene Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Message-ID: <20200918221524.GA28875@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , Paul Magwene , Daniel =?utf-8?B?TWFydMODxpLDgg==?= n , 43470-done@debbugs.gnu.org References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> X-Spam-Flag: NO X-Spam-Status: No, hits=-2.8 required=4.7 symbols=ALL_TRUSTED, BAYES_00, URI_HEX device=10.2.0.1 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 43470-done Cc: 43470-done@debbugs.gnu.org, Daniel =?utf-8?B?TWFydMODxpLDgg==?= n X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) On Fri, Sep 18, 2020 at 05:27:17PM -0400, Paul Magwene wrote: > I can confirm this patch restores basic drag-and-drop functionality -- for > example I can drag URLs from a browser into emacs. > > However, there still seems to be regression with respect to the behavior of > the package org-download (https://github.com/abo-abo/org-download) -- images > dragged from a web browser are no longer recognized as attachments, only > their URLs are getting pasted. Try holding the option key when dragging into the Emacs frame. Emacs 26 didn't handle drag and drop according to Apple's guidelines, which meant that different source applications were able to force Emacs to handle drag and drop in apparently arbitrary ways. It didn't help that changing which keys worked as meta and super affected the drag and drop in unexpected ways too! The result was that there was no way to be able to predict what would happen when you dragged something into Emacs. For example, dragging highlighted text from iTerm would result in Emacs doing something different than when dragging highlighted text from TextEdit. More info here: http://emacs.1067599.n8.nabble.com/bug-30929-26-0-91-Text-drag-and-drop-does-not-work-td451899.html -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 19:22:55 2020 Received: (at 43470-done) by debbugs.gnu.org; 18 Sep 2020 23:22:55 +0000 Received: from localhost ([127.0.0.1]:45339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJPiR-0001wv-GN for submit@debbugs.gnu.org; Fri, 18 Sep 2020 19:22:55 -0400 Received: from smtp-gw-20.oit.duke.edu ([152.3.189.246]:48050 helo=mail-gw-20.oit.duke.edu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJPiP-0001wi-3u for 43470-done@debbugs.gnu.org; Fri, 18 Sep 2020 19:22:54 -0400 Received: from smtpgw-08.oit.duke.edu (north-ltm-a-c24-39-vlan2756-glbp.oit.duke.edu [10.136.225.66]) by mail-gw-20.oit.duke.edu (8.16.0.42/8.16.0.42) with ESMTPS id 08INMlrL012075 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 19:22:47 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2100.outbound.protection.outlook.com [104.47.70.100]) by smtpgw-08.oit.duke.edu (8.16.0.42/8.16.0.42) with ESMTPS id 08INMlC0030550 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 19:22:47 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxisiiNMIP8dFaaE4Iyt2aziQLF5jp9X/QyB3QswWMbiDmWMHXCUHFZ0UP5XKm/2DPJYY99jPr6norULUl5NQODt4yr046+vNhp1eh7UAZ38VlrQ/LLot4N3vrrw3ubRlT0zft9P3ocGa1SaMcYFmXVHP0ym/Ul8Iyn0DokUtKRB3uFrfoUAvQgWrU4xe8WtrdmRTCyVtaOJ1DKs9aHeNFOO2ijFnZH48YOes4Y3qqWukQPcEa0+NcfHdLjvBUsE7RQpzGtYwJDx3iB8xdAYpqDeCDjMynLZivjRXFTTIFFD+PSdOysn3vAkd1Z/PI+0bfzZJP8q84adqUYNQqQKpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aOtJ4YBlX2nAkakc03+HahmuU/Plgka0NF76x1ll/mE=; b=oSnURVvmb3l5PHFBsBI6/ud+fSnW0HVPwp+/emOpJWDuXs2ZRRUTunm0sZdHnWObhpCX4ShJ7ugnQz3BcfC2bgoYHdex/5I7gJs1RHWslhslOBiOcIbG05GhhZ2jwox/kf5MfBL7tffzzg45weZAse790pMet+yI90BIvLTlSv5M1gZvDMGgnXCDve11Rw8ZcdQStXc3Am6RXGqkpubLjc62EAcB1zKz4YkgFjhxF0U/e89WvShJvG6EnxEo0Phol/b7c+sjWIg3XjQzxA+slQfUpgc3IykOInvkQ8MuHgNWiI9PkABGetxr0hwUyASSStto3+A5wQD9FIqUu+ft/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=duke.edu; dmarc=pass action=none header.from=duke.edu; dkim=pass header.d=duke.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=duke.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aOtJ4YBlX2nAkakc03+HahmuU/Plgka0NF76x1ll/mE=; b=mVlehUhF/TBuPZRrC6dJw1LHNoLxqI9u+SsXdKGEiU4KU9au2I7aqAzGwkEHJJYI79sC2UU4waMlagfnKsjYW+oIItRYiIH9jH/dfcklu53LDd6xyQu+qyhPayStI1d/EkY+Fh47D4KpXlgGqPY4yt/yYE0B8YJhOtVXPRujLyY= Received: from BL0PR05MB5587.namprd05.prod.outlook.com (2603:10b6:208:6c::28) by BL0PR05MB4898.namprd05.prod.outlook.com (2603:10b6:208:58::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.9; Fri, 18 Sep 2020 23:22:46 +0000 Received: from BL0PR05MB5587.namprd05.prod.outlook.com ([fe80::196d:ac30:b2f6:f3d4]) by BL0PR05MB5587.namprd05.prod.outlook.com ([fe80::196d:ac30:b2f6:f3d4%7]) with mapi id 15.20.3412.006; Fri, 18 Sep 2020 23:22:46 +0000 From: "Paul Magwene, Ph.D." To: Alan Third Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Thread-Topic: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Thread-Index: AQHWjPZQmGxxYMNTkk2eNC7i5wzKPqltGxIAgAAHZqmAABodgIABEB1ggAAPDACAAF8WD4AACioAgAAmDICAAA1yAIAAEtGA Date: Fri, 18 Sep 2020 23:22:46 +0000 Message-ID: References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> <20200918221524.GA28875@breton.holly.idiocy.org> In-Reply-To: <20200918221524.GA28875@breton.holly.idiocy.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: idiocy.org; dkim=none (message not signed) header.d=none;idiocy.org; dmarc=none action=none header.from=duke.edu; x-originating-ip: [107.15.37.134] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1cc971f8-2be5-4d49-01fc-08d85c29c044 x-ms-traffictypediagnostic: BL0PR05MB4898: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r3L0dP0/Jz7+9oT8wfJHZKkqXs/t1aklhk1l4Wosz7rfYkjSFa+yJqscJfQ2TJVuLnvZtIBmAqq3V90ouMODF8f8C0Lp+c3O2TfQFY6eltxBz3LBaVpB97DYUEbw762/wbyEb+35Io1MMlGZRNVBNO5MaqG31JOEzrdDlt3cVdvB29fsqRyTvvMeIbWjXWpITrtmefE85KrpfuU9cXMCO723DGrb61vL08l47yiXOUYZgmrd44mAQls+5K2UsHRWxzjEFi6XFCz3bLmF30A5xWQABFHHBuCrqieSuzzL541aCadFZq+kI3VTL0bQN4gcPktrZHUDAT7oPrj6YEeJwLk1FKiew+it5qnPwtSavtJ12bOkLZI6T9s0shnf1n8j3BFiBj9CbC5HXbQE79s04Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR05MB5587.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(366004)(136003)(376002)(39860400002)(75432002)(76116006)(66946007)(5660300002)(8676002)(66574015)(2616005)(786003)(316002)(86362001)(83380400001)(64756008)(66476007)(4326008)(66446008)(66556008)(54906003)(966005)(36756003)(2906002)(6486002)(6512007)(6916009)(71200400001)(33656002)(26005)(8936002)(478600001)(53546011)(6506007)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: aAKiXmOl9IGs7dziKFbOy82ULr2cM/nr7ZdlMDcJbXa8Wq9pOX/CBG0Eh4h3HoI+Pv0urfCBFmkJAP5HcNdzD7T/nKOkg1S0Wz9TgFI6OXMBYrovI4AmTy0shUcIn9zp8Q5qsgMyMZ0XV69VWI7Dtzuf7fLeDv4BpiC3bdHqHO/R/cXP4uH0aTFVy6t8q/4CM7Xz6BeNOuLvckfNlPjAhc0IQmcelreEVm01BlbFMki4hmwWf67BgDadPcA8m3aewTu6ehKgnUCNzi9jMQJdQ8InTgGfq5HeolhwMEhHYWyjZONWY7pqUhrT2KKd9cks4kWPAULe9YUQS9oU7mlM4aL7ccMRZ1x08PXBUnLvqTA5U1A09e0CbzwSxtFKCdHCknCOmpBO62SeJzo1Fws6UjIitkNdwN6bNSRDmqYuFwJTc0FFWuLFvRDf+hxQ4SG5+pmhpMdg2ygdcEIGDSy8W2tru50i1cTpfGjq9pwahUUt3UpLCQdueoviB/35LP6ABcIU60TaiEA5Ww1OBrPxpTEVzs4dByabbYvA3a69P/apXQbdvD+aWG/m3MHg+fcBS6prgaos8ZiU6JjqGNyb+7gKswXUfvGRfJaKAZMMoeR+KVK0hyFo+E0g/8+gMadSouKr2WXS82JJVcSIgswfBw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: duke.edu X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR05MB5587.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cc971f8-2be5-4d49-01fc-08d85c29c044 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2020 23:22:46.0333 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: cb72c54e-4a31-4d9e-b14a-1ea36dfac94c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OgqSDx4HCQRmH7yfrOi/la3kp2X45LPVonkZyuutJBfQCRMlhIL6X8lxC1PQ5hen X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR05MB4898 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-18_18:2020-09-16, 2020-09-18 signatures=0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-18_18:2020-09-16, 2020-09-18 signatures=0 X-Proofpoint-Spam-Reason: safe X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 43470-done Cc: "43470-done@debbugs.gnu.org" <43470-done@debbugs.gnu.org>, =?Windows-1252?Q?Daniel_Mart=C3=83=C2_n?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) > On Sep 18, 2020, at 6:15 PM, Alan Third wrote: >=20 > On Fri, Sep 18, 2020 at 05:27:17PM -0400, Paul Magwene wrote: >> I can confirm this patch restores basic drag-and-drop functionality -- f= or >> example I can drag URLs from a browser into emacs. >>=20 >> However, there still seems to be regression with respect to the behavior= of >> the package org-download (https://urldefense.com/v3/__https://github.com= /abo-abo/org-download__;!!OToaGQ!8m3-afgTMTEJM6rEIKhlRQZ4Hu1ZcDjjtoDKEKWvNf= sYjq_DrTj5_mBe8gX44ZvuVvg$ ) -- images >> dragged from a web browser are no longer recognized as attachments, only >> their URLs are getting pasted. >=20 > Try holding the option key when dragging into the Emacs frame. >=20 > Emacs 26 didn't handle drag and drop according to Apple's guidelines, > which meant that different source applications were able to force > Emacs to handle drag and drop in apparently arbitrary ways. >=20 > It didn't help that changing which keys worked as meta and super > affected the drag and drop in unexpected ways too! >=20 > The result was that there was no way to be able to predict what would > happen when you dragged something into Emacs. For example, dragging > highlighted text from iTerm would result in Emacs doing something > different than when dragging highlighted text from TextEdit. >=20 > More info here: >=20 > https://urldefense.com/v3/__http://emacs.1067599.n8.nabble.com/bug-30929-= 26-0-91-Text-drag-and-drop-does-not-work-td451899.html__;!!OToaGQ!8m3-afgTM= TEJM6rEIKhlRQZ4Hu1ZcDjjtoDKEKWvNfsYjq_DrTj5_mBe8gX42IpwYfI$=20 >=20 > --=20 > Alan Third My testing suggests that there's still source application specific behavior= . * Simple drag of images works when Safari or Chrome is the web browser. * No combination of Option, Command, or Control seems to work in Firefox; t= he drag behavior always produces a URL. So I guess the patch partially fixes the regression. Given the state of th= e OS X api I'm not sure what the best way forward is. I'd try and jump in t= o contribute but I unfortunately have zero experience working with Objectiv= e C or programming against Apple's APIs Best, Paul From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 19 07:02:32 2020 Received: (at 43470) by debbugs.gnu.org; 19 Sep 2020 11:02:33 +0000 Received: from localhost ([127.0.0.1]:45735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJadU-0008S2-Ns for submit@debbugs.gnu.org; Sat, 19 Sep 2020 07:02:32 -0400 Received: from sonic306-19.consmr.mail.ir2.yahoo.com ([77.238.176.205]:43583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJadS-0008Rf-AN for 43470@debbugs.gnu.org; Sat, 19 Sep 2020 07:02:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1600513342; bh=J/23Pq44KzdFbaa7E78+J4qI/nN/fcqDsDkX7BxQyRQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=uigkMjLpEnB0nSnSvcSZ/hWebqUStqF7lKkRCwEwVXjlQhTSqjCYDUo2fF3XZkqHTORe6PJI/81pK5nr79w/fFrBiorj6Racqdnx9MjOIng7MRBmHhOV80hJ5LnVcM8pwnehxY2AU8ThgpDtEEjU1ElcPVf3Exg8mbCZRBpVvcAdYT94FDXKOhj/n1OFySS04pvY+M5nc1I9XLoKSH/mlTVOICQ7O5+AgeHs3/wSeWqumx8xiPfVYPEgsgeXSt309hy8d1/4xGf3HGXxMT3RJiGxhF1yI5KpsBiORXl8JPEPD4um7pnRA2FlYrBI0JcF2Fcg2/VR1/WFP8m+lHU3XA== X-YMail-OSG: IflW5VYVM1mDQsKK8WN5KcP4U4zcsx.STOLrKYZcphlgfre1UYY67QcChDsda8V AYpOuwHVhkzX3p_QecKsJ1C9.Lu7gemOP4REckMH6cdbQUk3b2ayyw9APTNzw7vmr76rQXKjRWAu _D.jWSmPhGIF_gsYwMPf8jIJb7Dz44SXOG7xjs9_dPA338oUXG6Nx3iFwLiPinTrCPzPXiceTVp1 KyZ_xNZ2D1svqHxThaSqn4XJRckYgkJQ02Z63m8jaFG5WaPi0rTuigUjyhwE3p0_U8fYoXV.Km_O .kpWwSyz6.nGYi9UeSZ0zVY4hBiIYaJWP.ycbXsaMbJ77iuXQtYRgkI7SrnSb1STVyWfnoD4T5k5 Z1MW56aORt6X8vuL.CtVzfLZdh6xIoZDFTG4ReLP4CXX32GedSKYn7wOgnk7tWV14OCAn2II6fNX CrwJ6DGEtH3KBmZQw2Uxqk1I28WmNRtAPPWjIgAkglnFRlSILsUBifv7VYxs5RFJBiUe8sesZ9RC jz.dgLU5BUwbSdv4N5kWH3hd4fVuGF8irOL9pfAXm7NIcdEqrqwwyJk4ohq3jItWVsjrwAWmR_Xo zdF_y6.lMIIU3xqV4CnGw.alBPoKTfjPscSN48DuLbZoahh9hu7n6CJX3HwpzSiCj6_3Bjb9Dct2 zyA21SgsCGGcJn9LnRKMjVR6jO58aFtLIuoMK.1hRWd9XBf.O.OKf07nf3cOCj5C9WXC0_72tGPg cx_UqywqgRcw5rESgsBAPKwvxobY1sklami.MmcbP._Kd4hwIZq0r5E.xbcswS.jm0YLhdZeV4kb z8Eb0i25BfuYSSiViMLKjXvHJXRmzkKGzmkt55PIYMml5DS48tiDzieko.Nps5nvXph6XE09Y.Bg E4b6GkafP8VS4RYn_IZs4ZWLZxTz4j6DQ2wTKx4LGWVj8Rwe7QyhFHwzKQPdv21Jp9Yh7lCVkLlO Zge.l2zn37DrqoWmpvQDrA_FscbcTyiQkEH1l7EVLTtsEmVF2QEWZcFFmAtx5J8ezEAHH0nWoMZQ j6IhFoYe9nIFs7TgNHZAFVT4icwPpYstuHYEhcLwSZ9G1H.S6VzAGs1KKH33OtR8MSM9GfmQArG2 PxtN8CsjQcD46FGMaq4jmQ_BhkPAoycwM14gzqKAL_Ga74yfbtbjCp50ZSKzqTGbWb01tH5bz8E2 WcmcuTQ0TMScnqlSX_zSS6pY1ECr8Dq2pLV94OR7GGUXBKI1H1R30jG5CBFMg48oj_JKnqhN8t5y ofZ1j7cX8HWB4ERsWGYGYBHzE9iAHKFCjdkfq.31GMRN7iGrG5K2PJtVX2r2Qk5xUN3lZPDYiGtX 94SXHm7tpC3xfTa69j3uIqecKuwhtuDXAhVNPjTaGejhfosHtrtBcofCEgpC17GCyDNSHBYJ02la FuPJ8VqzgnRZBT4B2hlzeX.i4WFCSgco5LaPLcnwyNy3w_8ZDOI3p7Zzvve3T4LlGah8Ocm3iz1E p.1KmhAtsycyYvAsbuMpg_I.ZyduQIIU0blNk_evxmfos_PL3dAUcA2rbZwkzflFN3S8kWpM- Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ir2.yahoo.com with HTTP; Sat, 19 Sep 2020 11:02:22 +0000 Received: by smtp421.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID e4336c684f73c5d3b1c1130b6063add0; Sat, 19 Sep 2020 11:02:18 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: "Paul Magwene, Ph.D." Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> <20200918221524.GA28875@breton.holly.idiocy.org> Date: Sat, 19 Sep 2020 13:02:15 +0200 In-Reply-To: (Paul Magwene's message of "Fri, 18 Sep 2020 23:22:46 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Content-Length: 634 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43470 Cc: Alan Third , 43470@debbugs.gnu.org, "43470-done@debbugs.gnu.org" <43470-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) "Paul Magwene, Ph.D." writes: > > My testing suggests that there's still source application specific behavior. > > * Simple drag of images works when Safari or Chrome is the web browser. > > * No combination of Option, Command, or Control seems to work in Firefox; the drag behavior always produces a URL. > Thank you for the additional testing. I can reproduce the drag behavior differences between 26.3 and 27.1, and also the Firefox vs. other browsers difference. I'm familiarizing with that part of the codebase and I'll prepare a patch that will keep the same default drag behavior as in 26.3. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 19 08:45:35 2020 Received: (at 43470) by debbugs.gnu.org; 19 Sep 2020 12:45:35 +0000 Received: from localhost ([127.0.0.1]:45802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJcFC-0006in-R7 for submit@debbugs.gnu.org; Sat, 19 Sep 2020 08:45:35 -0400 Received: from sonic308-17.consmr.mail.ir2.yahoo.com ([77.238.178.145]:35285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJcF9-0006iS-Tr for 43470@debbugs.gnu.org; Sat, 19 Sep 2020 08:45:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1600519525; bh=mP0xYTp9X7xA+2W8yRxop+UgFUtpe5GrZFRavwVBLJQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=p6ajjzgSI6BNnpAjWNOeIPWBz0VpIqedDP9+T0NKVWxjYFOsVkA62W6pYwhNdNYLk7upxyS/VKvUxJNLjYg0QFOevvED+NKHmhN691Tpz189ggSDgrrOP+0v8h8oHGeF1/y3SJe2tOaVN8MZUeJRVirvX+hGMWMb+q6bm/AstzKAiHfLIUMp1crFG9fC/hDFKa+XYlJr5phEi2tuxNxhpyh5srrbVDvC96QFdNKWnMY7fBNspD1BtYBjtGW3Af3JXLPCjnf5QfyTjEp6qXdW3ilLqppSYOxKdNHzqmJquHJuVfpGkdnnz/om0JNHvq/cOStopPgPEKeM6x4gapmwLQ== X-YMail-OSG: C11WUp4VM1nynBBnXy0kWzMihwWmJppTeD65pzlZce7zomImLpJvpare9azXxoz AckRILRmDi6JQtZXE.o34FamaIga_13YCr_5jNI2ot_GQSQCxSCTqUbrPf0Uhv1Yhtr0fZ.8QCGN wD3iA8euDOQXQyhinAvwqA3Lkw4AfgC3hcUbksFJ3eSA5bacQJ5aQ5j65WqS0w1ai5OIVxNhYnAr _E0EA.HGfT4oz84hQbCx_qNuQJtYunGB1E4K9T3XS9T0YkuzPzSBq3ukPNqVQ4R0AaSKChF0DMrp YL1Oftwn4U0xqFmnncF5XPybg0lvoe8UDyqaEnxJIH2p7NCUKU2AvbHixg83yv9KF7H.P3elbw1C hku0bwskW2kCPvYrZ8GGKhDYEVnZJjArlkJ.5F3Pa4CGW_42JnLo7rSWkwmvMvvYt84KRNO7LtQN XQ0avKWH.HlmKpfQbqxrNU5lHd_9FePLP7iyk5U1ZS49QZdbf9Q3Fkm7JpyNVhBjmQLTWcfQYDYj 5YRbSaQGLDiJN_L07C.74UDwZvU9yywe3j7ELRDGL.UAy6S3Vy7dzgUJotubRDeMeP2aKHFTPf3N UcTL_CZzFj9.2GPVP_ICm5nM3.fa8gzpr.qj77E.uRPUmpKGgzLkQ3VYNsXxgBIX9ULKSOJPRpJf uw4KIuw7yS.h8tzwE6ahgbzh1clMqCVMErfRgEpZJT4eubiHUAzOeEgyGFLikzb2zLCYvGKO6g4c iRtqqmcQb4plyfn46pmz2AcaN7wIgfkSjuP8Lxg1Wt7H5bsIcPUtkP687Dd78Rpdi83VU_7Khttd C2_lqmofXK2Ri5uYadqIrtWogQdMvi9YnxnEYhXZZqFhJFhuc2umfdbi7LzDa4rQp1_ug02U4OMf o1HqwkDMyCEF_RFqRtapqhEdghUrcdLn6lfDTaoZ_DmYmLjIgoDQ8sBSgiddCvsByTUkRh58WWMb vQK8KdhGRcYMKlVzXGvQcFF2StvugNX17pvMczUbEJMcznu5zGl7Jnz7BBhCnMXxZyrM4r_DAxIm KFXuVZr7aFTgYxLMvVboBZkMUYCpwDEtPIIIy262Lr6mtbQB0asMaC2xYpcZSkza9D4QhTIjSTmW asNFoT5zqtas1mkABYG43Gis0cmdPfPvBCvnnChZO70PEn6P2ar.i5bojNuD6vFc_t7I7fmWepxK 6FeCy6RJyrp3mbeAdhS_WSOUUzZl52.mSPkrIB3TBmA7SCHi2jPnZQGZeWkTO2q3Wi46wqxopZyH yJjmnMLxubl_G4dDVlbZjHPbUuxdkk8SQOS.QU_gvUAkCUBcsy5giH7j1632VU9nW9VNDFPrzoOK .D6UY.G0LNUZy7v2Mp4hIj28lbg87Kyb_lQp9JXfuB1JitmShsr0LZC7DAa0ddMeM3XqAwyHXScj fe6JulqKANsEHKaSW13SAW9v5lcildzubm0owL2cqlnl8ykRAgi9SjbwuTJxYTyHreXeldYRMrtp Hzl3aTMdVe1BmJ3DHBjsEsSc1fixnzDp6hpO36yxCSeWDrk4rEgBLwPg3JE_0rO7OJRgiCO.Riw- - Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ir2.yahoo.com with HTTP; Sat, 19 Sep 2020 12:45:25 +0000 Received: by smtp411.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID e402460757a5f93811e2cecab26d7524; Sat, 19 Sep 2020 12:45:21 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: "Paul Magwene, Ph.D." Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> <20200918221524.GA28875@breton.holly.idiocy.org> Date: Sat, 19 Sep 2020 14:45:19 +0200 In-Reply-To: (Paul Magwene's message of "Fri, 18 Sep 2020 23:22:46 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Content-Length: 3591 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43470 Cc: Alan Third , 43470@debbugs.gnu.org, "43470-done@debbugs.gnu.org" <43470-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain "Paul Magwene, Ph.D." writes: > > My testing suggests that there's still source application specific behavior. > > * Simple drag of images works when Safari or Chrome is the web browser. > > * No combination of Option, Command, or Control seems to work in Firefox; the drag behavior always produces a URL. > > So I guess the patch partially fixes the regression. Given the state > of the OS X api I'm not sure what the best way forward is. I'd try and > jump in to contribute but I unfortunately have zero experience working > with Objective C or programming against Apple's APIs > > Best, > Paul OK, I've created a patch on top of emacs-27. I've tested it by dragging and dropping files, text, URLs, images, from Safari and Firefox, and I get the same default behavior as in Emacs 26.3. Note that you should still be able to override the default behavior by pressing Option, Command, etc. while dragging the content. Could you test it and see if it completely fixes the drag and drop behavior on macOS? Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Give-ns-drag-operation-copy-preference-when-handling.patch >From 1a41df947bcf102e0884f295d8f394ade8d9eb18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Sat, 19 Sep 2020 14:13:53 +0200 Subject: [PATCH] Give ns-drag-operation-copy preference when handling drag and drop Some applications like Firefox send NSDragOperationEvery when dragging URLs or images. That constant means "every possible operation (copy, link, move)". When there's more than one operation, we want to consider specialized actions like ns-drag-operation-copy before generic ones like ns-drag-operation-generic. This change brings back the same drag and drop behavior as in Emacs 26.3. (Bug#43470). * lisp/term/ns-win.el (ns-drag-n-drop): Move the check for ns-drag-operation-copy before ns-drag-operation-generic. --- lisp/term/ns-win.el | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el index 90024b001f..fc20de5a05 100644 --- a/lisp/term/ns-win.el +++ b/lisp/term/ns-win.el @@ -513,19 +513,19 @@ ns-drag-n-drop (set-frame-selected-window nil window) (raise-frame) (setq window (selected-window)) - (cond ((memq 'ns-drag-operation-generic operations) - ;; Perform the default action for the type. - (if (eq type 'file) - (dolist (data objects) - (dnd-handle-one-url window 'private (concat "file:" data))) - (dnd-insert-text window 'private string))) - ((memq 'ns-drag-operation-copy operations) + (cond ((memq 'ns-drag-operation-copy operations) ;; Try to open the file/URL. If type is nil, try to open ;; it as a URL anyway. (dolist (data objects) (dnd-handle-one-url window 'private (if (eq type 'file) (concat "file:" data) data)))) + ((memq 'ns-drag-operation-generic operations) + ;; Perform the default action for the type. + (if (eq type 'file) + (dolist (data objects) + (dnd-handle-one-url window 'private (concat "file:" data))) + (dnd-insert-text window 'private string))) (t ;; Insert the text as is. (dnd-insert-text window 'private string))))) -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 19 10:08:32 2020 Received: (at 43470-done) by debbugs.gnu.org; 19 Sep 2020 14:08:32 +0000 Received: from localhost ([127.0.0.1]:47645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJdXU-0002pZ-1X for submit@debbugs.gnu.org; Sat, 19 Sep 2020 10:08:32 -0400 Received: from wilbur.contactoffice.com ([212.3.242.68]:50346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJdXQ-0002pG-Dd for 43470-done@debbugs.gnu.org; Sat, 19 Sep 2020 10:08:30 -0400 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id B0724175C; Sat, 19 Sep 2020 16:08:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600524501; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=2963; bh=HYmlMZ6XWYWO+kGYAsUv3jMRa2efHl7cqMmpvHrism8=; b=XhXaqnpVJgPbR/7SOvw5KUCDN/rhN5Wv/drK6qMiMhEH372Djhri9eW9Y0wx8kxM ILiA70x0D+bXyIvi2vBQ6TjbYOSKjJes3d4ovCm4Ap4Ug473W28+KX+rDR6zjFehZ+z rswcjm6RHRbRbJ3b6bHCmfFovGbBunL7NCaNy8X/biZq5duS6PU5Itu1FSpKR0PyaDK mkChiOfiJNohe+A8UU8zJdDM1iLVEMjwluvAZnxnV9YmMAgm3REV/7Qh+LUwsZFZmBI hCRJ2kcoTMnZsEizFHhjbsSY51KoMFA3A4mc3kEROcYxQ7AOekNPjp1lgiq/F8Ayg2g 7/VRPFZAqQ== Received: by smtp.mailfence.com with ESMTPA ; Sat, 19 Sep 2020 16:08:18 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 27F8D202572DCE; Sat, 19 Sep 2020 15:08:17 +0100 (BST) Date: Sat, 19 Sep 2020 15:08:17 +0100 From: Alan Third To: "Paul Magwene, Ph.D." Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Message-ID: <20200919140817.GB28875@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , "Paul Magwene, Ph.D." , "43470-done@debbugs.gnu.org" <43470-done@debbugs.gnu.org>, Daniel =?utf-8?B?TWFydMODxpLDgg==?= n References: <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> <20200918221524.GA28875@breton.holly.idiocy.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.21 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43470-done Cc: "43470-done@debbugs.gnu.org" <43470-done@debbugs.gnu.org>, Daniel =?utf-8?B?TWFydMODxpLDgg==?= n X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Sep 18, 2020 at 11:22:46PM +0000, Paul Magwene, Ph.D. wrote: > > My testing suggests that there's still source application specific behavior. > > * Simple drag of images works when Safari or Chrome is the web browser. > > * No combination of Option, Command, or Control seems to work in Firefox; the drag behavior always produces a URL. That's how Apple designed it, what we wanted to avoid was where the source application defined which modifiers Emacs saw in use as that just turned into a nightmare of random behaviour. Probably what's happening is that Firefox is setting some drag operations that don't include NSDragOperationCopy, which is the one we chose to always try opening the text as a URL. It would be interesting to know what it's setting. You could try adding something like NSLog ("%lx", op); into performDragOperation in nsterm.m and then we can compare it to the constants listed here: https://developer.apple.com/documentation/appkit/nsdragoperation?language=objc > So I guess the patch partially fixes the regression. Given the state > of the OS X api I'm not sure what the best way forward is. I'd try > and jump in to contribute but I unfortunately have zero experience > working with Objective C or programming against Apple's APIs The ns-drag-n-drop function is customisable, so if you wanted to ALWAYS force it to try and open ANY text as a URL you could do something like (defun ns-drag-n-drop (event) "Edit the files listed in the drag-n-drop EVENT. Switch to a buffer editing the last file dropped." (interactive "e") (let* ((window (posn-window (event-start event))) (arg (car (cdr (cdr event)))) (type (car arg)) (objects (cdr (cdr arg)))) (set-frame-selected-window nil window) (raise-frame) (setq window (selected-window)) (princ operations) (dolist (data objects) (dnd-handle-one-url window 'private (if (eq type 'file) (concat "file:" data) data))))) It's quite possible we should have more logic in ns-drag-n-drop to work out what to do given the data type and available dragging options. BTW, Apple's documentation seems to be inconsistent. One page[1] has this table: | Modifier Key | Dragging Operation | |--------------------+---------------------| | Option | NSDragOperationCopy | | Command | NSDragOperationMove | | Option and Command | NSDragOperationLink | and another[2] has this: | Modifier Key | Dragging Operation | |--------------+------------------------| | Control | NSDragOperationLink | | Option | NSDragOperationCopy | | Command | NSDragOperationGeneric | The latter seems to be the correct one. [1] https://developer.apple.com/documentation/appkit/nsdragginginfo/1415966-draggingsourceoperationmask?language=objc [2] https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/DragandDrop/Concepts/dragsource.html#//apple_ref/doc/uid/20000976-104936 -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 22 08:25:05 2020 Received: (at 43470) by debbugs.gnu.org; 22 Sep 2020 12:25:05 +0000 Received: from localhost ([127.0.0.1]:57466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKhM1-0002BK-29 for submit@debbugs.gnu.org; Tue, 22 Sep 2020 08:25:05 -0400 Received: from wilbur.contactoffice.com ([212.3.242.68]:46338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKhLy-0002Ab-K2; Tue, 22 Sep 2020 08:25:03 -0400 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id 2B269D78; Tue, 22 Sep 2020 14:24:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600777496; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=1221; bh=UVhwerlQzYa8TmdQo7apjL5f4vJ4n7lCwWd+FdKp2ZM=; b=u3MrCbFIv239JzKjo3GkQi4yXE2I2q1H8Lf3eETxui0Ev4SZ+9o2T8o1LM+B450h QYpbMVX3pW7P1dHxeTc0krsyEWCCwBZCBbQ70fjK+BZwe5B6MwhVVx+fA61QFAp2aar MQ8Lg85uBu70yjhaR4gPYJYAvGvC9ZPSichCdvjFO2HWK3wzKlC2SimY2uawSFCSyR3 Ca9uN2JrNBtN0JRO6zGk6brjhiVkQLMuuJ5pU49VKifUXBU2GJ7I5QyoszDt9Dz0RtG mGkgi6ovEu5TM+ZcyPxiA6TmXtvskIkLjsl4h+9zgnCkN7LY7VMhOhKZ5UahKTy7rwO fzlo+iL/ig== Received: by smtp.mailfence.com with ESMTPA ; Tue, 22 Sep 2020 14:24:52 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 31ED6202586B03; Tue, 22 Sep 2020 13:24:51 +0100 (BST) Date: Tue, 22 Sep 2020 13:24:51 +0100 From: Alan Third To: Daniel =?iso-8859-1?Q?Mart=EDn?= Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Message-ID: <20200922122451.GD28875@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , Daniel =?iso-8859-1?Q?Mart=EDn?= , "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org, "43470-done@debbugs.gnu.org" <43470-done@debbugs.gnu.org> References: <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> <20200918221524.GA28875@breton.holly.idiocy.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.20 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43470 Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org, "43470-done@debbugs.gnu.org" <43470-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Sep 19, 2020 at 02:45:19PM +0200, Daniel Martín wrote: > > Some applications like Firefox send NSDragOperationEvery when dragging > URLs or images. That constant means "every possible operation (copy, > link, move)". When there's more than one operation, we want to > consider specialized actions like ns-drag-operation-copy before > generic ones like ns-drag-operation-generic. Hi Daniel, I don't think this is correct, we should always choose generic when it's available as that is the "default" action taken by the application. The more specialised copy, move, etc., are there for the sending application (or user via modifiers) to force the receiving application to do something else. The big decision is what should Emacs do by default? My opinion is that when receiving a URL we should insert the link as text rather than try to open it: Emacs isn't a web browser. Perhaps that's wrong, I'm not sure what Emacs does on other platforms. > This change brings back the same drag and drop behavior as in Emacs > 26.3. (Bug#43470). This is untrue as the Emacs 26 behaviour was almost entirely arbitrary and broken. What it does is fix this one particular use-case. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 26 07:39:24 2020 Received: (at 43470) by debbugs.gnu.org; 26 Sep 2020 11:39:24 +0000 Received: from localhost ([127.0.0.1]:45980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kM8Xz-0001AB-QZ for submit@debbugs.gnu.org; Sat, 26 Sep 2020 07:39:24 -0400 Received: from sonic314-19.consmr.mail.ir2.yahoo.com ([77.238.177.145]:38546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kM8Xx-00019p-G6 for 43470@debbugs.gnu.org; Sat, 26 Sep 2020 07:39:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1601120353; bh=AqDjX/vduXd7IAkkxAB6p+JB0lkQbXMabF5D69TZ/M4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=rkRmgF0RaXR8vqmwi73vgY4212hN2j1qiiwmzJg0yw0/hQfjyKNfYG698ewAVWYjSCnWs9yuQXUonxIhCLIJK5OMgQUXhIb59uixOrteGb05o1GwpyEohCAu8peXPVdkxwAkhO0Gg2TWg2Ck52J5EZYLkg9Q84yqQAR3mvwovKavLpPIiUq7T7z1XW/G7dWB/f2bRCvSaIp7ahSvDorIzoqhf5uNZHgWQkftQ8POar5ZtSyP3i9rrQ5vOMfkN6OajNrL8ZAtKBk8m4QH8K31wqtHFgk+xoVjnnRqOBJvq5r8fib82Vk176oWvbDwbzCYvrLRQYVrX+7wvWBvxMEArQ== X-YMail-OSG: EUmR4dYVM1nLRHW7PofSxs8jjc2DCilcUzb1dZeZ2Y_jVjQOw2NPvfYN9D50___ 5MQfiUZHoOxGOSlFjKhVc2mbv0VEF5oVWllfu7MwCdgW2tILW8Vy0qX3u.RiYj8wqkcjZbhuRkWw 5tIUghbRqTginrgkypNFD3Qy2FgrOl0IUXMag9tg3g33K8CGruxyzGkonWBjxt32awIfhmmDT_vi dNcfUXWKXHSYpRWEaMjro5UEAt2W0BcwWtMTrE9lRxk8p56DX0saF4GyGJwxb4yrUXObxa.tYzZk z4oUO3Zny8SWZ3etZvVQhxGgio8mR6YolOE0EhSnGCBmdy2I6ajYWcQd5yVzN9kDtwTY7R9gnWbE EnasXm4OhIBbwgmtTdHFAcFUQxr_NOkjJo9dj5gkA750LPvl2_IJIZZT_bwSITOVTE1PjSGt8HP0 Xz8ZfZ.7V8HrdnOFkkZaE.7S.guOCTWYZXIxSqxtopv7FzRNCOzm4iXibwyhGO7oS7h0x0dFB0oa lDsb7z60MgXnNjbidQF7PaH4dL2ekozxFIlHq6wKSpgDGCV841W_3pseOP.4z0FsuZE2aN7T3RfJ cSb2ZRV4YBOh6BYOOpgspfKG33dPo0YPPzNN1JydiSzRivFYOz_PPs84i_31_DIW394Q2zs.hh0d _DSY7PEbbe1dzGCMDLRkdHwsdp1ybJwZFGsSg7.lnt1Brt0R5tD4eLMyCzNvsJX.G_T3muqFr8Cn oMfscQIQpx7Ys6hUUq0b0_8Yf2LePtFuDnTu_SNV5ZcyvQM2kfQgqv0NO9Ykad41H6EpvL42N.I6 bSdPmTHMToe7GVw5ys51hjWn_ckjV.yd8RzOqYcFslVESYJGpsqULg4oeJHHtcfn15x4fHDWWJRQ TDe2S.Jj7k6aJeVCKIg18H4otY8kXZub1jnIlRgpe7tBAqQUHgiwdiEuffEbJCLiuLgde9sRjooA F6GErM4tx2hOi3pAYVolKo99RIT6OPMIRLyRYUyGISJRqm8GrK4Ykn23o_jLrcior3EK5V76tEPD QgS.RgkRhwrfmKKYB8OkRTlgR_QkUMbJlKgexdG19btR5Iyq6jIkz5s_Xpmjtor1gNfaQ_KVWyVy LDkW_fPp_euM_wR6g_d.GekRcyUdSjcT77WjvFrqVgYbIvnPMcexmxlrTw_GbSPywKOA86ZEaWRK TEogjYEJi4SHaQLl5TxrxHsx2rjnGm_Z1Dsk4kYzoUbj8hxagVHE1SUSsz4.UhYziIdOZGmfbNPh d04BjVeoma3uHVl0RaPTkKjz71m24.PYHaGGKi_njiO41yyGj0sofFqD6yjBCb9Zbjb6ZtjZju4S 0gan8Y1AUJ6NJ0ypXAlrA2UTNm828AGSqau0kY.jzhPkhS6f1BS5vm8M2gV1B04oFj3mqeuyW9jz Rg1F3sSDt18LDki_C5Otbcc8CRsqCSb0oLQGkQ7XAzf9G_szVGBqgtwReu99YitOHP1Z5oy0T1Hr 521v0M7qMOO8C1RoLZM7PvqZydUZ3NXcDfl8AuX7DF0sAr1ShVjeTbhsFoy5LMIxPqok- Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Sat, 26 Sep 2020 11:39:13 +0000 Received: by smtp412.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID b78e1f7bc2efe7d25fac591f8c856a45; Sat, 26 Sep 2020 11:39:11 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Alan Third Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX References: <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> <20200918221524.GA28875@breton.holly.idiocy.org> <20200922122451.GD28875@breton.holly.idiocy.org> Date: Sat, 26 Sep 2020 13:39:03 +0200 In-Reply-To: <20200922122451.GD28875@breton.holly.idiocy.org> (Alan Third's message of "Tue, 22 Sep 2020 13:24:51 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.16674 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Content-Length: 577 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 43470 Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org, "43470-done@debbugs.gnu.org" <43470-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Alan Third writes: > > The big decision is what should Emacs do by default? My opinion is > that when receiving a URL we should insert the link as text rather > than try to open it: Emacs isn't a web browser. Perhaps that's wrong, > I'm not sure what Emacs does on other platforms. I've tested on GNU/Linux (Emacs 27.1 and Emacs 24) and the behavior is that dragging an dropping a URL from Firefox opens the web page source, just like Emacs 26 on macOS. The GNU/Linux version does not seem to support overriding the destination action with Ctrl, Shift, etc. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 27 05:59:49 2020 Received: (at 43470) by debbugs.gnu.org; 27 Sep 2020 09:59:49 +0000 Received: from localhost ([127.0.0.1]:48366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMTTA-0006aK-Qj for submit@debbugs.gnu.org; Sun, 27 Sep 2020 05:59:49 -0400 Received: from wilbur.contactoffice.com ([212.3.242.68]:38366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMTT8-0006a5-0J for 43470@debbugs.gnu.org; Sun, 27 Sep 2020 05:59:47 -0400 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id 4AC46D04; Sun, 27 Sep 2020 11:59:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1601200779; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=3181; bh=mbiveCNiW0LJ+19NvxuDc6/aj/fsBFN9X7eSxZAhtHQ=; b=tV29MAnDSXKwwD+h7AU6YkCkDT2GyBZ54/PqXoykzS2avOSl0yJ96GcKgt/yh9IV U4Y8bhbC+G8F60bQYf6uwi7Ex2vrMl5rBz2+xDDwBL7rIV68IlzAcYyMhlivjgqlKTw c8fODvoF+2t9UQYKM/1eTK5XLthWmCOimnteouNlFC8V1RTzqbhRlX9ffOkk8C5yevk Qf8PoBjf388NBHK0xdG49v3YGK19m4IrdVs5zgeFQL1mQ7D+pZBZWZo/c/YSCkO9hOm f9jmB4SD6yHuRm1MsjMzNZ5P3CcbDjMUrLncvAxuIuFgbRuK+2oJMZKHqE8K3LfzeDp cYn4kV4EEA== Received: by smtp.mailfence.com with ESMTPA ; Sun, 27 Sep 2020 11:59:34 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 0965E2025C162C; Sun, 27 Sep 2020 10:59:32 +0100 (BST) Date: Sun, 27 Sep 2020 10:59:32 +0100 From: Alan Third To: Daniel =?iso-8859-1?Q?Mart=EDn?= Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Message-ID: <20200927095932.GH28875@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , Daniel =?iso-8859-1?Q?Mart=EDn?= , "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org References: <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> <20200918221524.GA28875@breton.holly.idiocy.org> <20200922122451.GD28875@breton.holly.idiocy.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ZfOjI3PrQbgiZnxM" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.1 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43470 Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --ZfOjI3PrQbgiZnxM Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sat, Sep 26, 2020 at 01:39:03PM +0200, Daniel Martín wrote: > Alan Third writes: > > > > The big decision is what should Emacs do by default? My opinion is > > that when receiving a URL we should insert the link as text rather > > than try to open it: Emacs isn't a web browser. Perhaps that's wrong, > > I'm not sure what Emacs does on other platforms. > > I've tested on GNU/Linux (Emacs 27.1 and Emacs 24) and the behavior is > that dragging an dropping a URL from Firefox opens the web page source, > just like Emacs 26 on macOS. The GNU/Linux version does not seem to > support overriding the destination action with Ctrl, Shift, etc. I've been fiddling with this more and I've realised that (at least on my machine today) Chrome and Safari never actually send the URLs as NSPasteboardTypeURL, they just send them as plain text. I suspect this means that if we want to support the NS drag and drop process correctly (and I think we do) then we really need to look into a larger rewrite, unfortunately. And any larger rewrite will need to wait for Emacs 28, I think. In the meantime I suppose the simplest work-around is something like the attached, which is near enough the same as what you did, Daniel, but making explicit that "copy" and "generic" are doing the same thing. -- Alan Third --ZfOjI3PrQbgiZnxM Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-Make-drag-and-drop-on-NS-open-all-URLs-bug-43470.patch" Content-Transfer-Encoding: 8bit >From 908a5fade4afc77467ef61b771c4e3c46c8cd798 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Sun, 27 Sep 2020 10:55:32 +0100 Subject: [PATCH] Make drag and drop on NS open all URLs (bug#43470) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * lisp/term/ns-win.el (ns-drag-n-drop): Merge generic and copy actions. Co-authored-by: Daniel Martín --- lisp/term/ns-win.el | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el index 90024b001f..184271d9e6 100644 --- a/lisp/term/ns-win.el +++ b/lisp/term/ns-win.el @@ -513,15 +513,9 @@ ns-drag-n-drop (set-frame-selected-window nil window) (raise-frame) (setq window (selected-window)) - (cond ((memq 'ns-drag-operation-generic operations) - ;; Perform the default action for the type. - (if (eq type 'file) - (dolist (data objects) - (dnd-handle-one-url window 'private (concat "file:" data))) - (dnd-insert-text window 'private string))) - ((memq 'ns-drag-operation-copy operations) - ;; Try to open the file/URL. If type is nil, try to open - ;; it as a URL anyway. + (cond ((or (memq 'ns-drag-operation-generic operations) + (memq 'ns-drag-operation-copy operations)) + ;; Perform the default/copy action. (dolist (data objects) (dnd-handle-one-url window 'private (if (eq type 'file) (concat "file:" data) -- 2.26.1 --ZfOjI3PrQbgiZnxM-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 27 18:22:51 2020 Received: (at 43470) by debbugs.gnu.org; 27 Sep 2020 22:22:51 +0000 Received: from localhost ([127.0.0.1]:50628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMf4E-0001zT-Po for submit@debbugs.gnu.org; Sun, 27 Sep 2020 18:22:50 -0400 Received: from sonic312-26.consmr.mail.ir2.yahoo.com ([77.238.178.97]:33856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMf4B-0001zF-U3 for 43470@debbugs.gnu.org; Sun, 27 Sep 2020 18:22:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1601245361; bh=c6ju4xx+VdLQT2aP7CeuTw1Sv0HgriKm/efpFT9HTJ8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=b5qMgifXCgTieerS6gttxBtbQqVVTNBt2W582ciWsQPPcMrfKiWzmdvd7I9S9bHNp8zJawIHRZbWUsI6HBhnbaM0csRpOOrsEZua2cLoxkeROIxe7pQm93tpvhRaHgzf9ZgnUerZXwdO10Y7v/x+m1U6mDRhXYDS/ZsLTFZnGP72O9S8+QI+xC/jw7CNW+E98XDAVtOwW7esgqbeDu4AZL3kbjnoLIiWytpCA4/KaX3jFZM1WwqRH+5QIf6CrOiUeQWwunGVL2HXs4rWSaUAIKboSYz3ocuZojN7tYHISbcwyNOn5pUV7mtu8QMsY2iT/OEYtChtaYw27PGIKAx5GQ== X-YMail-OSG: d_jlH2QVM1liWCtt6zBXVE3huLUUPDhwVw2uHlHzq7kJtOJVLrSeaRl4KdI7.4v kEcb6m8D4L603fJWAPyhEbYdW8.Suxa1y7FYcfYkvRtgnpqYhb3iBVMAjNcGass5QeAWYEN8m8ku U028dHfQylH.4mPjBwqyoLsxbJ8PSybRq7TUw85suqUbDzPqCFUwdBHu2H4VRmjsuYvJ.CBwzId5 VRDTLuvKmHWyV8yKH8JQs0uK473x22W3MrBt7XT8ZCWtBJNxOwmjqv0JUMldbrnqPa5w9FimAgBb 0SlFHmRFXfVaZSjMmsvg3BrMqroiaF4cHUAfz98hVJkxo2e21fSXgWLbcuKM0ChXUTU96satd1Ba lzlh8NjOOHiqsnGlQhcg1Q7YSvVPVFpekFTMlN1UP46WdJJX6PKOAxc.6O1OelxRgFoEjVnW4gJM 7glXe0Ku.EfWuG32jCxqjofBv.dPpo0HzAVG6Rkp1UWWIyVdF2HUoUbE8HJv_2xC0AICyUz5jPzN Y3gB7lIYyKCnj6DViTidDKF4ceA1sN3Vmoca_yShe.32JfJsTMhHiubJbXuVRmZFDoIrP2zAE4Z3 s7.kbT3YA8DL5tYTcuy_pg7M5_WpNpnAxngWkqWrEj9nN2RcD8ze3A3K77.pb3pp59k5.CXmYOy0 5K1ipbQbjouwOSWne2aOKUO8zy3f44AzIXgGDD4LEHUcsxhOEaOaitFA6EQ6_RO4v9RhWz_k2Sxp GKmJY4wbtRcHG9_Lr9Ly2Y83N_B63A91mf0FYpo_WP80LMtw5spFTtjkdYxIuQqZw3nlEGxxvBcU zQi2LCxqIlCqkIw_RrpBnSMnhs.AJEgCHvTyQllIuniE_fXNbdxPumUAVG4BJMP3uIhAU513qHbl N1845PkcfS.02Edu3qDP8dHJ6e2eokbJ0A2lu_Buce9nDMQjHi6pzeg6kb0wSfww7WUCxqJLLU_t EQ8bdALTF3wtwYuimB1AVIl1hQL020EKbcpeCeovKKryaCzxw2iADCCKEu6qYyRWm4WVux0zf.7q YhH4kNQN6.S1f2sinL6gWSqnNE0uc3KAS7X0qlvSm1He3nJeX74.oQpvCFsBfdhuCYgpLl04FWjV 7ztZUB_S3WUTeVaG.DvJetUs4VLIeULyWxD.6M718R97TFGDAt5gVFayHSFpuQ15.J2PZACv3pmp l80TUjyp0pjxC6tEGi1azcElEyUeD.hni5e0WItUwLKAr9OSpWvxk7O5NvzRkH_mZqYjnaAISS1C 3tsUk9etEjSwTIGxVzLP07_LhME844R5tlUHfVAIFvT4lfGQwTR.R20MK0kD77AQ.uv1Sv9AEmyF R55sNNHcBLUtj_BgKFa5jIZfuZu00qFdGZE5naZPWlmVbp8_hEGd6IrFNLqoEeB4QOpvspHxosg8 LGLjRIjRAdtyRghmBZDCaqb_DDs6GKyUbYcd8T8kQ6eq69PbBck0XLq_EV6x64mxcAW85TZYlWVa M88RjlCo9X6P6Yzuukxw25cOwAQS823LrKcqE6pKypPANPYACr1AakhxW4nAHJMUXL6Aamo8. Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Sun, 27 Sep 2020 22:22:41 +0000 Received: by smtp419.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID a3ad025640a47d5efdb66d18c1342559; Sun, 27 Sep 2020 22:22:36 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Alan Third Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX References: <20200918125424.GF635@breton.holly.idiocy.org> <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> <20200918221524.GA28875@breton.holly.idiocy.org> <20200922122451.GD28875@breton.holly.idiocy.org> <20200927095932.GH28875@breton.holly.idiocy.org> Date: Mon, 28 Sep 2020 00:22:35 +0200 In-Reply-To: <20200927095932.GH28875@breton.holly.idiocy.org> (Alan Third's message of "Sun, 27 Sep 2020 10:59:32 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.16674 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Content-Length: 345 X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 43470 Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) Alan Third writes: > In the meantime I suppose the simplest work-around is something like > the attached, which is near enough the same as what you did, Daniel, > but making explicit that "copy" and "generic" are doing the same > thing. I've tested the patch and it works fine for the use cases mentioned by the OP. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 03 10:44:02 2020 Received: (at 43470-done) by debbugs.gnu.org; 3 Oct 2020 14:44:02 +0000 Received: from localhost ([127.0.0.1]:44307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOilW-0004PM-8j for submit@debbugs.gnu.org; Sat, 03 Oct 2020 10:44:02 -0400 Received: from wilbur.contactoffice.com ([212.3.242.68]:58238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOilU-0004Ov-Jz for 43470-done@debbugs.gnu.org; Sat, 03 Oct 2020 10:44:01 -0400 Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by wilbur.contactoffice.com (Postfix) with ESMTP id EA294541; Sat, 3 Oct 2020 16:43:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1601736233; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=494; bh=kNM4LMutOMqo/smetyVO91ooAnvLh54KRsm7G/XXRfo=; b=fHTyOk/osuwVOCLGcPmcKderaCiFnq2Ryh0VgisnqQWkzaU4MbBKwuK8NWCLhxBZ Vy6eO9baei/phATsgybOBetNS71VjbPhKrT2x1yBtMNIfd5y3ZPsjBwoNz1qCAcotnb bMio+5uohbRbEbmn+vesH1SlI+Sma064IeeiJMtyL7BvlRh9QPDXASBgxb3rV7VzKQw UxcHXWKhCSygTtSG+zqFqt27icYo2vrQ6bEdHEqRP1IYOE+svVEzmct93wk8mYDVwaC tmjrZksj/JRoga/DE6/LjRwtc94qxHlt3BtAUgq0qrAvSRZCrUH9yGRZje+Mszd39Fj JiHTI++eHQ== Received: by smtp.mailfence.com with ESMTPA ; Sat, 3 Oct 2020 16:43:50 +0200 (CEST) Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 131CF2025D62C7; Sat, 3 Oct 2020 15:43:51 +0100 (BST) Date: Sat, 3 Oct 2020 15:43:50 +0100 From: Alan Third To: Daniel =?iso-8859-1?Q?Mart=EDn?= Subject: Re: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Message-ID: <20201003144350.GJ28875@breton.holly.idiocy.org> Mail-Followup-To: Alan Third , Daniel =?iso-8859-1?Q?Mart=EDn?= , "Paul Magwene, Ph.D." , 43470-done@debbugs.gnu.org References: <20200918191106.GH635@breton.holly.idiocy.org> <2c6d27a2-682b-d0eb-5b8f-b0b08c7293b0@duke.edu> <20200918221524.GA28875@breton.holly.idiocy.org> <20200922122451.GD28875@breton.holly.idiocy.org> <20200927095932.GH28875@breton.holly.idiocy.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=4.7 symbols=ALL_TRUSTED, BAYES_00 device=10.2.0.1 X-ContactOffice-Account: com:241649512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43470-done Cc: "Paul Magwene, Ph.D." , 43470-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Sep 28, 2020 at 12:22:35AM +0200, Daniel Martín wrote: > Alan Third writes: > > > In the meantime I suppose the simplest work-around is something like > > the attached, which is near enough the same as what you did, Daniel, > > but making explicit that "copy" and "generic" are doing the same > > thing. > > I've tested the patch and it works fine for the use cases mentioned by > the OP. Thanks. I've pushed it to the emacs-27 branch. -- Alan Third From unknown Fri Aug 15 20:28:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 01 Nov 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator