From unknown Wed Jun 18 23:13:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43467 <43467@debbugs.gnu.org> To: bug#43467 <43467@debbugs.gnu.org> Subject: Status: 28.0.50; [PATCH] defcustom warning-show-suppression-buttons Reply-To: bug#43467 <43467@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:13:49 +0000 retitle 43467 28.0.50; [PATCH] defcustom warning-show-suppression-buttons reassign 43467 emacs submitter 43467 No Wayman severity 43467 normal tag 43467 wontfix patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 11:52:14 2020 Received: (at submit) by debbugs.gnu.org; 17 Sep 2020 15:52:14 +0000 Received: from localhost ([127.0.0.1]:38731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwCk-0002mM-5K for submit@debbugs.gnu.org; Thu, 17 Sep 2020 11:52:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:40026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwCh-0002mE-J8 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 11:52:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIwCh-0007By-7i for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 11:52:11 -0400 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]:40792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIwCf-0002Ts-6q for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 11:52:10 -0400 Received: by mail-qk1-x742.google.com with SMTP id w16so2697613qkj.7 for ; Thu, 17 Sep 2020 08:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:message-id:date:mime-version; bh=CQH5T82p6FpiRUy7oNfyhBOUfZbE6CzC4CVbCUyLDdY=; b=WE01IWC6d5HuCmsHYVFR0Mb7kL3JFxpcl+PTy1y/z/smFQNaB12weRY4fAKUaw2IKe ugqdHnS57pbLlEIg79/z8x8+v1LEAni/QgdgxdOxgdzhmWS/Nir5Nu+3pDa3eg7YyyZC yth4j94CcQYzT685XkcKUM+sr/jScQdopHatGddD/nyPfW8jRsPoUw6LoPNi70WY4B2y FtRx0NPONony+KSvkPb8P0Yj6p4j4xuaEC370Gu0DVpdJR3WKM2hKH0cH5F1jF4uSPcU tL1fs8EJQNouY+i5ZcGvcVRL9q5MPCR1qtAC4gO7OpIhVpR7302tDRPcOowYSHzTlXdd UJtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:message-id:date:mime-version; bh=CQH5T82p6FpiRUy7oNfyhBOUfZbE6CzC4CVbCUyLDdY=; b=WS8dhsDVnF+qO6QS6a9L2UQyP3IrtO8aY886VMP61PBkce8Vq4I/XpK+DRUboSAT65 OBncP+Z/osZ6D9+fs7HptKcEYUtQ4BQpCjrDuU6iTfd17+UI+I83kr+L4XKG0M+1ngpj eaUqFeE8uSspH7KpktN7m6AwppMiVyHMhq8VJKGESl78Hdlv2p+tdy1tCfL0Pu8x9Ush M/7YCJOQQGGQdUusCnf4EMwoTekqxAN8u2DJSCtgg1RDT+TPb7XFh0LIFcbvNUipTSL3 hWDCC7disEcQrpu2Y2CKQ4wQFCaWKXHLeJtktZI+6s0innc2j2re/daXf5R7053V1E+/ 1kDA== X-Gm-Message-State: AOAM531hJ2k0zsRXDE9WMZVC1z29ZjN/cH85sAdJ/CpR+BI2jLS27Pjl lewjCPvBVGxnyu+IJedPdJWAfreTCBTM6Q== X-Google-Smtp-Source: ABdhPJzIhEPBws4lZe6TznAB6I9yAayr3qKsX910YIV1Rlx7F/yp9v7sk5rM63IW/YGVfTKPLTbTJg== X-Received: by 2002:a05:620a:1098:: with SMTP id g24mr28261444qkk.399.1600357926807; Thu, 17 Sep 2020 08:52:06 -0700 (PDT) Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id x124sm115144qkd.72.2020.09.17.08.52.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 08:52:05 -0700 (PDT) From: No Wayman To: bug-gnu-emacs@gnu.org Subject: 28.0.50; [PATCH] defcustom warning-show-suppression-buttons Message-ID: <87363g8krw.fsf@gmail.com> Date: Thu, 17 Sep 2020 11:52:04 -0400 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::742; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qk1-x742.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; format=flowed User-agent: mu4e 1.5.5; emacs 28.0.50 User-agent: mu4e 1.5.5; emacs 28.0.50 BCC: No Wayman The new warning suppression button behavior introduced in 66d01012ba61a364fe92cdc1728bfa135a90626a is a great idea, but I don't have much use for it and would prefer to not have the buttons clutter the *Warnings* buffer. The attached patch introduces a defcustom to control the display of the buttons. Thanks, Nicholas Vollmer --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Allow-customization-of-warning-suppression-button-di.patch Content-Description: defcustom-warning-show-suppression-buttons >From 74b2cce64bb0a1c6a65749b055078e5b1c326160 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Thu, 17 Sep 2020 11:40:41 -0400 Subject: [PATCH] Allow customization of warning suppression button display * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons): new defcustom to disable/enable display of warning suppression buttons in *Warnings* buffer. --- lisp/emacs-lisp/warnings.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el index e10c149d89..35e9870d1a 100644 --- a/lisp/emacs-lisp/warnings.el +++ b/lisp/emacs-lisp/warnings.el @@ -116,6 +116,11 @@ warning-suppress-types See also `warning-suppress-log-types'." :type '(repeat (repeat symbol)) :version "22.1") + +(defcustom warning-show-suppression-buttons t + "Whether or not to show suppresion buttons in the *Warnings* buffer. +If t, buttons are shown, else they are not." + :type 'boolean) ;; The autoload cookie is so that programs can bind this variable ;; safely, testing the existing value, before they call one of the @@ -294,7 +299,7 @@ display-warning message) ;; Don't output the buttons when doing batch compilation ;; and similar. - (unless noninteractive + (unless (or noninteractive warning-show-suppression-buttons) (insert " ") (insert-button "Disable showing" 'type 'warning-suppress-warning -- 2.28.0 --=-=-= Content-Type: text/plain Date: Thu, 17 Sep 2020 11:52:04 -0400 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 12:04:31 2020 Received: (at 43467) by debbugs.gnu.org; 17 Sep 2020 16:04:31 +0000 Received: from localhost ([127.0.0.1]:38765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwOc-00038g-RG for submit@debbugs.gnu.org; Thu, 17 Sep 2020 12:04:31 -0400 Received: from mail-qv1-f52.google.com ([209.85.219.52]:46260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwOZ-00038O-Tf for 43467@debbugs.gnu.org; Thu, 17 Sep 2020 12:04:29 -0400 Received: by mail-qv1-f52.google.com with SMTP id di5so1213926qvb.13 for <43467@debbugs.gnu.org>; Thu, 17 Sep 2020 09:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:message-id:date:mime-version; bh=ZEbsoZSR8yzLExFEbOnvHKTpz+hh8IfQnaBK9BVxzME=; b=aIeYZrSuee5KFXuC0nV7zUlqXqAnzN1BfsxAuSepoc+lt2thSSaprxMLw8qxwjr81a 6rNM7K36myyunAXlrk53pczfHBvfVxqm9OuizbuPPuoXyVgdo+Nema2tOBoaidL5pKfl ZEGV451mWBFVS39gqsTbVxw4f/h3weQL7BcNeFEPZfmxUsqI/D3uwiEu9uv+F+gnHcjH pue3yHNpWd/tVjOOws/d9Q54C13jR0L7LaGUKDaGc9qQeekft3qsvtniRZbcmADGWa/8 if67L9eGZ49W/Qvnbv/fs0/lWbVb47I61CHd4aXSdGzYRneOKYL12httz+m3+tJWC55o Jl8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:message-id:date :mime-version; bh=ZEbsoZSR8yzLExFEbOnvHKTpz+hh8IfQnaBK9BVxzME=; b=iuhYHlvd85JGEKsiC7jxlAFxsaKBAiqHOMzUB7HfLdXyYL8h416jelipyyAC8L0YiQ Hn5D4Az5UNuHRQpw27D7mTySdmghAHAZ2fP5ygLkax8N6uye1fyJXvJyvqO5Z9p5m7Y9 KLyBnE1j7/8Fq5Kin/r+rZYgCex1a/BA+fTFzP1IxQQhXmfF0hybh002kybyeGyzUpZ8 Uwipg8f32/9Nh4Ttiy17iNn9No2EswWe6K+WnSsnWTCtg8rVw1xhe/PJg8U9cpXKzMjo bqX8cFoQinbhD+mE7ngJURt/aHBOeU1QHRJcoTOc0WVOiNDwbxpBcd+33/SjyfPlEx+w 5wGg== X-Gm-Message-State: AOAM533wtxUPAYJrPJ6iwxSGHZChUvwxGZS8Iyx9u4M0kWg6/PrkGuSY 9sVKp9Bgb+7e3DrlWBE+GJ7YmiNZGFaYvw== X-Google-Smtp-Source: ABdhPJzF3A3OP6FLjQnArVBIZ85AJcB2E9nH4OXY5TUv6MeFE6Mgc01wicoMToS3aEqVSIveRy+ZLg== X-Received: by 2002:a0c:ee86:: with SMTP id u6mr12994193qvr.56.1600358661967; Thu, 17 Sep 2020 09:04:21 -0700 (PDT) Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id t140sm116115qke.125.2020.09.17.09.04.20 for <43467@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 09:04:21 -0700 (PDT) User-agent: mu4e 1.5.5; emacs 28.0.50 From: No Wayman To: 43467@debbugs.gnu.org Subject: [PATCH] defcustom warning-show-suppression-buttons correction Message-ID: <87d02k2xvf.fsf@gmail.com> Date: Thu, 17 Sep 2020 12:04:20 -0400 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43467 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed Sorry, just woke up. The attached patch corrects the logic of the first one. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-warning-show-suppression-buttons-defcustom.patch Content-Description: warning-show-suppression-buttons-correction >From 0f5caefcfe496ebccfedf24cfc75b249e1e7bf76 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Thu, 17 Sep 2020 11:40:41 -0400 Subject: [PATCH] Allow customization of warning suppression button display * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons): new defcustom to disable/enable display of warning suppression buttons in *Warnings* buffer. --- lisp/emacs-lisp/warnings.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el index e10c149d89..8ed4e425f3 100644 --- a/lisp/emacs-lisp/warnings.el +++ b/lisp/emacs-lisp/warnings.el @@ -116,6 +116,11 @@ warning-suppress-types See also `warning-suppress-log-types'." :type '(repeat (repeat symbol)) :version "22.1") + +(defcustom warning-show-suppression-buttons t + "Whether or not to show suppresion buttons in the *Warnings* buffer. +If t, buttons are shown, else they are not." + :type 'boolean) ;; The autoload cookie is so that programs can bind this variable ;; safely, testing the existing value, before they call one of the @@ -294,7 +299,7 @@ display-warning message) ;; Don't output the buttons when doing batch compilation ;; and similar. - (unless noninteractive + (unless (or noninteractive (not warning-show-suppression-buttons)) (insert " ") (insert-button "Disable showing" 'type 'warning-suppress-warning -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 12:14:07 2020 Received: (at 43467) by debbugs.gnu.org; 17 Sep 2020 16:14:07 +0000 Received: from localhost ([127.0.0.1]:38796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwXv-0003Q4-5A for submit@debbugs.gnu.org; Thu, 17 Sep 2020 12:14:07 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:51313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwXt-0003PU-PW for 43467@debbugs.gnu.org; Thu, 17 Sep 2020 12:14:06 -0400 Received: by mail-wm1-f47.google.com with SMTP id w2so2523736wmi.1 for <43467@debbugs.gnu.org>; Thu, 17 Sep 2020 09:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=VbbeNc4pymAih4C0SKskAo45Kz9mqq76c6mIM2mxdWg=; b=X3Abh+B81AeX+y2Uy5N7oi2RUnPNsBEK3M9otIaREFChMC2ozg6QnH/m0uIuKFECNg xbCpsjsxpVOgsCdyrfO6O8BBSgyP5dqgTaH1o/sVV13kcqGgChooTGZ5xt7cOcafJMuF 3XJLq+eLrMANeTv6oeiN55jvsVlh1/OBQYCi6rc73PHDnpLSd5H04Ekl2M1JDumgZ2IL M9QWKTtYpEcMMPPTP5DbWvkjoOCike1Dye/2uJbkAg/LMrlHtk0CNZxa3cVI9DB2aw2I 8UgtFHDCsbYjBJCu9bzCB1CAQZV7B8/KqKKlC4EHoGRxBUENw1Iu6I/9CUCuBn5e2blv OThA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=VbbeNc4pymAih4C0SKskAo45Kz9mqq76c6mIM2mxdWg=; b=idbec342zut9a2NKQMu35GJhM60X767ikFi7oDSSiXkhyWCqTsKJXbrCOetBuAKt1Q ZdixHBjpj2wD+AcWai+HodfDaDetNCKE6eNJ/k0RQKAbgAeiqynPHRJ4iu195WRSJ8/p 30xprRZw1OXIiS1CDUEktRQBuIbzxfPt+8EbNbZeBS25oHEaYYlxKap3zOiwzGXAoUop 8/Qv5trjbI1BkAy9UDe0UA+NGweIodTueugJ3gPG+lkm6x1zMwh5MMZm1Y/pNFE3p605 /tWiIAK4CSJRS20kvlZ/L3T/mJS6twZxL1fJtTu8IGZREL9ttkB1mcO6jIazE1WWQCbm jcwQ== X-Gm-Message-State: AOAM533br+lgNo2I+0g0afkDIlCp1bbrnRR2xre+pg3qtjx7uISLSs0E iRXGMT5TxBe7HUuCI3ADti5f+b2Ul14= X-Google-Smtp-Source: ABdhPJyNg1/x/rM1WVuZkSxI4DZYR+HydxPYDuXh/C/j2mel/MRufAs6/NouaeC00jN6MwjRPi/vFg== X-Received: by 2002:a05:600c:414b:: with SMTP id h11mr10890852wmm.20.1600359239491; Thu, 17 Sep 2020 09:13:59 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:99bb:88d4:2cf6:2ab9]) by smtp.gmail.com with ESMTPSA id w14sm50766wrk.95.2020.09.17.09.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 09:13:58 -0700 (PDT) From: Robert Pluim To: No Wayman Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction References: <87363g8krw.fsf@gmail.com> <87d02k2xvf.fsf@gmail.com> Date: Thu, 17 Sep 2020 18:13:57 +0200 In-Reply-To: <87d02k2xvf.fsf@gmail.com> (No Wayman's message of "Thu, 17 Sep 2020 12:04:20 -0400") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43467 Cc: 43467@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 17 Sep 2020 12:04:20 -0400, No Wayman said: No> Sorry, just woke up. The attached patch corrects the logic of the No> first one. No> From 0f5caefcfe496ebccfedf24cfc75b249e1e7bf76 Mon Sep 17 00:00:00 2001 No> From: Nicholas Vollmer No> Date: Thu, 17 Sep 2020 11:40:41 -0400 No> Subject: [PATCH] Allow customization of warning suppression button display No> * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons): No> new defcustom to disable/enable display of warning suppression buttons No> in *Warnings* buffer. No> --- No> lisp/emacs-lisp/warnings.el | 7 ++++++- No> 1 file changed, 6 insertions(+), 1 deletion(-) No> diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el No> index e10c149d89..8ed4e425f3 100644 No> --- a/lisp/emacs-lisp/warnings.el No> +++ b/lisp/emacs-lisp/warnings.el No> @@ -116,6 +116,11 @@ warning-suppress-types No> See also `warning-suppress-log-types'." No> :type '(repeat (repeat symbol)) No> :version "22.1") No> + No> +(defcustom warning-show-suppression-buttons t No> + "Whether or not to show suppresion buttons in the *Warnings* buffer. No> +If t, buttons are shown, else they are not." No> + :type 'boolean) Your defcustom needs a :version "28.1" Robert From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 12:16:27 2020 Received: (at 43467) by debbugs.gnu.org; 17 Sep 2020 16:16:27 +0000 Received: from localhost ([127.0.0.1]:38814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwaB-0004la-FJ for submit@debbugs.gnu.org; Thu, 17 Sep 2020 12:16:27 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwaA-0004fO-0k for 43467@debbugs.gnu.org; Thu, 17 Sep 2020 12:16:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q3J6ieY40z9WpUQYDYEqVw6l2iT27vfEPxj0gda5E5Q=; b=NDOeaPGZMpMGXr/Qooxma+udTX IQT4yavt8TdhkPL6wDXPGHA5mU3m80Hy5hpGy5xHnqcsGwNeokOkVlv/W6zS0VdPmwiSGWL1sqCLJ 7nvhtBDaQFGIUBeOIPSiFjCq9pEtXCPiqUCDzArH3btHmIHuOJ10ZkegKATdO4qHlfrw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIwZy-0002Mx-Cd; Thu, 17 Sep 2020 18:16:19 +0200 From: Lars Ingebrigtsen To: No Wayman Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction References: <87363g8krw.fsf@gmail.com> <87d02k2xvf.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUZGRojIyV/f39i YmOhoaDc29n///+lfWGoAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QJERAOBs9yinQAAAFpSURBVDjL xZJtcoQgDIaTcgGyegGr/b8Ke4Cu4QSF+1+lCeCuqP1dZmCGPOTrJQBEVrYuC9siPTCfoFaE/1qo +ekKoIBPe0EI0PD30Wo1Evr4vAAAXUh8PwJlj5TifErh7JJSOiZB9D8fQey8lvtWXXcLsxjdxJxN L6XpEafVmsB8zI4cCTonoE1ioec585rkrQCGAQiJT2VRWp253wIPrd24FMVBWp+rcBvxKc0kx9Pu AZKbRA6WvZYWNg83fYkeQYEtLyvwrEC1mukP4HKoF+g5ZHtk14bquTjE59iGMhWIIq2HWb0WLCD3 IRO+9TdSr8WKRxsKHBUHEbepCuiWa2Iey/WtVSdGL1sbxD2wuc2S2zagm7hUazXFe7qp8/IZfEdo ytVHC2/t7ZNr9iD/imcgkVJN3YQC+dY41LlpgAgs44lVkR0wkwxItTQgP5apsCegS6b3EtDideCQ DiAruR7Lzb0IYMrgF7e4T4Xs5IhwAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTA5LTE3VDE2OjE0 OjA2KzAwOjAwPt+8MgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0wOS0xN1QxNjoxNDowNiswMDow ME+CBI4AAAAASUVORK5CYII= X-Now-Playing: Noveller's _Arrow_: "Landscape" Date: Thu, 17 Sep 2020 18:16:13 +0200 In-Reply-To: <87d02k2xvf.fsf@gmail.com> (No Wayman's message of "Thu, 17 Sep 2020 12:04:20 -0400") Message-ID: <87imccnzua.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: No Wayman writes: > * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons): > new defcustom to disable/enable display of warning suppression buttons > in *Warnings* buffer. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43467 Cc: 43467@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) No Wayman writes: > * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons): > new defcustom to disable/enable display of warning suppression buttons > in *Warnings* buffer. Warnings are something you should rarely get, so I'm not quite sure I see the use case for this? In any case, some minor comments... > +(defcustom warning-show-suppression-buttons t > + "Whether or not to show suppresion buttons in the *Warnings* buffer. suppression > +If t, buttons are shown, else they are not." We usually say "if non-nil", not "t". > + :type 'boolean) And there should be a :version here. > - (unless noninteractive > + (unless (or noninteractive (not warning-show-suppression-buttons)) And perhaps this would be clearer as a (when (and .. instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 12:24:29 2020 Received: (at 43467) by debbugs.gnu.org; 17 Sep 2020 16:24:29 +0000 Received: from localhost ([127.0.0.1]:38820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwhx-0005pl-C3 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 12:24:29 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:41465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIwhv-0005pW-UK for 43467@debbugs.gnu.org; Thu, 17 Sep 2020 12:24:28 -0400 Received: by mail-qk1-f172.google.com with SMTP id g72so2815098qke.8 for <43467@debbugs.gnu.org>; Thu, 17 Sep 2020 09:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=qKwLrV5gXQ6NqNhhvo1TZRG19rRrJV3JbAmhSDCkydA=; b=WA0e6RjNt6MAurr7U7C7+ZGGu0Gh/o5IJ9U8wyG/bbfW43Xs4NC/kk4tvw29AYcj4p 9KtiMQKYwbiysVP9mFAuY9EeDlflm04kesSmN9V9EJ75SAQv1o9bPWvUl3FLT/0f/rxc Qj+0UgMbLdSsSq0FixlCpPbj8cOU8hBfF6PRjdsnIXCW/qyTYt/GgrcDiyyfnzbpjmd4 PmYatO7SfppXuraMvegDVIT4HD5IJSkADlwqN2JCp6V1raEc7X64HXRWSoKM/TEOsUrx hACk4HeZK1hRPSDqWfp0o3CjCDXFHup27NIGLLzfHWa/V/ikxt/ZldepnnjnwEkODbi5 plIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=qKwLrV5gXQ6NqNhhvo1TZRG19rRrJV3JbAmhSDCkydA=; b=pQSYnbriT0IeiEOmLgfV2My2fCM8DhQXofmNN4HQZcLETR6wOun/cyaf3ITbh6ZM6Z MytiCA+y89fP2F76BUEmNiOURkMZ//CUGDIP/6sFEI4M7Gao1KcTjANwo+p5irE0fZnn ASoOJeEuVq+u7NCzR/2Y+9MWyh45mfIxV2OyFe4Mhz1v8uVpFByRJAbpQYzZlbE6ly1d Z2bPMaJbC32tTg35BSVUica2DRQryiEVFMpYGON8mG545ns5wQ77HG4aA4PeMx3xyayW 0pobaPYABFhuDkdXmx/riok6QxOgiFPFhqB8WHmJiLRdOyqEhK55R0+Ji+gJgHUJTVXk OCig== X-Gm-Message-State: AOAM530SRs+mquz7XtNCjrjuPG67y1LJjohACgI4dI5ryawNPMDHRY04 K8dYsxpswFNL5dVEOX0myufyhy//qyEZ8A== X-Google-Smtp-Source: ABdhPJwwh/Vr1YQyLX35SiPiD0hfPQ2XtYY+lQyGfpDqFOMtWB/KWotdEyA2drYXkZM5kzZHhlj4/w== X-Received: by 2002:a05:620a:1583:: with SMTP id d3mr28033467qkk.495.1600359862150; Thu, 17 Sep 2020 09:24:22 -0700 (PDT) Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id v131sm194566qkb.15.2020.09.17.09.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 09:24:20 -0700 (PDT) References: <87363g8krw.fsf@gmail.com> <87d02k2xvf.fsf@gmail.com> User-agent: mu4e 1.5.5; emacs 28.0.50 From: No Wayman To: Robert Pluim Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction In-reply-to: Date: Thu, 17 Sep 2020 12:24:20 -0400 Message-ID: <878sd82wy3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43467 Cc: 43467@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed Robert Pluim writes: > Your defcustom needs a :version "28.1" Thanks, Robert. Addressed in attached patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-warning-show-suppression-buttons-take-three.patch Content-Description: take three >From 6160b555d4155141646c9064e59a41895c11e665 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Thu, 17 Sep 2020 11:40:41 -0400 Subject: [PATCH] Allow customization of warning suppression button display * lisp/emacs-lisp/warnings.el (warning-show-suppression-buttons): new defcustom to disable/enable display of warning suppression buttons in *Warnings* buffer. --- lisp/emacs-lisp/warnings.el | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el index e10c149d89..5a8152d2dc 100644 --- a/lisp/emacs-lisp/warnings.el +++ b/lisp/emacs-lisp/warnings.el @@ -116,6 +116,12 @@ warning-suppress-types See also `warning-suppress-log-types'." :type '(repeat (repeat symbol)) :version "22.1") + +(defcustom warning-show-suppression-buttons t + "Whether or not to show suppresion buttons in the *Warnings* buffer. +If t, buttons are shown, else they are not." + :type 'boolean + :version "28.1") ;; The autoload cookie is so that programs can bind this variable ;; safely, testing the existing value, before they call one of the @@ -294,7 +300,7 @@ display-warning message) ;; Don't output the buttons when doing batch compilation ;; and similar. - (unless noninteractive + (unless (or noninteractive (not warning-show-suppression-buttons)) (insert " ") (insert-button "Disable showing" 'type 'warning-suppress-warning -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 13:09:24 2020 Received: (at 43467) by debbugs.gnu.org; 17 Sep 2020 17:09:24 +0000 Received: from localhost ([127.0.0.1]:38864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxPP-0006wC-QG for submit@debbugs.gnu.org; Thu, 17 Sep 2020 13:09:24 -0400 Received: from mail-qv1-f43.google.com ([209.85.219.43]:33669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxPO-0006vz-Kn for 43467@debbugs.gnu.org; Thu, 17 Sep 2020 13:09:23 -0400 Received: by mail-qv1-f43.google.com with SMTP id cy2so1356214qvb.0 for <43467@debbugs.gnu.org>; Thu, 17 Sep 2020 10:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=0AmEn5Vh3m7JEhiU+fB+JOsGXVKme546oBp9eTt7gws=; b=ZIrL3bDik9fEA9r/PE2v4w1f2cqr7BOzib3MXniYUUbXKXQjkViOOCRSebELJhcak4 6I6/1SU/iPUOR4iLPlxM702rul89hkyerGydEAsN+wQuX7YRnRCnwG3aqSf3pka464TC dlwhDFJu09e8qYprZYR8l1zEQ3pH9yyGy5nhScGeFxKf+OP/078xOczsmaozrZWXkzKt uMdgtM1y8iPPidCe8PNRXhjdrxKZyN3r2lAnJgj0XUvCTsu7+hPKXVDbj84jsaq62muT HNYwcaHzy9rZd22W3YX7k6ZWrBd+53STM7k8coaagHRQyotjWMlDhPVutqmcz+eZZVA1 sZsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=0AmEn5Vh3m7JEhiU+fB+JOsGXVKme546oBp9eTt7gws=; b=Ol4mZHW6bR7aH/D9CsQe8SJnlpca0St3RFNIUdvxzGDxbOvvX5HQ/Dpcwc37DEK9Mz emKhKEBFaAoLcvIKQww/MBXuRM1B1bNq/Yyfu7dZ+nC+qidhoA4n6UxnAfXBJreThLJf zyjGoAW7AZH2m9P65uTxW8T94T2UVFBYRjfBlqojkxb3xjFs3M6YcxYFgXol4VpH1rZx 8LGLOA5tfw0PHz8fomehYHXUMRDMbBIYRQNy0n9b/MQHNJCvW1APkvyseUK8gkTpghgF cLWgKO8PvlDI6S3d7XdLHv1wdwh1Bf2ZJBaMQQIlKqh7zPKHsAsAvHlPzOHk8seXcVDg M8Vw== X-Gm-Message-State: AOAM533b7NamdS0ckf2nPtDUcdK1KHVgH3dqFAAJ9b+TGgKslJH36J9f IERUlEUMaA0GpS6CCdM+7M2lUqY4BpWKGw== X-Google-Smtp-Source: ABdhPJwjYdBXYrmD265OGVjuRR8F8ERpAyqJ4vaAMFJ6QOMj19JlD7TLpwmsPrg7dmO4XmjTVGubMw== X-Received: by 2002:a0c:f48e:: with SMTP id i14mr29496256qvm.5.1600362556893; Thu, 17 Sep 2020 10:09:16 -0700 (PDT) Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id 10sm251125qkk.88.2020.09.17.10.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 10:09:14 -0700 (PDT) References: <87363g8krw.fsf@gmail.com> <87d02k2xvf.fsf@gmail.com> <87imccnzua.fsf@gnus.org> User-agent: mu4e 1.5.5; emacs 28.0.50 From: No Wayman To: Lars Ingebrigtsen Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction In-reply-to: <87imccnzua.fsf@gnus.org> Date: Thu, 17 Sep 2020 13:09:13 -0400 Message-ID: <874knw2uva.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43467 Cc: 43467@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed Lars Ingebrigtsen writes: Thanks for the feedback, Lars. > Warnings are something you should rarely get, so I'm not quite > sure I > see the use case for this? In any case, some minor comments... The same argument could be made against the buttons/suppression themselves: "Warnings are something you should rarely get, so I'm not quite sure I see the use case for suppressing them." I don't see either as a particularly strong argument. For me, the buttons are useless because I have `custom-file` set to `null-device'. They just add visual clutter to the buffer in that case. The customization seems pretty low-cost in terms of complexity/maintenance IMO and provides the flexibility to accommodate my (and possibly other we haven't thought of) use cases. > And perhaps this would be clearer as a (when (and .. instead. Addressed by changing the customization to `warning-hide-suppression-buttons' and inverting the semantics in the attached patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-warning-hide-suppression-buttons.patch Content-Description: warning-hide-suppression-buttons >From 03035944c1f19bbb628c798ce1f6feeceedbc7b3 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Thu, 17 Sep 2020 11:40:41 -0400 Subject: [PATCH] Allow customization of warning suppression button display * lisp/emacs-lisp/warnings.el (warning-hide-suppression-buttons): new defcustom to disable/enable display of warning suppression buttons in *Warnings* buffer. --- lisp/emacs-lisp/warnings.el | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el index e10c149d89..d7345b2536 100644 --- a/lisp/emacs-lisp/warnings.el +++ b/lisp/emacs-lisp/warnings.el @@ -116,6 +116,12 @@ warning-suppress-types See also `warning-suppress-log-types'." :type '(repeat (repeat symbol)) :version "22.1") + +(defcustom warning-hide-suppression-buttons nil + "Whether or not to hide suppression buttons in the *Warnings* buffer. +If non-nil, buttons are hidden, else they shown." + :type 'boolean + :version "28.1") ;; The autoload cookie is so that programs can bind this variable ;; safely, testing the existing value, before they call one of the @@ -294,7 +300,7 @@ display-warning message) ;; Don't output the buttons when doing batch compilation ;; and similar. - (unless noninteractive + (unless (or noninteractive warning-hide-suppression-buttons) (insert " ") (insert-button "Disable showing" 'type 'warning-suppress-warning -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 13:27:58 2020 Received: (at 43467) by debbugs.gnu.org; 17 Sep 2020 17:27:58 +0000 Received: from localhost ([127.0.0.1]:38880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxhN-0007No-VT for submit@debbugs.gnu.org; Thu, 17 Sep 2020 13:27:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxhL-0007NV-ND for 43467@debbugs.gnu.org; Thu, 17 Sep 2020 13:27:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YHV0xv9WcDajvMW1E7aIR6bM/4+HrQiPwgFQd1UW/z8=; b=Za9CqffK59jpl+C6sZ6E670WXI 609fsUNGpVmy0UsO8wsk2ojBBA3fqlJBUGOk9WYUFePOrOrFadVV4gRxt81yvaTaFY7tZejHDZHeS 6oVssk+lzUw1LPiAgyR4XpjPvV51iLlYgYav4c5/5mah0UMGV+5URfguNxTHp6UzxZCU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIxhC-00032T-Jg; Thu, 17 Sep 2020 19:27:49 +0200 From: Lars Ingebrigtsen To: No Wayman Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction References: <87363g8krw.fsf@gmail.com> <87d02k2xvf.fsf@gmail.com> <87imccnzua.fsf@gnus.org> <874knw2uva.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEW4xMRuaZIqKkT/ //8985ebAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QJEREZOApSeX4AAAFLSURBVCjPTdC/asMwEAbw M7gdOqXgQMnWoaXkKRyoO7tgmSZzHWI9RbJ0dqAJjaa0WMb6nrJ3iv9Ei/Tjk04nEV1GkPopUkmW ZncAzkSfX2ht3aEwcDgLKqLGwPYIcJL5si2YHYzVcXeG7ifvKd12eC7+zgM0mmrA6hrGF1VKSUdL ICZex7wOKZxQrDnmZLZ+Ke2WsWc8gXuL+fyB9z0ariD45jM5zyDA7DKiNdBwYrBLu1dzAkkGJJEs FouUG0QyocCq48oJtvxHNn8rXP9hXBSCKJJEJWqjUU8VSe+JyjRayuWeOL7JtNv0l1Com9YXkFdF +tjO4V3Qg9atHNP4KYmreYCnRevhGG6+O43Qe97mcEH+245YSgc9SvUxoqgij5NAVSHDdkktcNpD uXA6lsYrt9thhWpmLGB9B6jnAp948yh9AT8kUVfjH1Zi8EUZV0QkAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIwLTA5LTE3VDE3OjI1OjU2KzAwOjAw3Ylm7AAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0w OS0xN1QxNzoyNTo1NiswMDowMKzU3lAAAAAASUVORK5CYII= X-Now-Playing: African Head Charge's _Drastic Season_: "Depth Charge" Date: Thu, 17 Sep 2020 19:27:45 +0200 In-Reply-To: <874knw2uva.fsf@gmail.com> (No Wayman's message of "Thu, 17 Sep 2020 13:09:13 -0400") Message-ID: <87een0nwj2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: No Wayman writes: >> Warnings are something you should rarely get, so I'm not quite sure I >> see the use case for this? In any case, some minor comments... > > The same argument could be made against the buttons/suppr [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43467 Cc: 43467@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) No Wayman writes: >> Warnings are something you should rarely get, so I'm not quite sure I >> see the use case for this? In any case, some minor comments... > > The same argument could be made against the buttons/suppression > themselves: > > "Warnings are something you should rarely get, so I'm not quite sure I > see the use case for suppressing them." No, the opposite -- since you get the warnings so seldom, it makes sense to have the very few you see come with ready-made ways of making them go away, and then you're back to no warnings again. > I don't see either as a particularly strong argument. > For me, the buttons are useless because I have `custom-file` set to > `null-device'. I think that's a very unusual thing to do, so it doesn't seem much like a use case. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 14:08:19 2020 Received: (at 43467) by debbugs.gnu.org; 17 Sep 2020 18:08:19 +0000 Received: from localhost ([127.0.0.1]:38988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyKR-0004Jr-97 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 14:08:19 -0400 Received: from mail-qk1-f178.google.com ([209.85.222.178]:44347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyKQ-0004Jd-8q for 43467@debbugs.gnu.org; Thu, 17 Sep 2020 14:08:18 -0400 Received: by mail-qk1-f178.google.com with SMTP id n133so3171539qkn.11 for <43467@debbugs.gnu.org>; Thu, 17 Sep 2020 11:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=9nKJRSG9gzDhT3B8Ku/0N6oNOlNN/jgkw2zV5zP+NzM=; b=UkcRJKCrtqHQ9UKCZ9ZmEJjiBfM4O0ZWWBp+BsBqUYicMl8sxuOpcpZeNyWwE28XES iq9zM9f5C2ITlj4S7Ea3Z1kx8yscFzlHwJT6dOlHgdz3LTM+BmdM8WtR4Q4Bp9vDcFLK 3BXeH0xRfleUB/6AY9BqGAL2XMgzN6UEF/1RD/ULYlZ1UqBuMORBjkFL8VCM2Vf1ER7S vEchN+aIW02AysGn2X76NgIJNCcxu21ve8jeZ3YJPstsBJePrjPKSR9sfdNKx97FA1P5 VtfP6f+gGZmWxobSLSwmmTN+92v2V2OFXQM/i1osTCGmi/PZzH8FAZehL//y0fkWBcbt 9+JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=9nKJRSG9gzDhT3B8Ku/0N6oNOlNN/jgkw2zV5zP+NzM=; b=TdzapePKejmQS7uzkiuxjYTsxbISdj+1Yodkx+OykFejmop8T5kwQynt/n87iCF1XT TgFyFdF4264bgo4A7dmOdYo81rQPZ8akbiCcKEgdHRW3NAUdugy1AN6taTpva/q6QAL6 nbdZfFW7qNDue2qTfO+ZxpmoL81KZfvLzxJNeop2HmHD1Kr65meRhZ3Xbjr5E3E/3gfJ w4iskevQejQatlXWtzUHPnmX9exqz/uMGIFU6lREiyx5r4ofbs4a+bM98cwRnOBhKeDD 0+yt0PlbsUCOD4wDIc9aGwV1e3+AZQr2AVIoi08CD7fCySRZRYiHhwUzVYm2RYIAUfI6 s9CA== X-Gm-Message-State: AOAM53311NmBle1jkcMe6H9n/OmpxUyKhF9cXSmLb9G55accWekFVvoY enhJAYcbPJN1TJPBQRaPdUbzIvAiewBAtw== X-Google-Smtp-Source: ABdhPJyzawfCEgrFw28xMOxDUp7vVGQC/LDSAaLJ85wykpSUt2oq3L8Z4ZUxBsXA7D5CplBwZvAv0A== X-Received: by 2002:a37:c09:: with SMTP id 9mr29945975qkm.471.1600366092517; Thu, 17 Sep 2020 11:08:12 -0700 (PDT) Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id z6sm369357qkl.39.2020.09.17.11.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 11:08:11 -0700 (PDT) References: <87363g8krw.fsf@gmail.com> <87d02k2xvf.fsf@gmail.com> <87imccnzua.fsf@gnus.org> <874knw2uva.fsf@gmail.com> <87een0nwj2.fsf@gnus.org> User-agent: mu4e 1.5.5; emacs 28.0.50 From: No Wayman To: Lars Ingebrigtsen Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction In-reply-to: <87een0nwj2.fsf@gnus.org> Date: Thu, 17 Sep 2020 14:08:10 -0400 Message-ID: <87363g8eet.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43467 Cc: 43467@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > No Wayman writes: > I think that's a very unusual thing to do, so it doesn't seem > much like > a use case. We don't see eye to eye on this, but fair enough. I've offered the patch and my justification. I have nothing more to add. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 09:14:14 2020 Received: (at 43467) by debbugs.gnu.org; 18 Sep 2020 13:14:14 +0000 Received: from localhost ([127.0.0.1]:41245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJGDO-0000Nb-L8 for submit@debbugs.gnu.org; Fri, 18 Sep 2020 09:14:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJGDM-0000NP-Ty for 43467@debbugs.gnu.org; Fri, 18 Sep 2020 09:14:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=B5Vlu1AH4W/FBwb/p2AJvugmYVS63QSacGTtSNUsUq0=; b=SkOSbwZUtOCh7NZJcSKhnQYebb cUA0SmYT4Fygi+mSauCDj8rW+e9TxOREPIrVPVxEPDjCZocIWfth+8Q431CTPSliFWvAtYGSRQm5h nQdJMgJFnTjzkFuC12cGwBBpHnSjLcSOfLfeqnHCGEThmkawQPl4U1LiBt6mU4aZf2Nk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJGDE-00067H-KN; Fri, 18 Sep 2020 15:14:07 +0200 From: Lars Ingebrigtsen To: No Wayman Subject: Re: bug#43467: [PATCH] defcustom warning-show-suppression-buttons correction References: <87363g8krw.fsf@gmail.com> <87d02k2xvf.fsf@gmail.com> <87imccnzua.fsf@gnus.org> <874knw2uva.fsf@gmail.com> <87een0nwj2.fsf@gnus.org> <87363g8eet.fsf@gmail.com> X-Now-Playing: Stina Nordenstam's _This Is Stina Nordenstam_: "Lori Glory" Date: Fri, 18 Sep 2020 15:14:03 +0200 In-Reply-To: <87363g8eet.fsf@gmail.com> (No Wayman's message of "Thu, 17 Sep 2020 14:08:10 -0400") Message-ID: <87ft7fi5wk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: No Wayman writes: > We don't see eye to eye on this, but fair enough. > I've offered the patch and my justification. I have nothing more to > add. OK; then it seems unlikely that we'll make further progress in this bug report, and I'm closing it. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43467 Cc: 43467@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) No Wayman writes: > We don't see eye to eye on this, but fair enough. > I've offered the patch and my justification. I have nothing more to > add. OK; then it seems unlikely that we'll make further progress in this bug report, and I'm closing it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 09:14:23 2020 Received: (at control) by debbugs.gnu.org; 18 Sep 2020 13:14:23 +0000 Received: from localhost ([127.0.0.1]:41248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJGDW-0000Ny-Sw for submit@debbugs.gnu.org; Fri, 18 Sep 2020 09:14:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJGDU-0000Nj-Oj for control@debbugs.gnu.org; Fri, 18 Sep 2020 09:14:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jdcG+9A6NTP/OEGkca6UtzdzMEg+nSqI2kIEOkWkZtg=; b=r93PGPEjqLrqmSJ2tyXfCuGuPQ t+v7jyG2eGCzrB+y+oRtrbKPpI187W8ud7rlguqwuLoTuqHOo7Kxg3q9POWTgB6oXxRFsXeA3JnWH 1omrcNTYP3zcTtfhbRHlQu0Btt60B/BAjOxWIhWFc5ltsP/73Iz78AabSbcmG5mCaXxY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJGDN-00067P-0x for control@debbugs.gnu.org; Fri, 18 Sep 2020 15:14:15 +0200 Date: Fri, 18 Sep 2020 15:14:11 +0200 Message-Id: <87eemzi5wc.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43467 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43467 wontfix close 43467 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43467 wontfix close 43467 quit From unknown Wed Jun 18 23:13:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 17 Oct 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator