From unknown Tue Jun 24 22:34:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43457 <43457@debbugs.gnu.org> To: bug#43457 <43457@debbugs.gnu.org> Subject: Status: 28.0.50; [FEATURE][PATCH] cperl-mode: Add value "PBP" to cperl-set-style Reply-To: bug#43457 <43457@debbugs.gnu.org> Date: Wed, 25 Jun 2025 05:34:23 +0000 retitle 43457 28.0.50; [FEATURE][PATCH] cperl-mode: Add value "PBP" to cper= l-set-style reassign 43457 emacs submitter 43457 Harald J=C3=B6rg severity 43457 normal tag 43457 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 16 17:18:32 2020 Received: (at submit) by debbugs.gnu.org; 16 Sep 2020 21:18:32 +0000 Received: from localhost ([127.0.0.1]:36653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIeox-00047M-Rc for submit@debbugs.gnu.org; Wed, 16 Sep 2020 17:18:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:37110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIeov-00047E-LZ for submit@debbugs.gnu.org; Wed, 16 Sep 2020 17:18:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIeov-00045j-EY for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 17:18:29 -0400 Received: from mout02.posteo.de ([185.67.36.66]:39479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIeos-0007jk-4d for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 17:18:29 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id EEC1D2400FB for ; Wed, 16 Sep 2020 23:18:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1600291102; bh=NG1D2jitC6bhfeiejhriEDjuVesDrR8dBzVvD7jlFqc=; h=To:From:Subject:Autocrypt:Date:From; b=RIW+8fFpAGckjjpd8WXCEKU/YaFlQ+uQIY0welE1P9tyUq4ZqGwYoOxJ4TqD2gBom DOo5pjKDR9pDiwIaDLWMEnEOFN3KGDkyjxFtd1jXrz+PUnMLkrKpzQcoovhy9D5RBZ Sx4BNpn1Y7ckzX4GsEDUhpTgpmp6frFylDkhvxNnkuAbB6RD1ZYDuNKyfwg6iLdS7P 0yh5a7sByXhEq/Q1x3XcER3+jg5x2hBrok209qPJRbkFrqXQGx8XWvnIo60xbudf4r lRi8r8aGNIJWcMdsAxKX47lguC8eEhfl9rOLHSBoK7jKvDLXjTTAjNQE3tQpKDEoBl Y1xNLk0oXohMg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BsCcs2qdsz6tmJ for ; Wed, 16 Sep 2020 23:18:21 +0200 (CEST) To: bug-gnu-emacs@gnu.org From: =?UTF-8?Q?Harald_J=c3=b6rg?= Subject: 28.0.50; [FEATURE][PATCH] cperl-mode: Add value "PBP" to cperl-set-style Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN4XzzzqAcpv0Lw/9H0KfYwkBY1jO aE8gBIP7cUGytufW9Kp2o8LsvwvVSq33q7oZANndaEfGV6aaUSATfTYG9PwHNgVY376qyEq8 n8Gfi5IUmBMsD3ofi7eEcgk6jqNzXXTLm5HNPuqMvi2RPUzn9nR+3f4Vax1je6XEn5oL+ow3 2nIFgBSRUby/YA5jgu1peZibYwCd9CBJAAoufBFo7GfgSygBWevGWL8Zv6m5lybPIxHUBuhw 18ZAU218lf+SexwMAy9ULh0K6hTZeLHiIqigIvu1+mz3pql869n7GC00PZIXtDY+s0VEulUZ 7S8ZVJKTpGv4lrunQ3JydBYt+0pLp5cgioF+3aKPaAsWQizeuLp6nGXNbrneXMlbqEOsdKvV NTAKy7sBFH73/brkrWn9LF80oP9ekeO7PVLYLPHmW7Ra2nC8I6R9t5my6V8fBnvqeJt+lQQP S0srdPdSJFgmbdBFj+89rVdAg43HkqNpcc8bRUKvBT8UfXmvJ/OPDCVGm2hhoU/nCDrE+nsv ZIBnj0SrvkDTZOsrHFyAMgqX4/Zw/RD8B3IjJA4F5aU9kfgT9vjhnstl/oNNbDUceB4rYVoi f9oLEEY7KMUgL303JgrgBq7Shtvv0NNqcZb1nefMC4krNZpMHW257PwhIgz1Ofl/38yNguKh r4Hl40J3cCOwNxnnyAWaE5m0DWhhakBwb3N0ZW8uZGWJAk4EEwEKADgWIQQilgRktDKfEXxD Xso3hfPPOoBymwUCXWzAvgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA3hfPPOoBy m1LuEACVTqDi5AtVFzaUpVo9spdwoPKpZmXM7WK3MHIQ0gpwDEj0E2lJVBG9qqo1IPumnqwf lH5FY8gS+iT8lknGB4VyCNOefPm3v8dOnWqFi26lodspkWGFOcFw4Nx0vuF+nNGWZyQOkT1T +OOOUeyF7Vd4pdJr3EoTZ9aQyH5p1GSmlMuV8PqD7wCIWKwKQQl7N2lqgALfESK5ImBv3AKe A/5jiRRy3DZBAvop/IyTmq6k9rrmwHu6HHkPmubLqpncrYPdUOy1Qp2jsY7FBL0as/XU6JSe X0mAK/SJtPRV5tJlJXEZS+x/1yiBaRhjWFLyRWyKOo6Z2ehGrtuKCo3IbsJvvQBRtQP5LWzY md0/Ac1FlCrKoLXoW8E3+cjNZQNiulrE0uq/+VDgAbPeCG1xKnlgocd8CvCeUzIc6u0/wiv/ 9NJCJSx6eCocBAP5SgGv4V4GgMBXT66iaQu6D14ErwjPAXFHYbRXZY9ApAvjvaocLRFXuy5S 9mrfS84kvOiCtDcN63xeTFhlv/ztZzB1s+qiLj9QcdQcdVEGhCIb+WPpyWMg4zwuKPn6Ov+s O1siqS5owNCxsLui1b5qAoeQHh408ziVr1I7p3nrbdiJJxp0BqzFClR3KGBKJI8H7nd4NQuS tgWj8vM2j54pkzYDQGXZFahXwK1jH8SheQ7R98FT87kCDQRdA1ayARAAooZdrnmvf4HaJTL9 nfDGTCM0iNUttovG5VQPUXUI70eaeAr+PM0C8NvVKNdsy/RRlX+Om95dg4CmYrM32DDuinIB c0gLAS6RKKYHe5fo2Ez3IQWqNAjGyfIC1v0D9lxwLhyf0CY+1CvKyigqgQFekGXyQV8t8FMO B+Uvu1hRc6UQVMtzEsNpYsxMpZAChakVcD4B5ZSn995TSXt1EEyeX5wU/40Omph1zz4sn0DW fUczVwbh2ElLbs54PyQyCSB/UkeYyqxU9wefpd9mrsRqWYJMPrrFu1/W4uocrH1W0ObZncFV 29g3JNKR3bGVCxhAYGODND2z5hDCxSDWaUJ074K76YqrSEBv/tQzr1N/f5uWPCOJXX69edie whRMBA5Gwja4s2qsKGjSxxgFuIPdyoo4+soaHPdLRMjGn7Qyh8zihw4KolQ3chXgCDsRiPu7 E3QNfWJMKB0ebQCa4CK5rB8HGEWFMJNI3E+UbZoe1CrnOSBdd/Rv4ED5HPw69rbUddQSuLF7 A12LqPQjuK+ZeI9MHYEBIq8pRzUGJJmDmJ3cOf9GaF5esfweidTNo3CEiSKkB7ccBSoOWECm KTGKlsraFnpps68wlz8UMwNEvumG4JZwmTa10qj7PDu/W0H6nH3egWbrfqUh29kspVrlfoqE 20EPCcUtCaayB3lZdLsAEQEAAYkCNgQYAQgAIBYhBCKWBGS0Mp8RfENeyjeF8886gHKbBQJd A1ayAhsMAAoJEDeF8886gHKbPZ8QAI16XfXtSGcMDjm5/2M0qLNTpCcPCVGbKlWdshJPt9gH QcQKHXrHEl4kTdBFB15LzHIqfcjbhMxdxEPqU+3wpz9UVIEUHQ+9+sFMU79CXGCPMOz6bo44 UXo4bbe0AdX7pLmdZnYce+wAlUEYlzBgf+5tA62RqgB4/kDgk8TX9LZKpxUp5zUhUTac6o2b NVhf77jFz/gGSEdo9DFxXyZOnvW5sy71cSXaYvecCX4Zkt1PIt6Je8FPrZB18m7204/5abHA FcekJd+WfxbLBpiidIsPqEGhjQuH3NE7A/YIYcYno0gasjjOl9voOgF63gWq0rU9DXPYzAEo T0X5U61d1MieiGzszbnAiFjuiCPOgEAZ5UOG1jgk0brXOGXcB6uLUKXdHY/Hew2Qw2UN4jsF qgaVHmgokTr0ml7VVP2x/QTsFB7+mCbJvKIy7wuaRUN8/YELIrcBo9TlZbHFhQuF/nUloLFy qWfnjERPf3F15raGx0mGtxyYmgjRGAmtn11fNUrvrPxvbrVOWq7kcSukdtHavH3J6VBv+8kd YFQMaa1HVZ6Fhp50GYB+zZ29C7gtNIe0rn59xAcsBab/TyNjpG4BP4D0oGCl0+TTgzNIemji AsnleF4J+/xNczT+QQusHYtByZ6FRWqKPxLl3NE9h5e4Uy5QpwXCCI97ZA248Hmp Message-ID: Date: Wed, 16 Sep 2020 23:18:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------F88D2624A8D301B64DF756FC" Content-Language: en-US Received-SPF: pass client-ip=185.67.36.66; envelope-from=haj@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 15:26:36 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------F88D2624A8D301B64DF756FC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit This is not a bug report, but a feature request. If I understand correctly, both go through the same channel. Motivation: cperl-mode offers a command 'cperl-set-style' which sets some customization values for code formatting according to a list of rule sets. The book "Perl Best Practices", known as "PBP" in the Perl community, also defines such a rule set, including the corresponding settings for Emacs (among other editors). The PBP rules are widely accepted for Perl code, so in my opinion it makes sense to make these settings available through 'cperl-set-style'. The attached patch adds the new value "PBP" to the style selection and to the documentation, and also contains a simple formatting test according to these rules. I also added some lines to etc/NEWS, but I'm unsure about the handling of "---" to indicate that the change is not relevant to the manual: There is no texinfo manual for CPerl mode, so maybe "---" should be added before the heading "CPerl Mode"? -- Cheers, haj --------------F88D2624A8D301B64DF756FC Content-Type: text/x-patch; charset=UTF-8; name="0001-cperl-mode-Add-new-value-PBP-for-cperl-set-style.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-cperl-mode-Add-new-value-PBP-for-cperl-set-style.patch" =46rom 14d2c238eafbaf64c29b845cb4de9e4bbac7217f Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Harald=3D20J=3DC3=3DB6rg?=3D Date: Wed, 16 Sep 2020 22:30:01 +0200 Subject: [PATCH] cperl-mode: Add new value "PBP" for 'cperl-set-style' * lisp/progmodes/cperl-mode.el (cperl-style-alist, cperl-set-style): Add indentation style recommended by Damian Conway's book "Perl Best Practices". * test/lisp/progmodes/cperl-mode-tests.el (cperl-mode-test-indent-styles)= : Add a test to verify indentation and unraveling of conditionals. --- etc/NEWS | 5 +++ lisp/progmodes/cperl-mode.el | 41 +++++++++++++---- .../cperl-indent-styles.pl | 44 +++++++++++++++++++ test/lisp/progmodes/cperl-mode-tests.el | 32 ++++++++++++++ 4 files changed, 114 insertions(+), 8 deletions(-) create mode 100644 test/lisp/progmodes/cperl-mode-resources/cperl-indent= -styles.pl diff --git a/etc/NEWS b/etc/NEWS index 81a4273b0f..8b336a8aa9 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1168,6 +1168,11 @@ non-nil, even if protected by 'dbus-ignore-errors'= otherwise. =20 --- *** D-Bus events keep the type information of their arguments. +** CPerl Mode +*** The command 'cperl-set-style' offers the new value "PBP". +This value customizes Emacs to use the style recommended in Damian +Conway's book "Perl Best Practices" for indentation and formatting +of conditionals. =20 =0C * New Modes and Packages in Emacs 28.1 diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index af179e2797..8804e83fce 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -1234,6 +1234,7 @@ cperl-old-style ["Auto fill" auto-fill-mode t]) ("Indent styles..." ["CPerl" (cperl-set-style "CPerl") t] + ["PBP" (cperl-set-style "PBP") t] ["PerlStyle" (cperl-set-style "PerlStyle") t] ["GNU" (cperl-set-style "GNU") t] ["C++" (cperl-set-style "C++") t] @@ -1553,12 +1554,12 @@ cperl-mode `cperl-min-label-indent' Minimal indentation for line that is a label. =20 -Settings for classic indent-styles: K&R BSD=3DC++ GNU PerlStyle=3DWhites= mith - `cperl-indent-level' 5 4 2 4 - `cperl-brace-offset' 0 0 0 0 - `cperl-continued-brace-offset' -5 -4 0 0 - `cperl-label-offset' -5 -4 -2 -4 - `cperl-continued-statement-offset' 5 4 2 4 +Settings for classic indent-styles: K&R BSD=3DC++ GNU PBP PerlStyle=3DWh= itesmith + `cperl-indent-level' 5 4 2 4 4 + `cperl-brace-offset' 0 0 0 0 0 + `cperl-continued-brace-offset' -5 -4 0 0 0 + `cperl-label-offset' -5 -4 -2 -2 -4 + `cperl-continued-statement-offset' 5 4 2 4 4 =20 CPerl knows several indentation styles, and may bulk set the corresponding variables. Use \\[cperl-set-style] to do this. Use @@ -6046,7 +6047,19 @@ cperl-style-examples stop; } =20 -### PerlStyle (=3DCPerl with 4 as indent) 4/0/0/-4/4/t/nil +### PBP (=3DPerl Best Practices) 4/0/0/-4/4/nil/nil +if (foo) { + bar + baz; + label: + { + boon; + } +} +else { + stop; +} +### PerlStyle (=3DCPerl with 4 as indent) 4/0/0/-2/4/t/nil if (foo) { bar baz; @@ -6149,6 +6162,18 @@ cperl-style-alist (cperl-extra-newline-before-brace-multiline . nil) (cperl-merge-trailing-else . t)) =20 + ("PBP" ;; Perl Best Practices by Damian Conway + (cperl-indent-level . 4) + (cperl-brace-offset . 0) + (cperl-continued-brace-offset . 0) + (cperl-label-offset . -2) + (cperl-continued-statement-offset . 4) + (cperl-extra-newline-before-brace . nil) + (cperl-extra-newline-before-brace-multiline . nil) + (cperl-merge-trailing-else . nil) + (cperl-indent-parens-as-block . t) + (cperl-tab-always-indent . t)) + ("PerlStyle" ; CPerl with 4 as indent (cperl-indent-level . 4) (cperl-brace-offset . 0) @@ -6220,7 +6245,7 @@ cperl-set-style "Set CPerl mode variables to use one of several different indentation = styles. The arguments are a string representing the desired style. The list of styles is in `cperl-style-alist', available styles -are CPerl, PerlStyle, GNU, K&R, BSD, C++ and Whitesmith. +are CPerl, PBP, PerlStyle, GNU, K&R, BSD, C++ and Whitesmith. =20 The current value of style is memorized (unless there is a memorized data already), may be restored by `cperl-set-style-back'. diff --git a/test/lisp/progmodes/cperl-mode-resources/cperl-indent-styles= =2Epl b/test/lisp/progmodes/cperl-mode-resources/cperl-indent-styles.pl new file mode 100644 index 0000000000..0832f86828 --- /dev/null +++ b/test/lisp/progmodes/cperl-mode-resources/cperl-indent-styles.pl @@ -0,0 +1,44 @@ +#!/usr/bin/env perl +use strict; +use warnings; +use 5.020; + +# This file contains test input and expected output for the tests in +# cperl-mode-tests.el, cperl-mode-test-indent-exp. The code is +# syntactically valid, but doesn't make much sense. + +# -------- PBP indent: input -------- +for my $foo (@ARGV) +{ +...; +} +# -------- PBP indent: expected output -------- +for my $foo (@ARGV) { + ...; +} +# -------- PBP indent: end -------- + +# -------- PBP uncuddle else: input -------- +{ +if (1 < 2) +{ +say "Seems ok"; +} elsif (1 =3D=3D 2) { +say "Strange things are happening"; +} else { +die "This world is backwards"; +} +} +# -------- PBP uncuddle else: expected output -------- +{ + if (1 < 2) { + say "Seems ok"; + } + elsif (1 =3D=3D 2) { + say "Strange things are happening"; + } + else { + die "This world is backwards"; + } +} +# -------- PBP uncuddle else: end -------- diff --git a/test/lisp/progmodes/cperl-mode-tests.el b/test/lisp/progmode= s/cperl-mode-tests.el index 2eaf633d17..8e3b73d649 100644 --- a/test/lisp/progmodes/cperl-mode-tests.el +++ b/test/lisp/progmodes/cperl-mode-tests.el @@ -172,4 +172,35 @@ cperl-mode-test-indent-exp (setq got (concat "test case " name ":\n" (buffer-string))) (should (equal got expected)))))))) =20 +(ert-deftest cperl-mode-test-indent-styles () + "Verify correct indentation by style \"PBP\". +Perl Best Practices sets some indentation values different from + the defaults, and also wants an \"else\" or \"elsif\" keyword + to align with the \"if\"." + (let ((file (expand-file-name "cperl-indent-styles.pl" + cperl-mode-tests-data-directory))) + (with-temp-buffer + (cperl-set-style "PBP") + (insert-file-contents file) + (goto-char (point-min)) + (while (re-search-forward + (concat "^# ?-+ \\_<\\(?1:.+?\\)\\_>: input ?-+\n" + "\\(?2:\\(?:.*\n\\)+?\\)" + "# ?-+ \\1: expected output ?-+\n" + "\\(?3:\\(?:.*\n\\)+?\\)" + "# ?-+ \\1: end ?-+") + nil t) + (let ((name (match-string 1)) + (code (match-string 2)) + (expected (match-string 3)) + got) + (with-temp-buffer + (insert code) + (cperl-mode) + (indent-region (point-min) (point-max)) ; here we go! + (setq expected (concat "test case " name ":\n" expected)) + (setq got (concat "test case " name ":\n" (buffer-string))) + (should (equal got expected))))) + (cperl-set-style "CPerl")))) + ;;; cperl-mode-tests.el ends here --=20 2.20.1 --------------F88D2624A8D301B64DF756FC-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 11:36:11 2020 Received: (at 43457) by debbugs.gnu.org; 17 Sep 2020 15:36:11 +0000 Received: from localhost ([127.0.0.1]:38698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIvxD-0000Dc-8o for submit@debbugs.gnu.org; Thu, 17 Sep 2020 11:36:11 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIvxB-0000DM-2R for 43457@debbugs.gnu.org; Thu, 17 Sep 2020 11:36:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VZFcT+YCxEEKfm+tRzED6MesUNEC/Yb5GEAdDTQLD6A=; b=KOb050Ku3I6gUAlGKI19XlKTES b56DyPESJ7ZicrBoMszRdDSZmLAkGnfornQXvKdZYjS93Iqdiq+Mxt1PMOdBvlTkdVoSotwwRJoVl 6gmRRuiZhQNfNqtNsi7c4oxd8GHQeyn8wHwoifDu2kAxsUxPEstAq7Qez9a5vRsxpErE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIvx1-000201-MG; Thu, 17 Sep 2020 17:36:02 +0200 From: Lars Ingebrigtsen To: Harald =?utf-8?Q?J=C3=B6rg?= Subject: Re: bug#43457: 28.0.50; [FEATURE][PATCH] cperl-mode: Add value "PBP" to cperl-set-style References: X-Now-Playing: PJ Harvey's _Dry Demos_: "Water" Date: Thu, 17 Sep 2020 17:35:58 +0200 In-Reply-To: ("Harald =?utf-8?Q?J=C3=B6rg=22's?= message of "Wed, 16 Sep 2020 23:18:20 +0200") Message-ID: <871rj0pg9t.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Harald Jörg writes: > This is not a bug report, but a feature request. If I understand > correctly, both go through the same channel. Yup. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43457 Cc: 43457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Harald J=C3=B6rg writes: > This is not a bug report, but a feature request. If I understand > correctly, both go through the same channel. Yup. > The attached patch adds the new value "PBP" to the style selection and > to the documentation, and also contains a simple formatting test > according to these rules. Looks great! Applied to Emacs 28. > I also added some lines to etc/NEWS, but I'm unsure about the handling > of "---" to indicate that the change is not relevant to the manual: > There is no texinfo manual for CPerl mode, so maybe "---" should be > added before the heading "CPerl Mode"? Yup; I did so before committing. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 11:36:15 2020 Received: (at control) by debbugs.gnu.org; 17 Sep 2020 15:36:15 +0000 Received: from localhost ([127.0.0.1]:38701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIvxH-0000Dy-JB for submit@debbugs.gnu.org; Thu, 17 Sep 2020 11:36:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIvxG-0000DU-2D for control@debbugs.gnu.org; Thu, 17 Sep 2020 11:36:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LWAuUoyxMGZt84/+D5LBfC2hPxgXguG6TCGmZv3x+9k=; b=kpHrDquzGBZsYzOBjGB09CjP3O rhNPv9VsCE4kOYUm3hnLf+nedxY8MZKizyYrCfqlvzK/dKCtOhrXLUa6sBOEMljHTNpK7geLg1SUE HjBH9eSSy7uVYeqCnTnRD+OmwqhKv4KBxz/hfVM4mw7LXKX0VL6qaFSse3ovcDZV1Vfw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIvx8-00020C-8W for control@debbugs.gnu.org; Thu, 17 Sep 2020 17:36:08 +0200 Date: Thu, 17 Sep 2020 17:36:05 +0200 Message-Id: <87zh5oo1p6.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43457 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43457 fixed close 43457 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43457 fixed close 43457 28.1 quit From unknown Tue Jun 24 22:34:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 16 Oct 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator