GNU bug report logs - #43457
28.0.50; [FEATURE][PATCH] cperl-mode: Add value "PBP" to cperl-set-style

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43457 in the body.
You can then email your comments to 43457 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Harald Jörg <haj <at> posteo.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [FEATURE][PATCH] cperl-mode: Add value "PBP" to
 cperl-set-style
Date: Wed, 16 Sep 2020 23:18:20 +0200

[Message part 1 (text/plain, inline)]

This is not a bug report, but a feature request.  If I understand
correctly, both go through the same channel.

Motivation: cperl-mode offers a command 'cperl-set-style' which sets
some customization values for code formatting according to a list of
rule sets.  The book "Perl Best Practices", known as "PBP" in the Perl
community, also defines such a rule set, including the corresponding
settings for Emacs (among other editors).

The PBP rules are widely accepted for Perl code, so in my opinion it
makes sense to make these settings available through 'cperl-set-style'.

The attached patch adds the new value "PBP" to the style selection and
to the documentation, and also contains a simple formatting test
according to these rules.

I also added some lines to etc/NEWS, but I'm unsure about the handling
of "---" to indicate that the change is not relevant to the manual:
There is no texinfo manual for CPerl mode, so maybe "---" should be
added before the heading "CPerl Mode"?
--
Cheers,
haj

[0001-cperl-mode-Add-new-value-PBP-for-cperl-set-style.patch (text/x-patch, attachment)]

Message #8 received at 43457 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Harald Jörg <haj <at> posteo.de>
Cc: 43457 <at> debbugs.gnu.org
Subject: Re: bug#43457: 28.0.50; [FEATURE][PATCH] cperl-mode: Add value
 "PBP" to cperl-set-style
Date: Thu, 17 Sep 2020 17:35:58 +0200

Harald Jörg <haj <at> posteo.de> writes:

> This is not a bug report, but a feature request.  If I understand
> correctly, both go through the same channel.

Yup.

> The attached patch adds the new value "PBP" to the style selection and
> to the documentation, and also contains a simple formatting test
> according to these rules.

Looks great!  Applied to Emacs 28.

> I also added some lines to etc/NEWS, but I'm unsure about the handling
> of "---" to indicate that the change is not relevant to the manual:
> There is no texinfo manual for CPerl mode, so maybe "---" should be
> added before the heading "CPerl Mode"?

Yup; I did so before committing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.