Subject: bug#43456: closed (Re: [bug#43456] guix bash-completion -> add --profile to "package" completion)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 21 Sep 2020 21:37:02 +0000

Your bug report

#43456: guix bash-completion -> add --profile to "package" completion

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
43456: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43456
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#43456] guix bash-completion -> add --profile to "package" completion
From: Ludovic Courtès <[email-masked]>
To: Fulbert <[email-masked]>
Cc: [email-masked]
Date: Mon, 21 Sep 2020 23:36:28 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Fulbert,

Fulbert <[email-masked]> skribis:

>   I'm using a modified guix bash-completion as the upstream does not
> complete for --profile for the "package" command.
>
>   & there probably is a good reason for this, but just in case&

No, there was no good reason.  :-)

>>>From a8eb589640d1fc1757b3d91da73eea1c3e6fe9ba Mon Sep 17 00:00:00 2001
> From: Fulbert <[email-masked]>
> Date: Wed, 16 Sep 2020 18:10:56 +0200
> Subject: [PATCH] =?UTF-8?q?=20Sur=20la=20branche=20for-patch=20=09modifi?=
>  =?UTF-8?q?=C3=A9=C2=A0:=20=20=20=20=20=20=20=20=20guix?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> ---
>  etc/completion/bash/guix | 2 +-

I tweaked the commit message to match our conventions and applied it.

Thank you!

Ludo’.

Subject: guix bash-completion -> add --profile to "package" completion
From: Fulbert <[email-masked]>
To: [email-masked]
Date: Wed, 16 Sep 2020 20:48:55 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

  Hello!

  I'm using a modified guix bash-completion as the upstream does not
complete for --profile for the "package" command.

  … there probably is a good reason for this, but just in case…

  Best regards and thanks for Guix,
  Fulbert
>From a8eb589640d1fc1757b3d91da73eea1c3e6fe9ba Mon Sep 17 00:00:00 2001
From: Fulbert <[email-masked]>
Date: Wed, 16 Sep 2020 18:10:56 +0200
Subject: [PATCH] =?UTF-8?q?=20Sur=20la=20branche=20for-patch=20=09modifi?=
 =?UTF-8?q?=C3=A9=C2=A0:=20=20=20=20=20=20=20=20=20guix?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 etc/completion/bash/guix | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/completion/bash/guix b/etc/completion/bash/guix
index 98d20484f7..aa217bd318 100644
--- a/etc/completion/bash/guix
+++ b/etc/completion/bash/guix
@@ -181,7 +181,7 @@ _guix_complete ()
 	*)
 	    if _guix_is_command "package"
 	    then
-		if _guix_is_dash_L || _guix_is_dash_m
+		if _guix_is_dash_L || _guix_is_dash_m || _guix_is_dash_p
 		then
 		    _guix_complete_file
 		elif _guix_is_removing
-- 
2.20.1