GNU bug report logs - #43441
27.1; [PATCH] Fix incorrectly base64-padded faces in gnus-convert-face-to-png

Previous Next

Full log

View this message in rfc822 format

From: Alex Bochannek <alex <at> bochannek.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43441 <at> debbugs.gnu.org
Subject: bug#43441: 27.1; [PATCH] Fix incorrectly base64-padded faces in gnus-convert-face-to-png
Date: Mon, 28 Sep 2020 08:58:36 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Alex Bochannek <alex <at> bochannek.com> writes:
>
>> Took me a little while, but I broke this out into a utility function as
>> you suggested. I also wrote some tests for it. As part of me getting
>> familiar with ERT, I added a bunch of tests for gnus-string< and
>> gnus-string>, which I hope are useful. They should probably be in a
>> separate commit, but I leave that up to you.
>
> Thanks; looks good to me.  I did some minor touch-ups before committing
> -- the first line in the comment string should be a complete sentence,
> and ";;" instead of ";;;", and when is preferred over else-less ifs and
> pushed to Emacs 28.

Great, thanks!

-- 
Alex.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.