From unknown Sun Jun 15 08:45:50 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4344: Highlight escape character sequences in isearch and query-replace Reply-To: Juri Linkov , 4344@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 04 Sep 2009 21:25:10 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4344 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12520991857133 (code B ref -1); Fri, 04 Sep 2009 21:25:10 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 4 Sep 2009 21:19:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n84LJhEq007127 for ; Fri, 4 Sep 2009 14:19:44 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjgC7-0005J4-Bd for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjgC2-0005Eo-Qh for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:42 -0400 Received: from [199.232.76.173] (port=46363 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjgC2-0005El-LG for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:38 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3]:42127 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjgC2-000194-9d for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:38 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.70.181.cable.starman.ee [82.131.70.181]) by mx1.starman.ee (Postfix) with ESMTP id DB8E43F447F for ; Sat, 5 Sep 2009 00:19:31 +0300 (EEST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Organization: JURTA Date: Sat, 05 Sep 2009 00:14:38 +0300 Message-ID: <87ws4el8e9.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Normally characters sequences using `^' are displayed in the `escape-glyph' face. However, in isearch and query-replace that both use `isearch-text-char-description' it is hard to distinguish escape character sequences visually because they are not highlighted. Here is a fix: Index: lisp/isearch.el =================================================================== RCS file: /sources/emacs/emacs/lisp/isearch.el,v retrieving revision 1.346 diff -u -r1.346 isearch.el --- lisp/isearch.el 1 Sep 2009 07:24:19 -0000 1.346 +++ lisp/isearch.el 4 Sep 2009 21:12:37 -0000 @@ -2496,8 +2501,8 @@ (defun isearch-text-char-description (c) (cond - ((< c ?\s) (format "^%c" (+ c 64))) - ((= c ?\^?) "^?") + ((< c ?\s) (propertize (format "^%c" (+ c 64)) 'face 'escape-glyph)) + ((= c ?\^?) (propertize "^?" 'face 'escape-glyph)) (t (char-to-string c)))) ;; General function to unread characters or events. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Sun Jun 15 08:45:50 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4344: Highlight escape character sequences in isearch and query-replace Reply-To: Stefan Monnier , 4344@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 08 Sep 2009 19:55:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4344 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125243935524650 (code B ref -1); Tue, 08 Sep 2009 19:55:06 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 8 Sep 2009 19:49:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.2 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n88JnEhs024640 for ; Tue, 8 Sep 2009 12:49:15 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ml6gj-0001oT-FW for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2009 15:49:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ml6gf-0001nz-NG for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2009 15:49:13 -0400 Received: from [199.232.76.173] (port=49336 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ml6gf-0001nv-HV for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2009 15:49:09 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:60690) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ml6gf-00049u-3F for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2009 15:49:09 -0400 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n88JmwD6026805; Tue, 8 Sep 2009 15:48:58 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id E9F863A8F3; Tue, 8 Sep 2009 15:48:57 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: 4344@debbugs.gnu.org, bug-gnu-emacs@gnu.org Message-ID: References: <87ws4el8e9.fsf@mail.jurta.org> Date: Tue, 08 Sep 2009 15:48:57 -0400 In-Reply-To: <87ws4el8e9.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 05 Sep 2009 00:14:38 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3358=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) > Normally characters sequences using `^' are displayed in the > `escape-glyph' face. However, in isearch and query-replace that both > use `isearch-text-char-description' it is hard to distinguish > escape character sequences visually because they are not highlighted. > Here is a fix: Feel free to install it, thanks, Stefan From unknown Sun Jun 15 08:45:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Juri Linkov Subject: bug#4344 closed by Juri Linkov (Re: bug#4344: Highlight escape character sequences in isearch and query-replace) Message-ID: References: <87ocpjy5wk.fsf@mail.jurta.org> <87ws4el8e9.fsf@mail.jurta.org> X-Emacs-PR-Message: they-closed 4344 X-Emacs-PR-Package: emacs Reply-To: 4344@debbugs.gnu.org Date: Thu, 10 Sep 2009 01:05:07 +0000 Content-Type: multipart/mixed; boundary="----------=_1252544707-21613-1" This is a multi-part message in MIME format... ------------=_1252544707-21613-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4344: Highlight escape character sequences in isearch and query-replace It has been closed by Juri Linkov . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Juri Linkov by replying to this email. --=20 4344: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4344 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1252544707-21613-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4344-done) by emacsbugs.donarmstrong.com; 10 Sep 2009 00:56:20 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8A0uIFK019898 for <4344-done@emacsbugs.donarmstrong.com>; Wed, 9 Sep 2009 17:56:19 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.30.70.cable.starman.ee [82.131.30.70]) by mx1.starman.ee (Postfix) with ESMTP id 87B7A3F422B; Thu, 10 Sep 2009 03:56:11 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Cc: 4344-done@debbugs.gnu.org Subject: Re: bug#4344: Highlight escape character sequences in isearch and query-replace Organization: JURTA References: <87ws4el8e9.fsf@mail.jurta.org> Date: Thu, 10 Sep 2009 03:55:55 +0300 In-Reply-To: (Stefan Monnier's message of "Tue, 08 Sep 2009 15:48:57 -0400") Message-ID: <87ocpjy5wk.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Normally characters sequences using `^' are displayed in the >> `escape-glyph' face. However, in isearch and query-replace that both >> use `isearch-text-char-description' it is hard to distinguish >> escape character sequences visually because they are not highlighted. >> Here is a fix: > > Feel free to install it, thanks, Done. -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1252544707-21613-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 4 Sep 2009 21:19:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n84LJhEq007127 for ; Fri, 4 Sep 2009 14:19:44 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjgC7-0005J4-Bd for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjgC2-0005Eo-Qh for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:42 -0400 Received: from [199.232.76.173] (port=46363 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjgC2-0005El-LG for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:38 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3]:42127 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjgC2-000194-9d for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:38 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.70.181.cable.starman.ee [82.131.70.181]) by mx1.starman.ee (Postfix) with ESMTP id DB8E43F447F for ; Sat, 5 Sep 2009 00:19:31 +0300 (EEST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Highlight escape character sequences in isearch and query-replace Organization: JURTA Date: Sat, 05 Sep 2009 00:14:38 +0300 Message-ID: <87ws4el8e9.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Normally characters sequences using `^' are displayed in the `escape-glyph' face. However, in isearch and query-replace that both use `isearch-text-char-description' it is hard to distinguish escape character sequences visually because they are not highlighted. Here is a fix: Index: lisp/isearch.el =================================================================== RCS file: /sources/emacs/emacs/lisp/isearch.el,v retrieving revision 1.346 diff -u -r1.346 isearch.el --- lisp/isearch.el 1 Sep 2009 07:24:19 -0000 1.346 +++ lisp/isearch.el 4 Sep 2009 21:12:37 -0000 @@ -2496,8 +2501,8 @@ (defun isearch-text-char-description (c) (cond - ((< c ?\s) (format "^%c" (+ c 64))) - ((= c ?\^?) "^?") + ((< c ?\s) (propertize (format "^%c" (+ c 64)) 'face 'escape-glyph)) + ((= c ?\^?) (propertize "^?" 'face 'escape-glyph)) (t (char-to-string c)))) ;; General function to unread characters or events. -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1252544707-21613-1--