From unknown Sat Jun 14 18:56:05 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4343: comint-carriage-motion for async-shell-command Reply-To: Juri Linkov , 4343@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 04 Sep 2009 21:25:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4343 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12520991857130 (code B ref -1); Fri, 04 Sep 2009 21:25:06 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 4 Sep 2009 21:19:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.2 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n84LJh1p007126 for ; Fri, 4 Sep 2009 14:19:44 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjgC7-0005Im-1e for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjgC2-0005Eg-5j for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:42 -0400 Received: from [199.232.76.173] (port=46362 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjgC1-0005Ed-VX for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:38 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3]:42125 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjgC1-00018l-Ew for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:37 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.70.181.cable.starman.ee [82.131.70.181]) by mx1.starman.ee (Postfix) with ESMTP id 7A01A3F4478 for ; Sat, 5 Sep 2009 00:19:31 +0300 (EEST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Organization: JURTA Date: Sat, 05 Sep 2009 00:02:33 +0300 Message-ID: <878wguo23a.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Often an asynchronous shell command run with M-& produces the output that looks like garbage when programs use carriage control characters ^M to display progress with percentages. Even the `compile' command is better in this regard because its `compilation-filter' handles carriage motion using the function `comint-carriage-motion'. The following patch does the same for asynchronous commands in `shell-command'. It seems it was intended to do this anyway because `*Async Shell Command*' uses `shell-mode'. But `shell-mode' doesn't set the filter that processes carriage control characters. It is the `shell' command that sets the filter via `comint-exec' before enabling `shell-mode'. So it's necessary to set the filter explicitly in `shell-command' after enabling `shell-mode': Index: lisp/simple.el =================================================================== RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.1008 diff -u -r1.1008 simple.el --- lisp/simple.el 28 Aug 2009 04:21:17 -0000 1.1008 +++ lisp/simple.el 4 Sep 2009 21:02:21 -0000 @@ -2214,7 +2220,11 @@ (setq mode-line-process '(":%s")) (require 'shell) (shell-mode) (set-process-sentinel proc 'shell-command-sentinel) + ;; Use the comint filter for proper handling of carriage motion + ;; (see `comint-inhibit-carriage-motion'),. + (set-process-filter proc 'comint-output-filter) )) (shell-command-on-region (point) (point) command output-buffer nil error-buffer))))))) -- Juri Linkov http://www.jurta.org/emacs/ From unknown Sat Jun 14 18:56:05 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4343: comint-carriage-motion for async-shell-command Reply-To: Stefan Monnier , 4343@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 08 Sep 2009 19:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4343 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125243611015251 (code B ref -1); Tue, 08 Sep 2009 19:00:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 8 Sep 2009 18:55:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.2 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n88It80X015212 for ; Tue, 8 Sep 2009 11:55:10 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ml5qO-0007Uf-E9 for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2009 14:55:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ml5qJ-0007Og-Om for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2009 14:55:08 -0400 Received: from [199.232.76.173] (port=45306 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ml5qJ-0007OW-IY for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2009 14:55:03 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:52536) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ml5qJ-00030n-6C for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2009 14:55:03 -0400 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n88IswJH031481; Tue, 8 Sep 2009 14:54:58 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 4EDD43A8F3; Tue, 8 Sep 2009 14:54:58 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: 4343@debbugs.gnu.org, bug-gnu-emacs@gnu.org Message-ID: References: <878wguo23a.fsf@mail.jurta.org> Date: Tue, 08 Sep 2009 14:54:58 -0400 In-Reply-To: <878wguo23a.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 05 Sep 2009 00:02:33 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3358=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) > The following patch does the same for asynchronous commands in > `shell-command'. It seems it was intended to do this anyway because > `*Async Shell Command*' uses `shell-mode'. But `shell-mode' doesn't set > the filter that processes carriage control characters. It is the `shell' > command that sets the filter via `comint-exec' before enabling `shell-mode'. > So it's necessary to set the filter explicitly in `shell-command' > after enabling `shell-mode': That looks right. Could you try and check whether there's more of comint's setup code that could be copied here? And try and move this into a new function `comint-setup-process' which both compile.el and M-& could then use? Stefan From unknown Sat Jun 14 18:56:05 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4343: comint-carriage-motion for async-shell-command Reply-To: Juri Linkov , 4343@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 09 Sep 2009 03:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4343 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4343-submit@emacsbugs.donarmstrong.com id=B4343.125246606016770 (code B ref 4343); Wed, 09 Sep 2009 03:20:03 +0000 Received: (at 4343) by emacsbugs.donarmstrong.com; 9 Sep 2009 03:14:20 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n893EIHZ016757 for <4343@emacsbugs.donarmstrong.com>; Tue, 8 Sep 2009 20:14:19 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.28.177.cable.starman.ee [82.131.28.177]) by mx2.starman.ee (Postfix) with ESMTP id 82C6C3F4297; Wed, 9 Sep 2009 06:14:12 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Cc: 4343@debbugs.gnu.org Organization: JURTA References: <878wguo23a.fsf@mail.jurta.org> Date: Wed, 09 Sep 2009 03:59:29 +0300 In-Reply-To: (Stefan Monnier's message of "Tue, 08 Sep 2009 14:54:58 -0400") Message-ID: <873a6wzuoc.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> The following patch does the same for asynchronous commands in >> `shell-command'. It seems it was intended to do this anyway because >> `*Async Shell Command*' uses `shell-mode'. But `shell-mode' doesn't set >> the filter that processes carriage control characters. It is the `shell' >> command that sets the filter via `comint-exec' before enabling `shell-mode'. >> So it's necessary to set the filter explicitly in `shell-command' >> after enabling `shell-mode': > > That looks right. Could you try and check whether there's more of > comint's setup code that could be copied here? Other than setting `comint-output-filter', `comint-exec' also starts a process. But starting a process is not necessary in `shell-command' that starts it explicitly. > And try and move this into a new function `comint-setup-process' which > both compile.el and M-& could then use? They can't be merged because `compilation-filter' runs a compile-specific hook `compilation-filter-hook'. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Sat Jun 14 18:56:05 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4343: comint-carriage-motion for async-shell-command Reply-To: Stefan Monnier , 4343@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 09 Sep 2009 15:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4343 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4343-submit@emacsbugs.donarmstrong.com id=B4343.12525079449681 (code B ref 4343); Wed, 09 Sep 2009 15:00:04 +0000 Received: (at 4343) by emacsbugs.donarmstrong.com; 9 Sep 2009 14:52:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n89EqMig009542 for <4343@emacsbugs.donarmstrong.com>; Wed, 9 Sep 2009 07:52:24 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq4EACtep0pFpZBe/2dsb2JhbACBU91FhBgFh20 X-IronPort-AV: E=Sophos;i="4.44,358,1249272000"; d="scan'208";a="45452446" Received: from 69-165-144-94.dsl.teksavvy.com (HELO pastel.home) ([69.165.144.94]) by ironport2-out.teksavvy.com with ESMTP; 09 Sep 2009 10:50:48 -0400 Received: by pastel.home (Postfix, from userid 20848) id 09CF39410; Wed, 9 Sep 2009 10:52:15 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: 4343@debbugs.gnu.org Message-ID: References: <878wguo23a.fsf@mail.jurta.org> <873a6wzuoc.fsf@mail.jurta.org> Date: Wed, 09 Sep 2009 10:52:15 -0400 In-Reply-To: <873a6wzuoc.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 09 Sep 2009 03:59:29 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Other than setting `comint-output-filter', `comint-exec' also starts > a process. But starting a process is not necessary in `shell-command' > that starts it explicitly. OK, then. >> And try and move this into a new function `comint-setup-process' which >> both compile.el and M-& could then use? > They can't be merged because `compilation-filter' runs a compile-specific > hook `compilation-filter-hook'. Too bad. Please install your patch, then. Stefan From unknown Sat Jun 14 18:56:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Juri Linkov Subject: bug#4343 closed by Juri Linkov (Re: bug#4343: comint-carriage-motion for async-shell-command) Message-ID: References: <87tyzby5xi.fsf@mail.jurta.org> <878wguo23a.fsf@mail.jurta.org> X-Emacs-PR-Message: they-closed 4343 X-Emacs-PR-Package: emacs Reply-To: 4343@debbugs.gnu.org Date: Thu, 10 Sep 2009 01:05:05 +0000 Content-Type: multipart/mixed; boundary="----------=_1252544705-21175-1" This is a multi-part message in MIME format... ------------=_1252544705-21175-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4343: comint-carriage-motion for async-shell-command It has been closed by Juri Linkov . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Juri Linkov by replying to this email. --=20 4343: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4343 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1252544705-21175-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4343-done) by emacsbugs.donarmstrong.com; 10 Sep 2009 00:56:20 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8A0uIpY019897 for <4343-done@emacsbugs.donarmstrong.com>; Wed, 9 Sep 2009 17:56:19 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.30.70.cable.starman.ee [82.131.30.70]) by mx1.starman.ee (Postfix) with ESMTP id 88E263F4180; Thu, 10 Sep 2009 03:56:10 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Cc: 4343-done@debbugs.gnu.org Subject: Re: bug#4343: comint-carriage-motion for async-shell-command Organization: JURTA References: <878wguo23a.fsf@mail.jurta.org> <873a6wzuoc.fsf@mail.jurta.org> Date: Thu, 10 Sep 2009 03:55:21 +0300 In-Reply-To: (Stefan Monnier's message of "Wed, 09 Sep 2009 10:52:15 -0400") Message-ID: <87tyzby5xi.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Other than setting `comint-output-filter', `comint-exec' also starts >> a process. But starting a process is not necessary in `shell-command' >> that starts it explicitly. > > OK, then. > >>> And try and move this into a new function `comint-setup-process' which >>> both compile.el and M-& could then use? > >> They can't be merged because `compilation-filter' runs a compile-specific >> hook `compilation-filter-hook'. > > Too bad. Please install your patch, then. Done. -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1252544705-21175-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 4 Sep 2009 21:19:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.2 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n84LJh1p007126 for ; Fri, 4 Sep 2009 14:19:44 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjgC7-0005Im-1e for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjgC2-0005Eg-5j for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:42 -0400 Received: from [199.232.76.173] (port=46362 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjgC1-0005Ed-VX for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:38 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3]:42125 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjgC1-00018l-Ew for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2009 17:19:37 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.70.181.cable.starman.ee [82.131.70.181]) by mx1.starman.ee (Postfix) with ESMTP id 7A01A3F4478 for ; Sat, 5 Sep 2009 00:19:31 +0300 (EEST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: comint-carriage-motion for async-shell-command Organization: JURTA Date: Sat, 05 Sep 2009 00:02:33 +0300 Message-ID: <878wguo23a.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Often an asynchronous shell command run with M-& produces the output that looks like garbage when programs use carriage control characters ^M to display progress with percentages. Even the `compile' command is better in this regard because its `compilation-filter' handles carriage motion using the function `comint-carriage-motion'. The following patch does the same for asynchronous commands in `shell-command'. It seems it was intended to do this anyway because `*Async Shell Command*' uses `shell-mode'. But `shell-mode' doesn't set the filter that processes carriage control characters. It is the `shell' command that sets the filter via `comint-exec' before enabling `shell-mode'. So it's necessary to set the filter explicitly in `shell-command' after enabling `shell-mode': Index: lisp/simple.el =================================================================== RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.1008 diff -u -r1.1008 simple.el --- lisp/simple.el 28 Aug 2009 04:21:17 -0000 1.1008 +++ lisp/simple.el 4 Sep 2009 21:02:21 -0000 @@ -2214,7 +2220,11 @@ (setq mode-line-process '(":%s")) (require 'shell) (shell-mode) (set-process-sentinel proc 'shell-command-sentinel) + ;; Use the comint filter for proper handling of carriage motion + ;; (see `comint-inhibit-carriage-motion'),. + (set-process-filter proc 'comint-output-filter) )) (shell-command-on-region (point) (point) command output-buffer nil error-buffer))))))) -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1252544705-21175-1--