GNU bug report logs - #43412
[FEATURE] autorevert-only-if-visible [PATCH]

Previous Next

Full log

Message #23 received at 43412 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 43412 <at> debbugs.gnu.org
Subject: Re: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH]
Date: Tue, 15 Sep 2020 20:47:05 +0200

Boruch Baum <boruch_baum <at> gmx.com> writes:

Hi Boruch,

> The attached proposed patch adds a defcustom and makes a change to two
> existing functions in order to allow a user the option to only have
> autorevert mode operate on visible buffers. The change to function
> 'after-find-files' may also fix a bug (or change behavior) in that
> sometimes when being prompted to manually revert a buffer that had been
> in auto-revert-mode, the auto-revert-mode status would be lost, ie. set
> to nil.

I haven't tested your patch, but I'm asking myself whether it cooperates
with autorevert triggered by file notifications. That is, if a file
changes on disk, a notification event is sent, and autovert happens. If
autorevert does not happen because the buffer is not visible, this event
will be lost, and no autorevert will happen later on when the buffer
becomes visible.

Have you tested this scenario?

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.