GNU bug report logs - #43401
28.0.50; [PATCH] Emacs Lisp type error when the buffer passed to diff-buffer-with-file is not visiting a file

Previous Next

Package: emacs;

Reported by: Daniel Martín <mardani29 <at> yahoo.es>

Date: Mon, 14 Sep 2020 16:13:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43401 in the body.
You can then email your comments to 43401 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#43401; Package emacs. (Mon, 14 Sep 2020 16:13:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Daniel Martín <mardani29 <at> yahoo.es>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 14 Sep 2020 16:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Emacs Lisp type error when the buffer passed to
 diff-buffer-with-file is not visiting a file
Date: Mon, 14 Sep 2020 18:12:11 +0200

[Message part 1 (text/plain, inline)]
Steps to reproduce the problem:

emacs -Q
C-x b "Sample" RET (that is, create an empty buffer)
M-x diff-buffer-with-file RET
RET (confirm the default buffer)

Actual result:

Emacs shows "Wrong type argument: stringp, nil"

Expected result:

Emacs shows a more descriptive error that explains why the command
couldn't be executed.

I've attached a patch that implements the expected result.

Thank you very much.


[0001-Check-that-the-buffer-in-diff-buffer-with-file-is-vi.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#43401; Package emacs. (Tue, 15 Sep 2020 12:57:01 GMT) Full text and rfc822 format available.

Message #8 received at 43401 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: 43401 <at> debbugs.gnu.org
Subject: Re: bug#43401: 28.0.50; [PATCH] Emacs Lisp type error when the
 buffer passed to diff-buffer-with-file is not visiting a file
Date: Tue, 15 Sep 2020 14:56:29 +0200

Daniel Martín <mardani29 <at> yahoo.es> writes:

> Emacs shows a more descriptive error that explains why the command
> couldn't be executed.
>
> I've attached a patch that implements the expected result.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 15 Sep 2020 12:57:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 43401 <at> debbugs.gnu.org and Daniel Martín <mardani29 <at> yahoo.es> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 15 Sep 2020 12:57:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 14 Oct 2020 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 249 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.