From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 14 10:30:37 2020 Received: (at submit) by debbugs.gnu.org; 14 Sep 2020 14:30:37 +0000 Received: from localhost ([127.0.0.1]:55703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpV6-0007hy-Qp for submit@debbugs.gnu.org; Mon, 14 Sep 2020 10:30:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:34084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpV3-0007hp-Ja for submit@debbugs.gnu.org; Mon, 14 Sep 2020 10:30:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHpV3-00080F-DD for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 10:30:33 -0400 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]:44586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHpV0-0002bN-Mu for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 10:30:33 -0400 Received: by mail-qk1-x741.google.com with SMTP id n133so216178qkn.11 for ; Mon, 14 Sep 2020 07:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=n0r57nXeeIaMMD5L8BM5mIcXHj60ajVvTpuSccxtNwQ=; b=UTl53y+Pv1nB3HCKnf/jQmVB1sYSJcJL8M3PymTM1l8wJE8yJwMiWFoR+NEI60VrEQ nE0PDUPNsTzJ3jHU/v2NyYfoTTst0V+X6qr/lJb65Pptbablu2fK0aXrjtUTQVV1dO3B s7S/fAna2ZxeMWJIZbztA9vtDzKP/CbQAf7eOCDUGiusQihig0utUqFue+5WPNsQKDs+ 8dP0Yt31OoaGf+Z0gqGm3PWVD1X/4ws8cmfkxTLfmCqXgzSOuPOTkoTUuxwlG85O4QuC f3BToCSq2eoALHm8PFo3hSNAlxVOMB/oMNmTnZ+AVjnU5LEJSqFmXuBG16cUt80irMql YHhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=n0r57nXeeIaMMD5L8BM5mIcXHj60ajVvTpuSccxtNwQ=; b=F1QDrT7haUGCUzZTW761Kb7xslYBav0v14WslxMq0ipx0ci7CJMxXbbU2TjUJMeM0i BjIvFmpmSnkrDvMaSvciCbZOHnQ9xe9FniGzF4+m1NfdJCa04rfl3ylxIYQqMcAwMBx6 u3n21qqPuS+OXbx9zXczyO0mTY3wrZ7TwTHNWzbYnypoOZuwNlNZJU/IeWpMbpG62n99 i39ZZwFrCnjFLy9qyOc4RHy1hwS8SUQGkEx9KD37Xu3Hk21eo9KEThSt+Z55+bwFhXFA 9PVhIQI2rt4TzPh+jmw9gmagm+nKWR1aZtYCaNUDnBwVGlt8VAIRWxBzmEQH0yVB14Se 7rHA== X-Gm-Message-State: AOAM533pqhpBvuDAJ0q8drUicvqo52FF4P/FKlpycLlwey1oOMZ6odk7 HW1uo+JFF4v3p6bRL5TDzSAkepN4Kng= X-Google-Smtp-Source: ABdhPJzb/oy8id7OkfciLWZjY++pdkXAzGxCkzma4nLbXsbLh31+V87UGV/DgmlAU+fCzWLVoISEiw== X-Received: by 2002:a37:6848:: with SMTP id d69mr12351724qkc.80.1600093828697; Mon, 14 Sep 2020 07:30:28 -0700 (PDT) Received: from localhost.localdomain ([181.223.151.236]) by smtp.gmail.com with ESMTPSA id t1sm14594889qtj.12.2020.09.14.07.30.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 07:30:28 -0700 (PDT) From: Caio Henrique X-Google-Original-From: Caio Henrique To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Adding tool bar items: update tool bar Date: Mon, 14 Sep 2020 11:30:22 -0300 Message-ID: <87h7s0jurl.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::741; envelope-from=caiohcs0@gmail.com; helo=mail-qk1-x741.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi all, I don't know if this is a bug or the expected behavior of the function tool-bar-add-item-from-menu: 1. emacs -Q 2. paste and eval this: (progn (tool-bar-add-item-from-menu 'undo-redo "redo" nil :vert-only t) (redraw-display) (force-mode-line-update)) I'm using both redraw-display and force-mode-line-update to try to force the tool-bar to draw the icon (I know that I should'nt do this, I'm just trying to figure if this is a bug); but the icon only appears when I click one or two times with the mouse anywhere in the buffer. If there is a bug, this is possibly related to it: https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg00603.html https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg00726.html https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg00780.html And also this: https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg01089.html https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg01101.html > Eli: Here, the above displays nothing at all on the tool bar. (If I click with the mouse anywhere in the buffer, that icon also gets displayed for me) Thanks! ____ In GNU Emacs 28.0.50 (build 19, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, cairo version 1.16.0) Configured features: XPM JPEG TIFF GIF PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 14 17:44:21 2020 Received: (at 43397) by debbugs.gnu.org; 14 Sep 2020 21:44:21 +0000 Received: from localhost ([127.0.0.1]:56554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHwGr-0002WT-85 for submit@debbugs.gnu.org; Mon, 14 Sep 2020 17:44:21 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:39058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHwGo-0002W3-94 for 43397@debbugs.gnu.org; Mon, 14 Sep 2020 17:44:19 -0400 Received: by mail-qt1-f196.google.com with SMTP id h6so1462583qtd.6 for <43397@debbugs.gnu.org>; Mon, 14 Sep 2020 14:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cwDiKj3Ugv2cGFuTGHYX+3NXQW/wn9Ngi1S0djmjEE0=; b=GkTiWkqS/OT+i7abZbVa1uTQCOVxaR8WfM7Rg7hZFNFF9QDglC8Qe/ubF4rHfzTQsz 8IYCF6L8T0+qrPfrYIhsMiHVB8iQBi9DXV0djU1+WbgYA3AFU8pgesz9pC+9cwJ3zuhp SrUAIRNA9VBeRcFFyCaDhuWF/r4VQS2rSNJBUwUiJihHjL2QnColuTBeGP9BfzYxshzv GPssf1EWb1mqawEB+qNIuid30WWNABNB4JRUgaoSyj1urdCowgEHnoPScEI1yDc6SSO3 V7BCilP1XPAKhTytzo9LpmxL1OSU3a5YmzzPN42zV6Stf8DlP02ET1tUqDs8lwaKeOMP ehIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cwDiKj3Ugv2cGFuTGHYX+3NXQW/wn9Ngi1S0djmjEE0=; b=srMGAO2FIGV/KqqCQnKjRZp4kTOTA6MdXeA6Zm4JAhlVqGCGCSgroT45yr/jKPfkwT nUpg/9YtcV5C4mZ2YMnRiLrWAkjPO4JurX8jMvZ1EMuIN5worouxtZpWyz+NVZK7DAX3 HMy1Wim1ubZhMAw7KBHYIaooEXo2+pf253SXK7ZVV0MtpMWnrCsp/vbhaayZB4VIHrw4 d6s2UR8QDaFqND9FtElu1GfnjtYJalKhdWwwxQn98zCiesDR8whaZxUShVn6kimRCUNW cur9xraUAxOqTibXb6ugIcJCJ8xWiu05XPilFnHY6GLgPcJKT9HrsIjjiFd4+ktjIQXJ qrzg== X-Gm-Message-State: AOAM533YU7EJk8Xw304P+9qHSYJC/Hsr7oW9W4hdtwUuR6ZKUDbag496 gHHq+YQNU1tRhf8nGMb6AHhF+zoInF4= X-Google-Smtp-Source: ABdhPJwtVkB/jBqLnk2lsHprsiBVdYBENeSX99dS12MgSLTauaI9n1UWdZp6pGONgKZ9rxWE2S5c9Q== X-Received: by 2002:ac8:4f4e:: with SMTP id i14mr14262981qtw.213.1600119852524; Mon, 14 Sep 2020 14:44:12 -0700 (PDT) Received: from localhost.localdomain ([181.223.151.236]) by smtp.gmail.com with ESMTPSA id z3sm14602590qkf.92.2020.09.14.14.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 14:44:12 -0700 (PDT) From: Caio Henrique To: Caio Henrique Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> Date: Mon, 14 Sep 2020 18:44:03 -0300 In-Reply-To: <87h7s0jurl.fsf@gmail.com> (Caio Henrique's message of "Mon, 14 Sep 2020 11:30:22 -0300") Message-ID: <877dswm3to.fsf@localhost.localdomain.i-did-not-set--mail-host-address--so-tickle-me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Gnus has a function called gnus-tool-bar-update. I tried using it but got the same result, i.e. the icon is only displayed when I click with the mouse on the buffer. 1. emacs -Q 2. eval this: (progn (defvar tool-bar-mode) (defun gnus-tool-bar-update (&rest ignore) "Update the tool bar." (when (and (boundp 'tool-bar-mode) tool-bar-mode) (let* ((args nil) (func (cond ((fboundp 'tool-bar-update) 'tool-bar-update) ((fboundp 'force-window-update) 'force-window-update) ((fboundp 'redraw-frame) (setq args (list (selected-frame))) 'redraw-frame) (t 'ignore)))) (apply func args)))) (tool-bar-add-item-from-menu 'undo-redo "redo" nil :vert-only t) (gnus-tool-bar-update)) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 11:27:19 2020 Received: (at 43397) by debbugs.gnu.org; 15 Sep 2020 15:27:19 +0000 Received: from localhost ([127.0.0.1]:60227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kICrX-0001Cb-Jy for submit@debbugs.gnu.org; Tue, 15 Sep 2020 11:27:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kICrW-0001CP-BS for 43397@debbugs.gnu.org; Tue, 15 Sep 2020 11:27:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47315) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kICrQ-0002sd-Pr; Tue, 15 Sep 2020 11:27:12 -0400 Received: from [176.228.60.248] (port=4733 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kICrP-0002Xn-P7; Tue, 15 Sep 2020 11:27:12 -0400 Date: Tue, 15 Sep 2020 18:27:17 +0300 Message-Id: <83lfhb83hm.fsf@gnu.org> From: Eli Zaretskii To: Caio Henrique , Stefan Monnier In-Reply-To: <87h7s0jurl.fsf@gmail.com> (message from Caio Henrique on Mon, 14 Sep 2020 11:30:22 -0300) Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Caio Henrique > Date: Mon, 14 Sep 2020 11:30:22 -0300 > > 1. emacs -Q > 2. paste and eval this: > (progn > (tool-bar-add-item-from-menu 'undo-redo > "redo" nil :vert-only t) > (redraw-display) > (force-mode-line-update)) > > I'm using both redraw-display and force-mode-line-update to try to force > the tool-bar to draw the icon (I know that I should'nt do this, I'm just > trying to figure if this is a bug) (Calling force-mode-line-update won't help, because tool-bar-add-item-from-menu does it internally.) > but the icon only appears when I > click one or two times with the mouse anywhere in the buffer. I've now looked into this, and I'm quite sure it is not a redisplay bug. The display engine faithfully inspects the tool-bar items each time it is invoked after the above code runs, and each time it finds that the tool-bar items haven't changed -- until they do. Based on what I see, and on the modified recipe below, it looks like we stick to the old value of the tool-bar items, like if we cached them somewhere. Since I don't understand where is that "cache", I don't really have a clear idea of what triggers the flushing of that "cache", but one trigger I found is -- surprise! -- GC. To see this, perform the following greatly simplified recipe: emacs -Q M-x blink-cursor-mode RET M-x global-eldoc-mode RET (The last two commands are to make sure there are no redisplay cycles except due to changes in buffers or strings.) Then evaluate: (defun myfun () (interactive) (tool-bar-add-item "redo" 'undo-redo 'undo-redo) (garbage-collect)) (global-set-key [f5] 'myfun) Finally, press F5: you should see the "redo" icon appear immediately. Now repeat the same, in a fresh Emacs session, but this time remove the call to garbage-collect from myfun, and instead do this before evaluating the function and the global-set-key form: M-x set-variable RET garbage-collection-messages RET t RET Then evaluate the forms and press F5. The tool bar won't change. Now do some random clicks, watching the echo area: you will see that the tool bar is updated with the "redo" icon precisely when the "Garbage collecting..." message appears in the echo area. Maybe Stefan (CC'ed) can help us understand why this happens and how GC is involved in this... From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 16:06:05 2020 Received: (at 43397) by debbugs.gnu.org; 15 Sep 2020 20:06:05 +0000 Received: from localhost ([127.0.0.1]:60635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHDJ-0001ym-Ej for submit@debbugs.gnu.org; Tue, 15 Sep 2020 16:06:05 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHDG-0001y8-3q for 43397@debbugs.gnu.org; Tue, 15 Sep 2020 16:06:04 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6022F80A93; Tue, 15 Sep 2020 16:05:56 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E963680B6D; Tue, 15 Sep 2020 16:05:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600200354; bh=0mH1oMiubu+GU5Zpx1ry8s17xpM0BJ1xXRHseJKgF6A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MwlVmdlpdWryVytVTYA6wLpSVzcHfr6KMDkNMvCn/Q4Wq2MzG8Co81+VwfdhwSqVo BoVZWRnGq72xjqSIPneBxEuCuJEAZ8JIcmwpCcyZAO1lginFGbI8PExJeQklJbPbB+ f21WeaP8koAZbHf7YaRMkqLSxQ0M6qzHk5bJGTsFiJxTcINv448TXmVU2q1j/y+d/6 e3YBj6DNPEOWBbplFPet5cYoG4r6/KEkhOnv4K773s+tof1nfbcbFB/9j6FKzpYkQo xWKDUBB9g8jxnV6cQ1u5n1allTHl+qadx8Fir89UAs2ySU5kf1lQdR5P/pFQT9V7nc IcXQlUvGtNGgw== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8F58D120285; Tue, 15 Sep 2020 16:05:54 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar Message-ID: References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> Date: Tue, 15 Sep 2020 16:05:53 -0400 In-Reply-To: <83lfhb83hm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Sep 2020 18:27:17 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Maybe Stefan (CC'ed) can help us understand why this happens and how > GC is involved in this... I'm afraid I don't know much more than you do here. `compact_font_caches` maybe? Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 22:26:31 2020 Received: (at 43397) by debbugs.gnu.org; 16 Sep 2020 02:26:31 +0000 Received: from localhost ([127.0.0.1]:32814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIN9S-0004lj-P2 for submit@debbugs.gnu.org; Tue, 15 Sep 2020 22:26:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIN9R-0004lV-0O for 43397@debbugs.gnu.org; Tue, 15 Sep 2020 22:26:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59063) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIN9L-0005gS-L8; Tue, 15 Sep 2020 22:26:23 -0400 Received: from [176.228.60.248] (port=1332 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kIN9L-0007zf-1t; Tue, 15 Sep 2020 22:26:23 -0400 Date: Wed, 16 Sep 2020 05:26:30 +0300 Message-Id: <835z8e8njd.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Tue, 15 Sep 2020 16:05:53 -0400) Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, caiohcs0@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Caio Henrique , 43397@debbugs.gnu.org > Date: Tue, 15 Sep 2020 16:05:53 -0400 > > > Maybe Stefan (CC'ed) can help us understand why this happens and how > > GC is involved in this... > > I'm afraid I don't know much more than you do here. We are basically talking about modifying a keymap, since this is what tool-bar-add-item and friends do. The question is: why isn't the modified keymap immediately visible? why does the old keymap continue to be visible until the next GC? > `compact_font_caches` maybe? I will look there, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 27 13:40:36 2021 Received: (at 43397) by debbugs.gnu.org; 27 Aug 2021 17:40:36 +0000 Received: from localhost ([127.0.0.1]:52920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfqC-0006pL-5M for submit@debbugs.gnu.org; Fri, 27 Aug 2021 13:40:36 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfq6-0006oz-9V for 43397@debbugs.gnu.org; Fri, 27 Aug 2021 13:40:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+l83P/UHRwA8RXgEJM0PvxnG+A/ZrRhMVZyi7GtGfQk=; b=O+z8pn4/nWnlM6M03pfhQeSrYz C3rghNzfUAHcGo499hklKNM5NVo72xTTS+XS8XzdlSMDbHPQMpjlK7WGl9VziedU3iuFTPz1rm+nc +Qet0sB/qkjGdp0lCu5R4iC6KGxLPEJv+y+U2frKu7f34WFb8nOLPSCP5TxK1SZAgo80=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJfpu-00066N-9n; Fri, 27 Aug 2021 19:40:18 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> Date: Fri, 27 Aug 2021 19:40:13 +0200 In-Reply-To: <83lfhb83hm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Sep 2020 18:27:17 +0300") Message-ID: <874kban5vm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Then evaluate the forms and press F5. The tool bar won't change. This was a year ago, but I can still reproduce this on the current trunk. Here's an even easier variation of the recipe: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Caio Henrique , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > Then evaluate the forms and press F5. The tool bar won't change. This was a year ago, but I can still reproduce this on the current trunk. Here's an even easier variation of the recipe: (progn (blink-cursor-mode -1) (global-eldoc-mode -1) (defun myfun () (interactive) (tool-bar-add-item "redo" 'undo-redo 'undo-redo)) (global-set-key [f5] 'myfun)) And then M-: (garbage-collect) makes the tool bar update. However! The garbage-collect in itself isn't sufficient to trigger it. With this variation: (progn (blink-cursor-mode -1) (global-eldoc-mode -1) (tool-bar-add-item "redo" 'undo-redo 'undo-redo) (global-set-key [f5] (lambda () (interactive) (garbage-collect)))) pressing does not make the icon appear. > Now do some random clicks, watching the echo area: you will see that > the tool bar is updated with the "redo" icon precisely when the > "Garbage collecting..." message appears in the echo area. Very mysterious. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 27 18:04:51 2021 Received: (at 43397) by debbugs.gnu.org; 27 Aug 2021 22:04:51 +0000 Received: from localhost ([127.0.0.1]:53124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJjxv-0002s5-NM for submit@debbugs.gnu.org; Fri, 27 Aug 2021 18:04:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJjxp-0002rn-Ut for 43397@debbugs.gnu.org; Fri, 27 Aug 2021 18:04:46 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0A41F100216; Fri, 27 Aug 2021 18:04:36 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 29FBE1001EE; Fri, 27 Aug 2021 18:04:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1630101874; bh=WJ7OZEnFITJj7CdVmLPFCuTszBpMwiseOtxC9HJS/qk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MSD+wPhMZz80XVM3rgAgwKyv8qKJYz98q0vlVuRi3xrjk/lB53FWIHYhxjyBpOgoW x8/B6+k4zydiAT+wwYGZAYgK937NL5y5U8+GglcwdiMBqM8lZnCmrA/iBGrVFZrgoB o1kNLomgLa77RPkAqq1/jDQjBNOZFpwuI5gwmhWva7gWj1MbfJ8CZFI9y7gYIwRZIO d5j8Yhi5v7uq4zpX6K3obC2T7l5BXDsoT7ElEifE51ysXehZjX6OQWkBXNxNcwn6V7 FT3KumVJPnqRmOMVdiknaWxwEltrsiK1sBWRNs8nGcSIWO62SQzlJ46i46z5lMolsT wiUj/7hIu3law== Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E14FF12023D; Fri, 27 Aug 2021 18:04:33 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar Message-ID: References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> Date: Fri, 27 Aug 2021 18:04:33 -0400 In-Reply-To: <874kban5vm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 27 Aug 2021 19:40:13 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.063 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-08-27 19:40:13] wrote: > Eli Zaretskii writes: >> Then evaluate the forms and press F5. The tool bar won't change. > > This was a year ago, but I can still reproduce this on the current > trunk. Here's an even easier variation of the recipe: > > (progn > (blink-cursor-mode -1) > (global-eldoc-mode -1) > > (defun myfun () > (interactive) > (tool-bar-add-item "redo" 'undo-redo 'undo-redo)) > > (global-set-key [f5] 'myfun)) > > And then M-: (garbage-collect) makes the tool bar update. > However! The garbage-collect in itself isn't sufficient to trigger it. Of course, it's the use of the minibuffer (as part of `M-:`) which triggered it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 28 11:31:12 2021 Received: (at 43397) by debbugs.gnu.org; 28 Aug 2021 15:31:12 +0000 Received: from localhost ([127.0.0.1]:54839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK0IV-0006FY-VN for submit@debbugs.gnu.org; Sat, 28 Aug 2021 11:31:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK0IR-0006Eu-7h for 43397@debbugs.gnu.org; Sat, 28 Aug 2021 11:31:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1hQnMgSJVbpoUil+hgq1zVBdmiik+AlKYb5Eb53GTlg=; b=VeDaHUUWvcB8GiaDqdZKGMPO5y RxegU7KnBDOFki//ApxbO7Ewk7PkFTGcTqrZk+3DOZBaCWj9a95cWdI7gMJKftlvp1+XsCajH6r9y SprKIKGRRBRGQ4bK/Khp68chhqZ+OksnJt/JT4WSWxTAei3evLJ7sbDpMqPMjzrem2D8=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mK0IF-0004vo-Ab; Sat, 28 Aug 2021 17:30:55 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> Date: Sat, 28 Aug 2021 17:30:49 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 27 Aug 2021 18:04:33 -0400") Message-ID: <87tuj9io2e.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > Of course, it's the use of the minibuffer (as part of `M-:`) which > triggered it. No, I'm able to trigger the appearance of the icon by just `C-x C-e'-ing after: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > Of course, it's the use of the minibuffer (as part of `M-:`) which > triggered it. No, I'm able to trigger the appearance of the icon by just `C-x C-e'-ing after: (garbage-collect) `C-x C-e' after (progn (garbage-collect) nil) does not trigger it. This triggers it: (progn (garbage-collect) (message "Foo\nfoo\nbar") nil) This does not: (progn (message "Foo\nfoo\nbar") nil) So: We have to have a garbage-collect, and then we have to have something that changes the size of the minibuffer area (which probably triggers a more complete repaint)... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 11:28:23 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 15:28:23 +0000 Received: from localhost ([127.0.0.1]:40695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nluRq-0007cj-Qk for submit@debbugs.gnu.org; Tue, 03 May 2022 11:28:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nluRo-0007cL-V5 for 43397@debbugs.gnu.org; Tue, 03 May 2022 11:28:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gxDzaJhLINAv5OsJJFcj8B4hZm2W6EoI8PqFwSRMpVo=; b=DSE+BxJTH1/GGsL6ok0OG3ivB4 4QzYe6IMaywk0vd7+Y2On7T+0J1AZj68XzV1zMstPhpbWYwxnEwqTS/ReRHcLpKp1aMA7UhBVUqBs dC7AiD/Ua3ZnX9sY2ukGLE1OYa4htgqcQmbav96Mu/n53SThtolgmTwvR/GQMaGPXh3I=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nluRd-0007gf-QS; Tue, 03 May 2022 17:28:12 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> X-Now-Playing: New Musik's _Warp_: "Kingdom Of Horses" Date: Tue, 03 May 2022 17:28:09 +0200 In-Reply-To: <87tuj9io2e.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 28 Aug 2021 17:30:49 +0200") Message-ID: <87sfpqws8m.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > This triggers it: > > (progn > (garbage-collect) > (message "Foo\nfoo\nbar") > nil) > > This does not: > > (progn > (message "Foo\nfoo\nbar") > nil) > > So: We have to have a garbage-collect, and th [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > This triggers it: > > (progn > (garbage-collect) > (message "Foo\nfoo\nbar") > nil) > > This does not: > > (progn > (message "Foo\nfoo\nbar") > nil) > > So: We have to have a garbage-collect, and then we have to have > something that changes the size of the minibuffer area (which probably > triggers a more complete repaint)... This is still the case in Emacs 29, and I still don't understand why. Calling flush_frame doesn't help either, or calling fset_redisplay (f); redisplay_internal (); etc. So something in tool bar seems to be hanging on to the old shapes until... something... triggers a special kind of redraw. Anybody got any ideas? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 11:42:08 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 15:42:08 +0000 Received: from localhost ([127.0.0.1]:40713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlufA-000813-Cy for submit@debbugs.gnu.org; Tue, 03 May 2022 11:42:08 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nluf8-00080Y-Q6 for 43397@debbugs.gnu.org; Tue, 03 May 2022 11:42:07 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5BBF280683; Tue, 3 May 2022 11:42:01 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0F7BD804E6; Tue, 3 May 2022 11:42:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651592520; bh=W1U5XAIE3A1KEHJO19BGHT+xJiTwH7JrPzoeEEq9HXQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MPsNt94d0c9wvG/0e/33eXubEhm/5Qmwlf/9vktq1mmGD/bFHJRYehG4HNVM4Yta0 gn4X4yDPT6BU7s7X82sRXmJM4RANhvF94JGw6qk0Pf1I5Z+Ehl2hxC44i6dwIYzhu5 PUykExSnCWBMp+5c7tKy0hc74xzijEPSdkk8TyMPM09IgxAOfJNpxYpoEsGTsVatxD xf9/F2jaW2S42bj1V7/AO4s5ljTomEwYPDg3cIy/VLZ+N7k9l8xlYretwVnrYbcci1 pDDRIrFzkXzeS4ET1wJGFCboxQltgE1eHIW5Kj8UVkzoRbPKsbtKP+ywtXmjGrQISm 7Npe7KcBVOvHw== Received: from alfajor (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C6727120328; Tue, 3 May 2022 11:41:59 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar Message-ID: References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> Date: Tue, 03 May 2022 11:41:58 -0400 In-Reply-To: <87sfpqws8m.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 03 May 2022 17:28:09 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> This triggers it: >> >> (progn >> (garbage-collect) >> (message "Foo\nfoo\nbar") >> nil) >> >> This does not: >> >> (progn >> (message "Foo\nfoo\nbar") >> nil) My crystal ball suggests there's a weak hash-table in here somewhere. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:09:59 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:09:59 +0000 Received: from localhost ([127.0.0.1]:40747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlv5s-0000Pt-5i for submit@debbugs.gnu.org; Tue, 03 May 2022 12:09:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlv5q-0000PZ-EW for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:09:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EnZ4L8GMUdbp7giD2sGswX3Po/+7x6sXcTI2iHzS6XI=; b=fqsViX9Iso12Q51RZeFblNti+q by86HYrQIyRfUiPgmdDwT/pGQGg5Jo/nQgnFtD7JrJ8SzLtM4dcsyDdqNuENZx8C7ySvp+bDVomFe upCIftZYNju/26im/iOfa66Fni1cDban61X8+yz3sxMUMrrmNRfzEab8huy9CyQJaLYc=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlv5f-00082b-5h; Tue, 03 May 2022 18:09:33 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> X-Now-Playing: Grace Jones's _Living My Life_: "Everybody Hold Still" Date: Tue, 03 May 2022 18:09:30 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 03 May 2022 11:41:58 -0400") Message-ID: <87y1zivbr9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > My crystal ball suggests there's a weak hash-table in here somewhere. That's a really good crystal ball: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > My crystal ball suggests there's a weak hash-table in here somewhere. That's a really good crystal ball: (defconst tool-bar-keymap-cache (make-hash-table :weakness t :test 'equal)) If I remove the :weakness t there, then the toolbar is never updated. So it's a caching problem, one of the two difficult problems in programming. Hm... poking around in that code, I don't quite follow how this is all supposed to be hooked up, or which caches should be flushed. Does the crystal ball have more insights? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:20:10 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:20:10 +0000 Received: from localhost ([127.0.0.1]:40769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvFy-0002tP-Hc for submit@debbugs.gnu.org; Tue, 03 May 2022 12:20:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvFw-0002t4-3I for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:20:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OHBva/2ggzJyg88hjdUiHHeOM9MuY62JtWo5R4MN1yU=; b=iP6zDIm9wHbAAevZFet0XWRT5T lESO18BrjFAlgmFszYomZMS3pdFluvmh0GaJIZBrqn1ZHmVabHLa9rM6lpkhYjZYYomVG/PKrDwhf pqBOdLFDoWmvhKFqkyW4BScVYCEReCd1aNLn+COyq3NzkGfkElXxM+b1sJj4EklxacnE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlvFl-00088Y-Rc; Tue, 03 May 2022 18:20:00 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEXr5NX9/fGypZ+S g31wS0SNWVBTMCwwHx////+KWAfPAAAAAWJLR0QIht6VegAAAAd0SU1FB+YFAxATEy/r0Z0AAAGN SURBVDjLddPNboMwDADgsEndlVD6AGUHzmjVOFcK6bkq7LxJ1LmuPyOvPzsEsCvV6qHkI9hJHKWU 1in+kkTjvzlSNT1lRVEopbYzJJq/t/yVoJ+AennfTc9zQlV8tOC933LAF62nAHAVhzqMDjTB/3DI /RK/S/JUpQyuEyhctC6HmML7vwUw1gMOYjjMJMpNAXpjjKX0iQQaH6HiK8/AjIDf2gvACU07wjeH Nc7o2jbAlcMGTNN1JpR145AH2PF6R1gRnLIAsawIPc1QlGNwewYllesqAhBQ+wEPpAmfAg4rHHV3 f7cER77AAc4G8xC4rQDb4BK7FpOLcrMeGhw/fT1uCQJN6KgljhzwPHAXu5bgIhru01p77oxbuiFC 3lusi4qSu4sn5TB9aKy77F1LZxvAS6ixLjtCIuBtoPYJUAnIoZ9gLyDDDYxwEZBStwNr6/lGHUKH Ug/fJJQhBcwLmWGz3B0JWr2O9yAuhN3a1APrH36dD9Qj00I41PG2XR5BxRhz6CfBZiT09jz+D81l 2y3pw6/UAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTAzVDE2OjE5OjE5KzAwOjAwbM0Z1gAA ACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0wM1QxNjoxOToxOSswMDowMB2QoWoAAAAASUVORK5C YII= X-Now-Playing: Grace Jones's _Living My Life_: "Unlimited Capacity For Love" Date: Tue, 03 May 2022 18:19:57 +0200 In-Reply-To: <87y1zivbr9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 03 May 2022 18:09:30 +0200") Message-ID: <87tua6vb9u.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Hm... poking around in that code, I don't quite follow how this is all > supposed to be hooked up, or which caches should be flushed. Does the > crystal ball have more insights? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Hm... poking around in that code, I don't quite follow how this is all > supposed to be hooked up, or which caches should be flushed. Does the > crystal ball have more insights? Well, actually, that's not really material. We just have to flush the cache after adding elements, so I've now done that in Emacs 29, and that makes the tool bar item show up immediately. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:20:19 2022 Received: (at control) by debbugs.gnu.org; 3 May 2022 16:20:19 +0000 Received: from localhost ([127.0.0.1]:40772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvG3-0002tq-OU for submit@debbugs.gnu.org; Tue, 03 May 2022 12:20:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvG2-0002tN-0n for control@debbugs.gnu.org; Tue, 03 May 2022 12:20:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DgAnmCe8mhq9Y507EpFKv5N5ro+YDjcWZPd0FdIPm+Y=; b=DQ23xGmS549KCMohrv4tZK7bc2 tbUGhX+gOrwzbQESV5rUiYp+6W3+YYXEsAkZ37N6v1HTsl6YP0PiVVDyFe7hqfgcX5ximi+BWfUb+ spQYdjbXEfTsnxkI/5rL7VCbhFnmOzVABMebT2VABbzcKuuqWOkDOz0ArOWGs8ltpidw=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlvFu-00088r-F7 for control@debbugs.gnu.org; Tue, 03 May 2022 18:20:08 +0200 Date: Tue, 03 May 2022 18:20:05 +0200 Message-Id: <87sfpqvb9m.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43397 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 43397 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 43397 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:31:17 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:31:17 +0000 Received: from localhost ([127.0.0.1]:40831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvQj-0004UW-Hx for submit@debbugs.gnu.org; Tue, 03 May 2022 12:31:17 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvQi-0004Nx-Ir for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:31:16 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E8434442678; Tue, 3 May 2022 12:31:10 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7E2BC442675; Tue, 3 May 2022 12:31:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651595469; bh=stnSLbOzTvoV7TtEIccA00OxPv5hdL86Zy0U3uVspMI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GGfArgndulbwwnQ9Qak1lLJc/iq2OjMljsx4Y3bPCfmyRfUgvq0nSZaLgaTI2YYeR vEnS1LVOvtu/oDBJPjpxXn+lHISZM53aO9Dc4qqgZuXDvy4KiJmgGtvrKWwOHdgxTh /kb2ZABjODJqGvO1JUwug6aWaBiN233KukekHjkSHHiBe8dBz3WUMN9J9WzONE9asv ulxYJGs/vMQ2LWRP4K5jObnliFQ3Z5EjzoI+EoGE7XCU9IfxWhYb10AvvORYiYwAsP c/j8c4LfabqavgLPHDYW5JtIAkFWIu5L8x3BKp7EtGRoMkGZDahw02zmMvBqFbFBGE 4ddIAB7t8R9tg== Received: from alfajor (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4A8FE1206CF; Tue, 3 May 2022 12:31:09 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar Message-ID: References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> Date: Tue, 03 May 2022 12:31:08 -0400 In-Reply-To: <87y1zivbr9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 03 May 2022 18:09:30 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Hm... poking around in that code, I don't quite follow how this is all > supposed to be hooked up, or which caches should be flushed. Does the > crystal ball have more insights? This cache is broken: (defun tool-bar-make-keymap (&optional _ignore) "Generate an actual keymap from `tool-bar-map'. Its main job is to figure out which images to use based on the display's color capability and based on the available image libraries." (let ((key (cons (frame-terminal) tool-bar-map))) (or (gethash key tool-bar-keymap-cache) (puthash key (tool-bar-make-keymap-1) tool-bar-keymap-cache)))) `tool-bar-map` is a normal keymap, which we modify in the usual way, i.e. via side-effect. So the key we place in this `equal` hash table will be routinely modified via side-effect, thus changing its sxhash. Maybe we'd be better off using an `eq` hash table and manually flushing the corresponding entry whenever `tool-bar-map` is modified by side-effect. I also see that we use a `:weakness t` but the values stored there will usually not be stored anywhere else, so the hash table will be completely flushed at every GC (and partly refilled soon after as part of redisplay). It should have `:weakness 'key` instead (but without fixing the current bug report, this will cause the keymap to never be refreshed until we manually flush the hash table ;-). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:40:07 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:40:07 +0000 Received: from localhost ([127.0.0.1]:40851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvZH-0005gk-4T for submit@debbugs.gnu.org; Tue, 03 May 2022 12:40:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvZE-0005g9-M1 for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:40:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1UprG6qCR+e79QUoTd8K/1lS72Ns7JkaXdd3GX4jJtk=; b=Xp1187qy1yaf0QZ/5C6l6HDyJc DIw2q3GVglWk7mhWZJq025CIPkHPgrfrItNL9cjPgz8cq//52iNm5PX8scXoiyVD9rlo/fkzXQzsz gV+c4pnLxg0fYMl1z3XVjawCanqUhSfPTGJvGEtkxVm0do0OY2hcf1xKMfYAPYemWz1c=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlvZ4-0008Ky-03; Tue, 03 May 2022 18:39:56 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUuLCNGRDdmYlSC fG2Nh3gMCQm+t6j///9hzOHLAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YFAxAhIpNFhdYAAAGZSURB VDjLdZLBbsIwDIbdae15rVTOow08AOs4Dwg9pxHmDKj4/R9htpsWRrMIJchf/99ObIA8z4uKV8M/ G9ZhswE3gmUKSWP3eSHk6wHqFSIam6IzKplAUyI6++MQvEgGIAIroL+wrOuFCGBB3Shor3+AGNmW AbY33jxRP4LaWkpZQT3KzstCJ6CxREcNjYAYFJWxLdFFTVLdBzAIiHOciL4RzwEUnIEF8i2H7hNI iqqRuNSz1eM0Kmox2rMAF+o4Jq9MSzcJywXVMeEIW4nTEOdLq6P+YWDpiuPKxk8GcMfZ4hx1u1vN wRo4U4kx0JkdRoE3xxjI4M3GnNBD8hmLowMvlZcxwLWa/h+wpjICZDq2s7t34JcyBbMKTtA1h495 UZ3cvKV+P+ZIwnnm19UGUnjHdXj2TDqoIGTP7k9gmgUJhHMhw2BUMnhk/UNRPCfJrlNyyAevQXEO PfDE016pVwiE6pyAQmY3JHWhXGzBJbkM72XWWgcqOUaASJrVC1gwEImJApG8duodEFQSB0lexAHM gQdUyRz8Am3mQYD9DGS6AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTAzVDE2OjMzOjM0KzAw OjAwAHFWYwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0wM1QxNjozMzozNCswMDowMHEs7t8A AAAASUVORK5CYII= X-Now-Playing: Deutsch Amerikanische Freundschaft's =?utf-8?Q?=5FF=C3=BCr?= Immer_: "Verlieb Dich in mich" Date: Tue, 03 May 2022 18:39:51 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 03 May 2022 12:31:08 -0400") Message-ID: <87ilqmvaco.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > `tool-bar-map` is a normal keymap, which we modify in the usual way, > i.e. via side-effect. So the key we place in this `equal` hash table > will be routinely modified via side-effect, thus changin [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > `tool-bar-map` is a normal keymap, which we modify in the usual way, > i.e. via side-effect. So the key we place in this `equal` hash table > will be routinely modified via side-effect, thus changing its sxhash. Hm... I assumed that that was the point, really, but that it didn't work for... reasons... I.e., whenever somebody modifies the map, the cache is supposed to be refreshed. I don't understand why that didn't work, but it doesn't. > Maybe we'd be better off using an `eq` hash table and manually flushing > the corresponding entry whenever `tool-bar-map` is modified by > side-effect. Yup. Should be faster, too. > I also see that we use a `:weakness t` but the values stored there will > usually not be stored anywhere else, so the hash table will be > completely flushed at every GC (and partly refilled soon after as part > of redisplay). Yeah, that's true, too. But if we have flushing, then we can probably make it non-weak, because we'll get rid up the values that way. > It should have `:weakness 'key` instead (but without > fixing the current bug report, this will cause the keymap to never be > refreshed until we manually flush the hash table ;-). I added flushing in one of the interface functions -- I didn't know whether any needed it, but they probably do. I'll poke around a bit. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:46:53 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:46:53 +0000 Received: from localhost ([127.0.0.1]:40860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvfp-0005rt-5Q for submit@debbugs.gnu.org; Tue, 03 May 2022 12:46:53 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvfo-0005re-09 for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:46:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MwVJM9R+qAlAK3TRvaHIgVEwiyZnT85vdGBk25Smu7I=; b=O2UWn868DSgZdtYTmk9OQOGD3i GLcTsEjBK0IPPYkeL7J2eyC3G9K4U7/m4Orp+G76lRWONUV8ZD8fROvKPKPnRZ90KkaGJ/ejqcCb2 DeulI+LjF7tsokraUiGz/HDD8nIx+80/+VJ25Lve52C6u6gdESmNCuwxNAJBWoqbGRGQ=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlvfd-0008QY-U4; Tue, 03 May 2022 18:46:44 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> <87ilqmvaco.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUuLCNGRDdmYlSC fG2Nh3gMCQm+t6j///9hzOHLAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YFAxAhIpNFhdYAAAGZSURB VDjLdZLBbsIwDIbdae15rVTOow08AOs4Dwg9pxHmDKj4/R9htpsWRrMIJchf/99ObIA8z4uKV8M/ G9ZhswE3gmUKSWP3eSHk6wHqFSIam6IzKplAUyI6++MQvEgGIAIroL+wrOuFCGBB3Shor3+AGNmW AbY33jxRP4LaWkpZQT3KzstCJ6CxREcNjYAYFJWxLdFFTVLdBzAIiHOciL4RzwEUnIEF8i2H7hNI iqqRuNSz1eM0Kmox2rMAF+o4Jq9MSzcJywXVMeEIW4nTEOdLq6P+YWDpiuPKxk8GcMfZ4hx1u1vN wRo4U4kx0JkdRoE3xxjI4M3GnNBD8hmLowMvlZcxwLWa/h+wpjICZDq2s7t34JcyBbMKTtA1h495 UZ3cvKV+P+ZIwnnm19UGUnjHdXj2TDqoIGTP7k9gmgUJhHMhw2BUMnhk/UNRPCfJrlNyyAevQXEO PfDE016pVwiE6pyAQmY3JHWhXGzBJbkM72XWWgcqOUaASJrVC1gwEImJApG8duodEFQSB0lexAHM gQdUyRz8Am3mQYD9DGS6AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTAzVDE2OjMzOjM0KzAw OjAwAHFWYwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0wM1QxNjozMzozNCswMDowMHEs7t8A AAAASUVORK5CYII= X-Now-Playing: Deutsch Amerikanische Freundschaft's =?utf-8?Q?=5FF=C3=BCr?= Immer_: "Prinzessin" Date: Tue, 03 May 2022 18:46:41 +0200 In-Reply-To: <87ilqmvaco.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 03 May 2022 18:39:51 +0200") Message-ID: <87ee1ava1a.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I added flushing in one of the interface functions -- I didn't know > whether any needed it, but they probably do. Now done -- seems to work fine. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > I added flushing in one of the interface functions -- I didn't know > whether any needed it, but they probably do. Now done -- seems to work fine. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:49:07 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:49:08 +0000 Received: from localhost ([127.0.0.1]:40870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvhz-0005yX-NT for submit@debbugs.gnu.org; Tue, 03 May 2022 12:49:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvhx-0005xt-9V for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:49:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlvhr-0005eb-QI; Tue, 03 May 2022 12:49:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FtQkPo8se7jC9p4Opy+Xta6ouRgCPkwvKgPQkrZAtmU=; b=Qv8kZLXGMceD eDG/pl8YBEqI1MUNbpR8UF9K4m9e+S4k7f7GcS22edIgc+u1kNHEXfuA4jZg2wQ3kbWtoHtMEH1wi hZYLvPNFGsWHxYNN3wwrEWwlZsZ1WpJuTUtqNBWDi+LtNEOwANhS8oIvLmvF0qsfrLpUG7pRVleKZ urcgl0HR7dpB1ey42EOCkJcdByzCxu2fSNzHuUIajV84XA7oNrKBPottnbJlh89Hu6SWRTSMQzCBq 8wMYAFpf2I3ALdmZfDTlafk7k3lHgHlQ4dV2hHIkCgyI6NHaSamkmE4jSkTJ8g4hTrkwA7jFX4/J6 p8n+gknw7LDbSD9svhAmUQ==; Received: from [87.69.77.57] (port=1944 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlvhr-0001YT-4X; Tue, 03 May 2022 12:48:59 -0400 Date: Tue, 03 May 2022 19:49:10 +0300 Message-Id: <83k0b24l4p.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87tua6vb9u.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 03 May 2022 18:19:57 +0200) Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> <87tua6vb9u.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, caiohcs0@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique > > Date: Tue, 03 May 2022 18:19:57 +0200 > > Lars Ingebrigtsen writes: > > > Hm... poking around in that code, I don't quite follow how this is all > > supposed to be hooked up, or which caches should be flushed. Does the > > crystal ball have more insights? > > Well, actually, that's not really material. We just have to flush the > cache after adding elements, so I've now done that in Emacs 29, and that > makes the tool bar item show up immediately. With what recipe? If I evaluate the below by "C-x C-e" after the right parenthesis: (tool-bar-add-item-from-menu 'undo-redo "redo" nil :vert-only t) it doesn't show up immediately here, I need at least to type "M-x", and sometimes also C-g or something else. From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:50:52 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:50:52 +0000 Received: from localhost ([127.0.0.1]:40876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvjg-00061d-2e for submit@debbugs.gnu.org; Tue, 03 May 2022 12:50:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvje-00061K-EP for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:50:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wkwSb8eJwO1j5TW+68QUj9Ip8E9eNgpHzsEnWHydfUI=; b=M2HR+bafCmD9G6t3LhzIbEv/y8 tgriVAnX4Df+Yrpv6MqOoO8W64AaTLeWbQjJA6mwdV4wD/pLUuA6V8AbrNn5LVZp0jaW9A1kGmpEo Nsi8mhVoxi3Qc/x2pAoydL1uOWeu0s08KL+JBTzAKf6ZNz5klCFhBtjjhp4bEnfBo8M4=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlvjV-0008Sb-7Q; Tue, 03 May 2022 18:50:43 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> <87tua6vb9u.fsf@gnus.org> <83k0b24l4p.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUuLCNGRDdmYlSC fG2Nh3gMCQm+t6j///9hzOHLAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YFAxAhIpNFhdYAAAGZSURB VDjLdZLBbsIwDIbdae15rVTOow08AOs4Dwg9pxHmDKj4/R9htpsWRrMIJchf/99ObIA8z4uKV8M/ G9ZhswE3gmUKSWP3eSHk6wHqFSIam6IzKplAUyI6++MQvEgGIAIroL+wrOuFCGBB3Shor3+AGNmW AbY33jxRP4LaWkpZQT3KzstCJ6CxREcNjYAYFJWxLdFFTVLdBzAIiHOciL4RzwEUnIEF8i2H7hNI iqqRuNSz1eM0Kmox2rMAF+o4Jq9MSzcJywXVMeEIW4nTEOdLq6P+YWDpiuPKxk8GcMfZ4hx1u1vN wRo4U4kx0JkdRoE3xxjI4M3GnNBD8hmLowMvlZcxwLWa/h+wpjICZDq2s7t34JcyBbMKTtA1h495 UZ3cvKV+P+ZIwnnm19UGUnjHdXj2TDqoIGTP7k9gmgUJhHMhw2BUMnhk/UNRPCfJrlNyyAevQXEO PfDE016pVwiE6pyAQmY3JHWhXGzBJbkM72XWWgcqOUaASJrVC1gwEImJApG8duodEFQSB0lexAHM gQdUyRz8Am3mQYD9DGS6AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTAzVDE2OjMzOjM0KzAw OjAwAHFWYwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0wM1QxNjozMzozNCswMDowMHEs7t8A AAAASUVORK5CYII= X-Now-Playing: Deutsch Amerikanische Freundschaft's =?utf-8?Q?=5FF=C3=BCr?= Immer_: "Die Lippe" Date: Tue, 03 May 2022 18:50:40 +0200 In-Reply-To: <83k0b24l4p.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 May 2022 19:49:10 +0300") Message-ID: <87a6byv9un.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > With what recipe? If I evaluate the below by "C-x C-e" after the > right parenthesis: > > (tool-bar-add-item-from-menu 'undo-redo "redo" nil :vert-only t) > > it doesn't show up immediately here, I [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, caiohcs0@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > With what recipe? If I evaluate the below by "C-x C-e" after the > right parenthesis: > > (tool-bar-add-item-from-menu 'undo-redo "redo" nil :vert-only t) > > it doesn't show up immediately here, I need at least to type "M-x", > and sometimes also C-g or something else. Is this before or after the latest tool-bar.el changes? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:54:20 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:54:20 +0000 Received: from localhost ([127.0.0.1]:40894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvn2-00067z-6N for submit@debbugs.gnu.org; Tue, 03 May 2022 12:54:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvn0-00067k-NA for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:54:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33252) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlvmv-0006YE-5C; Tue, 03 May 2022 12:54:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rGRC5YtDNeJyuz2CDRoW39s+69NSj9Z0FdwWqAW32eY=; b=niRJ+XK0Aphj Yac7jQou/KFW+AhmX/ymYQhyHZq5mcSiW6APAWl6o9jrHNzoHofQ1QaHCWiu8dWgpqDL/Q5ONW+VQ +FOhkTyY0J5zr5eF9EVCV66rm0ITY7F1mfIUfDUfCnKjk+zegL5y6EZIhnVK2FIZfKJ1msOazonPi fUhPuA4NNWqmyYhSJLJjc8ObfhpK+CfdEQ1GCVrX09XqsHTqWA5qw2NVG+4NDrlZcPxA3lni0hXHD MpFX9+Wlw5tdrjjKV1H4+7ItuyQPmNxsb5SbYIt4r4A49Yvx8J66n/JbA0r09kjWkDsQP3hOOoArA 47r/pTo9wyejfr21H4dxzw==; Received: from [87.69.77.57] (port=2265 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlvmu-0002xc-K7; Tue, 03 May 2022 12:54:12 -0400 Date: Tue, 03 May 2022 19:54:24 +0300 Message-Id: <83ilqm4kw0.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87ee1ava1a.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 03 May 2022 18:46:41 +0200) Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> <87ilqmvaco.fsf@gnus.org> <87ee1ava1a.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, caiohcs0@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique > > Date: Tue, 03 May 2022 18:46:41 +0200 > > Lars Ingebrigtsen writes: > > > I added flushing in one of the interface functions -- I didn't know > > whether any needed it, but they probably do. > > Now done -- seems to work fine. Works here too, thanks. I just hope we didn't make redisplay slower by flushing the tool bar too frequently... From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 12:58:10 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:58:10 +0000 Received: from localhost ([127.0.0.1]:40913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvqk-0006Fb-Ab for submit@debbugs.gnu.org; Tue, 03 May 2022 12:58:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlvqj-0006FN-27 for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:58:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PYrsIAHXdXlXYQtY+ag9zJ6lrbDfBDMrTiKuzop/lfY=; b=KhDEWj8TmE59S00OFpYKALG9d8 eNyFXC3kIjHg4MAr56WWRybjZBXm1fjhljwWVgPF+9BBOCnRcE3nggYynKlQvb96cK0P6s22UnNH0 KjzoA8YM7o84QoT1kQxmedMeof5lJYbVzqVxvlEso8L+ZXF4EQFUB5Gng6Di6e0f/miQ=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlvqZ-000068-7N; Tue, 03 May 2022 18:58:01 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> <87ilqmvaco.fsf@gnus.org> <87ee1ava1a.fsf@gnus.org> <83ilqm4kw0.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUuLCNGRDdmYlSC fG2Nh3gMCQm+t6j///9hzOHLAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YFAxAhIpNFhdYAAAGZSURB VDjLdZLBbsIwDIbdae15rVTOow08AOs4Dwg9pxHmDKj4/R9htpsWRrMIJchf/99ObIA8z4uKV8M/ G9ZhswE3gmUKSWP3eSHk6wHqFSIam6IzKplAUyI6++MQvEgGIAIroL+wrOuFCGBB3Shor3+AGNmW AbY33jxRP4LaWkpZQT3KzstCJ6CxREcNjYAYFJWxLdFFTVLdBzAIiHOciL4RzwEUnIEF8i2H7hNI iqqRuNSz1eM0Kmox2rMAF+o4Jq9MSzcJywXVMeEIW4nTEOdLq6P+YWDpiuPKxk8GcMfZ4hx1u1vN wRo4U4kx0JkdRoE3xxjI4M3GnNBD8hmLowMvlZcxwLWa/h+wpjICZDq2s7t34JcyBbMKTtA1h495 UZ3cvKV+P+ZIwnnm19UGUnjHdXj2TDqoIGTP7k9gmgUJhHMhw2BUMnhk/UNRPCfJrlNyyAevQXEO PfDE016pVwiE6pyAQmY3JHWhXGzBJbkM72XWWgcqOUaASJrVC1gwEImJApG8duodEFQSB0lexAHM gQdUyRz8Am3mQYD9DGS6AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTAzVDE2OjMzOjM0KzAw OjAwAHFWYwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0wM1QxNjozMzozNCswMDowMHEs7t8A AAAASUVORK5CYII= X-Now-Playing: Deutsch Amerikanische Freundschaft's =?utf-8?Q?=5FF=C3=BCr?= Immer_: "Wer =?utf-8?Q?sch=C3=B6n?= sein will muss leiden" Date: Tue, 03 May 2022 18:57:58 +0200 In-Reply-To: <83ilqm4kw0.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 May 2022 19:54:24 +0300") Message-ID: <875ymmv9ih.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I just hope we didn't make redisplay slower by flushing the tool bar > too frequently... I think it should actually be faster -- the hash table is an eql one now instead of equal, so we don't have to hash the entire contents. And gc no longer clears out the data, which would then have to [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, caiohcs0@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > I just hope we didn't make redisplay slower by flushing the tool bar > too frequently... I think it should actually be faster -- the hash table is an eql one now instead of equal, so we don't have to hash the entire contents. And gc no longer clears out the data, which would then have to be recreated. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 13:53:30 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 17:53:30 +0000 Received: from localhost ([127.0.0.1]:40982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlwiI-0001bq-JX for submit@debbugs.gnu.org; Tue, 03 May 2022 13:53:30 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlwiH-0001bb-0v for 43397@debbugs.gnu.org; Tue, 03 May 2022 13:53:29 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8EDA5100006; Tue, 3 May 2022 13:53:23 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2561810029F; Tue, 3 May 2022 13:53:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651600402; bh=sj/6zp1GLUnskY7UZ8OZ0GGAArJ1/1b4sbLF/Ls01Ck=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DMm/FpKt5o7BGpy+t3dLogsm5NPPMe87xMQj2Jy6I4P/Jz1+sIervPVjUDPTDoeDU z0d6SJAd9BBWQctzEIT1sML41NSUrTYsuRyzrLFatE0DVJjKb+YG+//95zqUR9GOX5 gY2dWuIJTZKp4gME5p56dX6Hm6cGnre3m9PMialb6C7pAy0qAFM1CMH0ulj6kBZy4Z v8BMw6cIXt8zIOTKzBsCsZvZYmoSXWS6/J4vSX3IA14JyndogUJZY5i2eFvFxiCcnY x71hdstjTKQ5/KtFA+pJ+Li9Urfv/ARyZW9vWLqjHWOd6j6LpKsKoiI3uBqzjevb4V O347KTLiQhXBw== Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E950E120697; Tue, 3 May 2022 13:53:21 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar Message-ID: References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> <87ilqmvaco.fsf@gnus.org> Date: Tue, 03 May 2022 13:53:21 -0400 In-Reply-To: <87ilqmvaco.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 03 May 2022 18:39:51 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2022-05-03 18:39:51] wrote: > Stefan Monnier writes: >> `tool-bar-map` is a normal keymap, which we modify in the usual way, >> i.e. via side-effect. So the key we place in this `equal` hash table >> will be routinely modified via side-effect, thus changing its sxhash. > Hm... I assumed that that was the point, really, but that it didn't > work for... reasons... I.e., whenever somebody modifies the map, the > cache is supposed to be refreshed. I don't understand why that didn't > work, but it doesn't. Since the key is stored as-is in the hash table, modifying the key and looking it up again should find it its hash value is unchanged, and the `equal` test will return t since both the in-hashtable key and the lookup-key are one and the same object. In any case side effects on a key's stored in an `equal` hash table lead in general to the hash table having an inconsistent internal state, so they should be avoided as much as possible. [ Just like using `aset` on the `symbol-name` of an interned symbol, for the same reason. ] Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 14:59:03 2022 Received: (at 43397) by debbugs.gnu.org; 3 May 2022 18:59:03 +0000 Received: from localhost ([127.0.0.1]:41087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlxjj-0003Su-I3 for submit@debbugs.gnu.org; Tue, 03 May 2022 14:59:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlxjh-0003SH-V4 for 43397@debbugs.gnu.org; Tue, 03 May 2022 14:59:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=W99IZGWqfQ0h3iAunbhj/k49itqYW0kDoAb/7j9bNpM=; b=mDu7fNoWyzMNWaGlCPrU0SdnYB HviWBM02kBYhiMmZUdMUmEEhzhPXFhR7oZQ2Uv2ok/Y7sYCaPZIiT0j0l9qCXSd1IY4BVOVoGhbfO Ry+YPDK/4ndMfeB+7nkGXebIBArr7aCzgKglqVGCRUAiwij8xBoapdYJ5fqxoECWHm/w=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlxjX-0001A3-8q; Tue, 03 May 2022 20:58:53 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43397: 28.0.50; Adding tool bar items: update tool bar References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> <87y1zivbr9.fsf@gnus.org> <87ilqmvaco.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAM1BMVEWBgnuSkouspZn9 /f3z8OrXyrdzdG15enJqa2Xf2dS0vt4+GhViXliEdnDKtp6tmHv///8jAvd+AAAAAWJLR0QQlbIN LAAAAAd0SU1FB+YFAxE6LNwJCXwAAAGcSURBVEjHtdaNboQgDABgKNCCOnz/t13Lzw0UiC5bc+oF +WgRNSqlNf9A658dGGMNb7wD7eoZ0EppQKVJtcFnFIMaIA3Sxr0VcWA6dERRC0h/mlP4+kdQgnQB pUPtxgCpjwvoAweAEPKEZeYanwErQHZvgA3mOUjrcCsJOWagxj8B/TcZcAX4KoVtg22UgYbAmLDh 7jPARsyB3fb9uKzDvCT3FU3wu74u3BzsDPSOFciEl4A7mvNSEtaSaAD4JorHbQ5IC2APf9wmvQIG whuQYvA8rMHtXvoFaN8aDwBf1XdALuw7sMwQwsuSomsB5v7T27sH+S76gEcZPilmIITonB0+02Pg YnRQQClmXZKAWEEbTzJQHr0+DyNgY8oQYlNSWYgJgAzOmgGRJkBO+ALAgQBczwGvAG8A+/FbcF5A njSWMmvuDqhhBuwL7YAfgNsgd+B74NFzpJ0cD7BnjJAA+TYy8HVN6hgHhATOBqD0Tv8UeuJvD3bE HyCyFXBGBtZzs+IPEo0qfURwBuR3Yo082sGDg4DIQNryVs5+A3X/NZWE4oh1AAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIyLTA1LTAzVDE3OjU4OjQ0KzAwOjAwx3e3SwAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMi0wNS0wM1QxNzo1ODo0NCswMDowMLYqD/cAAAAASUVORK5CYII= X-Now-Playing: Eurythmics's _Sweet Dreams (Are Made Of This)_: "This City Never Sleeps" Date: Tue, 03 May 2022 20:58:50 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 03 May 2022 13:53:21 -0400") Message-ID: <87czgutpcl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > Since the key is stored as-is in the hash table, modifying the key and > looking it up again should find it its hash value is unchanged, and the > `equal` test will return t since both the in-hashta [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43397 Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > Since the key is stored as-is in the hash table, modifying the key and > looking it up again should find it its hash value is unchanged, and the > `equal` test will return t since both the in-hashtable key and the > lookup-key are one and the same object. D'oh. I completely blanked about that. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Jun 19 12:36:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 01 Jun 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator