From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 21:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 43383@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160003082921089 (code B ref -1); Sun, 13 Sep 2020 21:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Sep 2020 21:00:29 +0000 Received: from localhost ([127.0.0.1]:51892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHZ6r-0005U4-90 for submit@debbugs.gnu.org; Sun, 13 Sep 2020 17:00:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:42650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHZ6o-0005Tw-CR for submit@debbugs.gnu.org; Sun, 13 Sep 2020 17:00:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHZ6o-0006ux-1u for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 17:00:26 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:37068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHZ6m-0001Mk-2t for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 17:00:25 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08DKx8w7154597 for ; Sun, 13 Sep 2020 21:00:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=f+9hr61JEVGpsQAvBaB2wwC0Lf3wVN/qkjeBMNKNEp8=; b=dTvj1s3p0vkbS+G/JDedQ85aJqV6932foFVM6YJMzlvjr/6Lv81DWJ/ywyMdbL6nAknN sN7n72UyV1WDS4HQNBroFHYRulyQtU6oxBMfD3SPZ9nRI4qvueMswv2gYuRNk49Er48Z 6U3md+qdE40ijEyUuglM1wFX0SbYPRB1ZJEqe6FyFDdK5T+sZ7U2jOo5NIsAChmvZ7Bx tr+mrTMksVntbLhPMpAldnP8d/S/yWN+/axm581Dych8zpOL/QHZWstMyxP7UVNs7PoT UDzqvW9jxftnSI2mBbxANTs4E6vVx60G3176FFFV9N2y9ET8gkiN72dNm267QMa0qC/Y lg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 33gp9kucwx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 13 Sep 2020 21:00:22 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08DKtp0Q139238 for ; Sun, 13 Sep 2020 20:58:22 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 33h7wk1jmc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 13 Sep 2020 20:58:21 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08DKwJ9C011042 for ; Sun, 13 Sep 2020 20:58:20 GMT MIME-Version: 1.0 Message-ID: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> Date: Sun, 13 Sep 2020 20:58:16 +0000 (UTC) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9743 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009130195 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9743 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=1 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009130195 Received-SPF: pass client-ip=141.146.126.78; envelope-from=drew.adams@oracle.com; helo=aserp2120.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/13 17:00:22 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -60 X-Spam_score: -6.1 X-Spam_bar: ------ X-Spam_report: (-6.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.695, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I don't understand the doc string: Toggle menu bar on or off, based on the status of the current frame. See `menu-bar-mode' for more information. I have no idea what is meant by "based on the status of the current frame". Is the status whether it shows the menu-bar? Furthermore, this seems to be used only in menu Options > Show/Hide. Which means it's only visible when the menu-bar is visible, right? Sorry, but I just don't get the point of this command, e.g., compared to command `menu-bar-mode'. What's more, the doc string tells you to see the doc string of `menu-bar-mode'. But that doesn't explain anything more about `toggle-menu-bar-mode-from-frame', e.g., how it differs from `menu-bar-mode'. It's not even mentioned there. What is this command - what's its use case? And can the doc string be improved? In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32) of 2019-08-29 Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd Windowing system distributor `Microsoft Corp.', version 10.0.18362 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 23:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 43383@debbugs.gnu.org Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.160003981711666 (code B ref 43383); Sun, 13 Sep 2020 23:31:01 +0000 Received: (at 43383) by debbugs.gnu.org; 13 Sep 2020 23:30:17 +0000 Received: from localhost ([127.0.0.1]:52052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHbRo-00031b-Ng for submit@debbugs.gnu.org; Sun, 13 Sep 2020 19:30:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHbRm-0002to-Jv for 43383@debbugs.gnu.org; Sun, 13 Sep 2020 19:30:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=p8Bb4vq3cxAp9JNsDKsRxG+4DFzoWSSGy+XK32laFjE=; b=ACwtqh9wzAVvl17i51gU+wHX6K rtjFDfGa7BGcPT/M7dZqUFfDpRJePRaqw/dYrqF2vzyEiG0UZ0fkzR4fpHwGNlcVixq8XPR9033+/ 9D/2LA4MvgwiWORojb//90kxEBWQVHsOoKCLCZgroDxSXvzKSVmfpYEFRI2Z7pM6Agio=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHbRc-00016z-Ox; Mon, 14 Sep 2020 01:30:08 +0200 From: Lars Ingebrigtsen References: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> X-Now-Playing: Rema Rema's _Fond Reflections (1): Wheel in the Roses (Extended)_: "Feedback Song" Date: Mon, 14 Sep 2020 01:30:03 +0200 In-Reply-To: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> (Drew Adams's message of "Sun, 13 Sep 2020 20:58:16 +0000 (UTC)") Message-ID: <87tuw1dzlw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > I don't understand the doc string: > > Toggle menu bar on or off, based on the status of the current frame. > See `menu-bar-mode' for more information. > > I have no idea what is meant by "based on [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > I don't understand the doc string: > > Toggle menu bar on or off, based on the status of the current frame. > See `menu-bar-mode' for more information. > > I have no idea what is meant by "based on the status of the current > frame". Is the status whether it shows the menu-bar? > > Furthermore, this seems to be used only in menu Options > Show/Hide. > Which means it's only visible when the menu-bar is visible, right? It's very confusing indeed, but the patch that introduces this has a long essay about why it was added. It's something to do with... multi-tty? Which clarifies the meaning of "Toggle menu bar on or off, based on the status of the current frame." somewhat, since the exegesis says that the (global) status may be... wrong? That sounds like a bug, doesn't it? commit 6a5af08f8d3bb831a78edf17e9c38813bbfbb6f8 Author: Karoly Lorentey AuthorDate: Sun Mar 26 14:20:01 2006 +0000 Commit: Karoly Lorentey CommitDate: Sun Mar 26 14:20:01 2006 +0000 Fix tool-bar and menu-bar toggles in Show/Hide menu to reflect the state of the current frame. * lisp/tool-bar.el (toggle-tool-bar-mode-from-frame): New function. * lisp/menu-bar.el (toggle-menu-bar-mode-from-frame): New function. (menu-bar-showhide-menu): Use them to change "Menu-bar" and "Tool-bar" toggles to reflect the state of the current frame. git-archimport-id: lorentey@elte.hu--2004/emacs--multi-tty--0--patch-537 diff --git a/README.multi-tty b/README.multi-tty index 2ac27bafe5..442c4c92fd 100644 --- a/README.multi-tty +++ b/README.multi-tty @@ -404,17 +404,6 @@ is probably not very interesting for anyone else.) THINGS TO DO ------------ -** `tool-bar-mode', `scroll-bar-mode', `menu-bar-mode' and - 'fringe-mode' are modes global to the entire Emacs session, not - just a single frame or a single terminal. This means that their - status sometimes differs from what's actually displayed on the - screen. As a consequence, the Options | Show/Hide menu sometimes - shows incorrect status, and you have to select an option twice for - it to have any visible effect on the current frame. - - Change Emacs so that the status of the items in the Options | - Show/Hide menu correspond to the current frame. - ** emacsclient -t on the console does not work after su: # su lorentey @@ -1485,5 +1474,18 @@ DIARY OF CHANGES (Done in patch-500.) +-- `tool-bar-mode', `scroll-bar-mode', `menu-bar-mode' and + 'fringe-mode' are modes global to the entire Emacs session, not + just a single frame or a single terminal. This means that their + status sometimes differs from what's actually displayed on the + screen. As a consequence, the Options | Show/Hide menu sometimes + shows incorrect status, and you have to select an option twice for + it to have any visible effect on the current frame. + + Change Emacs so that the status of the items in the Options | + Show/Hide menu correspond to the current frame. + + (Done in patch-537.) + ;;; arch-tag: 8da1619e-2e79-41a8-9ac9-a0485daad17d diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 75d68d0baa..a9987d589f 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -935,15 +935,15 @@ menu-bar-showhide-menu :button `(:toggle . tooltip-mode))) (define-key menu-bar-showhide-menu [menu-bar-mode] - '(menu-item "Menu-bar" menu-bar-mode + '(menu-item "Menu-bar" toggle-menu-bar-mode-from-frame :help "Toggle menu-bar on/off" - :button (:toggle . menu-bar-mode))) + :button (:toggle . (> (frame-parameter nil 'menu-bar-lines) 0)))) (define-key menu-bar-showhide-menu [showhide-tool-bar] - (list 'menu-item "Tool-bar" 'tool-bar-mode - :help "Turn tool-bar on/off" + (list 'menu-item "Tool-bar" 'toggle-tool-bar-mode-from-frame + :help "Toggle tool-bar on/off" :visible `(display-graphic-p) - :button `(:toggle . tool-bar-mode))) + :button `(:toggle . (> (frame-parameter nil 'tool-bar-lines) 0)))) (define-key menu-bar-options-menu [showhide] (list 'menu-item "Show/Hide" menu-bar-showhide-menu @@ -1778,6 +1778,14 @@ menu-bar-mode "Menu-bar mode disabled. Use M-x menu-bar-mode to make the menu bar appear.")) menu-bar-mode) +(defun toggle-menu-bar-mode-from-frame (&optional arg) + "Toggle menu bar on or off, based on the status of the current frame. +See `menu-bar-mode' for more information." + (interactive (list (or current-prefix-arg 'toggle))) + (if (eq arg 'toggle) + (menu-bar-mode (if (> (frame-parameter nil 'menu-bar-lines) 0) 0 1)) + (menu-bar-mode arg))) + (provide 'menu-bar) ;;; arch-tag: 6e6a3c22-4ec4-4d3d-8190-583f8ef94ced diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el index be552854b1..023b90af5d 100644 --- a/lisp/tool-bar.el +++ b/lisp/tool-bar.el @@ -61,6 +61,16 @@ tool-bar-mode (display-graphic-p)) (tool-bar-setup)))) +;;;###autoload +;; Used in the Show/Hide menu, to have the toggle reflect the current frame. +(defun toggle-tool-bar-mode-from-frame (&optional arg) + "Toggle tool bar on or off, based on the status of the current frame. +See `tool-bar-mode' for more information." + (interactive (list (or current-prefix-arg 'toggle))) + (if (eq arg 'toggle) + (tool-bar-mode (if (> (frame-parameter nil 'tool-bar-lines) 0) 0 1)) + (tool-bar-mode arg))) + ;;;###autoload ;; We want to pretend the toolbar by standard is on, as this will make ;; customize consider disabling the toolbar a customization, and save -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2020 00:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 43383@debbugs.gnu.org Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.160004164721758 (code B ref 43383); Mon, 14 Sep 2020 00:01:02 +0000 Received: (at 43383) by debbugs.gnu.org; 14 Sep 2020 00:00:47 +0000 Received: from localhost ([127.0.0.1]:52106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHbvL-0005es-Dt for submit@debbugs.gnu.org; Sun, 13 Sep 2020 20:00:47 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:52502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHbvK-0005eg-4B for 43383@debbugs.gnu.org; Sun, 13 Sep 2020 20:00:46 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08DNxgNT028401; Mon, 14 Sep 2020 00:00:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=/9dDUipo1IMSr5zmVAguYCE3iPUene/05JPMAkKFP6k=; b=L6t4TPk+5wnbXJrDuf9ZPkoUOvs6+keZ/VR9qoVtcqkoeyd9YpE61VqKB4Dkb+GdD5Qc 8p72gTOUpJ87FF7epK3cnCmOue46ftfHDeDt+TlSA8yB4jofONRWDYmwIl+6qlrixDqd 8aP/KxDMYmeGtKo3uZfQdSP9PWXWA1ITbsrJ5p6BotwoBt8EXW+3zldpSNeHmBy2YNbf yJ+QKJ1UBeNbFibs3DKiSqePhLw5U48c+/f1951SZ3OEow+jXGf6eFSuUcDwX5WjW8ER apc8/9Y67qI/lwOOayDNys7BjEw/h/KNiGMC4Di8rgFkA7XN0B306W32CMW1NJu81H9/ cA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 33gp9kuj84-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Sep 2020 00:00:40 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08E00c5t135980; Mon, 14 Sep 2020 00:00:39 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 33h88upbey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Sep 2020 00:00:39 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08E00cdX016831; Mon, 14 Sep 2020 00:00:39 GMT MIME-Version: 1.0 Message-ID: <882a4660-736a-4361-b8d8-f60df88daccf@default> Date: Mon, 14 Sep 2020 00:00:37 +0000 (UTC) From: Drew Adams References: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> <87tuw1dzlw.fsf@gnus.org> In-Reply-To: <87tuw1dzlw.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9743 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009130223 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9743 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1011 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009130223 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > I don't understand the doc string: > > > > Toggle menu bar on or off, based on the status of the current frame. > > See `menu-bar-mode' for more information. > > > > I have no idea what is meant by "based on the status of the current > > frame". Is the status whether it shows the menu-bar? > > > > Furthermore, this seems to be used only in menu Options > Show/Hide. > > Which means it's only visible when the menu-bar is visible, right? >=20 > It's very confusing indeed, but the patch that introduces this has a > long essay about why it was added. >=20 > It's something to do with... multi-tty? Which clarifies the meaning of > "Toggle menu bar on or off, based on the status of the current frame." > somewhat, since the exegesis says that the (global) status may be... > wrong? >=20 > That sounds like a bug, doesn't it? Sorry, but I still don't understand it. I don't really care about this, so I'll leave it up to others (e.g. you, if you want) to figure out what, if anything, should be done about it. I suspect that even the command name is bad. ---- FWIW, I have a similarly named command, but it does what I'd expect a command with such a name to do: (defun toggle-menu-bar-for-frame (&optional frame) "Toggle showing the menu-bar for selected frame. When called from Lisp, optional arg FRAME is used instead of the selected frame." (interactive) (let ((now (or (frame-parameter frame 'menu-bar-lines) 0))) (set-frame-parameter frame 'menu-bar-lines (if (zerop now) 1 0)))) IOW, instead of toggling all existing and future frames, which is what `menu-bar-mode' does, it toggles only the selected frame. From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2020 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 43383@debbugs.gnu.org Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.160009457230787 (code B ref 43383); Mon, 14 Sep 2020 14:43:02 +0000 Received: (at 43383) by debbugs.gnu.org; 14 Sep 2020 14:42:52 +0000 Received: from localhost ([127.0.0.1]:55715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpgy-00080V-Ej for submit@debbugs.gnu.org; Mon, 14 Sep 2020 10:42:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpgx-00080I-EM for 43383@debbugs.gnu.org; Mon, 14 Sep 2020 10:42:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53268) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHpgs-00048q-4O; Mon, 14 Sep 2020 10:42:46 -0400 Received: from [176.228.60.248] (port=1235 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHpgr-0006DP-BD; Mon, 14 Sep 2020 10:42:45 -0400 Date: Mon, 14 Sep 2020 17:42:49 +0300 Message-Id: <838sdcbes6.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> (message from Drew Adams on Sun, 13 Sep 2020 20:58:16 +0000 (UTC)) References: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 13 Sep 2020 20:58:16 +0000 (UTC) > From: Drew Adams > > I don't understand the doc string: > > Toggle menu bar on or off, based on the status of the current frame. > See `menu-bar-mode' for more information. Yes, the doc string "needs work". > What's more, the doc string tells you to see the doc string of > `menu-bar-mode'. But that doesn't explain anything more about > `toggle-menu-bar-mode-from-frame', e.g., how it differs from > `menu-bar-mode'. It's not even mentioned there. > > What is this command - what's its use case? If you set the menu-bar-lines parameter of a frame to zero, but don't turn off menu-bar-mode, the menu bar will not be displayed. In that situation, "M-x menu-bar-mode RET" will do the exact opposite of what you want, whereas this command, when invoked from the menu popped up by C-mouse-3, will do what you expect. That's the use case. From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2020 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 43383@debbugs.gnu.org, drew.adams@oracle.com Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.160009505431690 (code B ref 43383); Mon, 14 Sep 2020 14:51:01 +0000 Received: (at 43383) by debbugs.gnu.org; 14 Sep 2020 14:50:54 +0000 Received: from localhost ([127.0.0.1]:55750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpok-0008F3-63 for submit@debbugs.gnu.org; Mon, 14 Sep 2020 10:50:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpoh-0008Ep-PH for 43383@debbugs.gnu.org; Mon, 14 Sep 2020 10:50:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53407) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHpoc-0005Mh-Eh; Mon, 14 Sep 2020 10:50:46 -0400 Received: from [176.228.60.248] (port=1731 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHpob-0006wH-SP; Mon, 14 Sep 2020 10:50:46 -0400 Date: Mon, 14 Sep 2020 17:50:50 +0300 Message-Id: <834ko0beet.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87tuw1dzlw.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 14 Sep 2020 01:30:03 +0200) References: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> <87tuw1dzlw.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Mon, 14 Sep 2020 01:30:03 +0200 > Cc: 43383@debbugs.gnu.org > > It's something to do with... multi-tty? Which clarifies the meaning of > "Toggle menu bar on or off, based on the status of the current frame." > somewhat, since the exegesis says that the (global) status may be... > wrong? > > That sounds like a bug, doesn't it? I think this command indeed has a bug, in that it cannot disable the menu bar only on the frame from which it is invoked. It _can_ enable the menu bar on a single frame, see my response to Drew. So I think this command needs to be improved. But that's another issue; the doc string definitely needs to be improved. Will you do that, or should I? Thanks. From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2020 14:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 43383@debbugs.gnu.org, drew.adams@oracle.com Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.160009513031847 (code B ref 43383); Mon, 14 Sep 2020 14:53:02 +0000 Received: (at 43383) by debbugs.gnu.org; 14 Sep 2020 14:52:10 +0000 Received: from localhost ([127.0.0.1]:55758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHppx-0008Hb-RK for submit@debbugs.gnu.org; Mon, 14 Sep 2020 10:52:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHppw-0008HL-2U for 43383@debbugs.gnu.org; Mon, 14 Sep 2020 10:52:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v2n4gZVPmPWJyUouAQSp6mFo/TpslH6Hg0z85w9RIBE=; b=j5EUiIGUhzzKGndOlQknMIcOG0 aE69In0+UyY4t3SD/NTcwJ43z3Ptg5B0/y01NiJ6vdg2GFO3ThM8Efck7AgLk3cIApddSpqMS9YsR 3BJwcIZB9mnjPrkZhiwFSS+cRqynzSeL3YburnTUUzJh58NgRvyh7HPrkefi/XYbqSn4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHppn-0002hd-DJ; Mon, 14 Sep 2020 16:52:02 +0200 From: Lars Ingebrigtsen References: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> <87tuw1dzlw.fsf@gnus.org> <834ko0beet.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEVdVltKLi6BfYCq uL4jFRL////lCCyUAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QJDg4yBqJDOjgAAAG+SURBVDjLbZMB 0qswCIRJ2gMEmwNEcoE2XkDe5P5neguJtrZ/ZupYPxdYQApElPCjWuzKdnL+V/y227/HGkUajwPA gbud/CgisrEHiJFIJ+g3ANrmafRWfIMcOF9AfSs+QP1UhBOUC0iehPPteQVEDvQKnolKmGV9g1gm WFZPLht8VoDTCIeSTGHMFDJydE1r4HcoIik/oA3AWT+ADOsARUOfQDCUrbUTZDXrvISjJdUNDoDZ wIeB5lU5gGtI9ACHQr7A2fYfMJpY3uDx/ByU/IAqtWFbAPoBsD7UBMAkpsjqA7llB3hSI1pM1PsO Ey/WnntqWKgSYzXA9v7yHH3ZSlxDraYYnZqg39osV8je4z3RAIi+ba/IKZDvzt51AN4DciUUSmrl 9gMs6+CcCbUo0wESKZGHpUBhX2aGKfbohK/lHvYD7PeMMIjSKQV5ZT0E43W7IHryfXd9Qlo4Tt0B F/bZqkMVuJO7K9axWEjHEjhiulIU9WjQu1mwZm9zRVcmTwXJXvHNGhBbusKng6UN0KJNagJri3U5 Zo0Sa52hBuin1Doc3qHOA1Ftv0BR7jX5fI4NtM1a+x+hEpIE/g9DKL5NUm5pkAAAACV0RVh0ZGF0 ZTpjcmVhdGUAMjAyMC0wOS0xNFQxNDo1MDowNiswMDowMM55bnMAAAAldEVYdGRhdGU6bW9kaWZ5 ADIwMjAtMDktMTRUMTQ6NTA6MDYrMDA6MDC/JNbPAAAAAElFTkSuQmCC X-Now-Playing: Drew Daniel, John Wiese's _Continuous Hole_: "Progress Bar" Date: Mon, 14 Sep 2020 16:51:58 +0200 In-Reply-To: <834ko0beet.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Sep 2020 17:50:50 +0300") Message-ID: <877dsw8l81.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I think this command indeed has a bug, in that it cannot disable the > menu bar only on the frame from which it is invoked. It _can_ enable > the menu bar on a single frame, see my response to Drew. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I think this command indeed has a bug, in that it cannot disable the > menu bar only on the frame from which it is invoked. It _can_ enable > the menu bar on a single frame, see my response to Drew. So I think > this command needs to be improved. But that's another issue; the doc > string definitely needs to be improved. Will you do that, or should > I? Please go ahead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2020 15:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Drew Adams Cc: 43383@debbugs.gnu.org Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.160009661116473 (code B ref 43383); Mon, 14 Sep 2020 15:17:02 +0000 Received: (at 43383) by debbugs.gnu.org; 14 Sep 2020 15:16:51 +0000 Received: from localhost ([127.0.0.1]:55894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHqDr-0004HM-DQ for submit@debbugs.gnu.org; Mon, 14 Sep 2020 11:16:51 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:34826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHqDp-0004C1-IH for 43383@debbugs.gnu.org; Mon, 14 Sep 2020 11:16:50 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08EF8k5c037035; Mon, 14 Sep 2020 15:16:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=MzlW/R4XsBVnp44orgUP8H62UeiNizYK7NW6/ZjIFlM=; b=DRA3FmqkZyl+8QIr/SHP7o6hKh0nPLUuWSgnYQ1vvNdE7AHnSEZ+8QgF7tzFAdcAjyTB JeS2HTjKnE0qg2lybT952ocihR78mPXPCvtqF5ehPbUOtk5RPUQcQDVOEns9mLVhCMzE huSgChOqpLgC9a/WPAsr1G+b6mJNQ4/LX/lKzyhBs5h2DaVh6SUP9kShYrp+DKYKyj6I oMe+Yg8JyIuwmfo2Zgkqmc79TvYdWmMCeYejQmbSpvhm3QySs7nFaMWeJgSTAzkXAPma tVQUksCEECzLxeO23FmfShz72pdG0zLfF3m0WtlyTgFbg2PnmJzeIbo9fE1IxTifhklo 2g== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 33gp9ky7qh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Sep 2020 15:16:43 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08EF9lHQ189081; Mon, 14 Sep 2020 15:16:42 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 33hm2xau29-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Sep 2020 15:16:42 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08EFGfKH001067; Mon, 14 Sep 2020 15:16:42 GMT MIME-Version: 1.0 Message-ID: <2577f0a1-5380-48dd-8327-f813d5693058@default> Date: Mon, 14 Sep 2020 15:16:40 +0000 (UTC) From: Drew Adams References: <<7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default>> <<838sdcbes6.fsf@gnu.org>> In-Reply-To: <<838sdcbes6.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9744 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009140124 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9744 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009140124 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > What is this command - what's its use case? >=20 > If you set the menu-bar-lines parameter of a frame to zero, but don't > turn off menu-bar-mode, the menu bar will not be displayed. In that > situation, "M-x menu-bar-mode RET" will do the exact opposite of what > you want, whereas this command, when invoked from the menu popped up > by C-mouse-3, will do what you expect. That's the use case. Thanks for the explanation. So its use is only when the menu-bar is not shown. The doc string should probably at least point that out. And perhaps it can be shown only by C-mouse-3, and only when the menu-bar is not shown (in the clicked frame). And maybe use the command I mentioned instead, either from the keyboard or from C-mouse-3. Or when the menu-bar is shown, from there too. It just toggles the menu-bar for the selected frame (or the FRAME arg). From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Sep 2020 16:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 43383@debbugs.gnu.org, drew.adams@oracle.com Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.160027318412139 (code B ref 43383); Wed, 16 Sep 2020 16:20:01 +0000 Received: (at 43383) by debbugs.gnu.org; 16 Sep 2020 16:19:44 +0000 Received: from localhost ([127.0.0.1]:35765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIa9o-00039i-6f for submit@debbugs.gnu.org; Wed, 16 Sep 2020 12:19:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIa9m-00039S-IE for 43383@debbugs.gnu.org; Wed, 16 Sep 2020 12:19:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44287) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIa9h-0008Bn-49; Wed, 16 Sep 2020 12:19:37 -0400 Received: from [176.228.60.248] (port=4730 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kIa9g-0005O2-KJ; Wed, 16 Sep 2020 12:19:36 -0400 Date: Wed, 16 Sep 2020 19:19:45 +0300 Message-Id: <83ft7h7kym.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <877dsw8l81.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 14 Sep 2020 16:51:58 +0200) References: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> <87tuw1dzlw.fsf@gnus.org> <834ko0beet.fsf@gnu.org> <877dsw8l81.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: drew.adams@oracle.com, 43383@debbugs.gnu.org > Date: Mon, 14 Sep 2020 16:51:58 +0200 > > Eli Zaretskii writes: > > > I think this command indeed has a bug, in that it cannot disable the > > menu bar only on the frame from which it is invoked. It _can_ enable > > the menu bar on a single frame, see my response to Drew. So I think > > this command needs to be improved. But that's another issue; the doc > > string definitely needs to be improved. Will you do that, or should > > I? > > Please go ahead. Done. I'm not closing the bug, because I think we should make the command work according to documentation: toggle the menu bar only on the frame from which the command is invoked. I think it should manipulate the menu-bar-lines frame parameter instead of invoking menu-bar mode. Patches welcome. From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Sep 2020 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Lars Ingebrigtsen Cc: 43383@debbugs.gnu.org, drew.adams@oracle.com Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.160027617216702 (code B ref 43383); Wed, 16 Sep 2020 17:10:02 +0000 Received: (at 43383) by debbugs.gnu.org; 16 Sep 2020 17:09:32 +0000 Received: from localhost ([127.0.0.1]:35811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIavz-0004LK-Rx for submit@debbugs.gnu.org; Wed, 16 Sep 2020 13:09:32 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:60066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIavj-0004Ks-0A for 43383@debbugs.gnu.org; Wed, 16 Sep 2020 13:09:30 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08GH4pFt077787; Wed, 16 Sep 2020 17:09:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=uBRelEoUJibxFXIx8ak1YmkqX47Ydm27R38a854ko9E=; b=c7UV1lUr1HWqDqkdZX4G0hhF++LuaVllWQtmIQK4hoOlqdjrbbrixqnRt4c0SEa3RNI3 Z/IZrL8QYLzpfHf2k1So5uBN1hbbqtM6u4U0pss/tMnists5KgP9uFVPVV93Jqb0nqJG SNbi394NjoLwjESIb8+Mvomtq9dZNaX9AFm4/42tMw0ajWkySM0/gzSdDzzrXYY584Nl A4QGAKLzDvPo3iWdrRt1zIJdzYcsfUVIYe7I/OS6i5WLxumdTz/pD29hOSH68bjMShn6 UwxFdN/Ons9OLoFh6hqzzS3+GqkXYqa0t464s7hH4ATBRBQwice88Fy99UkFahrxXBr5 +Q== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 33gp9mcc50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 Sep 2020 17:09:09 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08GH4leE106257; Wed, 16 Sep 2020 17:09:08 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 33h8921rm8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Sep 2020 17:09:08 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08GH97Ew027592; Wed, 16 Sep 2020 17:09:07 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 16 Sep 2020 17:09:06 +0000 (UTC) From: Drew Adams References: <<7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> <87tuw1dzlw.fsf@gnus.org>> <<834ko0beet.fsf@gnu.org>> <<877dsw8l81.fsf@gnus.org>> <<83ft7h7kym.fsf@gnu.org>> In-Reply-To: <<83ft7h7kym.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9746 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009160120 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9746 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009160120 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > > I think this command indeed has a bug, in that it cannot disable the > > > menu bar only on the frame from which it is invoked. It _can_ enable > > > the menu bar on a single frame, see my response to Drew. So I think > > > this command needs to be improved. But that's another issue; the doc > > > string definitely needs to be improved. Will you do that, or should > > > I? > > > > Please go ahead. >=20 > Done. >=20 > I'm not closing the bug, because I think we should make the command > work according to documentation: toggle the menu bar only on the frame > from which the command is invoked. I think it should manipulate the > menu-bar-lines frame parameter instead of invoking menu-bar mode. >=20 > Patches welcome. Isn't that what the code I sent does? Here it is again: (defun toggle-menu-bar-for-frame (&optional frame) "Toggle showing the menu-bar for selected frame. When called from Lisp, optional arg FRAME is used instead of the selected frame." (interactive) (let ((now (or (frame-parameter frame 'menu-bar-lines) 0))) (set-frame-parameter frame 'menu-bar-lines (if (zerop now) 1 0)))) From unknown Fri Aug 15 15:29:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Jan 2022 17:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 43383@debbugs.gnu.org, drew.adams@oracle.com Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.164365021028441 (code B ref 43383); Mon, 31 Jan 2022 17:31:01 +0000 Received: (at 43383) by debbugs.gnu.org; 31 Jan 2022 17:30:10 +0000 Received: from localhost ([127.0.0.1]:40629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEaVF-0007OK-TP for submit@debbugs.gnu.org; Mon, 31 Jan 2022 12:30:10 -0500 Received: from quimby.gnus.org ([95.216.78.240]:48540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEaVD-0007K5-V6 for 43383@debbugs.gnu.org; Mon, 31 Jan 2022 12:30:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DUAO1ZdnVhbmD0BwkLaUKe6ATnxeH+u20fP4HY7/qLY=; b=PxVsJipKhhj3T1VdDgltf5GODr KRSWi7OOe7bnImEQeNFXlzpaUNHokCfQge5Jzh2ADIe0pzmuYuU/w5Di71XFFZYobtgY2D1JVh0/3 9hLpdOzoKBkbAkLKgv+lgLk05kFlbWTKF3Fjxsy/DoV1U5GzLC1fokkNX8A6/D604DJY=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEaV4-0004zr-7u; Mon, 31 Jan 2022 18:30:00 +0100 From: Lars Ingebrigtsen References: <7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> <87tuw1dzlw.fsf@gnus.org> <834ko0beet.fsf@gnu.org> <877dsw8l81.fsf@gnus.org> <83ft7h7kym.fsf@gnu.org> X-Now-Playing: Moor Mother's _Fetish Bones_: "Valley Of Dry Bones" Date: Mon, 31 Jan 2022 18:29:57 +0100 In-Reply-To: <83ft7h7kym.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 16 Sep 2020 19:19:45 +0300") Message-ID: <871r0nyfsa.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I'm not closing the bug, because I think we should make the command > work according to documentation: toggle the menu bar only on the frame > from which the command is invoked. I think it should ma [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > I'm not closing the bug, because I think we should make the command > work according to documentation: toggle the menu bar only on the frame > from which the command is invoked. I think it should manipulate the > menu-bar-lines frame parameter instead of invoking menu-bar mode. The other similar options here (tool bar, tab bar) in this menu work across all frames, so I don't think it makes sense to alter how this command works. Instead I've adjusted the doc string to reflect how it works in Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 31 12:30:17 2022 Received: (at control) by debbugs.gnu.org; 31 Jan 2022 17:30:18 +0000 Received: from localhost ([127.0.0.1]:40633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEaVN-0007T2-Hp for submit@debbugs.gnu.org; Mon, 31 Jan 2022 12:30:17 -0500 Received: from quimby.gnus.org ([95.216.78.240]:48554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEaVH-0007Lv-CJ for control@debbugs.gnu.org; Mon, 31 Jan 2022 12:30:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eom7iedgudU8rdRkr+796mUaaeENRjKVVrRgzsxH228=; b=n+/OD/ivahmzD8n+XdoZpQJpLK SxBbt2ST+JzsjOXBGCk/4cViMcbG23NRFTaUUdgraJM7i+nsevMgg50saTOyomnEH6P9dOcyHyzWQ zj3VFiMatNwKvngqht8wVPiClX7gM5yUsX+oSDVBNzH53clrSIPmuU3INFaVXGLc6Sus=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEaV9-000506-Ec for control@debbugs.gnu.org; Mon, 31 Jan 2022 18:30:05 +0100 Date: Mon, 31 Jan 2022 18:30:02 +0100 Message-Id: <87zgnbx17p.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43383 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 43383 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 43383 quit