From unknown Tue Jul 15 11:17:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43382: [PATCH] Remove mention of compilation-minor-mode-map from docstring of compilation-mode-map Resent-From: akater Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43382 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 43382@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160003048420468 (code B ref -1); Sun, 13 Sep 2020 20:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Sep 2020 20:54:44 +0000 Received: from localhost ([127.0.0.1]:51882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHZ1H-0005K4-Vw for submit@debbugs.gnu.org; Sun, 13 Sep 2020 16:54:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:41220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHZ1E-0005Jt-8x for submit@debbugs.gnu.org; Sun, 13 Sep 2020 16:54:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHZ1E-0005oD-0k for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 16:54:40 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:34975) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHZ1C-0000jv-Dz for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 16:54:39 -0400 Received: by mail-wr1-x441.google.com with SMTP id e16so16564354wrm.2 for ; Sun, 13 Sep 2020 13:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=pC13g1POQrE/HA+iXDXVceCzphk/OvomcDtZ+g0fGhU=; b=rHJjviM8o0VIATPitajsW2q2F5UBbonj0VgUtx2RX8s7vBUp5nyABJB2QTzAvUhLWD xTnUxvEPG6njgi04OQ1cWHqC6lnF4JOj3i3zGUQ5Hk03r8jkhbVMuPgIfgo+UNLMu62a zdG57SeeXYYcIdH1L67++ouWwP70gVjBilU1bXr9rCPtelpD+PCUi05fufzTl1hQfdKj kqo0LNlwcffjL22/3azIqFRi87Af2mk14IAWFtRAXdTCX+NpCnkYLjfmyV017S8KxrHq cDnNlNBCrXiN5E+bbFx8FZSE+qq4jXcyfhhx2T0kuTImyTeh7YaR9OhNvxnZVLfXzPEG 3fwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=pC13g1POQrE/HA+iXDXVceCzphk/OvomcDtZ+g0fGhU=; b=W5FwqSLFAJA6N6YSLTHKSoGs2QpywVHFuqoiJ4l+yi3i1ec6mt9QEAX2re6CWfjXTu gGGxfKe4jpps6L0kFspc8sYUvEdc/pwQ6WVs8OzLqJyLO+HcsnkT3nVJ1978w2YtS/vt JUT3xzv8spfFx0Efbxy1xbxZout7bRSdeRfwrHu/sEDtT4hnsdDJl5aorH4SMUJiAH+S pjJQFGVXi7WmI5mymoLT4vf7QPsGVmGGWh/8aUQqy2z+Znztf6UftCnk0rAHPLUuJ+1z 564aAubATqKTTDoglYFedB1n8CQodysXvFuercH06P21QIuJtUE6vJVMOafiGpcCOfXF yVNw== X-Gm-Message-State: AOAM532tX1sxCrcN7O5BAWPcFu3mgi9PT8qc4zIZg1AlyzEPiOq6a2jE QAFCViNs7XZJN/dht39zvNkVfEwjiG9qrA== X-Google-Smtp-Source: ABdhPJxzuYG5mO3+t+qTpdh/ft9b4zdw8mg2iptqUYkOvauvt53wKiaUpDO/61yaD8o2yv1ntjvsmw== X-Received: by 2002:adf:f58b:: with SMTP id f11mr12469762wro.250.1600030475765; Sun, 13 Sep 2020 13:54:35 -0700 (PDT) Received: from localhost ([193.32.126.162]) by smtp.googlemail.com with ESMTPSA id z7sm17193375wrw.93.2020.09.13.13.54.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 13:54:35 -0700 (PDT) From: akater Date: Sun, 13 Sep 2020 20:44:14 +0000 Message-ID: <87bli976g1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=nuclearspace@gmail.com; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Looks like a mistake in docstring: * lisp/progmodes/compile.el (compilation-mode-map) Remove mention of compilation-minor-mode-map as comment in the body says ;; Don't inherit from compilation-minor-mode-map, ;; because that introduces a menu bar item we don't want. ;; That confuses C-down-mouse-3. and the map actually inherits from special-mode-map =2D-- lisp/progmodes/compile.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 13b672bd53..7ac5405ab1 100644 =2D-- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -2090,8 +2090,7 @@ define-key map [menu-bar compilation compilation-comp= ile] '(menu-item "Compile..." compile :help "Compile the program including the current buffer. Default: run= `make'")) map) =2D "Keymap for compilation log buffers. =2D`compilation-minor-mode-map' is a parent of this.") + "Keymap for compilation log buffers.") =20 (defvar compilation-mode-tool-bar-map ;; When bootstrapping, tool-bar-map is not properly initialized yet, =2D-=20 2.26.2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJfXoSwAAoJELK+sWGx7H9EPvkP/jafd+LiubOueD0Pt/KlBUJa lf2IrR1OBGPtlJBX5VE8BHFwe47uYIV0VAKNCnjTCILkDGVBMj6Wk5nd3ayQ0Izo jMuOLVy15kkG5Wvh2YW7uk7Khs/0Pkbx1VpenlYz2+J/+aatb03MtYEi0TXxHrng gW8sFdW1wlEnnv1b6Ig8Dz53mdJLHRVnaQskoxONQgKhvLpC2xxXmeApHEqQj7CN n67KeebmQEl+Ib4fasnr+2dgdcgJ0qIMb1kZ7eOk5aKK9PQ3FN8cy6K4iVtIOiXR WVCASl9y/bIylbYbFWuzdBKVAAKz8t5OYN4aCXs8zhW39Jr9K+Utvw7T4G8BFAU/ 9IRLKNzIJE1AbshZFHO/QOvAUhsu06WiQikBRXupp7VxNSn15WXwkYBzNgvd3T4G 3Y9D8u77V75iICJ3MrT8Nz5+8iHIHrquhNDqVx8SBoBqftF/sa71DA70TXSH3UzG QdVLrc9l8FjF8jztgtOTffcYh5Et36INdNAw4a8u7lSdnzEljmU9KJAJ1KPkiZCg uwE03L7dhYAbFvU+Z0w5MbegkE4rCmlcy9CK7f6/9jW1Fw1PIzKC8ARyxTPVFyUE lPZiBqvrQE2HGho8w6f4+mUu9YiahoEptXKDt/dX8osaZDER7/BnLXUZJLjGc/Fb pNNyDBCkhSoJkimaRr83 =B6DU -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jul 15 11:17:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43382: [PATCH] Remove mention of compilation-minor-mode-map from docstring of compilation-mode-map Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43382 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: akater Cc: 43382@debbugs.gnu.org Received: via spool by 43382-submit@debbugs.gnu.org id=B43382.1600038548363 (code B ref 43382); Sun, 13 Sep 2020 23:10:02 +0000 Received: (at 43382) by debbugs.gnu.org; 13 Sep 2020 23:09:08 +0000 Received: from localhost ([127.0.0.1]:52000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHb7M-00005i-4Y for submit@debbugs.gnu.org; Sun, 13 Sep 2020 19:09:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHb7G-000054-UN for 43382@debbugs.gnu.org; Sun, 13 Sep 2020 19:09:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=laSI14a1uV/mKnykRNwMZbhrR+EFqoGtn9xONcb0KPk=; b=mRT9YgeMPds5TU5TA/6iP4hY1y ShtUetIipyXXL3hXhArMSKH5Xun6Cb+MczQqPNb8fUvnbzUtuRyxthnfNd8x5AMZqMPI3hoN2FxO2 DIgsN64P8K58wTbfgsyD9ILUv5z+EPZicfQkDINin0KC8yOTq1/BzfgbqjvaU1P9vVJc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHb74-0000uL-Q4; Mon, 14 Sep 2020 01:08:56 +0200 From: Lars Ingebrigtsen References: <87bli976g1.fsf@gmail.com> X-Now-Playing: Rema Rema's _Fond Reflections (1): Demos and Demolitions_: "Why Ask Why" Date: Mon, 14 Sep 2020 01:08:49 +0200 In-Reply-To: <87bli976g1.fsf@gmail.com> (akater's message of "Sun, 13 Sep 2020 20:44:14 +0000") Message-ID: <87ft7lff5q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: akater writes: > Looks like a mistake in docstring: > > * lisp/progmodes/compile.el (compilation-mode-map) > > Remove mention of compilation-minor-mode-map as comment in the body says > > ;; Don't inherit from compi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) akater writes: > Looks like a mistake in docstring: > > * lisp/progmodes/compile.el (compilation-mode-map) > > Remove mention of compilation-minor-mode-map as comment in the body says > > ;; Don't inherit from compilation-minor-mode-map, > ;; because that introduces a menu bar item we don't want. > ;; That confuses C-down-mouse-3. > > and the map actually inherits from special-mode-map Thanks; patch applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 13 19:09:11 2020 Received: (at control) by debbugs.gnu.org; 13 Sep 2020 23:09:11 +0000 Received: from localhost ([127.0.0.1]:52002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHb7O-00005x-Cd for submit@debbugs.gnu.org; Sun, 13 Sep 2020 19:09:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHb7L-00005W-QX for control@debbugs.gnu.org; Sun, 13 Sep 2020 19:09:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K1L5WtdiVD/jjvf/yPv9cX/MoUTCdLr+LBp6PdzEkg8=; b=RkmN2Y6HelDx9dh7WAtKzSJP7b um3PzUgwUhDy0FgCLBF932209Ig4UITAjpbX8goS3EABKE4jfAwhXEw2eaJOlXYx48wEoOPDiGizI ERs3UK1vxPvkRc5vUK9uQ+4/IjfWl+jUQntWMCTES9JbnJ4KPf3Rya81huYsvJghWLrc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHb7E-0000uS-7L for control@debbugs.gnu.org; Mon, 14 Sep 2020 01:09:02 +0200 Date: Mon, 14 Sep 2020 01:08:59 +0200 Message-Id: <87een5ff5g.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43382 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43382 fixed close 43382 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43382 fixed close 43382 28.1 quit