GNU bug report logs - #43382
[PATCH] Remove mention of compilation-minor-mode-map from docstring of compilation-mode-map

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43382 in the body.
You can then email your comments to 43382 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: akater <nuclearspace <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove mention of compilation-minor-mode-map from docstring
 of compilation-mode-map
Date: Sun, 13 Sep 2020 20:44:14 +0000

[Message part 1 (text/plain, inline)]

Looks like a mistake in docstring:

* lisp/progmodes/compile.el (compilation-mode-map)

Remove mention of compilation-minor-mode-map as comment in the body says

;; Don't inherit from compilation-minor-mode-map,
;; because that introduces a menu bar item we don't want.
;; That confuses C-down-mouse-3.

and the map actually inherits from special-mode-map
---
 lisp/progmodes/compile.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 13b672bd53..7ac5405ab1 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2090,8 +2090,7 @@ define-key map [menu-bar compilation compilation-compile]
       '(menu-item "Compile..." compile
 		  :help "Compile the program including the current buffer.  Default: run `make'"))
     map)
-  "Keymap for compilation log buffers.
-`compilation-minor-mode-map' is a parent of this.")
+  "Keymap for compilation log buffers.")
 
 (defvar compilation-mode-tool-bar-map
   ;; When bootstrapping, tool-bar-map is not properly initialized yet,
-- 
2.26.2

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 43382 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: akater <nuclearspace <at> gmail.com>
Cc: 43382 <at> debbugs.gnu.org
Subject: Re: bug#43382: [PATCH] Remove mention of compilation-minor-mode-map
 from docstring of compilation-mode-map
Date: Mon, 14 Sep 2020 01:08:49 +0200

akater <nuclearspace <at> gmail.com> writes:

> Looks like a mistake in docstring:
>
> * lisp/progmodes/compile.el (compilation-mode-map)
>
> Remove mention of compilation-minor-mode-map as comment in the body says
>
> ;; Don't inherit from compilation-minor-mode-map,
> ;; because that introduces a menu bar item we don't want.
> ;; That confuses C-down-mouse-3.
>
> and the map actually inherits from special-mode-map

Thanks; patch applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.