Subject: bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port

From: Dale Sedivec <[email-masked]>
Date: Mon, 14 Sep 2020 17:10:30 -0500

On Sep 14, 2020, at 09:52, Eli Zaretskii <[email-masked]> wrote:
>> From: Lars Ingebrigtsen <[email-masked]>
>> Date: Mon, 14 Sep 2020 01:49:43 +0200
>> Cc: [email-masked], Dale Sedivec <[email-masked]>
>> 
>> Alan Third <[email-masked]> writes:
>> 
>>> Now you mention it, I can see that the X ports use the face colours as
>>> well...
>>> 
>>> xterm.c:1518
>>>      xgcv.background = s->f->output_data.x->cursor_pixel;
>>>      xgcv.foreground = s->face->background;
>>>           ^               ^
>> 
>> Yeah, it looks like it's been like that since at least the 90s.  So...
>> the documentation is just wrong?
> 
> Yes, the documentation is inaccurate: it describes what happens when
> the text at point uses the default face.  When the face is not the
> default, we merge that face into the cursor face, and that is what you
> see.
> 
> We should fix the documentation.

Understood.  Would it be appropriate for me to open a separate bug for the problem of the text under the box cursor being nearly unreadable, as in my example?  Maybe allowing the cursor face's :foreground to be used in preference to the background of the face at point?

Dale