Subject: Re: bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port

From: Eli Zaretskii <[email-masked]>
Date: Mon, 14 Sep 2020 17:52:13 +0300

> From: Lars Ingebrigtsen <[email-masked]>
> Date: Mon, 14 Sep 2020 01:49:43 +0200
> Cc: [email-masked], Dale Sedivec <[email-masked]>
> 
> Alan Third <[email-masked]> writes:
> 
> > Now you mention it, I can see that the X ports use the face colours as
> > well...
> >
> > xterm.c:1518
> >       xgcv.background = s->f->output_data.x->cursor_pixel;
> >       xgcv.foreground = s->face->background;
> >            ^               ^
> 
> Yeah, it looks like it's been like that since at least the 90s.  So...
> the documentation is just wrong?

Yes, the documentation is inaccurate: it describes what happens when
the text at point uses the default face.  When the face is not the
default, we merge that face into the cursor face, and that is what you
see.

We should fix the documentation.