GNU bug report logs - #43340
[PATCH 0/5] Speed up archive export/import

Previous Next

Full log

Message #29 received at 43340 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 43340 <at> debbugs.gnu.org
Subject: Re: [bug#43340] [PATCH 4/5] daemon: Spawn 'guix authenticate' once
 for all.
Date: Sat, 12 Sep 2020 09:20:04 +0200

> +                    (send-reply 500

Reply codes could be factorized in an enum.

> +    if (!agent) {
> +	Strings args = { "authenticate" };
> +	agent = std::shared_ptr<Agent>(new Agent(settings.guixProgram, args));
> +    }

make_shared should be preferred to the direct use of new.

> +	    if (strchr("0123456789", ch)) {

You can maybe use isdigit?

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.