GNU bug report logs - #43338
[PATCH] gnu: Add ripmime.

Previous Next

Full log

Message #8 received at 43338 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sébastien Lerique <sl <at> eauchat.org>
Cc: 43338 <at> debbugs.gnu.org
Subject: Re: [bug#43338] [PATCH] gnu: Add ripmime.
Date: Sun, 13 Sep 2020 23:16:33 +0200

Hello Sébastien!

Sébastien Lerique <sl <at> eauchat.org> skribis:

> * gnu/packages/mail.scm (ripmime): New variable.
> ---
> gnu/packages/mail.scm | 44
> +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)

Looks like your mail client mangled the patch.  Could you send it as an
attachment or using ‘git send-email’?  (See <https://git-send-email.io/>
for a tutorial.)

> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 7af7e8a8d7..48e9a11522 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -627,6 +627,50 @@ Extension (MIME).")
>                (base32
>                 "0slzlzcr3h8jikpz5a5amqd0csqh2m40gdk910ws2hnaf5m6hjbi"))))))
>
> +(define-public ripmime
> +  (let ((commit "a556ffe08d620602475c976732e8e1a82f3169e9")
> +        (revision "1"))
> +    (package
> +      (name "ripmime")
> +      (version (git-version "1.4.0.10" revision commit))

In general we provide released versions, unless there’s a good reason to
pick a development snapshot.  If it falls in this category, could you
add a short comment above the commit ID explaining why?

> +           (add-after 'unpack 'strip-buildcodes
> +             (lambda _
> +               (substitute* "generate-buildcodes.sh"
> +                 (("`date \\+%s`") "0")
> +                 (("`date`") "0")
> +                 (("`uname -a`") "Guix"))))

Please return #t at the end of the phase (it’s a convention).

> +           ;; https://github.com/inflex/ripMIME/pull/16 makes
> `mkdir-p-bin-man unnecessary
> +           (add-before 'install 'mkdir-p-bin-man
> +             (lambda _
> +               (mkdir-p (string-append (assoc-ref %outputs "out")
> "/bin"))
> +               (mkdir-p (string-append (assoc-ref %outputs "out")
> "/man")))))

Likewise.

> +      (synopsis "Extract attachments from MIME-encoded email")
> +      (description
> +       "ripMIME is a small program which is used to extract the
> attached files

s/which is used//g

> +out of a MIME-encoded email package.")

Could you send an updated patch?

Thanks for this first contribution! :-)

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.