GNU bug report logs - #43329
28.0.50; Incorrect indentation for variables starting with `def' in let form

Previous Next

Package: emacs;

Reported by: Philipp Stephani <p.stephani2 <at> gmail.com>

Date: Fri, 11 Sep 2020 10:11:02 UTC

Severity: minor

Tags: confirmed, moreinfo

Merged with 33301

Found in versions 24.3, 27.0.50, 28.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #31 received at 43329 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>,
 Noam Postavsky <npostavs <at> gmail.com>, 43329 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables
 starting with `def' in let form
Date: Wed, 13 Oct 2021 21:23:33 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> So 34 in-tree functions that start with "def", but an unknown number of
> macros.  That's not a lot, and I think we should add indent specs to all
> of them, including the macros.

I've now gone through all the functions that have names that start with
"def" and marked the ones that should have `defun' indent explicitly.
I'll do the macros next, and then we can remove the heuristic.

This will change how out-of-tree code indents, though.  This can be
fixed by out-of-tree packages doing markup, but is there some way we can
make the transition kinder?  (I don't think so, though.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 3 years and 214 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.