GNU bug report logs - #43329
28.0.50; Incorrect indentation for variables starting with `def' in let form

Previous Next

Package: emacs;

Reported by: Philipp Stephani <p.stephani2 <at> gmail.com>

Date: Fri, 11 Sep 2020 10:11:02 UTC

Severity: minor

Tags: confirmed, moreinfo

Merged with 33301

Found in versions 24.3, 27.0.50, 28.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, Noam Postavsky <npostavs <at> gmail.com>, 43329 <at> debbugs.gnu.org
Subject: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form
Date: Sun, 13 Sep 2020 11:24:43 -0400

> But the (def* thing is a heuristic, and we could say that we only use
> that heuristic at the top level?

We can replace one heuristic with another, yes.
That exchanges misindentationss for other misindentations.

> We should then mark all the (def* things we have in-tree with explicit
> indentation marking (which I think we should do anyway, really).

Indeed (and I think we've been getting there bit by bit.  Not sure how
far we stand from that nowadays).  Of course, that won't help with

    (let ((defvar
           3))
      (+ defvar 5))

and other oddball cases ;-)


        Stefan
This bug report was last modified 3 years and 237 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.