GNU bug report logs - #43329
28.0.50; Incorrect indentation for variables starting with `def' in let form

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, Noam Postavsky <npostavs <at> gmail.com>, 43329 <at> debbugs.gnu.org
Subject: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form
Date: Sun, 13 Sep 2020 14:44:45 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> Would something as simple as the following (which fixes this use case)
>> be the correct fix?  It only indents these forms as macros if they are
>> top-level...
>
> It obviously has the downside of not indenting properly those
> definitions which are not at the very-top level.  E.g. definitions
> inside an `eval-when-compile` or other.

That's true.  I guess the (def* calls can happen at any level, really.

But the (def* thing is a heuristic, and we could say that we only use
that heuristic at the top level?

We should then mark all the (def* things we have in-tree with explicit
indentation marking (which I think we should do anyway, really).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.