From unknown Tue Jun 17 19:48:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43329 <43329@debbugs.gnu.org> To: bug#43329 <43329@debbugs.gnu.org> Subject: Status: 28.0.50; Incorrect indentation for variables starting with `def' in let form Reply-To: bug#43329 <43329@debbugs.gnu.org> Date: Wed, 18 Jun 2025 02:48:49 +0000 retitle 43329 28.0.50; Incorrect indentation for variables starting with `d= ef' in let form reassign 43329 emacs submitter 43329 Philipp Stephani severity 43329 minor tag 43329 moreinfo confirmed thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 11 06:10:55 2020 Received: (at submit) by debbugs.gnu.org; 11 Sep 2020 10:10:56 +0000 Received: from localhost ([127.0.0.1]:42449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGg19-0004as-Kj for submit@debbugs.gnu.org; Fri, 11 Sep 2020 06:10:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:44656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGg18-0004al-7D for submit@debbugs.gnu.org; Fri, 11 Sep 2020 06:10:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGg18-00056I-2n for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2020 06:10:54 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:35170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGg14-0005sO-Qc for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2020 06:10:53 -0400 Received: by mail-wm1-x32b.google.com with SMTP id y15so4236646wmi.0 for ; Fri, 11 Sep 2020 03:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=v6TJ+0yM7ZbpSQwZJ0i3BybNaENOZ5PJormYnL8jDXI=; b=mw368Kkhku1H/kNacT7woV/sXHGWONIjkZc7SGEbN30h7BIAtg8ASCTo560FKTDL+x I4z3eCenwfEfvTNfkqLQrFqyZMIVWVShx5SemaPPO3Fv2CWQxdqLI1sS+xHs+riMDbNi v4pEwmAYsU5B10ou78R4iN1v65U3Fl9OqL2jA7keFF4KLGZ0Ekt9lPTpElzuj213FnRc rXYNJ6FWw2UvBgj1fvNyirX2p+6XlxQs6XBG7F93WhwJ9siFZ7Rrr7C9xaSlyFzgtFuI ArxLd/tigbAnlnBgvr3codm7HrbXE9gfYTJpFB8pVS1YZ44SIpfTn6r9rqJojx3lyYvX qJIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=v6TJ+0yM7ZbpSQwZJ0i3BybNaENOZ5PJormYnL8jDXI=; b=bWIPSV+Zl6LXc8VM2lD8vZtIJhWXVfk1y6uZ/TsPIN9mZ2DRQ27jIMjozuUGB8+avq BU+j3/PS/Ma8ceMGaoRZU0Q1TXRgsqZlzTZTWrt0d9GO2e+04Atfc0+bS0YaijyYFUxK Ku17b8sh3bwx6MDsOpbXWLJSMPwB0fI7R8XyXSF5sMAbQM4dQPszw6xkxCSkG6OPI7gr Rrp6/KWJzPdlBRl0pxE+hes9M490x2YMtRH8dCDV1VXjnTgJVLT2wDwTNC7k9Rt6/iuq Gt7L85fOtv0xYXMPBiYLCCAksw73DY4Ubah2aW2WVX3Qa5PvYzhOxmONvLoQyIPD4tWf q3EQ== X-Gm-Message-State: AOAM531pfno/Zbiufatp9jslI0Ody1ahW8ZzeiJjABAnknobZ2soiipW +edLuPS5p38JJdpEOS/MXvIYQC8HYNpO9Q== X-Google-Smtp-Source: ABdhPJyyXef0xqrTZXE43NHeyLufM61f6k+J/iFWGrlhd3k8IRPCSdgVFhfHpcBn93lWVHX7mTjVZA== X-Received: by 2002:a05:600c:2317:: with SMTP id 23mr1508825wmo.183.1599819048653; Fri, 11 Sep 2020 03:10:48 -0700 (PDT) Received: from phst1 ([85.233.38.233]) by smtp.gmail.com with ESMTPSA id p1sm9810742wma.0.2020.09.11.03.10.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 03:10:48 -0700 (PDT) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Incorrect indentation for variables starting with `def' in let form Date: Fri, 11 Sep 2020 12:10:46 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=p.stephani2@gmail.com; helo=mail-wm1-x32b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) In the scratch buffer, enter (let ((defa foo))) and reindent the second line. Emacs will insert an additional space before `foo' so that the `f' is now below the `e'. This seems to happen only for variables starting with `def' (but not `def' itself). In GNU Emacs 28.0.50 (build 90, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, = cairo version 1.16.0) of 2020-09-11 Repository revision: e2391d486e8a97e383db2337fad6a93c2c11656a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=3Dall --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O1 -ggdb3 -fno-omit-frame-pointer -fsanitize=3Daddress -fsanitize=3Dundefined -fsanitize=3Dpointer-compare -fsanitize=3Dpointer-subtract'' Configured features: XPM JPEG TIFF GIF PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER Important settings: value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822 mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars mailcap subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus xml compile comint ansi-color ring cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 68841 6345) (symbols 48 8619 1) (strings 32 23832 1278) (string-bytes 1 770267) (vectors 16 13727) (vector-slots 8 188001 5269) (floats 8 26 31) (intervals 56 218 0) (buffers 992 11)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 11 06:26:40 2020 Received: (at 43329) by debbugs.gnu.org; 11 Sep 2020 10:26:40 +0000 Received: from localhost ([127.0.0.1]:42465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGgGO-00051z-Hu for submit@debbugs.gnu.org; Fri, 11 Sep 2020 06:26:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGgGL-00051k-VG for 43329@debbugs.gnu.org; Fri, 11 Sep 2020 06:26:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5P5CLhZtG2PHR4psX9bi2WYlXEikKDH5OkCEQRmGaOI=; b=Nr95IEUUKOVnZ8iJaaxOElohte hetie3nq0P7HNIsBU1yIpmqi1RnV2l13x6tf9I8vDeaiFaXgbN7zL7Sy67RHzmFP8WqZnm5nql0c4 QGz1grtd17o6NrK6jEXy7frLT95tYQyKj9/QdLw+bpg9c389hTsgl2P5v22q5ZH8y2i4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGgGC-0000lW-Hm; Fri, 11 Sep 2020 12:26:31 +0200 From: Lars Ingebrigtsen To: Philipp Stephani Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUZFRcrJimFe35c VFiaj5D///8ztEFsAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QJCwoXOyIP/iAAAAGkSURBVDjLfZSB 0dsgDIUhXgCiLoDQAEZigQL7z1QZMMb/tdVd4oQv0pP0HBvjvHXGWd/DuX4xV9gwLvodMPgNyAJC dWS6fpL+D65PTMWZBQ5ZQDIOYN7AQK767m4QHsAXMHdXS8MctAPjF7BURoP7gKMtFL9+ap+uPIhE rWzfGjqbaLD7CaAD5PMGs5SF5CUKYZjguJcIQQFSWWCuPeUqjNRqsGbXsImrKlCJYqzbBjwSVC+I mubsuWlcAKRgBQW7H0f6VoBCmnFOo8ICmkQYJU0gSzwBUkQRGA7CzMg1fSMhpglWKYq6EUJKLCMj PUD7FYzM52aLgiCeO8Bz07AXSIyJI5fzNQd1CbVqgjV58brEglqqjYxR6pOqOptY24q0l/rIb4EI jCg1n3u7EkDXyBi95JeGBOGie1eDZ6k4AGsJXcgDjgkkxdwi0wVeDn5jyuprDnCXmhq/9LChTpLu UhNwBGpNb5M14A1CB60AduBvP3R9pbXS6hdfGZ/oswJFRO21dvHUelSE/faxAG1GfT8AQK5DfMDz f1ph/hV/gz1D9PUHSRlZMz3LMQMAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDktMTFUMTA6MjM6 NTkrMDA6MDAIPQn+AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA5LTExVDEwOjIzOjU5KzAwOjAw eWCxQgAAAABJRU5ErkJggg== X-Now-Playing: Rema Rema's _Fond Reflections (1): Demos and Demolitions_: "Rema-Rema (Hallorans Live)" Date: Fri, 11 Sep 2020 12:26:27 +0200 In-Reply-To: (Philipp Stephani's message of "Fri, 11 Sep 2020 12:10:46 +0200") Message-ID: <87y2lg1uek.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp Stephani writes: > In the scratch buffer, enter > > (let ((defa > foo))) > > and reindent the second line. Emacs will insert an additional space > before `foo' so that the `f' is now below the `e'. This seems to happe [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43329 Cc: 43329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philipp Stephani writes: > In the scratch buffer, enter > > (let ((defa > foo))) > > and reindent the second line. Emacs will insert an additional space > before `foo' so that the `f' is now below the `e'. This seems to happen > only for variables starting with `def' (but not `def' itself). Yes, the Emacs Lisp indentation machinery assumes that everything that starts with "def" is a macro that defines something. That's pretty quirky, but it's been that way since forever, so it's probably too late to do something about that now. It should, however, be possible to do something about this in a `let' form, you'd think. But I've tried to find the place where this happens (I was looking at it just the other day!), but my grep skills fail me. Anybody remember which function this happens in? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 11 12:35:57 2020 Received: (at 43329) by debbugs.gnu.org; 11 Sep 2020 16:35:57 +0000 Received: from localhost ([127.0.0.1]:45250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGm1l-0000oT-7d for submit@debbugs.gnu.org; Fri, 11 Sep 2020 12:35:57 -0400 Received: from mail-il1-f182.google.com ([209.85.166.182]:45042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGm1g-0000o6-QN; Fri, 11 Sep 2020 12:35:55 -0400 Received: by mail-il1-f182.google.com with SMTP id h11so9513196ilj.11; Fri, 11 Sep 2020 09:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ge28Bn3yIT+Z+XflriPiZH5cead3VuKgeYXNU89B+8c=; b=ANEMLX4ZbhpQoGkhx0ruqh5+2zFTzlGnrmHmR7OYFVsR51GHidHZtxS4BrxxrBP0JS KXZF+i/cOY75dIgtlIirTGGvwyy5zcVuuJ/kNA+lIcr2yqu5TCXc3ocqz80aktAPKT9m Cld9rTxnpvXcsC8DFj6+P5HWJQEIZYQcZFSgiH7NAP7godEuBqhhykTBIzv19UH8iK9y lzV+foqtbxGEBcCYjfeu0iSslXzKbxw8DHZR20suWRRxtTC8R0TZ3KlnIkVsa3eowRod FFYrlM1RyTSFW+tMfF6KaBAdR6RgFD6PBha0diI75vVoiBh3kG7JzGZMOTsvYw9VJVNP cyyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ge28Bn3yIT+Z+XflriPiZH5cead3VuKgeYXNU89B+8c=; b=uW/kDNBfDfFA3mv7aWpxVFoW70uQ49wbegm9mI915QWQevq3OTVO4WYFQPCmfPFgG2 I4119EBHUVehAzv40vQdBfBy+dDzmj7Z/FQMnWm3EtddEPv08MKvBkRPGsXwVkGjcGNg l8FzKm2X4pxBqteYJf6WdFZAo7wQu37RkX+PvR8nd4BM0OLud8/MoA+5SY6qvbUXEs7N db//IygQWnlaPLMrKkPNmlNKVFpdKI+6sjxaooIFjp9Qkaq8tg9aab8wrTo+vumcAYiS qCdmK3/xVPazoaLbjt+GVvpoHzCC/3JCgWosPUNiVdY807Rs9sHy8et7k0o5nzyi3o24 Qk0g== X-Gm-Message-State: AOAM532iufjTgt0fm4DBrBmJtOg+FzZz8num+tr0qmx7ACfWwLSsU8sM qF7iBbJXaclUdG2tDem1nFXUQfBSGvc= X-Google-Smtp-Source: ABdhPJw7OEf52nOJJ29lujwSKSE5IlgbclBNeBSGH02/NXX2IaXvgoALWrPfh4ey+PU2QN9l74LKOw== X-Received: by 2002:a92:dad1:: with SMTP id o17mr2462972ilq.22.1599842146986; Fri, 11 Sep 2020 09:35:46 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id z4sm1332657iol.52.2020.09.11.09.35.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Sep 2020 09:35:46 -0700 (PDT) From: Noam Postavsky To: Lars Ingebrigtsen Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form References: <87y2lg1uek.fsf@gnus.org> Date: Fri, 11 Sep 2020 12:35:46 -0400 In-Reply-To: <87y2lg1uek.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 11 Sep 2020 12:26:27 +0200") Message-ID: <85o8mcl199.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43329 Cc: Philipp Stephani , 43329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 33301 43329 quit Lars Ingebrigtsen writes: > Yes, the Emacs Lisp indentation machinery assumes that everything that > starts with "def" is a macro that defines something. [...] > Anybody remember which function this happens in? lisp-indent-function (see https://debbugs.gnu.org/33301#15) From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 12 07:57:20 2020 Received: (at 43329) by debbugs.gnu.org; 12 Sep 2020 11:57:20 +0000 Received: from localhost ([127.0.0.1]:46511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH49g-000893-4O for submit@debbugs.gnu.org; Sat, 12 Sep 2020 07:57:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH49d-00088o-Hm for 43329@debbugs.gnu.org; Sat, 12 Sep 2020 07:57:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iRNleKSfU4zhgeBKfaPmvPZhVFeM30sKGRcP2WUok7g=; b=XJrXfuhOc7WumgAw1i3WNSYnni kp5h1zc/QVuzIqU7LQpEUC8CM6anm3gSwq+0biCKMDsEFp6MTRx34FpFQZ2Jcv6JNgvdeb0lLBsBi xsVbPQ7gEGPvOwksJZzxuNbyMtFLfJWLPgmecwmLHoRJaF+g3Yma12M6rDxO4ki+mLF8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH49T-00067D-Hh; Sat, 12 Sep 2020 13:57:10 +0200 From: Lars Ingebrigtsen To: Noam Postavsky Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> X-Now-Playing: Joni Mitchell's _Clouds_: "I Don't Know Where I Stand" Date: Sat, 12 Sep 2020 13:57:05 +0200 In-Reply-To: <85o8mcl199.fsf@gmail.com> (Noam Postavsky's message of "Fri, 11 Sep 2020 12:35:46 -0400") Message-ID: <87h7s32ooe.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Noam Postavsky writes: > lisp-indent-function (see https://debbugs.gnu.org/33301#15) Ah, yes, there it is: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43329 Cc: Philipp Stephani , Stefan Monnier , 43329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > lisp-indent-function (see https://debbugs.gnu.org/33301#15) Ah, yes, there it is: (defun lisp-indent-function (indent-point state) [...] (cond ((or (eq method 'defun) (and (null method) (> (length function) 3) (string-match "\\`def" function))) (lisp-indent-defform state indent-point)) I think the general idea here is to indent everything that starts with "(def" as a macro, but in (let ((defa foo))) that's obviously not the case here. Would something as simple as the following (which fixes this use case) be the correct fix? It only indents these forms as macros if they are top-level... ("make check" signals no errors with the change in place.) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index 352210f859..a324846336 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -1141,6 +1141,7 @@ lisp-indent-function (cond ((or (eq method 'defun) (and (null method) (> (length function) 3) + (= (syntax-ppss-depth state) 1) (string-match "\\`def" function))) (lisp-indent-defform state indent-point)) ((integerp method) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 12 11:49:08 2020 Received: (at 43329) by debbugs.gnu.org; 12 Sep 2020 15:49:08 +0000 Received: from localhost ([127.0.0.1]:48851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH7m0-00066s-79 for submit@debbugs.gnu.org; Sat, 12 Sep 2020 11:49:08 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH7ly-00066Q-Lj for 43329@debbugs.gnu.org; Sat, 12 Sep 2020 11:49:07 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 11DB9441053; Sat, 12 Sep 2020 11:49:01 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C55E8440F4B; Sat, 12 Sep 2020 11:48:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599925702; bh=5uNRN5ATjscUUH7paBsECIuEieRCj1HPHszNdFgCMGo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Jj6LsgLZ9dL6j0Gon9cDO7jfUnHKOmsXr8rxzzKiVa2rf2RbQQ5a343/kiwM3v8wf 8MMF9LlDMKrpWE6ySthJ+BAk8IF3MTuOy/mVH9FmuAvi55EVt436+t0PRoxgbjWAHI 6vDjPzkIxUM/M1E+KCV9YK7uO74Zbn046lFWNaAOm58LxS2V4SyrGkBMjgY1FG6cyP us7XE3+PBlDVJ6G5CyuumEkh0hHTgjRxvxV4jsbNLdyoITVsh3LW/Do0Ug9SKYrMWg zRlUgEYAm2pDkKzKrVB06RZP9veEOCAj3UZumgv7G7QDoGct28WDzpLWRX9yfNbI2g jAi1swII91iyA== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6F383120793; Sat, 12 Sep 2020 11:48:22 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form Message-ID: References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> Date: Sat, 12 Sep 2020 11:48:21 -0400 In-Reply-To: <87h7s32ooe.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Sep 2020 13:57:05 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43329 Cc: Philipp Stephani , Noam Postavsky , 43329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Would something as simple as the following (which fixes this use case) > be the correct fix? It only indents these forms as macros if they are > top-level... It obviously has the downside of not indenting properly those definitions which are not at the very-top level. E.g. definitions inside an `eval-when-compile` or other. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 13 08:44:57 2020 Received: (at 43329) by debbugs.gnu.org; 13 Sep 2020 12:44:57 +0000 Received: from localhost ([127.0.0.1]:49660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRNJ-0007Ea-4N for submit@debbugs.gnu.org; Sun, 13 Sep 2020 08:44:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRNI-0007EN-4L for 43329@debbugs.gnu.org; Sun, 13 Sep 2020 08:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V7Msq+MBEI5fIVdkBJyaRTRRXSasFhbi5sv+hCD7CFI=; b=EOJke+d/M59W5N6inxEEWaPXNr Q2I0HC4JZ8B5ssn1I4VX9Ey10rNZFPnJQw6nisCOLl8ZW4KlQIm5OEEvmJdJH/yXAqj+gP6wIQUzB Ks20cjYZUUiBE+DGlsFGrIyFNiuu+LdO3hGmerBrv8ly+jKhWY1FONGXsJ5b9OiL07eg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHRN9-00030f-66; Sun, 13 Sep 2020 14:44:49 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> X-Now-Playing: =?utf-8?B?UsOzaXPDrW4=?= Murphy's _Play Thing_: "Play Thing" Date: Sun, 13 Sep 2020 14:44:45 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 12 Sep 2020 11:48:21 -0400") Message-ID: <87a6xtzw02.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> Would something as simple as the following (which fixes this use case) >> be the correct fix? It only indents these forms as macros if they are >> top-level... > > It obviously has the downside of [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43329 Cc: Philipp Stephani , Noam Postavsky , 43329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> Would something as simple as the following (which fixes this use case) >> be the correct fix? It only indents these forms as macros if they are >> top-level... > > It obviously has the downside of not indenting properly those > definitions which are not at the very-top level. E.g. definitions > inside an `eval-when-compile` or other. That's true. I guess the (def* calls can happen at any level, really. But the (def* thing is a heuristic, and we could say that we only use that heuristic at the top level? We should then mark all the (def* things we have in-tree with explicit indentation marking (which I think we should do anyway, really). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 13 11:24:55 2020 Received: (at 43329) by debbugs.gnu.org; 13 Sep 2020 15:24:56 +0000 Received: from localhost ([127.0.0.1]:51373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHTs7-0001Jn-Jh for submit@debbugs.gnu.org; Sun, 13 Sep 2020 11:24:55 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHTs3-0001JY-CC for 43329@debbugs.gnu.org; Sun, 13 Sep 2020 11:24:54 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F153E80DC9; Sun, 13 Sep 2020 11:24:45 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 80EDF80BCE; Sun, 13 Sep 2020 11:24:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600010684; bh=PT3DfKcI9I8R0QwVdGwemN5e+Betgjerjz9mexGHGUE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gDvua7tJvWoyRIScEby2U/XLJm7dVNnOJDhFc3GSBUai3U9fvtqKGq50pwk3uFice pxr+dUPSN+Bo6cspQEl0hiD6ERPI2XndykIyETmrGqlWdVhAz3aEzgOMXBWZK0oump 38z+pcoVOtqGg6jfqn93CYOHesqsL0ai5FkWhmKJaguuq3naXyJZRBD5hEi7gowzN4 bUAJ56AMfs+CRanQpLbUpXLB9+nu7d5EySGI0EhMZHS2q+63/vp1FTWEL3WB4cBmvA ZgaOpSX++FXI+YRW2+mZRoDKAomE9W5PHZcLhgrcALW4tHOPpHLq4iZ9SxwSsJz6Ux Nv1mRb0bzQQuw== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EBCB012076C; Sun, 13 Sep 2020 11:24:43 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form Message-ID: References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> <87a6xtzw02.fsf@gnus.org> Date: Sun, 13 Sep 2020 11:24:43 -0400 In-Reply-To: <87a6xtzw02.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Sep 2020 14:44:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43329 Cc: Philipp Stephani , Noam Postavsky , 43329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > But the (def* thing is a heuristic, and we could say that we only use > that heuristic at the top level? We can replace one heuristic with another, yes. That exchanges misindentationss for other misindentations. > We should then mark all the (def* things we have in-tree with explicit > indentation marking (which I think we should do anyway, really). Indeed (and I think we've been getting there bit by bit. Not sure how far we stand from that nowadays). Of course, that won't help with (let ((defvar 3)) (+ defvar 5)) and other oddball cases ;-) Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 13 13:21:01 2020 Received: (at 43329) by debbugs.gnu.org; 13 Sep 2020 17:21:01 +0000 Received: from localhost ([127.0.0.1]:51612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHVgS-0006Yb-Nb for submit@debbugs.gnu.org; Sun, 13 Sep 2020 13:21:00 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHVgQ-0006Y6-FV for 43329@debbugs.gnu.org; Sun, 13 Sep 2020 13:20:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AomCD8gEDxLaEmzZDHU1okZVW9TbPMr14DKB31krx/0=; b=UyLkjAopdqI24rmrmg7sH5hjCt 70Pw7N4rpzTvvkj57UBP6DyGY4N5hSgYSI/N9fjUE4JuK7/RXRoi4JEE2w4A1IF/553JFn8SlJ+pc Dg+XoKn0UUp6SsV762kIa4U23jXrXg8E1zQVFCfcEJVn7twBwIK3eFe5eauvUUmSS+ZQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHVgG-0005ZM-Mw; Sun, 13 Sep 2020 19:20:51 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> <87a6xtzw02.fsf@gnus.org> X-Now-Playing: Ultra =?utf-8?Q?Nat=C3=A9's?= _Hero Worship_: "Right Now" Date: Sun, 13 Sep 2020 19:20:47 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 13 Sep 2020 11:24:43 -0400") Message-ID: <87een5h9u8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > Indeed (and I think we've been getting there bit by bit. Not sure how > far we stand from that nowadays). João suggested over on bug#33301 to only make the heuristic happen for macros, and I was sceptical, but: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43329 Cc: Philipp Stephani , Noam Postavsky , 43329@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOh?= =?utf-8?B?dm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > Indeed (and I think we've been getting there bit by bit. Not sure how > far we stand from that nowadays). Jo=C3=A3o suggested over on bug#33301 to only make the heuristic happen for macros, and I was sceptical, but: > Indeed I don't know how to proceed. There seem to be around 34.=20 > Add indent specs for these 34 symbols? I suspect that some have exclusive= ly > one-line uses that don't need them. So 34 in-tree functions that start with "def", but an unknown number of macros. That's not a lot, and I think we should add indent specs to all of them, including the macros. > Of course, that won't help with > > (let ((defvar > 3)) > (+ defvar 5)) > > and other oddball cases ;-) Heh, no. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 15:23:49 2021 Received: (at 43329) by debbugs.gnu.org; 13 Oct 2021 19:23:49 +0000 Received: from localhost ([127.0.0.1]:33505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majqv-0008DO-Jd for submit@debbugs.gnu.org; Wed, 13 Oct 2021 15:23:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majqr-0008Ct-4q for 43329@debbugs.gnu.org; Wed, 13 Oct 2021 15:23:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=p3ZJjYnqg37WGgiBb4F8AzR1sTYoFpEFZzorJZcA9Uw=; b=EEfwjK3aeKEmJKBbyv1r1f339W Yg4MedkmlORTzG15JUBgC2aMco4qOybmRoXZ2Av4oHU4oOdPR6d48oDK7RZb3GZgU6qO66ZxFqiny X/o5ZeP9GlLIk0cdROu5uebRCriCDlCkBbKYPNiP9taD9T85bMxK8ZpvdpFZ1w/NXfJE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1majqh-0002r9-Hu; Wed, 13 Oct 2021 21:23:37 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> <87a6xtzw02.fsf@gnus.org> <87een5h9u8.fsf@gnus.org> X-Now-Playing: Stephan Mathieu's _Radiance (11): Music with Magnetic Strings_: "Version I" Date: Wed, 13 Oct 2021 21:23:33 +0200 In-Reply-To: <87een5h9u8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Sep 2020 19:20:47 +0200") Message-ID: <877deg3f0q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > So 34 in-tree functions that start with "def", but an unknown number of > macros. That's not a lot, and I think we should add indent specs to all > of them, including the macros. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43329 Cc: Philipp Stephani , Noam Postavsky , 43329@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9y?= =?utf-8?B?YQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > So 34 in-tree functions that start with "def", but an unknown number of > macros. That's not a lot, and I think we should add indent specs to all > of them, including the macros. I've now gone through all the functions that have names that start with "def" and marked the ones that should have `defun' indent explicitly. I'll do the macros next, and then we can remove the heuristic. This will change how out-of-tree code indents, though. This can be fixed by out-of-tree packages doing markup, but is there some way we can make the transition kinder? (I don't think so, though.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 16:05:42 2021 Received: (at control) by debbugs.gnu.org; 13 Oct 2021 20:05:42 +0000 Received: from localhost ([127.0.0.1]:33647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1makVS-0003q6-IE for submit@debbugs.gnu.org; Wed, 13 Oct 2021 16:05:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1makVQ-0003po-PH for control@debbugs.gnu.org; Wed, 13 Oct 2021 16:05:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YMd7fCldowV09vjaFyik7IyyFeZgMlRBGcfYouLy6tU=; b=N6SCwQt3RMiFHK8yX893TMPZfT 8mwzHJ/3TtFZLSOpNQVQEAntJimv0I0e6tDzUTZMgxZOSp9xMrkLOLlZJfx5u/4/bcKBULo0qNK1K Bb5pN+ZXVVCmXcBY+q7aQaKOgcLWRoyK82q3VspVtZRaqyfr7lGSXSKHfqIZxvFtFrcs=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1makVI-00039U-Vz for control@debbugs.gnu.org; Wed, 13 Oct 2021 22:05:34 +0200 Date: Wed, 13 Oct 2021 22:05:32 +0200 Message-Id: <871r4o3d2r.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43329 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43329 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 43329 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 18 04:01:00 2021 Received: (at 43329) by debbugs.gnu.org; 18 Oct 2021 08:01:00 +0000 Received: from localhost ([127.0.0.1]:45830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcNZr-00034p-Ik for submit@debbugs.gnu.org; Mon, 18 Oct 2021 04:00:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcNZm-0002uM-Kp; Mon, 18 Oct 2021 04:00:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OL7Rtan+rW/pHA5z3kT5rlnDqgb+8rxXNB7MjJi+tro=; b=J+yHEKJHf6Bk+iY7j4fwIng+1g CAdbSbt6vTUSqqhthfYgZJVwnt75fA+PdBsizOJd2Y2hIE60pgZLf8TTU0jRNZo+QfpjWLbqOuwC8 lLfHsy+9e2vFGVjROiWPEsMPOaFMjRARCEABBYkRRHfRSQNaqGikgsx2cb/lKTn5ygFE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcNZc-0000hS-Dw; Mon, 18 Oct 2021 10:00:46 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> <87a6xtzw02.fsf@gnus.org> <87een5h9u8.fsf@gnus.org> <877deg3f0q.fsf@gnus.org> X-Now-Playing: Brokeback's _Looks At The Bird_: "Pearl's Dream" Date: Mon, 18 Oct 2021 10:00:43 +0200 In-Reply-To: <877deg3f0q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 13 Oct 2021 21:23:33 +0200") Message-ID: <87lf2qlq38.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > This will change how out-of-tree code indents, though. This can be > fixed by out-of-tree packages doing markup, but is there some way we can > make the transition kinder? (I don't think so, though. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43329 Cc: Philipp Stephani , 33301@debbugs.gnu.org, Noam Postavsky , 43329@debbugs.gnu.org, =?utf-8?B?Sm8=?= =?utf-8?B?w6NvIFTDoXZvcmE=?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > This will change how out-of-tree code indents, though. This can be > fixed by out-of-tree packages doing markup, but is there some way we can > make the transition kinder? (I don't think so, though.) I've now pushed this change to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 18 04:01:14 2021 Received: (at control) by debbugs.gnu.org; 18 Oct 2021 08:01:14 +0000 Received: from localhost ([127.0.0.1]:45835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcNa4-0003H0-UV for submit@debbugs.gnu.org; Mon, 18 Oct 2021 04:01:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcNZp-0002xu-Pi for control@debbugs.gnu.org; Mon, 18 Oct 2021 04:00:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iqLL75A6uQbdwafsWfgcot1qGS+V3sJAtlwXUt/JKcM=; b=uUyZTwt7QkHX3uHTDTXKcvKz+6 QUOH3jld9MHxw3i6OvI7asAaU/0bzM5nVrIpPi5W/RDZi4LLY7ScKYh6luQW9BE6dWoZwElErKrCR MmqSXqPbVyJa5eXdX8DT6oUH23+1wyVKQ1HQpcnATsFyS0YD3yzwKjni6pgbNHtZhtD4=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcNZi-0000hd-8S for control@debbugs.gnu.org; Mon, 18 Oct 2021 10:00:52 +0200 Date: Mon, 18 Oct 2021 10:00:49 +0200 Message-Id: <87k0ialq32.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #33301 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 33301 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 33301 29.1 quit From unknown Tue Jun 17 19:48:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 15 Nov 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator